Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align handling of missing SSID in ScanNetworks with spec changes. #17925

Merged
merged 1 commit into from
May 2, 2022
Merged

Align handling of missing SSID in ScanNetworks with spec changes. #17925

merged 1 commit into from
May 2, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Spec has made SSID optional for wifi ScanNetworks, with missing value
treated as null.

Problem

Spec change in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5145

Change overview

Align with spec.

Testing

Will be tested by cert tests.

@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Apr 29, 2022
@boring-cyborg boring-cyborg bot added the app label Apr 29, 2022
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17925: Size comparison from ad2520a to 578de14

Increases (8 builds for cc13x2_26x2, cyw30739, k32w)
platform target config section ad2520a 578de14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689527 16 0.0
.text 586724 586740 16 0.0
pump-app LP_CC2652R7 (read only) 661955 661971 16 0.0
.text 580972 580988 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654811 16 0.0
.text 570876 570892 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626914 16 0.0
.app_xip_area 529432 529448 16 0.0
lock cyw930739m2evb_01 (read/write) 625594 625602 8 0.0
.app_xip_area 529592 529600 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574738 16 0.0
.app_xip_area 469100 469116 16 0.0
k32w light k32w061+release (read/write) 684860 684876 16 0.0
.text 599828 599844 16 0.0
lock k32w061+release (read/write) 729676 729692 16 0.0
.text 644260 644276 16 0.0
Decreases (11 builds for cc13x2_26x2, linux, p6, telink)
platform target config section ad2520a 578de14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162744 162728 -16 -0.0
pump-app LP_CC2652R7 (read/write) 182796 182780 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189756 189740 -16 -0.0
linux all-clusters-app debug (read only) 2732721 2732481 -240 -0.0
.text 2323138 2322898 -240 -0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228433 -224 -0.0
.text 1874402 1874178 -224 -0.0
thermostat-no-ble arm64 (read only) 2367732 2367492 -240 -0.0
.text 1992480 1992240 -240 -0.0
p6 all-clusters-app default (read/write) 2529352 2529320 -32 -0.0
.text 1487616 1487584 -32 -0.0
light-app default (read/write) 2419912 2419880 -32 -0.0
.text 1378176 1378144 -32 -0.0
lock-app default (read/write) 2429192 2429160 -32 -0.0
.text 1387456 1387424 -32 -0.0
telink lighting-app tlsr9518adk80d text 571822 571820 -2 -0.0
Full report (26 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section ad2520a 578de14 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689527 16 0.0
(read/write) 162744 162728 -16 -0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586724 586740 16 0.0
lock-ftd LP_CC2652R7 (read only) 677303 677303 0 0.0
(read/write) 166208 166208 0 0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 582464 582464 0 0.0
lock-mtd LP_CC2652R7 (read only) 626047 626047 0 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 531312 531312 0 0.0
pump-app LP_CC2652R7 (read only) 661955 661971 16 0.0
(read/write) 182796 182780 -16 -0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80499 80499 0 0.0
.text 580972 580988 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654811 16 0.0
(read/write) 189756 189740 -16 -0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83435 83435 0 0.0
.text 570876 570892 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626914 16 0.0
.app_xip_area 529432 529448 16 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625594 625602 8 0.0
.app_xip_area 529592 529600 8 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574738 16 0.0
.app_xip_area 469100 469116 16 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 684860 684876 16 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599828 599844 16 0.0
lock k32w061+release (read/write) 729676 729692 16 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 644260 644276 16 0.0
linux all-clusters-app debug (read only) 2732721 2732481 -240 -0.0
(read/write) 173336 173336 0 0.0
.bss 83584 83584 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234981 234981 0 0.0
.text 2323138 2322898 -240 -0.0
bridge-app debug+rpc (read only) 1887905 1887905 0 0.0
(read/write) 120664 120664 0 0.0
.bss 71584 71584 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1605090 1605090 0 0.0
chip-tool debug (read only) 8852773 8852773 0 0.0
(read/write) 550704 550704 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462581 462581 0 0.0
.text 7127525 7127525 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8694996 0 0.0
(read/write) 616497 616497 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429860 429860 0 0.0
.text 6867892 6867892 0 0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
(read/write) 151616 151616 0 0.0
.bss 73632 73632 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184553 184553 0 0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228433 -224 -0.0
(read/write) 146200 146200 0 0.0
.bss 72256 72256 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1874402 1874178 -224 -0.0
ota-provider-app debug (read only) 2056961 2056961 0 0.0
(read/write) 139216 139216 0 0.0
.bss 71648 71648 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1724738 1724738 0 0.0
ota-requestor-app debug (read only) 2088065 2088065 0 0.0
(read/write) 142024 142024 0 0.0
.bss 72288 72288 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1758082 1758082 0 0.0
shell debug (read only) 2557913 2557913 0 0.0
(read/write) 197328 197328 0 0.0
.bss 114312 114312 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2179666 2179666 0 0.0
thermostat-no-ble arm64 (read only) 2367732 2367492 -240 -0.0
(read/write) 174801 174801 0 0.0
.bss 86481 86481 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146100 146100 0 0.0
.text 1992480 1992240 -240 -0.0
tv-app debug (read only) 2840625 2840625 0 0.0
(read/write) 276832 276832 0 0.0
.bss 189496 189496 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217099 217099 0 0.0
.text 2441474 2441474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418892 2418892 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1381492 1381492 0 0.0
p6 all-clusters-app default (read/write) 2529352 2529320 -32 -0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1487616 1487584 -32 -0.0
light-app default (read/write) 2419912 2419880 -32 -0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1378176 1378144 -32 -0.0
lock-app default (read/write) 2429192 2429160 -32 -0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1387456 1387424 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 808144 0 0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571822 571820 -2 -0.0

@bzbarsky-apple
Copy link
Contributor Author

/rebase

@bzbarsky-apple bzbarsky-apple force-pushed the wifi-ssid-optional-scan branch from 578de14 to 3237315 Compare April 29, 2022 22:46
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17925: Size comparison from 4a145d6 to 3237315

Increases (9 builds for cc13x2_26x2, cyw30739, efr32, k32w)
platform target config section 4a145d6 3237315 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689527 16 0.0
.text 586724 586740 16 0.0
pump-app LP_CC2652R7 (read only) 661955 661971 16 0.0
.text 580972 580988 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654811 16 0.0
.text 570876 570892 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626914 16 0.0
.app_xip_area 529432 529448 16 0.0
lock cyw930739m2evb_01 (read/write) 625594 625602 8 0.0
.app_xip_area 529592 529600 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574738 16 0.0
.app_xip_area 469100 469116 16 0.0
efr32 lock-app BRD4161A+wf200 (read only) 917184 917200 16 0.0
.text 917176 917192 16 0.0
k32w light k32w061+release (read/write) 684860 684876 16 0.0
.text 599828 599844 16 0.0
lock k32w061+release (read/write) 729676 729692 16 0.0
.text 644260 644276 16 0.0
Decreases (15 builds for cc13x2_26x2, efr32, linux, p6, telink)
platform target config section 4a145d6 3237315 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162744 162728 -16 -0.0
pump-app LP_CC2652R7 (read/write) 182796 182780 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189756 189740 -16 -0.0
efr32 lighting-app BRD4161A (read only) 908936 908904 -32 -0.0
.text 908928 908896 -32 -0.0
BRD4161A+rpc (read only) 943280 943248 -32 -0.0
.text 943272 943240 -32 -0.0
BRD4161A+rs911x (read only) 747260 747228 -32 -0.0
.text 747252 747220 -32 -0.0
window-app BRD4161A (read only) 846168 846136 -32 -0.0
.text 846160 846128 -32 -0.0
linux all-clusters-app debug (read only) 2732721 2732481 -240 -0.0
.text 2323138 2322898 -240 -0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228433 -224 -0.0
.text 1874402 1874178 -224 -0.0
thermostat-no-ble arm64 (read only) 2367732 2367492 -240 -0.0
.text 1992480 1992240 -240 -0.0
p6 all-clusters-app default (read/write) 2529352 2529320 -32 -0.0
.text 1487616 1487584 -32 -0.0
light-app default (read/write) 2419912 2419880 -32 -0.0
.text 1378176 1378144 -32 -0.0
lock-app default (read/write) 2429192 2429160 -32 -0.0
.text 1387456 1387424 -32 -0.0
telink lighting-app tlsr9518adk80d text 571822 571820 -2 -0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section 4a145d6 3237315 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689527 16 0.0
(read/write) 162744 162728 -16 -0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586724 586740 16 0.0
lock-ftd LP_CC2652R7 (read only) 677303 677303 0 0.0
(read/write) 166208 166208 0 0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 582464 582464 0 0.0
lock-mtd LP_CC2652R7 (read only) 626047 626047 0 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 531312 531312 0 0.0
pump-app LP_CC2652R7 (read only) 661955 661971 16 0.0
(read/write) 182796 182780 -16 -0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80499 80499 0 0.0
.text 580972 580988 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654811 16 0.0
(read/write) 189756 189740 -16 -0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83435 83435 0 0.0
.text 570876 570892 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626914 16 0.0
.app_xip_area 529432 529448 16 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625594 625602 8 0.0
.app_xip_area 529592 529600 8 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574738 16 0.0
.app_xip_area 469100 469116 16 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908936 908904 -32 -0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908928 908896 -32 -0.0
BRD4161A+rpc (read only) 943280 943248 -32 -0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 943272 943240 -32 -0.0
BRD4161A+rs911x (read only) 747260 747228 -32 -0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 747252 747220 -32 -0.0
lock-app BRD4161A+wf200 (read only) 917184 917200 16 0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 917176 917192 16 0.0
window-app BRD4161A (read only) 846168 846136 -32 -0.0
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 846160 846128 -32 -0.0
k32w light k32w061+release (read/write) 684860 684876 16 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599828 599844 16 0.0
lock k32w061+release (read/write) 729676 729692 16 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 644260 644276 16 0.0
linux all-clusters-app debug (read only) 2732721 2732481 -240 -0.0
(read/write) 173336 173336 0 0.0
.bss 83584 83584 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234981 234981 0 0.0
.text 2323138 2322898 -240 -0.0
bridge-app debug+rpc (read only) 1887905 1887905 0 0.0
(read/write) 120664 120664 0 0.0
.bss 71584 71584 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1605090 1605090 0 0.0
chip-tool debug (read only) 8852773 8852773 0 0.0
(read/write) 550704 550704 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462581 462581 0 0.0
.text 7127525 7127525 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8694996 0 0.0
(read/write) 616497 616497 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429860 429860 0 0.0
.text 6867892 6867892 0 0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
(read/write) 151616 151616 0 0.0
.bss 73632 73632 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184553 184553 0 0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228433 -224 -0.0
(read/write) 146200 146200 0 0.0
.bss 72256 72256 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1874402 1874178 -224 -0.0
ota-provider-app debug (read only) 2056961 2056961 0 0.0
(read/write) 139216 139216 0 0.0
.bss 71648 71648 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1724738 1724738 0 0.0
ota-requestor-app debug (read only) 2088065 2088065 0 0.0
(read/write) 142024 142024 0 0.0
.bss 72288 72288 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1758082 1758082 0 0.0
shell debug (read only) 2557913 2557913 0 0.0
(read/write) 197328 197328 0 0.0
.bss 114312 114312 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2179666 2179666 0 0.0
thermostat-no-ble arm64 (read only) 2367732 2367492 -240 -0.0
(read/write) 174801 174801 0 0.0
.bss 86481 86481 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146100 146100 0 0.0
.text 1992480 1992240 -240 -0.0
tv-app debug (read only) 2840625 2840625 0 0.0
(read/write) 276832 276832 0 0.0
.bss 189496 189496 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217099 217099 0 0.0
.text 2441474 2441474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418892 2418892 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1381492 1381492 0 0.0
p6 all-clusters-app default (read/write) 2529352 2529320 -32 -0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1487616 1487584 -32 -0.0
light-app default (read/write) 2419912 2419880 -32 -0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1378176 1378144 -32 -0.0
lock-app default (read/write) 2429192 2429160 -32 -0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1387456 1387424 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 808144 0 0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571822 571820 -2 -0.0

@bzbarsky-apple
Align handling of missing SSID in ScanNetworks with spec changes.
f47340b 
Spec has made SSID optional for wifi ScanNetworks, with missing value
treated as null.
@bzbarsky-apple bzbarsky-apple force-pushed the wifi-ssid-optional-scan branch from 3237315 to f47340b Compare April 30, 2022 00:34
@github-actions
Copy link

github-actions bot commented Apr 30, 2022 •
edited
Loading

PR #17925: Size comparison from 9dc2682 to f47340b

Increases (10 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect)
platform target config section 9dc2682 f47340b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689047 689063 16 0.0
.text 586260 586276 16 0.0
pump-app LP_CC2652R7 (read only) 661347 661363 16 0.0
.text 580476 580492 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654187 654203 16 0.0
.text 570380 570396 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626426 626442 16 0.0
.app_xip_area 528960 528976 16 0.0
lock cyw930739m2evb_01 (read/write) 625122 625130 8 0.0
.app_xip_area 529120 529128 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574250 574266 16 0.0
.app_xip_area 468628 468644 16 0.0
efr32 lock-app BRD4161A+wf200 (read only) 916576 916592 16 0.0
.text 916568 916584 16 0.0
k32w light k32w061+release (read/write) 684396 684412 16 0.0
.text 599364 599380 16 0.0
lock k32w061+release (read/write) 729212 729228 16 0.0
.text 643796 643812 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 808752 808764 12 0.0
Decreases (17 builds for cc13x2_26x2, efr32, esp32, linux, p6, telink)
platform target config section 9dc2682 f47340b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163208 163192 -16 -0.0
pump-app LP_CC2652R7 (read/write) 183404 183388 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190364 190348 -16 -0.0
efr32 lighting-app BRD4161A (read only) 908248 908216 -32 -0.0
.text 908240 908208 -32 -0.0
BRD4161A+rpc (read only) 942592 942560 -32 -0.0
.text 942584 942552 -32 -0.0
BRD4161A+rs911x (read only) 746564 746532 -32 -0.0
.text 746556 746524 -32 -0.0
window-app BRD4161A (read only) 845480 845448 -32 -0.0
.text 845472 845440 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 999708 999696 -12 -0.0
.flash.text 999708 999696 -12 -0.0
m5stack (read only) 1054891 1054867 -24 -0.0
.flash.text 1049507 1049483 -24 -0.0
linux all-clusters-app debug (read only) 2730017 2729793 -224 -0.0
.text 2320562 2320338 -224 -0.0
lighting-app debug+rpc (read only) 2319577 2319337 -240 -0.0
.text 1968898 1968658 -240 -0.0
lock-app debug (read only) 2225969 2225729 -240 -0.0
.text 1871842 1871602 -240 -0.0
thermostat-no-ble arm64 (read only) 2365124 2364900 -224 -0.0
.text 1989984 1989760 -224 -0.0
p6 all-clusters-app default (read/write) 2528656 2528624 -32 -0.0
.text 1486920 1486888 -32 -0.0
light-app default (read/write) 2419224 2419192 -32 -0.0
.text 1377488 1377456 -32 -0.0
lock-app default (read/write) 2428496 2428464 -32 -0.0
.text 1386760 1386728 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807436 807428 -8 -0.0
text 571226 571224 -2 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9dc2682 f47340b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689047 689063 16 0.0
(read/write) 163208 163192 -16 -0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586260 586276 16 0.0
lock-ftd LP_CC2652R7 (read only) 676831 676831 0 0.0
(read/write) 166680 166680 0 0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 581992 581992 0 0.0
lock-mtd LP_CC2652R7 (read only) 625583 625583 0 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 530848 530848 0 0.0
pump-app LP_CC2652R7 (read only) 661347 661363 16 0.0
(read/write) 183404 183388 -16 -0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80387 80387 0 0.0
.text 580476 580492 16 0.0
pump-controller-app LP_CC2652R7 (read only) 654187 654203 16 0.0
(read/write) 190364 190348 -16 -0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83323 83323 0 0.0
.text 570380 570396 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626426 626442 16 0.0
.app_xip_area 528960 528976 16 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625122 625130 8 0.0
.app_xip_area 529120 529128 8 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574250 574266 16 0.0
.app_xip_area 468628 468644 16 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908248 908216 -32 -0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908240 908208 -32 -0.0
BRD4161A+rpc (read only) 942592 942560 -32 -0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 942584 942552 -32 -0.0
BRD4161A+rs911x (read only) 746564 746532 -32 -0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 746556 746524 -32 -0.0
lock-app BRD4161A+wf200 (read only) 916576 916592 16 0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 916568 916584 16 0.0
window-app BRD4161A (read only) 845480 845448 -32 -0.0
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 845472 845440 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 999708 999696 -12 -0.0
(read/write) 1474506 1474506 0 0.0
.dram0.bss 68376 68376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207248 207248 0 0.0
.flash.text 999708 999696 -12 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054891 1054867 -24 -0.0
(read/write) 476936 476936 0 0.0
.dram0.bss 73896 73896 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 237028 237028 0 0.0
.flash.text 1049507 1049483 -24 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684396 684412 16 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599364 599380 16 0.0
lock k32w061+release (read/write) 729212 729228 16 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 643796 643812 16 0.0
linux all-clusters-app debug (read only) 2730017 2729793 -224 -0.0
(read/write) 173112 173112 0 0.0
.bss 83360 83360 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234853 234853 0 0.0
.text 2320562 2320338 -224 -0.0
bridge-app debug+rpc (read only) 1885233 1885233 0 0.0
(read/write) 120440 120440 0 0.0
.bss 71360 71360 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160321 160321 0 0.0
.text 1602514 1602514 0 0.0
chip-tool debug (read only) 8850101 8850101 0 0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462485 462485 0 0.0
.text 7124949 7124949 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692404 0 0.0
(read/write) 616305 616305 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429748 429748 0 0.0
.text 6865412 6865412 0 0.0
lighting-app debug+rpc (read only) 2319577 2319337 -240 -0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184425 184425 0 0.0
.text 1968898 1968658 -240 -0.0
lock-app debug (read only) 2225969 2225729 -240 -0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194225 194225 0 0.0
.text 1871842 1871602 -240 -0.0
ota-provider-app debug (read only) 2054257 2054257 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 174971 174971 0 0.0
.text 1722162 1722162 0 0.0
ota-requestor-app debug (read only) 2085377 2085377 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171244 171244 0 0.0
.text 1755522 1755522 0 0.0
shell debug (read only) 2555225 2555225 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216594 216594 0 0.0
.text 2177106 2177106 0 0.0
thermostat-no-ble arm64 (read only) 2365124 2364900 -224 -0.0
(read/write) 174593 174593 0 0.0
.bss 86273 86273 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145988 145988 0 0.0
.text 1989984 1989760 -224 -0.0
tv-app debug (read only) 2837937 2837937 0 0.0
(read/write) 276608 276608 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216971 216971 0 0.0
.text 2438914 2438914 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418268 2418268 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1380868 1380868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180251 1180251 0 0.0
bss 142000 142000 0 0.0
rodata 150804 150804 0 0.0
text 808752 808764 12 0.0
p6 all-clusters-app default (read/write) 2528656 2528624 -32 -0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1486920 1486888 -32 -0.0
light-app default (read/write) 2419224 2419192 -32 -0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1377488 1377456 -32 -0.0
lock-app default (read/write) 2428496 2428464 -32 -0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1386760 1386728 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807436 807428 -8 -0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571226 571224 -2 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 12c39d4 into project-chip:master May 2, 2022
@bzbarsky-apple bzbarsky-apple deleted the wifi-ssid-optional-scan branch May 2, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved spec Mismatch between spec and implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt