-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Explicitly set chmod for Docker copied file #18031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
rgoliver
May 4, 2022 07:16
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 4, 2022 07:16
Without the explicit chmod the secret-tool might inherit incorrect permission bits from the build context - it might not be executable or might be inaccessible by non-root users. This commit also fixes RPM download from snapshots repository. Bug introduced in bfb4af1.
PR #18031: Size comparison from 0a9e871 to c5a4710 Full report (10 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
PR #18031: Size comparison from 0a9e871 to eaadfb5 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18031: Size comparison from 0a9e871 to 3e88f42 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 4, 2022
bzbarsky-apple
approved these changes
May 5, 2022
msandstedt
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without the explicit chmod the secret-tool might inherit incorrect permission bits from the build context - it might not be executable or might be inaccessible by non-root users (the latest image https://hub.docker.com/r/connectedhomeip/chip-build-tizen/tags has incorrect mode for this file - inaccessible by other users).
Change overview
chmod
in Dockerfile after COPYTesting
Tested locally if modifications of chmod in git (build context) will not affect Docker image.