-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "true" and "false" for boolean args in chip-tool. #18091
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:support-bool-chip-tool
May 6, 2022
Merged
Add support for "true" and "false" for boolean args in chip-tool. #18091
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:support-bool-chip-tool
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues allowing 0 and 1 for now for backwards compat, as aliases for false and true. Other numeric values continue not being allowed.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
May 5, 2022 15:12
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 5, 2022 15:12
PR #18091: Size comparison from dbfeeea to d3ef196 Increases (2 builds for linux)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
May 5, 2022
vivien-apple
approved these changes
May 5, 2022
PR #18091: Size comparison from dbfeeea to b29c92d Increases above 0.2%:
Increases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, efr32)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues allowing 0 and 1 for now for backwards compat, as
aliases for false and true. Other numeric values continue not being
allowed.
Problem
For booleans have to use 0/1 in chip-tool instead of false/true.
Change overview
Allow using false/true.
Testing
Ran
chip-tool operationalcredentials read fabrics ${NODE_ID} 0 --fabric-filtered false
andchip-tool operationalcredentials read fabrics ${NODE_ID} 0 --fabric-filtered true
on a node commissioned into multiple fabrics and verified the output is correct.