-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty events in report #18350
Merged
Damian-Nordic
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/allow_empty_events
May 12, 2022
Merged
Allow empty events in report #18350
Damian-Nordic
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/allow_empty_events
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
May 11, 2022 22:27
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
May 11, 2022 22:27
yunhanw-google
force-pushed
the
feature/allow_empty_events
branch
from
May 11, 2022 22:29
35e8d76
to
fb4669d
Compare
PR #18350: Size comparison from d2de7c1 to fb4669d Decreases (2 builds for linux)
Full report (7 builds for cyw30739, linux, mbed, telink)
|
yunhanw-google
force-pushed
the
feature/allow_empty_events
branch
from
May 11, 2022 22:52
fb4669d
to
93a029f
Compare
yunhanw-google
force-pushed
the
feature/allow_empty_events
branch
from
May 11, 2022 23:00
ad5116f
to
e795320
Compare
PR #18350: Size comparison from f59dbe1 to e795320 Decreases (13 builds for esp32, linux)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #18350: Size comparison from f59dbe1 to 7b95db7 Decreases (13 builds for esp32, linux)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 12, 2022
Damian-Nordic
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
spec says that empty event report list is allowed, but currently parser see it as protocol error
Change overview
Allow parser to process empty event list with no error.
Testing
Add unit test for the empty event event report list