Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All clusters app enable time format localization feature map attribute #18556

Merged
merged 2 commits into from
May 18, 2022
Merged

All clusters app enable time format localization feature map attribute #18556

merged 2 commits into from
May 18, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

The FeatureMap of the Time Format Localization cluster is not enabled.

Fix #17986

Change overview

  • Enable it

Testing

./out/debug/standalone/chip-tool timeformatlocalization read feature-map 0x12344321 0

@vivien-apple vivien-apple self-assigned this May 18, 2022
bzbarsky-apple
bzbarsky-apple approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, hoping for a better solution in #18213 but fine for now...

@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

PR #18556: Size comparison from 02d8302 to d2e2bd2

Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 02d8302 d2e2bd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692647 692663 16 0.0
.rodata 103911 103927 16 0.0
shell LP_CC2652R7 (read only) 687002 687018 16 0.0
.bss 77156 77164 8 0.0
.rodata 101458 101474 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1478082 1478106 24 0.0
.dram0.bss 68200 68208 8 0.0
.flash.rodata 209824 209848 24 0.0
m5stack (read/write) 480084 480100 16 0.0
.flash.rodata 240168 240184 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180875 1180895 20 0.0
bss 138372 138376 4 0.0
rodata 153044 153064 20 0.0
p6 all-clusters-app default (read/write) 2538928 2538944 16 0.0
.bss 136168 136176 8 0.0
.text 1497192 1497208 16 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 02d8302 d2e2bd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 158904 158888 -16 -0.0
shell LP_CC2652R7 (read/write) 160372 160364 -8 -0.0
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 02d8302 d2e2bd2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692647 692663 16 0.0
(read/write) 158904 158888 -16 -0.0
.bss 74532 74532 0 0.0
.data 3412 3412 0 0.0
.rodata 103911 103927 16 0.0
.text 588256 588256 0 0.0
lock-ftd LP_CC2652R7 (read only) 677367 677367 0 0.0
(read/write) 165288 165288 0 0.0
.bss 72692 72692 0 0.0
.data 3236 3236 0 0.0
.rodata 95055 95055 0 0.0
.text 581828 581828 0 0.0
lock-mtd LP_CC2652R7 (read only) 626183 626183 0 0.0
(read/write) 145524 145524 0 0.0
.bss 68428 68428 0 0.0
.data 3236 3236 0 0.0
.rodata 94943 94943 0 0.0
.text 530748 530748 0 0.0
pump-app LP_CC2652R7 (read only) 660875 660875 0 0.0
(read/write) 183060 183060 0 0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 80555 80555 0 0.0
.text 579840 579840 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654051 654051 0 0.0
(read/write) 189692 189692 0 0.0
.bss 73012 73012 0 0.0
.data 3232 3232 0 0.0
.rodata 83659 83659 0 0.0
.text 569912 569912 0 0.0
shell LP_CC2652R7 (read only) 687002 687018 16 0.0
(read/write) 160372 160364 -8 -0.0
.bss 77156 77164 8 0.0
.data 3416 3416 0 0.0
.rodata 101458 101474 16 0.0
.text 585060 585060 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 625446 625446 0 0.0
.app_xip_area 529060 529060 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628410 628410 0 0.0
.app_xip_area 533480 533480 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572794 572794 0 0.0
.app_xip_area 468148 468148 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917564 917564 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917556 917556 0 0.0
BRD4161A+rpc (read only) 951752 951752 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951744 951744 0 0.0
BRD4161A+rs911x (read only) 791004 791004 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 790996 790996 0 0.0
lock-app BRD4161A+wf200 (read only) 946904 946904 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946896 946896 0 0.0
window-app BRD4161A (read only) 897684 897684 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897676 897676 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000830 1000830 0 0.0
(read/write) 1478082 1478106 24 0.0
.dram0.bss 68200 68208 8 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209824 209848 24 0.0
.flash.text 1000830 1000830 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1055983 1055983 0 0.0
(read/write) 480084 480100 16 0.0
.dram0.bss 73720 73720 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240168 240184 16 0.0
.flash.text 1050599 1050599 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682972 682972 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 599028 599028 0 0.0
lock k32w061+release (read/write) 729476 729476 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645140 645140 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9077172 9077172 0 0.0
(read/write) 646161 646161 0 0.0
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583912 583912 0 0.0
.dynamic 560 560 0 0.0
.got 15008 15008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444980 444980 0 0.0
.text 7168052 7168052 0 0.0
thermostat-no-ble arm64 (read only) 2352604 2352604 0 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147148 147148 0 0.0
.text 1975440 1975440 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420568 2420568 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383212 1383212 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180875 1180895 20 0.0
bss 138372 138376 4 0.0
rodata 153044 153064 20 0.0
text 810576 810576 0 0.0
p6 all-clusters-app default (read/write) 2538928 2538944 16 0.0
.bss 136168 136176 8 0.0
.data 2808 2808 0 0.0
.text 1497192 1497208 16 0.0
light-app default (read/write) 2425376 2425376 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383640 1383640 0 0.0
lock-app default (read/write) 2436096 2436096 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394360 1394360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782624 782624 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553426 553426 0 0.0
lighting-app tlsr9518adk80d (read/write) 802708 802708 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570192 570192 0 0.0

@vivien-apple vivien-apple force-pushed the AllClustersApp_EnableTimeFormatLocalizationFeatureMapAttribute branch from d2e2bd2 to 99cb642 Compare May 18, 2022 17:33
@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

PR #18556: Size comparison from 76b1cb5 to 99cb642

Increases (6 builds for esp32, linux, nrfconnect, p6)
platform target config section 76b1cb5 99cb642 change % change
esp32 all-clusters-app c3devkit (read/write) 1478106 1478122 16 0.0
.flash.rodata 209848 209864 16 0.0
m5stack (read/write) 480100 480132 32 0.0
.dram0.bss 73720 73728 8 0.0
.flash.rodata 240184 240208 24 0.0
linux all-clusters-app debug (read only) 2750985 2751009 24 0.0
(read/write) 175904 175936 32 0.0
.data.rel.ro 82616 82648 32 0.0
shell debug (read only) 2566777 2566801 24 0.0
(read/write) 199800 199832 32 0.0
.data.rel.ro 76904 76936 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180943 1180963 20 0.0
bss 138376 138380 4 0.0
rodata 153064 153084 20 0.0
p6 all-clusters-app default (read/write) 2538992 2539016 24 0.0
.text 1497256 1497280 24 0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 76b1cb5 99cb642 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625502 625502 0 0.0
.app_xip_area 529116 529116 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628466 628466 0 0.0
.app_xip_area 533536 533536 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572850 572850 0 0.0
.app_xip_area 468204 468204 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917628 917628 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917620 917620 0 0.0
BRD4161A+rpc (read only) 951800 951800 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951792 951792 0 0.0
BRD4161A+rs911x (read only) 791068 791068 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 791060 791060 0 0.0
lock-app BRD4161A+wf200 (read only) 946968 946968 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946960 946960 0 0.0
window-app BRD4161A (read only) 897732 897732 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897724 897724 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000900 1000900 0 0.0
(read/write) 1478106 1478122 16 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209848 209864 16 0.0
.flash.text 1000900 1000900 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056035 1056035 0 0.0
(read/write) 480100 480132 32 0.0
.dram0.bss 73720 73728 8 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240184 240208 24 0.0
.flash.text 1050651 1050651 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683020 683020 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 599076 599076 0 0.0
lock k32w061+release (read/write) 729524 729524 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645188 645188 0 0.0
linux all-clusters-app debug (read only) 2750985 2751009 24 0.0
(read/write) 175904 175936 32 0.0
.bss 85056 85056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82616 82648 32 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 240733 240733 0 0.0
.text 2333922 2333922 0 0.0
bridge-app debug+rpc (read only) 2032545 2032545 0 0.0
(read/write) 147736 147736 0 0.0
.bss 72832 72832 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65384 65384 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168873 168873 0 0.0
.text 1705474 1705474 0 0.0
chip-tool debug (read only) 9308901 9308901 0 0.0
(read/write) 580088 580088 0 0.0
.bss 23936 23936 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 548704 548704 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 479933 479933 0 0.0
.text 7499877 7499877 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9078244 9078244 0 0.0
(read/write) 646209 646209 0 0.0
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583952 583952 0 0.0
.dynamic 560 560 0 0.0
.got 15016 15016 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444948 444948 0 0.0
.text 7169060 7169060 0 0.0
lighting-app debug+rpc (read only) 2327073 2327073 0 0.0
(read/write) 153184 153184 0 0.0
.bss 74624 74624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187913 187913 0 0.0
.text 1971730 1971730 0 0.0
lock-app debug (read only) 2240657 2240657 0 0.0
(read/write) 147864 147864 0 0.0
.bss 73312 73312 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198585 198585 0 0.0
.text 1880962 1880962 0 0.0
ota-provider-app debug (read only) 2061241 2061241 0 0.0
(read/write) 140944 140944 0 0.0
.bss 72768 72768 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60616 60616 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 178944 178944 0 0.0
.text 1723682 1723682 0 0.0
ota-requestor-app debug (read only) 2090433 2090433 0 0.0
(read/write) 143720 143720 0 0.0
.bss 73440 73440 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62648 62648 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175008 175008 0 0.0
.text 1755346 1755346 0 0.0
shell debug (read only) 2566777 2566801 24 0.0
(read/write) 199800 199832 32 0.0
.bss 115752 115752 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76904 76936 32 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 221746 221746 0 0.0
.text 2182082 2182082 0 0.0
thermostat-no-ble arm64 (read only) 2352844 2352844 0 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147148 147148 0 0.0
.text 1975680 1975680 0 0.0
tv-app debug (read only) 2852769 2852769 0 0.0
(read/write) 278752 278752 0 0.0
.bss 190712 190712 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 77096 77096 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221009 221009 0 0.0
.text 2448194 2448194 0 0.0
tv-casting-app debug (read only) 5415481 5415481 0 0.0
(read/write) 224992 224992 0 0.0
.bss 78328 78328 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 138088 138088 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339521 339521 0 0.0
.text 4715362 4715362 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420632 2420632 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383276 1383276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180943 1180963 20 0.0
bss 138376 138380 4 0.0
rodata 153064 153084 20 0.0
text 810632 810632 0 0.0
p6 all-clusters-app default (read/write) 2538992 2539016 24 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497256 1497280 24 0.0
light-app default (read/write) 2425424 2425424 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383688 1383688 0 0.0
lock-app default (read/write) 2436144 2436144 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394408 1394408 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782688 782688 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553492 553492 0 0.0
lighting-app tlsr9518adk80d (read/write) 802780 802780 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570258 570258 0 0.0

@andy31415 andy31415 merged commit 4ba6d4f into project-chip:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved
Projects
None yet
Milestone
No milestone
4 participants
@vivien-apple @andy31415 @bzbarsky-apple @Damian-Nordic