Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mrp] Fix #17471 - send standalone ack before crypto ops in CASE and PASE. #18773

Merged
merged 7 commits into from
Jun 1, 2022
Merged

[mrp] Fix #17471 - send standalone ack before crypto ops in CASE and PASE. #18773

merged 7 commits into from
Jun 1, 2022

Conversation

turon
Copy link
Contributor

@turon turon commented May 24, 2022 •
edited
Loading

Fix #17471

  • Added CHIP_DEVICE_CONFIG_SLOW_CRYPTO with default of 1
  • Force send a standalone ack response to all CASE and PASE when above flag enabled.
  • Adjusted expected # of expected packets in CASE and PASE tests.

Problem

CASE and PASE senders are getting excessive retries due to crypto operations delaying acknowledgement.

Testing

CI primarily

@boring-cyborg boring-cyborg bot added the lib label May 24, 2022
@github-actions
Copy link

github-actions bot commented May 24, 2022 •
edited
Loading

PR #18773: Size comparison from 2b02a50 to 0d68c5f

Full report (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2b02a50 0d68c5f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669743 669743 0 0.0
(read/write) 182112 182112 0 0.0
.bss 74836 74836 0 0.0
.data 3404 3404 0 0.0
.rodata 100655 100655 0 0.0
.text 568864 568864 0 0.0
lock-ftd LP_CC2652R7 (read only) 676471 676471 0 0.0
(read/write) 166376 166376 0 0.0
.bss 72884 72884 0 0.0
.data 3236 3236 0 0.0
.rodata 94551 94551 0 0.0
.text 581436 581436 0 0.0
lock-mtd LP_CC2652R7 (read only) 625879 625879 0 0.0
(read/write) 145716 145716 0 0.0
.bss 68620 68620 0 0.0
.data 3236 3236 0 0.0
.rodata 94431 94431 0 0.0
.text 530956 530956 0 0.0
pump-app LP_CC2652R7 (read only) 676331 676331 0 0.0
(read/write) 167940 167940 0 0.0
.bss 73284 73284 0 0.0
.data 3272 3272 0 0.0
.rodata 88771 88771 0 0.0
.text 587076 587076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654307 654307 0 0.0
(read/write) 189564 189564 0 0.0
.bss 73140 73140 0 0.0
.data 3232 3232 0 0.0
.rodata 83547 83547 0 0.0
.text 570280 570280 0 0.0
shell LP_CC2652R7 (read only) 662750 662750 0 0.0
(read/write) 184664 184664 0 0.0
.bss 77196 77196 0 0.0
.data 3408 3408 0 0.0
.rodata 97622 97622 0 0.0
.text 564900 564900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624734 624734 0 0.0
.app_xip_area 528012 528012 0 0.0
.bss 79364 79364 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627402 627402 0 0.0
.app_xip_area 532152 532152 0 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571178 571178 0 0.0
.app_xip_area 466244 466244 0 0.0
.bss 87312 87312 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916020 916020 0 0.0
(read/write) 133452 133452 0 0.0
.bss 131392 131392 0 0.0
.data 2060 2060 0 0.0
.text 916012 916012 0 0.0
BRD4161A+rpc (read only) 950192 950192 0 0.0
(read/write) 150136 150136 0 0.0
.bss 147872 147872 0 0.0
.data 2264 2264 0 0.0
.text 950184 950184 0 0.0
BRD4161A+rs911x (read only) 790612 790612 0 0.0
(read/write) 129720 129720 0 0.0
.bss 127652 127652 0 0.0
.data 2068 2068 0 0.0
.text 790604 790604 0 0.0
lock-app BRD4161A+wf200 (read only) 947080 947080 0 0.0
(read/write) 124188 124188 0 0.0
.bss 122164 122164 0 0.0
.data 2024 2024 0 0.0
.text 947072 947072 0 0.0
window-app BRD4161A (read only) 897212 897212 0 0.0
(read/write) 133504 133504 0 0.0
.bss 131456 131456 0 0.0
.data 2048 2048 0 0.0
.text 897204 897204 0 0.0
esp32 all-clusters-app c3devkit (read only) 1003030 1003030 0 0.0
(read/write) 1479978 1479978 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 210536 210536 0 0.0
.flash.text 1003030 1003030 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057815 1057815 0 0.0
(read/write) 481992 481992 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240884 240884 0 0.0
.flash.text 1052431 1052431 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683256 683256 0 0.0
.bss 80432 80432 0 0.0
.data 2016 2016 0 0.0
.text 599104 599104 0 0.0
lock k32w061+release (read/write) 729268 729268 0 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 644732 644732 0 0.0
linux all-clusters-app debug (read only) 2760073 2760073 0 0.0
(read/write) 178752 178752 0 0.0
.bss 86496 86496 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 241437 241437 0 0.0
.text 2344034 2344034 0 0.0
bridge-app debug+rpc (read only) 2035161 2035161 0 0.0
(read/write) 148440 148440 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65736 65736 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169065 169065 0 0.0
.text 1708978 1708978 0 0.0
chip-tool debug (read only) 9610669 9610669 0 0.0
(read/write) 596856 596856 0 0.0
.bss 24000 24000 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 565400 565400 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 492957 492957 0 0.0
.text 7738533 7738533 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9350020 9350020 0 0.0
(read/write) 663057 663057 0 0.0
.bss 42241 42241 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 600760 600760 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456748 456748 0 0.0
.text 7378772 7378772 0 0.0
lighting-app debug+rpc (read only) 2327513 2327513 0 0.0
(read/write) 154016 154016 0 0.0
.bss 74976 74976 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71240 71240 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188073 188073 0 0.0
.text 1973090 1973090 0 0.0
lock-app debug (read only) 2240369 2240369 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73664 73664 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67688 67688 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198713 198713 0 0.0
.text 1881698 1881698 0 0.0
ota-provider-app debug (read only) 2065593 2065593 0 0.0
(read/write) 141456 141456 0 0.0
.bss 73088 73088 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60792 60792 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179872 179872 0 0.0
.text 1727154 1727154 0 0.0
ota-requestor-app debug (read only) 2094545 2094545 0 0.0
(read/write) 144264 144264 0 0.0
.bss 73760 73760 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175840 175840 0 0.0
.text 1758674 1758674 0 0.0
shell debug (read only) 2576185 2576185 0 0.0
(read/write) 202776 202776 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 222418 222418 0 0.0
.text 2192546 2192546 0 0.0
thermostat-no-ble arm64 (read only) 2360916 2360916 0 0.0
(read/write) 177457 177457 0 0.0
.bss 88193 88193 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79944 79944 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147812 147812 0 0.0
.text 1984032 1984032 0 0.0
tv-app debug (read only) 2874217 2874217 0 0.0
(read/write) 280448 280448 0 0.0
.bss 191352 191352 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221809 221809 0 0.0
.text 2469922 2469922 0 0.0
tv-casting-app debug (read only) 5451601 5451601 0 0.0
(read/write) 226880 226880 0 0.0
.bss 78936 78936 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 139336 139336 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340929 340929 0 0.0
.text 4749954 4749954 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419208 2419208 0 0.0
.bss 202860 202860 0 0.0
.data 5872 5872 0 0.0
.text 1381852 1381852 0 0.0
p6 all-clusters-app default (read/write) 2541304 2541304 0 0.0
.bss 137360 137360 0 0.0
.data 2808 2808 0 0.0
.text 1499568 1499568 0 0.0
light-app default (read/write) 2424616 2424616 0 0.0
.bss 129696 129696 0 0.0
.data 2608 2608 0 0.0
.text 1382880 1382880 0 0.0
lock-app default (read/write) 2435176 2435176 0 0.0
.bss 129504 129504 0 0.0
.data 2568 2568 0 0.0
.text 1393440 1393440 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782900 782900 0 0.0
bss 70828 70828 0 0.0
noinit 40416 40416 0 0.0
text 553508 553508 0 0.0
lighting-app tlsr9518adk80d (read/write) 802924 802924 0 0.0
bss 71080 71080 0 0.0
noinit 40416 40416 0 0.0
text 570242 570242 0 0.0

@github-actions
Copy link

github-actions bot commented May 24, 2022 •
edited
Loading

PR #18773: Size comparison from 2b02a50 to e6bb8cc

Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b02a50 e6bb8cc change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669743 669831 88 0.0
.text 568864 568952 88 0.0
lock-ftd LP_CC2652R7 (read only) 676471 676559 88 0.0
.text 581436 581524 88 0.0
lock-mtd LP_CC2652R7 (read only) 625879 625975 96 0.0
.text 530956 531052 96 0.0
pump-app LP_CC2652R7 (read only) 676331 676419 88 0.0
.text 587076 587164 88 0.0
pump-controller-app LP_CC2652R7 (read only) 654307 654395 88 0.0
.text 570280 570368 88 0.0
shell LP_CC2652R7 (read only) 662750 662838 88 0.0
.text 564900 564988 88 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624734 624822 88 0.0
.app_xip_area 528012 528100 88 0.0
lock cyw930739m2evb_01 (read/write) 627402 627490 88 0.0
.app_xip_area 532152 532240 88 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571178 571258 80 0.0
.app_xip_area 466244 466324 80 0.0
efr32 lighting-app BRD4161A (read only) 916020 916084 64 0.0
.text 916012 916076 64 0.0
BRD4161A+rpc (read only) 950192 950256 64 0.0
.text 950184 950248 64 0.0
BRD4161A+rs911x (read only) 790612 790676 64 0.0
.text 790604 790668 64 0.0
lock-app BRD4161A+wf200 (read only) 947080 947176 96 0.0
.text 947072 947168 96 0.0
window-app BRD4161A (read only) 897212 897292 80 0.0
.text 897204 897284 80 0.0
esp32 all-clusters-app c3devkit (read only) 1003030 1003100 70 0.0
.flash.text 1003030 1003100 70 0.0
m5stack (read only) 1057815 1057883 68 0.0
.flash.text 1052431 1052499 68 0.0
k32w light k32w061+release (read/write) 683256 683336 80 0.0
.text 599104 599184 80 0.0
lock k32w061+release (read/write) 729268 729364 96 0.0
.text 644732 644828 96 0.0
linux all-clusters-app debug (read only) 2760073 2760329 256 0.0
.text 2344034 2344290 256 0.0
bridge-app debug+rpc (read only) 2035161 2035433 272 0.0
.text 1708978 1709250 272 0.0
chip-tool debug (read only) 9610669 9610925 256 0.0
.text 7738533 7738789 256 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9350020 9350292 272 0.0
.text 7378772 7379044 272 0.0
lighting-app debug+rpc (read only) 2327513 2327769 256 0.0
.text 1973090 1973346 256 0.0
lock-app debug (read only) 2240369 2240641 272 0.0
.text 1881698 1881970 272 0.0
ota-provider-app debug (read only) 2065593 2065849 256 0.0
.text 1727154 1727410 256 0.0
ota-requestor-app debug (read only) 2094545 2094801 256 0.0
.text 1758674 1758930 256 0.0
shell debug (read only) 2576185 2576441 256 0.0
.text 2192546 2192802 256 0.0
thermostat-no-ble arm64 (read only) 2360916 2361188 272 0.0
.text 1984032 1984304 272 0.0
tv-app debug (read only) 2874217 2874473 256 0.0
.text 2469922 2470178 256 0.0
tv-casting-app debug (read only) 5451601 5451873 272 0.0
.text 4749954 4750226 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2419208 2419408 200 0.0
.text 1381852 1382052 200 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1184539 1184635 96 0.0
text 812448 812540 92 0.0
p6 all-clusters-app default (read/write) 2541304 2541368 64 0.0
.text 1499568 1499632 64 0.0
light-app default (read/write) 2424616 2424696 80 0.0
.text 1382880 1382960 80 0.0
lock-app default (read/write) 2435176 2435240 64 0.0
.text 1393440 1393504 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782900 782944 44 0.0
text 553508 553552 44 0.0
lighting-app tlsr9518adk80d (read/write) 802924 802968 44 0.0
text 570242 570286 44 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 2b02a50 e6bb8cc change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182112 182024 -88 -0.0
lock-ftd LP_CC2652R7 (read/write) 166376 166288 -88 -0.1
pump-app LP_CC2652R7 (read/write) 167940 167852 -88 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189564 189476 -88 -0.0
shell LP_CC2652R7 (read/write) 184664 184576 -88 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b02a50 e6bb8cc change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669743 669831 88 0.0
(read/write) 182112 182024 -88 -0.0
.bss 74836 74836 0 0.0
.data 3404 3404 0 0.0
.rodata 100655 100655 0 0.0
.text 568864 568952 88 0.0
lock-ftd LP_CC2652R7 (read only) 676471 676559 88 0.0
(read/write) 166376 166288 -88 -0.1
.bss 72884 72884 0 0.0
.data 3236 3236 0 0.0
.rodata 94551 94551 0 0.0
.text 581436 581524 88 0.0
lock-mtd LP_CC2652R7 (read only) 625879 625975 96 0.0
(read/write) 145716 145716 0 0.0
.bss 68620 68620 0 0.0
.data 3236 3236 0 0.0
.rodata 94431 94431 0 0.0
.text 530956 531052 96 0.0
pump-app LP_CC2652R7 (read only) 676331 676419 88 0.0
(read/write) 167940 167852 -88 -0.1
.bss 73284 73284 0 0.0
.data 3272 3272 0 0.0
.rodata 88771 88771 0 0.0
.text 587076 587164 88 0.0
pump-controller-app LP_CC2652R7 (read only) 654307 654395 88 0.0
(read/write) 189564 189476 -88 -0.0
.bss 73140 73140 0 0.0
.data 3232 3232 0 0.0
.rodata 83547 83547 0 0.0
.text 570280 570368 88 0.0
shell LP_CC2652R7 (read only) 662750 662838 88 0.0
(read/write) 184664 184576 -88 -0.0
.bss 77196 77196 0 0.0
.data 3408 3408 0 0.0
.rodata 97622 97622 0 0.0
.text 564900 564988 88 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624734 624822 88 0.0
.app_xip_area 528012 528100 88 0.0
.bss 79364 79364 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627402 627490 88 0.0
.app_xip_area 532152 532240 88 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571178 571258 80 0.0
.app_xip_area 466244 466324 80 0.0
.bss 87312 87312 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916020 916084 64 0.0
(read/write) 133452 133452 0 0.0
.bss 131392 131392 0 0.0
.data 2060 2060 0 0.0
.text 916012 916076 64 0.0
BRD4161A+rpc (read only) 950192 950256 64 0.0
(read/write) 150136 150136 0 0.0
.bss 147872 147872 0 0.0
.data 2264 2264 0 0.0
.text 950184 950248 64 0.0
BRD4161A+rs911x (read only) 790612 790676 64 0.0
(read/write) 129720 129720 0 0.0
.bss 127652 127652 0 0.0
.data 2068 2068 0 0.0
.text 790604 790668 64 0.0
lock-app BRD4161A+wf200 (read only) 947080 947176 96 0.0
(read/write) 124188 124188 0 0.0
.bss 122164 122164 0 0.0
.data 2024 2024 0 0.0
.text 947072 947168 96 0.0
window-app BRD4161A (read only) 897212 897292 80 0.0
(read/write) 133504 133504 0 0.0
.bss 131456 131456 0 0.0
.data 2048 2048 0 0.0
.text 897204 897284 80 0.0
esp32 all-clusters-app c3devkit (read only) 1003030 1003100 70 0.0
(read/write) 1479978 1479978 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 210536 210536 0 0.0
.flash.text 1003030 1003100 70 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057815 1057883 68 0.0
(read/write) 481992 481992 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240884 240884 0 0.0
.flash.text 1052431 1052499 68 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683256 683336 80 0.0
.bss 80432 80432 0 0.0
.data 2016 2016 0 0.0
.text 599104 599184 80 0.0
lock k32w061+release (read/write) 729268 729364 96 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 644732 644828 96 0.0
linux all-clusters-app debug (read only) 2760073 2760329 256 0.0
(read/write) 178752 178752 0 0.0
.bss 86496 86496 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 241437 241437 0 0.0
.text 2344034 2344290 256 0.0
bridge-app debug+rpc (read only) 2035161 2035433 272 0.0
(read/write) 148440 148440 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65736 65736 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169065 169065 0 0.0
.text 1708978 1709250 272 0.0
chip-tool debug (read only) 9610669 9610925 256 0.0
(read/write) 596856 596856 0 0.0
.bss 24000 24000 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 565400 565400 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 492957 492957 0 0.0
.text 7738533 7738789 256 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9350020 9350292 272 0.0
(read/write) 663057 663057 0 0.0
.bss 42241 42241 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 600760 600760 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456748 456748 0 0.0
.text 7378772 7379044 272 0.0
lighting-app debug+rpc (read only) 2327513 2327769 256 0.0
(read/write) 154016 154016 0 0.0
.bss 74976 74976 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71240 71240 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188073 188073 0 0.0
.text 1973090 1973346 256 0.0
lock-app debug (read only) 2240369 2240641 272 0.0
(read/write) 148632 148632 0 0.0
.bss 73664 73664 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67688 67688 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198713 198713 0 0.0
.text 1881698 1881970 272 0.0
ota-provider-app debug (read only) 2065593 2065849 256 0.0
(read/write) 141456 141456 0 0.0
.bss 73088 73088 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60792 60792 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179872 179872 0 0.0
.text 1727154 1727410 256 0.0
ota-requestor-app debug (read only) 2094545 2094801 256 0.0
(read/write) 144264 144264 0 0.0
.bss 73760 73760 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175840 175840 0 0.0
.text 1758674 1758930 256 0.0
shell debug (read only) 2576185 2576441 256 0.0
(read/write) 202776 202776 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 222418 222418 0 0.0
.text 2192546 2192802 256 0.0
thermostat-no-ble arm64 (read only) 2360916 2361188 272 0.0
(read/write) 177457 177457 0 0.0
.bss 88193 88193 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79944 79944 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147812 147812 0 0.0
.text 1984032 1984304 272 0.0
tv-app debug (read only) 2874217 2874473 256 0.0
(read/write) 280448 280448 0 0.0
.bss 191352 191352 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221809 221809 0 0.0
.text 2469922 2470178 256 0.0
tv-casting-app debug (read only) 5451601 5451873 272 0.0
(read/write) 226880 226880 0 0.0
.bss 78936 78936 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 139336 139336 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340929 340929 0 0.0
.text 4749954 4750226 272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419208 2419408 200 0.0
.bss 202860 202860 0 0.0
.data 5872 5872 0 0.0
.text 1381852 1382052 200 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1184539 1184635 96 0.0
bss 139560 139560 0 0.0
rodata 153684 153684 0 0.0
text 812448 812540 92 0.0
p6 all-clusters-app default (read/write) 2541304 2541368 64 0.0
.bss 137360 137360 0 0.0
.data 2808 2808 0 0.0
.text 1499568 1499632 64 0.0
light-app default (read/write) 2424616 2424696 80 0.0
.bss 129696 129696 0 0.0
.data 2608 2608 0 0.0
.text 1382880 1382960 80 0.0
lock-app default (read/write) 2435176 2435240 64 0.0
.bss 129504 129504 0 0.0
.data 2568 2568 0 0.0
.text 1393440 1393504 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782900 782944 44 0.0
bss 70828 70828 0 0.0
noinit 40416 40416 0 0.0
text 553508 553552 44 0.0
lighting-app tlsr9518adk80d (read/write) 802924 802968 44 0.0
bss 71080 71080 0 0.0
noinit 40416 40416 0 0.0
text 570242 570286 44 0.0

@turon turon changed the title [mrp] Fix #17471 - send standalone ack before long crypto in CASE and PASE. [mrp] Fix #17471 - send standalone ack before long crypto ops in CASE and PASE. May 24, 2022
@turon turon changed the title [mrp] Fix #17471 - send standalone ack before long crypto ops in CASE and PASE. [mrp] Fix #17471 - send standalone ack before crypto ops in CASE and PASE. May 24, 2022
bzbarsky-apple
bzbarsky-apple approved these changes May 25, 2022
View reviewed changes
src/protocols/secure_channel/PASESession.cpp Outdated Show resolved Hide resolved
src/protocols/secure_channel/CASESession.cpp Outdated Show resolved Hide resolved
@turon @bzbarsky-apple
[mrp] Call FlushAcks rather than SendStandaloneAckMessage.
44aa9d1 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@turon turon requested a review from tcarmelveilleux May 27, 2022 19:48
@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

PR #18773: Size comparison from d2a6470 to 017c0d1

Increases (33 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2a6470 017c0d1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645223 88 0.0
.text 561116 561204 88 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679523 88 0.0
.text 582876 582964 88 0.0
lock-mtd LP_CC2652R7 (read only) 628843 628931 88 0.0
.text 532396 532484 88 0.0
pump-app LP_CC2652R7 (read only) 675863 675951 88 0.0
.text 586828 586916 88 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653879 88 0.0
.text 570016 570104 88 0.0
shell LP_CC2652R7 (read only) 638142 638230 88 0.0
.text 557152 557240 88 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621750 88 0.0
.app_xip_area 524928 525016 88 0.0
lock cyw930739m2evb_01 (read/write) 630370 630458 88 0.0
.app_xip_area 535108 535196 88 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570854 96 0.0
.app_xip_area 465816 465912 96 0.0
efr32 lighting-app BRD4161A (read only) 914152 914232 80 0.0
.text 914144 914224 80 0.0
BRD4161A+rpc (read only) 948324 948404 80 0.0
.text 948316 948396 80 0.0
BRD4161A+rs911x (read only) 788724 788804 80 0.0
.text 788716 788796 80 0.0
lock-app BRD4161A+wf200 (read only) 954012 954108 96 0.0
.text 954004 954100 96 0.0
window-app BRD4161A (read only) 899096 899176 80 0.0
.text 899088 899168 80 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002436 70 0.0
.flash.text 1002366 1002436 70 0.0
m5stack (read only) 1057635 1057715 80 0.0
.flash.text 1052251 1052331 80 0.0
k32w light k32w061+release (read/write) 680892 680988 96 0.0
.text 596740 596836 96 0.0
lock k32w061+release (read/write) 732232 732312 80 0.0
.text 647680 647760 80 0.0
linux all-clusters-app debug (read only) 2751465 2751481 16 0.0
.text 2335666 2335682 16 0.0
bridge-app debug+rpc (read only) 2024001 2024017 16 0.0
.text 1699586 1699602 16 0.0
chip-tool debug (read only) 9680229 9680245 16 0.0
.text 7790373 7790389 16 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423788 16 0.0
.text 7434724 7434740 16 0.0
ota-provider-app debug (read only) 2066657 2066673 16 0.0
.text 1728130 1728146 16 0.0
ota-requestor-app debug (read only) 2095873 2095889 16 0.0
.text 1759874 1759890 16 0.0
thermostat-no-ble arm64 (read only) 2359836 2359852 16 0.0
.text 1982960 1982976 16 0.0
tv-casting-app debug (read only) 5426113 5426129 16 0.0
.text 4728082 4728098 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2423968 2424224 256 0.0
.text 1386612 1386868 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183519 80 0.0
text 811892 811980 88 0.0
p6 all-clusters-app default (read/write) 2536808 2536888 80 0.0
.text 1495072 1495152 80 0.0
light-app default (read/write) 2420080 2420160 80 0.0
.text 1378344 1378424 80 0.0
lock-app default (read/write) 2438112 2438192 80 0.0
.text 1396376 1396456 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779632 44 0.0
text 551262 551306 44 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799664 52 0.0
text 567996 568040 44 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section d2a6470 017c0d1 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163660 163572 -88 -0.1
pump-app LP_CC2652R7 (read/write) 168400 168312 -88 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190328 190240 -88 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2a6470 017c0d1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 645135 645223 88 0.0
(read/write) 159168 159168 0 0.0
.bss 74852 74852 0 0.0
.data 3400 3400 0 0.0
.rodata 83783 83783 0 0.0
.text 561116 561204 88 0.0
lock-ftd LP_CC2652R7 (read only) 679435 679523 88 0.0
(read/write) 163660 163572 -88 -0.1
.bss 72876 72876 0 0.0
.data 3264 3264 0 0.0
.rodata 96075 96075 0 0.0
.text 582876 582964 88 0.0
lock-mtd LP_CC2652R7 (read only) 628843 628931 88 0.0
(read/write) 145992 145992 0 0.0
.bss 68612 68612 0 0.0
.data 3264 3264 0 0.0
.rodata 95955 95955 0 0.0
.text 532396 532484 88 0.0
pump-app LP_CC2652R7 (read only) 675863 675951 88 0.0
(read/write) 168400 168312 -88 -0.1
.bss 73276 73276 0 0.0
.data 3300 3300 0 0.0
.rodata 88551 88551 0 0.0
.text 586828 586916 88 0.0
pump-controller-app LP_CC2652R7 (read only) 653791 653879 88 0.0
(read/write) 190328 190240 -88 -0.0
.bss 73132 73132 0 0.0
.data 3260 3260 0 0.0
.rodata 83295 83295 0 0.0
.text 570016 570104 88 0.0
shell LP_CC2652R7 (read only) 638142 638230 88 0.0
(read/write) 154724 154724 0 0.0
.bss 77204 77204 0 0.0
.data 3404 3404 0 0.0
.rodata 80758 80758 0 0.0
.text 557152 557240 88 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621662 621750 88 0.0
.app_xip_area 524928 525016 88 0.0
.bss 79376 79376 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630370 630458 88 0.0
.app_xip_area 535108 535196 88 0.0
.bss 77936 77936 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570758 570854 96 0.0
.app_xip_area 465816 465912 96 0.0
.bss 87296 87296 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914152 914232 80 0.0
(read/write) 133464 133464 0 0.0
.bss 131368 131368 0 0.0
.data 2092 2092 0 0.0
.text 914144 914224 80 0.0
BRD4161A+rpc (read only) 948324 948404 80 0.0
(read/write) 150152 150152 0 0.0
.bss 147856 147856 0 0.0
.data 2296 2296 0 0.0
.text 948316 948396 80 0.0
BRD4161A+rs911x (read only) 788724 788804 80 0.0
(read/write) 129736 129736 0 0.0
.bss 127636 127636 0 0.0
.data 2100 2100 0 0.0
.text 788716 788796 80 0.0
lock-app BRD4161A+wf200 (read only) 954012 954108 96 0.0
(read/write) 128508 128508 0 0.0
.bss 126444 126444 0 0.0
.data 2064 2064 0 0.0
.text 954004 954100 96 0.0
window-app BRD4161A (read only) 899096 899176 80 0.0
(read/write) 133520 133520 0 0.0
.bss 131432 131432 0 0.0
.data 2088 2088 0 0.0
.text 899088 899168 80 0.0
esp32 all-clusters-app c3devkit (read only) 1002366 1002436 70 0.0
(read/write) 1479362 1479362 0 0.0
.dram0.bss 69416 69416 0 0.0
.dram0.data 14640 14640 0 0.0
.flash.rodata 209872 209872 0 0.0
.flash.text 1002366 1002436 70 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057635 1057715 80 0.0
(read/write) 481616 481616 0 0.0
.dram0.bss 74944 74944 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240468 240468 0 0.0
.flash.text 1052251 1052331 80 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680892 680988 96 0.0
.bss 80440 80440 0 0.0
.data 2008 2008 0 0.0
.text 596740 596836 96 0.0
lock k32w061+release (read/write) 732232 732312 80 0.0
.bss 80872 80872 0 0.0
.data 1976 1976 0 0.0
.text 647680 647760 80 0.0
linux all-clusters-app debug (read only) 2751465 2751481 16 0.0
(read/write) 178336 178336 0 0.0
.bss 86528 86528 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83608 83608 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242205 242205 0 0.0
.text 2335666 2335682 16 0.0
bridge-app debug+rpc (read only) 2024001 2024017 16 0.0
(read/write) 148024 148024 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65320 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168256 168256 0 0.0
.text 1699586 1699602 16 0.0
chip-tool debug (read only) 9680229 9680245 16 0.0
(read/write) 602512 602512 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571136 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497213 497213 0 0.0
.text 7790373 7790389 16 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423772 9423788 16 0.0
(read/write) 668833 668833 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606528 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460916 460916 0 0.0
.text 7434724 7434740 16 0.0
lighting-app debug+rpc (read only) 2314385 2314385 0 0.0
(read/write) 153632 153632 0 0.0
.bss 75008 75008 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70824 70824 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186952 186952 0 0.0
.text 1962066 1962066 0 0.0
lock-app debug (read only) 2253497 2253497 0 0.0
(read/write) 148728 148728 0 0.0
.bss 73696 73696 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67752 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200328 200328 0 0.0
.text 1893234 1893234 0 0.0
ota-provider-app debug (read only) 2066657 2066673 16 0.0
(read/write) 141456 141456 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60824 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179960 179960 0 0.0
.text 1728130 1728146 16 0.0
ota-requestor-app debug (read only) 2095873 2095889 16 0.0
(read/write) 144296 144296 0 0.0
.bss 73760 73760 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 62920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175968 175968 0 0.0
.text 1759874 1759890 16 0.0
shell debug (read only) 2555825 2555825 0 0.0
(read/write) 201840 201840 0 0.0
.bss 117448 117448 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222386 222386 0 0.0
.text 2174354 2174354 0 0.0
thermostat-no-ble arm64 (read only) 2359836 2359852 16 0.0
(read/write) 177585 177585 0 0.0
.bss 88209 88209 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 80008 80008 0 0.0
.dynamic 560 560 0 0.0
.got 4808 4808 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147532 147532 0 0.0
.text 1982960 1982976 16 0.0
tv-app debug (read only) 2875169 2875169 0 0.0
(read/write) 280464 280464 0 0.0
.bss 191368 191368 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78152 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221888 221888 0 0.0
.text 2470866 2470866 0 0.0
tv-casting-app debug (read only) 5426113 5426129 16 0.0
(read/write) 226160 226160 0 0.0
.bss 78952 78952 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138576 138576 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339136 339136 0 0.0
.text 4728082 4728098 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423968 2424224 256 0.0
.bss 202892 202892 0 0.0
.data 5872 5872 0 0.0
.text 1386612 1386868 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183439 1183519 80 0.0
bss 139552 139552 0 0.0
rodata 153112 153112 0 0.0
text 811892 811980 88 0.0
p6 all-clusters-app default (read/write) 2536808 2536888 80 0.0
.bss 137376 137376 0 0.0
.data 2800 2800 0 0.0
.text 1495072 1495152 80 0.0
light-app default (read/write) 2420080 2420160 80 0.0
.bss 129712 129712 0 0.0
.data 2600 2600 0 0.0
.text 1378344 1378424 80 0.0
lock-app default (read/write) 2438112 2438192 80 0.0
.bss 129520 129520 0 0.0
.data 2568 2568 0 0.0
.text 1396376 1396456 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779588 779632 44 0.0
bss 70840 70840 0 0.0
noinit 40416 40416 0 0.0
text 551262 551306 44 0.0
lighting-app tlsr9518adk80d (read/write) 799612 799664 52 0.0
bss 71100 71100 0 0.0
noinit 40416 40416 0 0.0
text 567996 568040 44 0.0

@bzbarsky-apple bzbarsky-apple merged commit c29619c into project-chip:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@emargolis emargolis Awaiting requested review from emargolis

@msandstedt msandstedt Awaiting requested review from msandstedt

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
config darwin lib linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MRP failures trying to commission all-clusters-app on m5stack
5 participants
@turon @tcarmelveilleux @msandstedt @emargolis @bzbarsky-apple