Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated IsCertificateValidAtIssuance() Input Parameters in the Test. #18780

Merged
merged 1 commit into from
May 26, 2022
Merged

Updated IsCertificateValidAtIssuance() Input Parameters in the Test. #18780

merged 1 commit into from
May 26, 2022

Conversation

emargolis
Copy link
Contributor

Change overview

Added more test cases and negative testing.

Testing

existing tests and added new tests

@boring-cyborg boring-cyborg bot added the crypto label May 24, 2022
@github-actions
Copy link

github-actions bot commented May 24, 2022 •
edited
Loading

PR #18780: Size comparison from 2b02a50 to 1e60159

Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2b02a50 1e60159 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669743 669743 0 0.0
(read/write) 182112 182112 0 0.0
.bss 74836 74836 0 0.0
.data 3404 3404 0 0.0
.rodata 100655 100655 0 0.0
.text 568864 568864 0 0.0
lock-ftd LP_CC2652R7 (read only) 676471 676471 0 0.0
(read/write) 166376 166376 0 0.0
.bss 72884 72884 0 0.0
.data 3236 3236 0 0.0
.rodata 94551 94551 0 0.0
.text 581436 581436 0 0.0
lock-mtd LP_CC2652R7 (read only) 625879 625879 0 0.0
(read/write) 145716 145716 0 0.0
.bss 68620 68620 0 0.0
.data 3236 3236 0 0.0
.rodata 94431 94431 0 0.0
.text 530956 530956 0 0.0
pump-app LP_CC2652R7 (read only) 676331 676331 0 0.0
(read/write) 167940 167940 0 0.0
.bss 73284 73284 0 0.0
.data 3272 3272 0 0.0
.rodata 88771 88771 0 0.0
.text 587076 587076 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654307 654307 0 0.0
(read/write) 189564 189564 0 0.0
.bss 73140 73140 0 0.0
.data 3232 3232 0 0.0
.rodata 83547 83547 0 0.0
.text 570280 570280 0 0.0
shell LP_CC2652R7 (read only) 662750 662750 0 0.0
(read/write) 184664 184664 0 0.0
.bss 77196 77196 0 0.0
.data 3408 3408 0 0.0
.rodata 97622 97622 0 0.0
.text 564900 564900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 624734 624734 0 0.0
.app_xip_area 528012 528012 0 0.0
.bss 79364 79364 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627402 627402 0 0.0
.app_xip_area 532152 532152 0 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571178 571178 0 0.0
.app_xip_area 466244 466244 0 0.0
.bss 87312 87312 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916020 916020 0 0.0
(read/write) 133452 133452 0 0.0
.bss 131392 131392 0 0.0
.data 2060 2060 0 0.0
.text 916012 916012 0 0.0
BRD4161A+rpc (read only) 950192 950192 0 0.0
(read/write) 150136 150136 0 0.0
.bss 147872 147872 0 0.0
.data 2264 2264 0 0.0
.text 950184 950184 0 0.0
BRD4161A+rs911x (read only) 790612 790612 0 0.0
(read/write) 129720 129720 0 0.0
.bss 127652 127652 0 0.0
.data 2068 2068 0 0.0
.text 790604 790604 0 0.0
lock-app BRD4161A+wf200 (read only) 947080 947080 0 0.0
(read/write) 124188 124188 0 0.0
.bss 122164 122164 0 0.0
.data 2024 2024 0 0.0
.text 947072 947072 0 0.0
window-app BRD4161A (read only) 897212 897212 0 0.0
(read/write) 133504 133504 0 0.0
.bss 131456 131456 0 0.0
.data 2048 2048 0 0.0
.text 897204 897204 0 0.0
esp32 all-clusters-app c3devkit (read only) 1003030 1003030 0 0.0
(read/write) 1479978 1479978 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 210536 210536 0 0.0
.flash.text 1003030 1003030 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057815 1057815 0 0.0
(read/write) 481992 481992 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240884 240884 0 0.0
.flash.text 1052431 1052431 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683256 683256 0 0.0
.bss 80432 80432 0 0.0
.data 2016 2016 0 0.0
.text 599104 599104 0 0.0
lock k32w061+release (read/write) 729268 729268 0 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 644732 644732 0 0.0
linux all-clusters-app debug (read only) 2760073 2760073 0 0.0
(read/write) 178752 178752 0 0.0
.bss 86496 86496 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 241437 241437 0 0.0
.text 2344034 2344034 0 0.0
bridge-app debug+rpc (read only) 2035161 2035161 0 0.0
(read/write) 148440 148440 0 0.0
.bss 73184 73184 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65736 65736 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169065 169065 0 0.0
.text 1708978 1708978 0 0.0
chip-tool debug (read only) 9610669 9610669 0 0.0
(read/write) 596856 596856 0 0.0
.bss 24000 24000 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 565400 565400 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 492957 492957 0 0.0
.text 7738533 7738533 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9350020 9350020 0 0.0
(read/write) 663057 663057 0 0.0
.bss 42241 42241 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 600760 600760 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456748 456748 0 0.0
.text 7378772 7378772 0 0.0
lighting-app debug+rpc (read only) 2327513 2327513 0 0.0
(read/write) 154016 154016 0 0.0
.bss 74976 74976 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71240 71240 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188073 188073 0 0.0
.text 1973090 1973090 0 0.0
lock-app debug (read only) 2240369 2240369 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73664 73664 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67688 67688 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198713 198713 0 0.0
.text 1881698 1881698 0 0.0
ota-provider-app debug (read only) 2065593 2065593 0 0.0
(read/write) 141456 141456 0 0.0
.bss 73088 73088 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60792 60792 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179872 179872 0 0.0
.text 1727154 1727154 0 0.0
ota-requestor-app debug (read only) 2094545 2094545 0 0.0
(read/write) 144264 144264 0 0.0
.bss 73760 73760 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175840 175840 0 0.0
.text 1758674 1758674 0 0.0
shell debug (read only) 2576185 2576185 0 0.0
(read/write) 202776 202776 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 222418 222418 0 0.0
.text 2192546 2192546 0 0.0
thermostat-no-ble arm64 (read only) 2360916 2360916 0 0.0
(read/write) 177457 177457 0 0.0
.bss 88193 88193 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79944 79944 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147812 147812 0 0.0
.text 1984032 1984032 0 0.0
tv-app debug (read only) 2874217 2874217 0 0.0
(read/write) 280448 280448 0 0.0
.bss 191352 191352 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221809 221809 0 0.0
.text 2469922 2469922 0 0.0
tv-casting-app debug (read only) 5451601 5451601 0 0.0
(read/write) 226880 226880 0 0.0
.bss 78936 78936 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 139336 139336 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340929 340929 0 0.0
.text 4749954 4749954 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419208 2419208 0 0.0
.bss 202860 202860 0 0.0
.data 5872 5872 0 0.0
.text 1381852 1381852 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1184539 1184539 0 0.0
bss 139560 139560 0 0.0
rodata 153684 153684 0 0.0
text 812448 812448 0 0.0
p6 all-clusters-app default (read/write) 2541304 2541304 0 0.0
.bss 137360 137360 0 0.0
.data 2808 2808 0 0.0
.text 1499568 1499568 0 0.0
light-app default (read/write) 2424616 2424616 0 0.0
.bss 129696 129696 0 0.0
.data 2608 2608 0 0.0
.text 1382880 1382880 0 0.0
lock-app default (read/write) 2435176 2435176 0 0.0
.bss 129504 129504 0 0.0
.data 2568 2568 0 0.0
.text 1393440 1393440 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782900 782900 0 0.0
bss 70828 70828 0 0.0
noinit 40416 40416 0 0.0
text 553508 553508 0 0.0
lighting-app tlsr9518adk80d (read/write) 802924 802924 0 0.0
bss 71080 71080 0 0.0
noinit 40416 40416 0 0.0
text 570242 570242 0 0.0

@tcarmelveilleux tcarmelveilleux merged commit 0db3261 into project-chip:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
crypto review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @tcarmelveilleux @bzbarsky-apple