Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ember] Optimize out ember strings in release builds #18806

Merged
merged 2 commits into from
May 26, 2022
Merged

[ember] Optimize out ember strings in release builds #18806

merged 2 commits into from
May 26, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Ember strings are still included in the binary even if the progress logging is disabled.

Change overview

Resolve emberPrint to noop if the progress logging is disabled.
The change saves around 14kB of flash in the case of nRF connect examples.

Testing

CI + smoke tests on nRF Connect platform.

LuDuda
LuDuda approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions
Copy link

github-actions bot commented May 25, 2022 •
edited
Loading

PR #18806: Size comparison from a3fdd05 to bf4ae07

Increases (1 build for cyw30739)
platform target config section a3fdd05 bf4ae07 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87304 87308 4 0.0
Decreases (1 build for cyw30739)
platform target config section a3fdd05 bf4ae07 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571218 570790 -428 -0.1
.app_xip_area 466292 465860 -432 -0.1
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a3fdd05 bf4ae07 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 622134 622134 0 0.0
.app_xip_area 525412 525412 0 0.0
.bss 79364 79364 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627450 627450 0 0.0
.app_xip_area 532200 532200 0 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571218 570790 -428 -0.1
.app_xip_area 466292 465860 -432 -0.1
.bss 87304 87308 4 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 912284 912284 0 0.0
(read/write) 133436 133436 0 0.0
.bss 131384 131384 0 0.0
.data 2052 2052 0 0.0
.text 912276 912276 0 0.0
BRD4161A+rpc (read only) 946456 946456 0 0.0
(read/write) 150128 150128 0 0.0
.bss 147872 147872 0 0.0
.data 2256 2256 0 0.0
.text 946448 946448 0 0.0
BRD4161A+rs911x (read only) 786852 786852 0 0.0
(read/write) 129704 129704 0 0.0
.bss 127644 127644 0 0.0
.data 2060 2060 0 0.0
.text 786844 786844 0 0.0
lock-app BRD4161A+wf200 (read only) 947056 947056 0 0.0
(read/write) 124180 124180 0 0.0
.bss 122156 122156 0 0.0
.data 2024 2024 0 0.0
.text 947048 947048 0 0.0
window-app BRD4161A (read only) 897188 897188 0 0.0
(read/write) 133496 133496 0 0.0
.bss 131448 131448 0 0.0
.data 2048 2048 0 0.0
.text 897180 897180 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001112 1001112 0 0.0
(read/write) 1479114 1479114 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14616 14616 0 0.0
.flash.rodata 209672 209672 0 0.0
.flash.text 1001112 1001112 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056139 1056139 0 0.0
(read/write) 481144 481144 0 0.0
.dram0.bss 74904 74904 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240044 240044 0 0.0
.flash.text 1050755 1050755 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681216 681216 0 0.0
.bss 80424 80424 0 0.0
.data 2008 2008 0 0.0
.text 597080 597080 0 0.0
lock k32w061+release (read/write) 729316 729316 0 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 644780 644780 0 0.0
linux all-clusters-app debug (read only) 2747161 2747161 0 0.0
(read/write) 178240 178240 0 0.0
.bss 86464 86464 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 83560 83560 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 240317 240317 0 0.0
.text 2333202 2333202 0 0.0
bridge-app debug+rpc (read only) 2022281 2022281 0 0.0
(read/write) 147928 147928 0 0.0
.bss 73152 73152 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65272 65272 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 167977 167977 0 0.0
.text 1698146 1698146 0 0.0
chip-tool debug (read only) 9609981 9609981 0 0.0
(read/write) 596824 596824 0 0.0
.bss 23968 23968 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 565400 565400 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 492797 492797 0 0.0
.text 7738005 7738005 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9349380 9349380 0 0.0
(read/write) 663057 663057 0 0.0
.bss 42241 42241 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 600760 600760 0 0.0
.dynamic 560 560 0 0.0
.got 15024 15024 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456652 456652 0 0.0
.text 7378228 7378228 0 0.0
lighting-app debug+rpc (read only) 2314665 2314665 0 0.0
(read/write) 153536 153536 0 0.0
.bss 74944 74944 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70792 70792 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187017 187017 0 0.0
.text 1962258 1962258 0 0.0
lock-app debug (read only) 2239633 2239633 0 0.0
(read/write) 148600 148600 0 0.0
.bss 73632 73632 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67688 67688 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198489 198489 0 0.0
.text 1881186 1881186 0 0.0
ota-provider-app debug (read only) 2064873 2064873 0 0.0
(read/write) 141424 141424 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60792 60792 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179680 179680 0 0.0
.text 1726626 1726626 0 0.0
ota-requestor-app debug (read only) 2093825 2093825 0 0.0
(read/write) 144232 144232 0 0.0
.bss 73728 73728 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175648 175648 0 0.0
.text 1758146 1758146 0 0.0
shell debug (read only) 2563337 2563337 0 0.0
(read/write) 202328 202328 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77776 77776 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 221362 221362 0 0.0
.text 2181714 2181714 0 0.0
thermostat-no-ble arm64 (read only) 2360276 2360276 0 0.0
(read/write) 177441 177441 0 0.0
.bss 88177 88177 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79944 79944 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147716 147716 0 0.0
.text 1983488 1983488 0 0.0
tv-app debug (read only) 2873497 2873497 0 0.0
(read/write) 280416 280416 0 0.0
.bss 191320 191320 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221617 221617 0 0.0
.text 2469394 2469394 0 0.0
tv-casting-app debug (read only) 5438721 5438721 0 0.0
(read/write) 226400 226400 0 0.0
.bss 78904 78904 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138888 138888 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339841 339841 0 0.0
.text 4739122 4739122 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419216 2419216 0 0.0
.bss 202852 202852 0 0.0
.data 5872 5872 0 0.0
.text 1381860 1381860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181875 1181875 0 0.0
bss 139552 139552 0 0.0
rodata 152844 152844 0 0.0
text 810628 810628 0 0.0
p6 all-clusters-app default (read/write) 2537544 2537544 0 0.0
.bss 137352 137352 0 0.0
.data 2800 2800 0 0.0
.text 1495808 1495808 0 0.0
light-app default (read/write) 2420856 2420856 0 0.0
.bss 129688 129688 0 0.0
.data 2600 2600 0 0.0
.text 1379120 1379120 0 0.0
lock-app default (read/write) 2435136 2435136 0 0.0
.bss 129496 129496 0 0.0
.data 2568 2568 0 0.0
.text 1393400 1393400 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780088 780088 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 551574 551574 0 0.0
lighting-app tlsr9518adk80d (read/write) 800104 800104 0 0.0
bss 71076 71076 0 0.0
noinit 40416 40416 0 0.0
text 568308 568308 0 0.0

@Damian-Nordic
[ember] Optimize out ember strings in release builds
40b21d8 
Ember strings are still included in the binary even if the
progress logging is disabled. The change saves around 14kB
of flash in the case of nRF connect examples.

Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
@Damian-Nordic
Fix build
4c27a38
@boring-cyborg boring-cyborg bot added the app label May 26, 2022
@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

PR #18806: Size comparison from 433c5ff to 4c27a38

Increases (2 builds for cyw30739, p6)
platform target config section 433c5ff 4c27a38 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87304 87308 4 0.0
p6 all-clusters-app default (read/write) 2537112 2537128 16 0.0
.text 1495376 1495392 16 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, linux)
platform target config section 433c5ff 4c27a38 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667287 645147 -22140 -3.3
(read/write) 184560 159144 -25416 -13.8
.rodata 100103 83779 -16324 -16.3
.text 566956 561132 -5824 -1.0
shell LP_CC2652R7 (read only) 660302 638170 -22132 -3.4
(read/write) 187104 154708 -32396 -17.3
.rodata 97070 80754 -16316 -16.8
.text 563008 557184 -5824 -1.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570598 -412 -0.1
.app_xip_area 466084 465668 -416 -0.1
esp32 all-clusters-app m5stack (read only) 1055891 1055887 -4 -0.0
.flash.text 1050507 1050503 -4 -0.0
linux all-clusters-app debug (read only) 2748681 2748665 -16 -0.0
.text 2334594 2334578 -16 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 433c5ff 4c27a38 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667287 645147 -22140 -3.3
(read/write) 184560 159144 -25416 -13.8
.bss 74828 74828 0 0.0
.data 3400 3400 0 0.0
.rodata 100103 83779 -16324 -16.3
.text 566956 561132 -5824 -1.0
lock-ftd LP_CC2652R7 (read only) 676327 676327 0 0.0
(read/write) 166512 166512 0 0.0
.bss 72876 72876 0 0.0
.data 3236 3236 0 0.0
.rodata 94551 94551 0 0.0
.text 581292 581292 0 0.0
lock-mtd LP_CC2652R7 (read only) 625727 625727 0 0.0
(read/write) 145708 145708 0 0.0
.bss 68612 68612 0 0.0
.data 3236 3236 0 0.0
.rodata 94431 94431 0 0.0
.text 530804 530804 0 0.0
pump-app LP_CC2652R7 (read only) 676115 676115 0 0.0
(read/write) 168148 168148 0 0.0
.bss 73276 73276 0 0.0
.data 3272 3272 0 0.0
.rodata 88715 88715 0 0.0
.text 586916 586916 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654099 654099 0 0.0
(read/write) 189764 189764 0 0.0
.bss 73132 73132 0 0.0
.data 3232 3232 0 0.0
.rodata 83499 83499 0 0.0
.text 570120 570120 0 0.0
shell LP_CC2652R7 (read only) 660302 638170 -22132 -3.4
(read/write) 187104 154708 -32396 -17.3
.bss 77188 77188 0 0.0
.data 3404 3404 0 0.0
.rodata 97070 80754 -16316 -16.8
.text 563008 557184 -5824 -1.0
cyw30739 light cyw930739m2evb_01 (read/write) 621950 621950 0 0.0
.app_xip_area 525228 525228 0 0.0
.bss 79364 79364 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 627258 627258 0 0.0
.app_xip_area 532008 532008 0 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570598 -412 -0.1
.app_xip_area 466084 465668 -416 -0.1
.bss 87304 87308 4 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 911852 911852 0 0.0
(read/write) 133436 133436 0 0.0
.bss 131384 131384 0 0.0
.data 2052 2052 0 0.0
.text 911844 911844 0 0.0
BRD4161A+rpc (read only) 945992 945992 0 0.0
(read/write) 150128 150128 0 0.0
.bss 147872 147872 0 0.0
.data 2256 2256 0 0.0
.text 945984 945984 0 0.0
BRD4161A+rs911x (read only) 786436 786436 0 0.0
(read/write) 129704 129704 0 0.0
.bss 127644 127644 0 0.0
.data 2060 2060 0 0.0
.text 786428 786428 0 0.0
lock-app BRD4161A+wf200 (read only) 946864 946864 0 0.0
(read/write) 124180 124180 0 0.0
.bss 122156 122156 0 0.0
.data 2024 2024 0 0.0
.text 946856 946856 0 0.0
window-app BRD4161A (read only) 896772 896772 0 0.0
(read/write) 133496 133496 0 0.0
.bss 131448 131448 0 0.0
.data 2048 2048 0 0.0
.text 896764 896764 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000820 1000820 0 0.0
(read/write) 1479114 1479114 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14616 14616 0 0.0
.flash.rodata 209672 209672 0 0.0
.flash.text 1000820 1000820 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1055891 1055887 -4 -0.0
(read/write) 481144 481144 0 0.0
.dram0.bss 74904 74904 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240044 240044 0 0.0
.flash.text 1050507 1050503 -4 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681024 681024 0 0.0
.bss 80424 80424 0 0.0
.data 2008 2008 0 0.0
.text 596888 596888 0 0.0
lock k32w061+release (read/write) 729124 729124 0 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 644588 644588 0 0.0
linux all-clusters-app debug (read only) 2748681 2748665 -16 -0.0
(read/write) 178240 178240 0 0.0
.bss 86496 86496 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83560 83560 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 240445 240445 0 0.0
.text 2334594 2334578 -16 -0.0
bridge-app debug+rpc (read only) 2023793 2023793 0 0.0
(read/write) 147896 147896 0 0.0
.bss 73120 73120 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65272 65272 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168096 168096 0 0.0
.text 1699538 1699538 0 0.0
chip-tool debug (read only) 9606005 9606005 0 0.0
(read/write) 596176 596176 0 0.0
.bss 23936 23936 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 564832 564832 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 492605 492605 0 0.0
.text 7735349 7735349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9345604 9345604 0 0.0
(read/write) 662353 662353 0 0.0
.bss 42225 42225 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600160 600160 0 0.0
.dynamic 560 560 0 0.0
.got 14944 14944 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 456460 456460 0 0.0
.text 7376084 7376084 0 0.0
lighting-app debug+rpc (read only) 2316121 2316121 0 0.0
(read/write) 153536 153536 0 0.0
.bss 74944 74944 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70776 70776 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187112 187112 0 0.0
.text 1963618 1963618 0 0.0
lock-app debug (read only) 2241153 2241153 0 0.0
(read/write) 148600 148600 0 0.0
.bss 73632 73632 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67704 67704 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198632 198632 0 0.0
.text 1882562 1882562 0 0.0
ota-provider-app debug (read only) 2066337 2066337 0 0.0
(read/write) 141360 141360 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60776 60776 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179768 179768 0 0.0
.text 1728002 1728002 0 0.0
ota-requestor-app debug (read only) 2095345 2095345 0 0.0
(read/write) 144200 144200 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175776 175776 0 0.0
.text 1759538 1759538 0 0.0
shell debug (read only) 2556049 2556049 0 0.0
(read/write) 201744 201744 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 220978 220978 0 0.0
.text 2175938 2175938 0 0.0
thermostat-no-ble arm64 (read only) 2361692 2361692 0 0.0
(read/write) 177425 177425 0 0.0
.bss 88177 88177 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79920 79920 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147708 147708 0 0.0
.text 1984928 1984928 0 0.0
tv-app debug (read only) 2875001 2875001 0 0.0
(read/write) 280368 280368 0 0.0
.bss 191304 191304 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221728 221728 0 0.0
.text 2470786 2470786 0 0.0
tv-casting-app debug (read only) 5440065 5440065 0 0.0
(read/write) 226416 226416 0 0.0
.bss 78888 78888 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138896 138896 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339936 339936 0 0.0
.text 4740370 4740370 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418120 2418120 0 0.0
.bss 202852 202852 0 0.0
.data 5872 5872 0 0.0
.text 1380764 1380764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181747 1181747 0 0.0
bss 139560 139560 0 0.0
rodata 152844 152844 0 0.0
text 810508 810508 0 0.0
p6 all-clusters-app default (read/write) 2537112 2537128 16 0.0
.bss 137352 137352 0 0.0
.data 2800 2800 0 0.0
.text 1495376 1495392 16 0.0
light-app default (read/write) 2420424 2420424 0 0.0
.bss 129688 129688 0 0.0
.data 2600 2600 0 0.0
.text 1378688 1378688 0 0.0
lock-app default (read/write) 2434704 2434704 0 0.0
.bss 129496 129496 0 0.0
.data 2568 2568 0 0.0
.text 1392968 1392968 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779872 779872 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 551364 551364 0 0.0
lighting-app tlsr9518adk80d (read/write) 799896 799896 0 0.0
bss 71076 71076 0 0.0
noinit 40416 40416 0 0.0
text 568098 568098 0 0.0

@Damian-Nordic Damian-Nordic merged commit 0219efa into project-chip:master May 26, 2022
@Damian-Nordic Damian-Nordic deleted the ember-print branch May 26, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Damian-Nordic @andy31415 @LuDuda @mrjerryjohns @harsha-rajendran @bzbarsky-apple