Update thread-network-diagnostics-cluster to align with the spec #18920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #18920: Size comparison from 5865352 to cc034ff Decreases (2 builds for esp32, linux)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
May 30, 2022
There was a problem hiding this comment.
I agree with the xml changes but shouldn't that be reflected in the encoding of the attributes on read commands as they are both encoded as lists
in src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
err = encoder.EncodeList([OpDatasetComponents](const auto & aEncoder) -> CHIP_ERROR {
ReturnErrorOnFailure(aEncoder.Encode(OpDatasetComponents));
return CHIP_NO_ERROR;
});
err = encoder.EncodeList([securityPolicy](const auto & aEncoder) -> CHIP_ERROR {
ReturnErrorOnFailure(aEncoder.Encode(securityPolicy));
return CHIP_NO_ERROR;
});
Good catch, updated |
|
PR #18920: Size comparison from 5121bf8 to 8af5381 Increases (4 builds for cc13x2_26x2, esp32)
Decreases (21 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
May 31, 2022
|
PR #18920: Size comparison from a35c4c4 to cc31daf Increases (4 builds for cc13x2_26x2, esp32)
Decreases (19 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Update thread-network-diagnostics-cluster to align with the spec
Testing
How was this tested? (at least one bullet point required)