Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TV Android app - Add commissioning User Prompter to TV android app #18926

Merged
merged 22 commits into from
May 31, 2022
Merged

TV Android app - Add commissioning User Prompter to TV android app #18926

merged 22 commits into from
May 31, 2022

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented May 29, 2022 •
edited
Loading

Problem

  • TV Android App does not have a UI support for UserPrompter logic
  • End users are not able to confirm or decline commissioning request
  • End users are not able to enter PIN to confirm commissioning request

Change overview

  • Added JNI layer for Native C++ UserPrompter logic so that code can prompt end users with UI dialog
  • Added JNI layer to Android UserPrompter logic so that code can pass back user response (accept/decline) or pin code

Testing

Manually tested the flow using the instrucitons @chrisdecenzo shared with me:

  1. Overwrite your src/platform/android/java/chip/platform/NsdManagerServiceResolver.java with the file provided
  2. For full shell command functionality from casting app, replace your OperationalDeviceProxy.h/cpp with the file
  3. Create a UDP port mapping from 5750 to 5650
    telnet localhost 5554
    auth XXXXX
    redir add udp:5750:5650
    redir add udp:5740:5640
  4. run linux tv-casting-app. It won't discover the TV so you need to manually force a user-directed-commissioning request to the TV using the remapped port:
    cast sendudc 127.0.0.1 5750
  5. The TV should receive the UDC command and automatically commission the casting app. Watch tv-app logs for messages like:
    ------PROMPT USER: is requesting permission to cast to this TV, approve? [0x0000_0000,0x0000_0000,AB4E0808D7EFD3B3]
    ------PROMPT USER: please enter pin displayed in casting app
    ------PROMPT USER: commissioning success
    Right now, tv-app is hardcoded to automatically commission since there is no current dialog box implemented.

lazarkov and others added 8 commits May 30, 2022 16:47
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
99f690d 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
ea48d7c 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
11cf153 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
056dc14 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
290fdd5 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov @chrisdecenzo
Update examples/tv-app/android/App/platform-app/src/main/java/com/mat…
6001999 
…ter/tv/server/MatterCommissioningPrompter.java

Co-authored-by: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
@lazarkov
Restyle fix
7de10c1
@lazarkov
Converted the error to string
f25e8c8
@lazarkov lazarkov force-pushed the feature/add-user-prompter-to-tv-android-app branch from abf3937 to f25e8c8 Compare May 30, 2022 15:25
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

PR #18926: Size comparison from e1c9658 to f25e8c8

Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 f25e8c8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647583 647583 0 0.0
(read/write) 158928 158928 0 0.0
.bss 74612 74612 0 0.0
.data 3400 3400 0 0.0
.rodata 84159 84159 0 0.0
.text 563188 563188 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 614455 614455 0 0.0
(read/write) 158100 158100 0 0.0
.bss 73844 73844 0 0.0
.data 3340 3340 0 0.0
.rodata 73551 73551 0 0.0
.text 540668 540668 0 0.0
lock-ftd LP_CC2652R7 (read only) 679567 679567 0 0.0
(read/write) 163288 163288 0 0.0
.bss 72636 72636 0 0.0
.data 3264 3264 0 0.0
.rodata 96135 96135 0 0.0
.text 582948 582948 0 0.0
lock-mtd LP_CC2652R7 (read only) 628967 628967 0 0.0
(read/write) 145752 145752 0 0.0
.bss 68372 68372 0 0.0
.data 3264 3264 0 0.0
.rodata 96015 96015 0 0.0
.text 532460 532460 0 0.0
pump-app LP_CC2652R7 (read only) 675979 675979 0 0.0
(read/write) 168044 168044 0 0.0
.bss 73036 73036 0 0.0
.data 3300 3300 0 0.0
.rodata 88611 88611 0 0.0
.text 586884 586884 0 0.0
pump-controller-app LP_CC2652R7 (read only) 653915 653915 0 0.0
(read/write) 189964 189964 0 0.0
.bss 72892 72892 0 0.0
.data 3260 3260 0 0.0
.rodata 83347 83347 0 0.0
.text 570088 570088 0 0.0
shell LP_CC2652R7 (read only) 640614 640614 0 0.0
(read/write) 154484 154484 0 0.0
.bss 76964 76964 0 0.0
.data 3404 3404 0 0.0
.rodata 81142 81142 0 0.0
.text 559240 559240 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621514 621514 0 0.0
.app_xip_area 525020 525020 0 0.0
.bss 79136 79136 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630214 630214 0 0.0
.app_xip_area 535192 535192 0 0.0
.bss 77696 77696 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570838 0 0.0
.app_xip_area 465896 465896 0 0.0
.bss 87296 87296 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914288 914288 0 0.0
(read/write) 133216 133216 0 0.0
.bss 131120 131120 0 0.0
.data 2092 2092 0 0.0
.text 914280 914280 0 0.0
BRD4161A+rpc (read only) 948508 948508 0 0.0
(read/write) 149904 149904 0 0.0
.bss 147608 147608 0 0.0
.data 2296 2296 0 0.0
.text 948500 948500 0 0.0
BRD4161A+rs911x (read only) 788836 788836 0 0.0
(read/write) 129488 129488 0 0.0
.bss 127388 127388 0 0.0
.data 2100 2100 0 0.0
.text 788828 788828 0 0.0
lock-app BRD4161A+wf200 (read only) 954064 954064 0 0.0
(read/write) 128268 128268 0 0.0
.bss 126204 126204 0 0.0
.data 2064 2064 0 0.0
.text 954056 954056 0 0.0
window-app BRD4161A (read only) 899216 899216 0 0.0
(read/write) 133280 133280 0 0.0
.bss 131192 131192 0 0.0
.data 2088 2088 0 0.0
.text 899208 899208 0 0.0
esp32 all-clusters-app c3devkit (read only) 1004822 1004822 0 0.0
(read/write) 1479522 1479522 0 0.0
.dram0.bss 69176 69176 0 0.0
.dram0.data 14648 14648 0 0.0
.flash.rodata 210256 210256 0 0.0
.flash.text 1004822 1004822 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060023 1060023 0 0.0
(read/write) 481744 481744 0 0.0
.dram0.bss 74696 74696 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240844 240844 0 0.0
.flash.text 1054639 1054639 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680676 680676 0 0.0
.bss 80200 80200 0 0.0
.data 2008 2008 0 0.0
.text 596764 596764 0 0.0
lock k32w061+release (read/write) 732092 732092 0 0.0
.bss 80632 80632 0 0.0
.data 1976 1976 0 0.0
.text 647780 647780 0 0.0
linux all-clusters-app debug (read only) 2766585 2766585 0 0.0
(read/write) 178080 178080 0 0.0
.bss 86272 86272 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83624 83624 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243645 243645 0 0.0
.text 2349538 2349538 0 0.0
all-clusters-minimal-app debug (read only) 2643737 2643737 0 0.0
(read/write) 170112 170112 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76520 76520 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2226130 2226130 0 0.0
bridge-app debug+rpc (read only) 2028681 2028681 0 0.0
(read/write) 147768 147768 0 0.0
.bss 72928 72928 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65320 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168832 168832 0 0.0
.text 1703858 1703858 0 0.0
chip-tool debug (read only) 9678149 9678149 0 0.0
(read/write) 602512 602512 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571136 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496349 496349 0 0.0
.text 7789157 7789157 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422124 9422124 0 0.0
(read/write) 668785 668785 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606528 0 0.0
.dynamic 528 528 0 0.0
.got 15016 15016 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459956 459956 0 0.0
.text 7434100 7434100 0 0.0
lighting-app debug+rpc (read only) 2317505 2317505 0 0.0
(read/write) 153408 153408 0 0.0
.bss 74784 74784 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70824 70824 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187464 187464 0 0.0
.text 1964818 1964818 0 0.0
lock-app debug (read only) 2257257 2257257 0 0.0
(read/write) 148504 148504 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67752 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1896562 1896562 0 0.0
ota-provider-app debug (read only) 2066865 2066865 0 0.0
(read/write) 141456 141456 0 0.0
.bss 73056 73056 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60824 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180248 180248 0 0.0
.text 1728050 1728050 0 0.0
ota-requestor-app debug (read only) 2095969 2095969 0 0.0
(read/write) 144296 144296 0 0.0
.bss 73760 73760 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 62920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176320 176320 0 0.0
.text 1759618 1759618 0 0.0
shell debug (read only) 2570881 2570881 0 0.0
(read/write) 201584 201584 0 0.0
.bss 117192 117192 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223762 223762 0 0.0
.text 2188226 2188226 0 0.0
thermostat-no-ble arm64 (read only) 2365996 2365996 0 0.0
(read/write) 177313 177313 0 0.0
.bss 87969 87969 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 80016 80016 0 0.0
.dynamic 528 528 0 0.0
.got 4800 4800 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148156 148156 0 0.0
.text 1988720 1988720 0 0.0
tv-app debug (read only) 2878297 2878297 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191112 191112 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78152 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222368 222368 0 0.0
.text 2473682 2473682 0 0.0
tv-casting-app debug (read only) 5432585 5432585 0 0.0
(read/write) 225904 225904 0 0.0
.bss 78696 78696 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138576 138576 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339648 339648 0 0.0
.text 4734210 4734210 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424544 2424544 0 0.0
.bss 202652 202652 0 0.0
.data 5872 5872 0 0.0
.text 1387188 1387188 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1185703 0 0.0
bss 139308 139308 0 0.0
rodata 153488 153488 0 0.0
text 814040 814040 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1134459 1134459 0 0.0
bss 138540 138540 0 0.0
rodata 130052 130052 0 0.0
text 787060 787060 0 0.0
p6 all-clusters-app default (read/write) 2539952 2539952 0 0.0
.bss 137136 137136 0 0.0
.data 2800 2800 0 0.0
.text 1498216 1498216 0 0.0
all-clusters-minimal-app default (read/write) 2485920 2485920 0 0.0
.bss 136360 136360 0 0.0
.data 2744 2744 0 0.0
.text 1444184 1444184 0 0.0
light-app default (read/write) 2420192 2420192 0 0.0
.bss 129464 129464 0 0.0
.data 2600 2600 0 0.0
.text 1378456 1378456 0 0.0
lock-app default (read/write) 2438216 2438216 0 0.0
.bss 129280 129280 0 0.0
.data 2568 2568 0 0.0
.text 1396480 1396480 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779472 779472 0 0.0
bss 70596 70596 0 0.0
noinit 40416 40416 0 0.0
text 551334 551334 0 0.0
lighting-app tlsr9518adk80d (read/write) 799500 799500 0 0.0
bss 70856 70856 0 0.0
noinit 40416 40416 0 0.0
text 568068 568068 0 0.0

@restyled-io restyled-io bot mentioned this pull request May 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

PR #18926: Size comparison from e1c9658 to 8ca6b15

Increases above 0.2%:

platform target config section e1c9658 8ca6b15 change % change
linux all-clusters-app debug .data.rel.ro 83624 83800 176 0.2
all-clusters-minimal-app debug .data.rel.ro 76520 76680 160 0.2
bridge-app debug+rpc .data.rel.ro 65320 65480 160 0.2
lighting-app debug+rpc .data.rel.ro 70824 70984 160 0.2
lock-app debug .data.rel.ro 67752 67912 160 0.2
ota-provider-app debug .data.rel.ro 60824 60984 160 0.3
ota-requestor-app debug .data.rel.ro 62920 63080 160 0.3
shell debug .data.rel.ro 77256 77416 160 0.2
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 8ca6b15 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647583 647743 160 0.0
.rodata 84159 84239 80 0.1
.text 563188 563268 80 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 614455 614615 160 0.0
.rodata 73551 73631 80 0.1
.text 540668 540748 80 0.0
lock-ftd LP_CC2652R7 (read only) 679567 679679 112 0.0
.rodata 96135 96199 64 0.1
.text 582948 582996 48 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629087 120 0.0
.rodata 96015 96087 72 0.1
.text 532460 532508 48 0.0
pump-app LP_CC2652R7 (read only) 675979 676091 112 0.0
.rodata 88611 88675 64 0.1
.text 586884 586932 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653915 654035 120 0.0
.rodata 83347 83419 72 0.1
.text 570088 570136 48 0.0
shell LP_CC2652R7 (read only) 640614 640750 136 0.0
.rodata 81142 81214 72 0.1
.text 559240 559304 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621514 621706 192 0.0
.app_xip_area 525020 525292 272 0.1
lock cyw930739m2evb_01 (read/write) 630214 630414 200 0.0
.app_xip_area 535192 535472 280 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570878 40 0.0
.app_xip_area 465896 466016 120 0.0
efr32 lighting-app BRD4161A (read only) 914288 914640 352 0.0
.text 914280 914632 352 0.0
BRD4161A+rpc (read only) 948508 948892 384 0.0
.text 948500 948884 384 0.0
BRD4161A+rs911x (read only) 788836 789100 264 0.0
.text 788828 789092 264 0.0
lock-app BRD4161A+wf200 (read only) 954064 954224 160 0.0
.text 954056 954216 160 0.0
window-app BRD4161A (read only) 899216 899584 368 0.0
.text 899208 899576 368 0.0
esp32 all-clusters-app c3devkit (read only) 1004822 1004870 48 0.0
(read/write) 1479522 1479554 32 0.0
.flash.rodata 210256 210336 80 0.0
.flash.text 1004822 1004870 48 0.0
m5stack (read only) 1060023 1060131 108 0.0
(read/write) 481744 481776 32 0.0
.flash.rodata 240844 240916 72 0.0
.flash.text 1054639 1054747 108 0.0
k32w light k32w061+release (read/write) 680676 680860 184 0.0
.text 596764 596988 224 0.0
lock k32w061+release (read/write) 732092 732364 272 0.0
.text 647780 648092 312 0.0
linux all-clusters-app debug (read only) 2766585 2767177 592 0.0
(read/write) 178080 178240 160 0.1
.data.rel.ro 83624 83800 176 0.2
.rodata 243645 243677 32 0.0
.text 2349538 2349618 80 0.0
all-clusters-minimal-app debug (read only) 2643737 2644297 560 0.0
(read/write) 170112 170240 128 0.1
.data.rel.ro 76520 76680 160 0.2
.text 2226130 2226210 80 0.0
bridge-app debug+rpc (read only) 2028681 2029513 832 0.0
(read/write) 147768 147896 128 0.1
.data.rel.ro 65320 65480 160 0.2
.text 1703858 1704274 416 0.0
chip-tool debug (read/write) 602512 602544 32 0.0
.data.rel.ro 571136 571160 24 0.0
chip-tool-no-interactive-ipv6only arm64 (read/write) 668785 668801 16 0.0
.data.rel.ro 606528 606560 32 0.0
lighting-app debug+rpc (read only) 2317505 2318049 544 0.0
(read/write) 153408 153504 96 0.1
.data.rel.ro 70824 70984 160 0.2
.text 1964818 1964946 128 0.0
lock-app debug (read only) 2257257 2258121 864 0.0
(read/write) 148504 148632 128 0.1
.data.rel.ro 67752 67912 160 0.2
.text 1896562 1896946 384 0.0
ota-provider-app debug (read only) 2066865 2067425 560 0.0
(read/write) 141456 141584 128 0.1
.data.rel.ro 60824 60984 160 0.3
.text 1728050 1728194 144 0.0
ota-requestor-app debug (read only) 2095969 2096209 240 0.0
(read/write) 144296 144424 128 0.1
.data.rel.ro 62920 63080 160 0.3
shell debug (read only) 2570881 2571265 384 0.0
(read/write) 201584 201648 64 0.0
.data.rel.ro 77256 77416 160 0.2
.rodata 223762 223794 32 0.0
thermostat-no-ble arm64 (read only) 2365996 2366172 176 0.0
(read/write) 177313 177409 96 0.1
.data.rel.ro 80016 80176 160 0.2
tv-app debug .data.rel.ro 78152 78200 48 0.1
tv-casting-app debug (read only) 5432585 5433113 528 0.0
(read/write) 225904 226000 96 0.0
.data.rel.ro 138576 138752 176 0.1
.text 4734210 4734322 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424544 2424816 272 0.0
.text 1387188 1387460 272 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1185919 216 0.0
rodata 153488 153560 72 0.0
text 814040 814188 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1134459 1134675 216 0.0
rodata 130052 130124 72 0.1
text 787060 787212 152 0.0
p6 all-clusters-app default (read/write) 2539952 2540216 264 0.0
.text 1498216 1498480 264 0.0
all-clusters-minimal-app default (read/write) 2485920 2486176 256 0.0
.text 1444184 1444440 256 0.0
light-app default (read/write) 2420192 2420600 408 0.0
.text 1378456 1378864 408 0.0
lock-app default (read/write) 2438216 2438648 432 0.0
.text 1396480 1396912 432 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779472 779552 80 0.0
text 551334 551382 48 0.0
lighting-app tlsr9518adk80d (read/write) 799500 799580 80 0.0
text 568068 568116 48 0.0
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 8ca6b15 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 158928 158888 -40 -0.0
.bss 74612 74572 -40 -0.1
all-clusters-minimal-app LP_CC2652R7 (read/write) 158100 158060 -40 -0.0
.bss 73844 73804 -40 -0.1
lock-ftd LP_CC2652R7 (read/write) 163288 163136 -152 -0.1
.bss 72636 72596 -40 -0.1
lock-mtd LP_CC2652R7 (read/write) 145752 145712 -40 -0.0
.bss 68372 68332 -40 -0.1
pump-app LP_CC2652R7 (read/write) 168044 167892 -152 -0.1
.bss 73036 72996 -40 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189964 189804 -160 -0.1
.bss 72892 72852 -40 -0.1
shell LP_CC2652R7 (read/write) 154484 154444 -40 -0.0
.bss 76964 76924 -40 -0.1
cyw30739 light cyw930739m2evb_01 .bss 79136 79056 -80 -0.1
lock cyw930739m2evb_01 .bss 77696 77616 -80 -0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87296 87216 -80 -0.1
efr32 lighting-app BRD4161A (read/write) 133216 133176 -40 -0.0
.bss 131120 131080 -40 -0.0
BRD4161A+rpc (read/write) 149904 149864 -40 -0.0
.bss 147608 147568 -40 -0.0
BRD4161A+rs911x (read/write) 129488 129448 -40 -0.0
.bss 127388 127348 -40 -0.0
lock-app BRD4161A+wf200 (read/write) 128268 128228 -40 -0.0
.bss 126204 126164 -40 -0.0
window-app BRD4161A (read/write) 133280 133240 -40 -0.0
.bss 131192 131152 -40 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 69176 69136 -40 -0.1
m5stack .dram0.bss 74696 74656 -40 -0.1
k32w light k32w061+release .bss 80200 80160 -40 -0.0
lock k32w061+release .bss 80632 80592 -40 -0.0
linux all-clusters-app debug .bss 86272 86240 -32 -0.0
all-clusters-minimal-app debug .bss 85536 85504 -32 -0.0
bridge-app debug+rpc .bss 72928 72896 -32 -0.0
.rodata 168832 168768 -64 -0.0
chip-tool debug (read only) 9678149 9675845 -2304 -0.0
.rodata 496349 496093 -256 -0.1
.text 7789157 7786821 -2336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422124 9419836 -2288 -0.0
.got 15016 15000 -16 -0.1
.rodata 459956 459812 -144 -0.0
.text 7434100 7431764 -2336 -0.0
lighting-app debug+rpc .bss 74784 74720 -64 -0.1
.rodata 187464 187400 -64 -0.0
lock-app debug .bss 73472 73440 -32 -0.0
ota-provider-app debug .bss 73056 73024 -32 -0.0
.rodata 180248 180184 -64 -0.0
ota-requestor-app debug .bss 73760 73728 -32 -0.0
.rodata 176320 176256 -64 -0.0
.text 1759618 1759442 -176 -0.0
shell debug .bss 117192 117096 -96 -0.1
.text 2188226 2188098 -128 -0.0
thermostat-no-ble arm64 .bss 87969 87921 -48 -0.1
.got 4800 4792 -8 -0.2
.text 1988720 1988432 -288 -0.0
tv-app debug (read only) 2878297 2875849 -2448 -0.1
(read/write) 280208 280176 -32 -0.0
.bss 191112 191048 -64 -0.0
.rodata 222368 222112 -256 -0.1
.text 2473682 2471202 -2480 -0.1
tv-casting-app debug .bss 78696 78632 -64 -0.1
.rodata 339648 339584 -64 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 202652 202612 -40 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139308 139268 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 138540 138500 -40 -0.0
p6 all-clusters-app default .bss 137136 137096 -40 -0.0
all-clusters-minimal-app default .bss 136360 136320 -40 -0.0
light-app default .bss 129464 129424 -40 -0.0
lock-app default .bss 129280 129240 -40 -0.0
telink light-switch-app tlsr9518adk80d bss 70596 70556 -40 -0.1
lighting-app tlsr9518adk80d bss 70856 70816 -40 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 8ca6b15 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647583 647743 160 0.0
(read/write) 158928 158888 -40 -0.0
.bss 74612 74572 -40 -0.1
.data 3400 3400 0 0.0
.rodata 84159 84239 80 0.1
.text 563188 563268 80 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 614455 614615 160 0.0
(read/write) 158100 158060 -40 -0.0
.bss 73844 73804 -40 -0.1
.data 3340 3340 0 0.0
.rodata 73551 73631 80 0.1
.text 540668 540748 80 0.0
lock-ftd LP_CC2652R7 (read only) 679567 679679 112 0.0
(read/write) 163288 163136 -152 -0.1
.bss 72636 72596 -40 -0.1
.data 3264 3264 0 0.0
.rodata 96135 96199 64 0.1
.text 582948 582996 48 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629087 120 0.0
(read/write) 145752 145712 -40 -0.0
.bss 68372 68332 -40 -0.1
.data 3264 3264 0 0.0
.rodata 96015 96087 72 0.1
.text 532460 532508 48 0.0
pump-app LP_CC2652R7 (read only) 675979 676091 112 0.0
(read/write) 168044 167892 -152 -0.1
.bss 73036 72996 -40 -0.1
.data 3300 3300 0 0.0
.rodata 88611 88675 64 0.1
.text 586884 586932 48 0.0
pump-controller-app LP_CC2652R7 (read only) 653915 654035 120 0.0
(read/write) 189964 189804 -160 -0.1
.bss 72892 72852 -40 -0.1
.data 3260 3260 0 0.0
.rodata 83347 83419 72 0.1
.text 570088 570136 48 0.0
shell LP_CC2652R7 (read only) 640614 640750 136 0.0
(read/write) 154484 154444 -40 -0.0
.bss 76964 76924 -40 -0.1
.data 3404 3404 0 0.0
.rodata 81142 81214 72 0.1
.text 559240 559304 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621514 621706 192 0.0
.app_xip_area 525020 525292 272 0.1
.bss 79136 79056 -80 -0.1
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630214 630414 200 0.0
.app_xip_area 535192 535472 280 0.1
.bss 77696 77616 -80 -0.1
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570878 40 0.0
.app_xip_area 465896 466016 120 0.0
.bss 87296 87216 -80 -0.1
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914288 914640 352 0.0
(read/write) 133216 133176 -40 -0.0
.bss 131120 131080 -40 -0.0
.data 2092 2092 0 0.0
.text 914280 914632 352 0.0
BRD4161A+rpc (read only) 948508 948892 384 0.0
(read/write) 149904 149864 -40 -0.0
.bss 147608 147568 -40 -0.0
.data 2296 2296 0 0.0
.text 948500 948884 384 0.0
BRD4161A+rs911x (read only) 788836 789100 264 0.0
(read/write) 129488 129448 -40 -0.0
.bss 127388 127348 -40 -0.0
.data 2100 2100 0 0.0
.text 788828 789092 264 0.0
lock-app BRD4161A+wf200 (read only) 954064 954224 160 0.0
(read/write) 128268 128228 -40 -0.0
.bss 126204 126164 -40 -0.0
.data 2064 2064 0 0.0
.text 954056 954216 160 0.0
window-app BRD4161A (read only) 899216 899584 368 0.0
(read/write) 133280 133240 -40 -0.0
.bss 131192 131152 -40 -0.0
.data 2088 2088 0 0.0
.text 899208 899576 368 0.0
esp32 all-clusters-app c3devkit (read only) 1004822 1004870 48 0.0
(read/write) 1479522 1479554 32 0.0
.dram0.bss 69176 69136 -40 -0.1
.dram0.data 14648 14648 0 0.0
.flash.rodata 210256 210336 80 0.0
.flash.text 1004822 1004870 48 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060023 1060131 108 0.0
(read/write) 481744 481776 32 0.0
.dram0.bss 74696 74656 -40 -0.1
.dram0.data 34208 34208 0 0.0
.flash.rodata 240844 240916 72 0.0
.flash.text 1054639 1054747 108 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680676 680860 184 0.0
.bss 80200 80160 -40 -0.0
.data 2008 2008 0 0.0
.text 596764 596988 224 0.0
lock k32w061+release (read/write) 732092 732364 272 0.0
.bss 80632 80592 -40 -0.0
.data 1976 1976 0 0.0
.text 647780 648092 312 0.0
linux all-clusters-app debug (read only) 2766585 2767177 592 0.0
(read/write) 178080 178240 160 0.1
.bss 86272 86240 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 83624 83800 176 0.2
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243645 243677 32 0.0
.text 2349538 2349618 80 0.0
all-clusters-minimal-app debug (read only) 2643737 2644297 560 0.0
(read/write) 170112 170240 128 0.1
.bss 85536 85504 -32 -0.0
.data 1904 1904 0 0.0
.data.rel.ro 76520 76680 160 0.2
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2226130 2226210 80 0.0
bridge-app debug+rpc (read only) 2028681 2029513 832 0.0
(read/write) 147768 147896 128 0.1
.bss 72928 72896 -32 -0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65480 160 0.2
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168832 168768 -64 -0.0
.text 1703858 1704274 416 0.0
chip-tool debug (read only) 9678149 9675845 -2304 -0.0
(read/write) 602512 602544 32 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571160 24 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496349 496093 -256 -0.1
.text 7789157 7786821 -2336 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422124 9419836 -2288 -0.0
(read/write) 668785 668801 16 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606560 32 0.0
.dynamic 528 528 0 0.0
.got 15016 15000 -16 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459956 459812 -144 -0.0
.text 7434100 7431764 -2336 -0.0
lighting-app debug+rpc (read only) 2317505 2318049 544 0.0
(read/write) 153408 153504 96 0.1
.bss 74784 74720 -64 -0.1
.data 2048 2048 0 0.0
.data.rel.ro 70824 70984 160 0.2
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187464 187400 -64 -0.0
.text 1964818 1964946 128 0.0
lock-app debug (read only) 2257257 2258121 864 0.0
(read/write) 148504 148632 128 0.1
.bss 73472 73440 -32 -0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67912 160 0.2
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1896562 1896946 384 0.0
ota-provider-app debug (read only) 2066865 2067425 560 0.0
(read/write) 141456 141584 128 0.1
.bss 73056 73024 -32 -0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60984 160 0.3
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180248 180184 -64 -0.0
.text 1728050 1728194 144 0.0
ota-requestor-app debug (read only) 2095969 2096209 240 0.0
(read/write) 144296 144424 128 0.1
.bss 73760 73728 -32 -0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 63080 160 0.3
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176320 176256 -64 -0.0
.text 1759618 1759442 -176 -0.0
shell debug (read only) 2570881 2571265 384 0.0
(read/write) 201584 201648 64 0.0
.bss 117192 117096 -96 -0.1
.data 1376 1376 0 0.0
.data.rel.ro 77256 77416 160 0.2
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223762 223794 32 0.0
.text 2188226 2188098 -128 -0.0
thermostat-no-ble arm64 (read only) 2365996 2366172 176 0.0
(read/write) 177313 177409 96 0.1
.bss 87969 87921 -48 -0.1
.data 1520 1520 0 0.0
.data.rel.ro 80016 80176 160 0.2
.dynamic 528 528 0 0.0
.got 4800 4792 -8 -0.2
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148156 148156 0 0.0
.text 1988720 1988432 -288 -0.0
tv-app debug (read only) 2878297 2875849 -2448 -0.1
(read/write) 280208 280176 -32 -0.0
.bss 191112 191048 -64 -0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78200 48 0.1
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222368 222112 -256 -0.1
.text 2473682 2471202 -2480 -0.1
tv-casting-app debug (read only) 5432585 5433113 528 0.0
(read/write) 225904 226000 96 0.0
.bss 78696 78632 -64 -0.1
.data 2400 2400 0 0.0
.data.rel.ro 138576 138752 176 0.1
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339648 339584 -64 -0.0
.text 4734210 4734322 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424544 2424816 272 0.0
.bss 202652 202612 -40 -0.0
.data 5872 5872 0 0.0
.text 1387188 1387460 272 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1185919 216 0.0
bss 139308 139268 -40 -0.0
rodata 153488 153560 72 0.0
text 814040 814188 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1134459 1134675 216 0.0
bss 138540 138500 -40 -0.0
rodata 130052 130124 72 0.1
text 787060 787212 152 0.0
p6 all-clusters-app default (read/write) 2539952 2540216 264 0.0
.bss 137136 137096 -40 -0.0
.data 2800 2800 0 0.0
.text 1498216 1498480 264 0.0
all-clusters-minimal-app default (read/write) 2485920 2486176 256 0.0
.bss 136360 136320 -40 -0.0
.data 2744 2744 0 0.0
.text 1444184 1444440 256 0.0
light-app default (read/write) 2420192 2420600 408 0.0
.bss 129464 129424 -40 -0.0
.data 2600 2600 0 0.0
.text 1378456 1378864 408 0.0
lock-app default (read/write) 2438216 2438648 432 0.0
.bss 129280 129240 -40 -0.0
.data 2568 2568 0 0.0
.text 1396480 1396912 432 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779472 779552 80 0.0
bss 70596 70556 -40 -0.1
noinit 40416 40416 0 0.0
text 551334 551382 48 0.0
lighting-app tlsr9518adk80d (read/write) 799500 799580 80 0.0
bss 70856 70816 -40 -0.1
noinit 40416 40416 0 0.0
text 568068 568116 48 0.0

lazarkov
lazarkov commented May 30, 2022
View reviewed changes
examples/tv-app/android/java/src/com/tcl/chip/tvapp/UserPrompterResolver.java Outdated Show resolved Hide resolved
examples/tv-app/android/App/platform-app/src/main/java/com/matter/tv/server/MainActivity.java Show resolved Hide resolved
...android/App/platform-app/src/main/java/com/matter/tv/server/MatterCommissioningPrompter.java Show resolved Hide resolved
...android/App/platform-app/src/main/java/com/matter/tv/server/MatterCommissioningPrompter.java Show resolved Hide resolved
...android/App/platform-app/src/main/java/com/matter/tv/server/MatterCommissioningPrompter.java Outdated Show resolved Hide resolved
...android/App/platform-app/src/main/java/com/matter/tv/server/MatterCommissioningPrompter.java Show resolved Hide resolved
...android/App/platform-app/src/main/java/com/matter/tv/server/MatterCommissioningPrompter.java Show resolved Hide resolved
lazarkov added 6 commits May 30, 2022 22:28
@restyled-io restyled-io bot mentioned this pull request May 30, 2022
Closed
lazarkov and others added 2 commits May 30, 2022 22:28
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

PR #18926: Size comparison from e1c9658 to 418d0fb

Increases above 0.2%:

platform target config section e1c9658 418d0fb change % change
cyw30739 light cyw930739m2evb_01 .data 704 708 4 0.6
lock cyw930739m2evb_01 .data 672 676 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 612 616 4 0.7
linux all-clusters-app debug .data.rel.ro 83624 83832 208 0.2
all-clusters-minimal-app debug .data.rel.ro 76520 76712 192 0.3
bridge-app debug+rpc .data.rel.ro 65320 65480 160 0.2
lighting-app debug+rpc .data.rel.ro 70824 70984 160 0.2
lock-app debug .data.rel.ro 67752 67912 160 0.2
ota-provider-app debug .data.rel.ro 60824 60984 160 0.3
ota-requestor-app debug .data.rel.ro 62920 63080 160 0.3
shell debug .data.rel.ro 77256 77448 192 0.2
thermostat-no-ble arm64 .data 1520 1528 8 0.5
tv-casting-app debug .data.rel.ro 138576 138912 336 0.2
p6 all-clusters-app default .data 2800 2808 8 0.3
Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 418d0fb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647583 648263 680 0.1
.data 3400 3404 4 0.1
.rodata 84159 84263 104 0.1
.text 563188 563764 576 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 614455 615103 648 0.1
.data 3340 3344 4 0.1
.rodata 73551 73655 104 0.1
.text 540668 541212 544 0.1
lock-ftd LP_CC2652R7 (read only) 679567 679815 248 0.0
.data 3264 3268 4 0.1
.rodata 96135 96199 64 0.1
.text 582948 583132 184 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629223 256 0.0
.data 3264 3268 4 0.1
.rodata 96015 96087 72 0.1
.text 532460 532644 184 0.0
pump-app LP_CC2652R7 (read only) 675979 676219 240 0.0
.data 3300 3304 4 0.1
.rodata 88611 88675 64 0.1
.text 586884 587060 176 0.0
pump-controller-app LP_CC2652R7 (read only) 653915 654163 248 0.0
.data 3260 3264 4 0.1
.rodata 83347 83419 72 0.1
.text 570088 570264 176 0.0
shell LP_CC2652R7 (read only) 640614 641262 648 0.1
.data 3404 3408 4 0.1
.rodata 81142 81238 96 0.1
.text 559240 559792 552 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 621514 621842 328 0.1
.app_xip_area 525020 525420 400 0.1
.data 704 708 4 0.6
lock cyw930739m2evb_01 (read/write) 630214 630550 336 0.1
.app_xip_area 535192 535600 408 0.1
.data 672 676 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570902 64 0.0
.app_xip_area 465896 466024 128 0.0
.data 612 616 4 0.7
efr32 lighting-app BRD4161A (read only) 914288 914752 464 0.1
.data 2092 2096 4 0.2
.text 914280 914744 464 0.1
BRD4161A+rpc (read only) 948508 948988 480 0.1
.data 2296 2300 4 0.2
.text 948500 948980 480 0.1
BRD4161A+rs911x (read only) 788836 789196 360 0.0
.data 2100 2104 4 0.2
.text 788828 789188 360 0.0
lock-app BRD4161A+wf200 (read only) 954064 954352 288 0.0
.data 2064 2068 4 0.2
.text 954056 954344 288 0.0
window-app BRD4161A (read only) 899216 899680 464 0.1
.data 2088 2092 4 0.2
.text 899208 899672 464 0.1
esp32 all-clusters-app c3devkit (read only) 1004822 1005432 610 0.1
(read/write) 1479522 1479594 72 0.0
.dram0.data 14648 14656 8 0.1
.flash.rodata 210256 210360 104 0.0
.flash.text 1004822 1005432 610 0.1
m5stack (read only) 1060023 1060587 564 0.1
(read/write) 481744 481808 64 0.0
.flash.rodata 240844 240940 96 0.0
.flash.text 1054639 1055203 564 0.1
k32w light k32w061+release (read/write) 680676 681000 324 0.0
.data 2008 2012 4 0.2
.text 596764 597116 352 0.1
lock k32w061+release (read/write) 732092 732504 412 0.1
.data 1976 1980 4 0.2
.text 647780 648220 440 0.1
linux all-clusters-app debug (read only) 2766585 2769441 2856 0.1
(read/write) 178080 178272 192 0.1
.data.rel.ro 83624 83832 208 0.2
.rodata 243645 243677 32 0.0
.text 2349538 2351858 2320 0.1
all-clusters-minimal-app debug (read only) 2643737 2646561 2824 0.1
(read/write) 170112 170272 160 0.1
.data.rel.ro 76520 76712 192 0.3
.text 2226130 2228450 2320 0.1
bridge-app debug+rpc (read only) 2028681 2029753 1072 0.1
(read/write) 147768 147896 128 0.1
.data.rel.ro 65320 65480 160 0.2
.text 1703858 1704514 656 0.0
chip-tool debug (read only) 9678149 9680645 2496 0.0
(read/write) 602512 602736 224 0.0
.data.rel.ro 571136 571336 200 0.0
.text 7789157 7790965 1808 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422124 9423884 1760 0.0
(read/write) 668785 668993 208 0.0
.data.rel.ro 606528 606736 208 0.0
.rodata 459956 460036 80 0.0
.text 7434100 7435140 1040 0.0
lighting-app debug+rpc (read only) 2317505 2318305 800 0.0
(read/write) 153408 153504 96 0.1
.data.rel.ro 70824 70984 160 0.2
.text 1964818 1965202 384 0.0
lock-app debug (read only) 2257257 2258377 1120 0.0
(read/write) 148504 148632 128 0.1
.data.rel.ro 67752 67912 160 0.2
.text 1896562 1897202 640 0.0
ota-provider-app debug (read only) 2066865 2067441 576 0.0
(read/write) 141456 141584 128 0.1
.data.rel.ro 60824 60984 160 0.3
.text 1728050 1728210 160 0.0
ota-requestor-app debug (read only) 2095969 2096241 272 0.0
(read/write) 144296 144424 128 0.1
.data.rel.ro 62920 63080 160 0.3
shell debug (read only) 2570881 2573545 2664 0.1
(read/write) 201584 201680 96 0.0
.data.rel.ro 77256 77448 192 0.2
.rodata 223762 223794 32 0.0
.text 2188226 2190354 2128 0.1
thermostat-no-ble arm64 (read only) 2365996 2366452 456 0.0
(read/write) 177313 177425 112 0.1
.data 1520 1528 8 0.5
.data.rel.ro 80016 80176 160 0.2
.rodata 148156 148164 8 0.0
tv-app debug .data.rel.ro 78152 78200 48 0.1
tv-casting-app debug (read only) 5432585 5437833 5248 0.1
(read/write) 225904 226160 256 0.1
.data.rel.ro 138576 138912 336 0.2
.rodata 339648 339808 160 0.0
.text 4734210 4738434 4224 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424544 2424944 400 0.0
.text 1387188 1387588 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1186495 792 0.1
rodata 153488 153584 96 0.1
text 814040 814728 688 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1134459 1135227 768 0.1
rodata 130052 130148 96 0.1
text 787060 787728 668 0.1
p6 all-clusters-app default (read/write) 2539952 2540816 864 0.0
.data 2800 2808 8 0.3
.text 1498216 1499080 864 0.1
all-clusters-minimal-app default (read/write) 2485920 2486760 840 0.0
.text 1444184 1445024 840 0.1
light-app default (read/write) 2420192 2420712 520 0.0
.text 1378456 1378976 520 0.0
lock-app default (read/write) 2438216 2438760 544 0.0
.text 1396480 1397024 544 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779472 779708 236 0.0
text 551334 551518 184 0.0
lighting-app tlsr9518adk80d (read/write) 799500 799736 236 0.0
text 568068 568252 184 0.0
Decreases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 418d0fb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 158928 158900 -28 -0.0
.bss 74612 74580 -32 -0.0
all-clusters-minimal-app LP_CC2652R7 (read/write) 158100 158072 -28 -0.0
.bss 73844 73812 -32 -0.0
lock-ftd LP_CC2652R7 (read/write) 163288 163008 -280 -0.2
.bss 72636 72604 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 145752 145724 -28 -0.0
.bss 68372 68340 -32 -0.0
pump-app LP_CC2652R7 (read/write) 168044 167772 -272 -0.2
.bss 73036 73004 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189964 189684 -280 -0.1
.bss 72892 72860 -32 -0.0
shell LP_CC2652R7 (read/write) 154484 154456 -28 -0.0
.bss 76964 76932 -32 -0.0
cyw30739 light cyw930739m2evb_01 .bss 79136 79064 -72 -0.1
lock cyw930739m2evb_01 .bss 77696 77624 -72 -0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 87296 87224 -72 -0.1
efr32 lighting-app BRD4161A (read/write) 133216 133184 -32 -0.0
.bss 131120 131088 -32 -0.0
BRD4161A+rpc (read/write) 149904 149876 -28 -0.0
.bss 147608 147576 -32 -0.0
BRD4161A+rs911x (read/write) 129488 129460 -28 -0.0
.bss 127388 127356 -32 -0.0
lock-app BRD4161A+wf200 (read/write) 128268 128244 -24 -0.0
.bss 126204 126172 -32 -0.0
window-app BRD4161A (read/write) 133280 133256 -24 -0.0
.bss 131192 131160 -32 -0.0
esp32 all-clusters-app c3devkit .dram0.bss 69176 69144 -32 -0.0
m5stack .dram0.bss 74696 74664 -32 -0.0
k32w light k32w061+release .bss 80200 80168 -32 -0.0
lock k32w061+release .bss 80632 80600 -32 -0.0
linux all-clusters-app debug .bss 86272 86240 -32 -0.0
all-clusters-minimal-app debug .bss 85536 85504 -32 -0.0
bridge-app debug+rpc .bss 72928 72896 -32 -0.0
.rodata 168832 168768 -64 -0.0
chip-tool debug .rodata 496349 496317 -32 -0.0
chip-tool-no-interactive-ipv6only arm64 .got 15016 15008 -8 -0.1
lighting-app debug+rpc .bss 74784 74720 -64 -0.1
.rodata 187464 187400 -64 -0.0
lock-app debug .bss 73472 73440 -32 -0.0
ota-provider-app debug .bss 73056 73024 -32 -0.0
.rodata 180248 180184 -64 -0.0
ota-requestor-app debug .bss 73760 73728 -32 -0.0
.rodata 176320 176256 -64 -0.0
.text 1759618 1759474 -144 -0.0
shell debug .bss 117192 117096 -96 -0.1
thermostat-no-ble arm64 .bss 87969 87921 -48 -0.1
.got 4800 4792 -8 -0.2
.text 1988720 1988704 -16 -0.0
tv-app debug (read only) 2878297 2876105 -2192 -0.1
(read/write) 280208 280176 -32 -0.0
.bss 191112 191048 -64 -0.0
.rodata 222368 222112 -256 -0.1
.text 2473682 2471458 -2224 -0.1
tv-casting-app debug .bss 78696 78632 -64 -0.1
mbed lock-app CY8CPROTO_062_4343W+release .bss 202652 202620 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139308 139276 -32 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 138540 138508 -32 -0.0
p6 all-clusters-app default .bss 137136 137104 -32 -0.0
all-clusters-minimal-app default .bss 136360 136328 -32 -0.0
light-app default .bss 129464 129432 -32 -0.0
lock-app default .bss 129280 129248 -32 -0.0
telink light-switch-app tlsr9518adk80d bss 70596 70564 -32 -0.0
lighting-app tlsr9518adk80d bss 70856 70824 -32 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e1c9658 418d0fb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 647583 648263 680 0.1
(read/write) 158928 158900 -28 -0.0
.bss 74612 74580 -32 -0.0
.data 3400 3404 4 0.1
.rodata 84159 84263 104 0.1
.text 563188 563764 576 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 614455 615103 648 0.1
(read/write) 158100 158072 -28 -0.0
.bss 73844 73812 -32 -0.0
.data 3340 3344 4 0.1
.rodata 73551 73655 104 0.1
.text 540668 541212 544 0.1
lock-ftd LP_CC2652R7 (read only) 679567 679815 248 0.0
(read/write) 163288 163008 -280 -0.2
.bss 72636 72604 -32 -0.0
.data 3264 3268 4 0.1
.rodata 96135 96199 64 0.1
.text 582948 583132 184 0.0
lock-mtd LP_CC2652R7 (read only) 628967 629223 256 0.0
(read/write) 145752 145724 -28 -0.0
.bss 68372 68340 -32 -0.0
.data 3264 3268 4 0.1
.rodata 96015 96087 72 0.1
.text 532460 532644 184 0.0
pump-app LP_CC2652R7 (read only) 675979 676219 240 0.0
(read/write) 168044 167772 -272 -0.2
.bss 73036 73004 -32 -0.0
.data 3300 3304 4 0.1
.rodata 88611 88675 64 0.1
.text 586884 587060 176 0.0
pump-controller-app LP_CC2652R7 (read only) 653915 654163 248 0.0
(read/write) 189964 189684 -280 -0.1
.bss 72892 72860 -32 -0.0
.data 3260 3264 4 0.1
.rodata 83347 83419 72 0.1
.text 570088 570264 176 0.0
shell LP_CC2652R7 (read only) 640614 641262 648 0.1
(read/write) 154484 154456 -28 -0.0
.bss 76964 76932 -32 -0.0
.data 3404 3408 4 0.1
.rodata 81142 81238 96 0.1
.text 559240 559792 552 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 621514 621842 328 0.1
.app_xip_area 525020 525420 400 0.1
.bss 79136 79064 -72 -0.1
.data 704 708 4 0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630214 630550 336 0.1
.app_xip_area 535192 535600 408 0.1
.bss 77696 77624 -72 -0.1
.data 672 676 4 0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570838 570902 64 0.0
.app_xip_area 465896 466024 128 0.0
.bss 87296 87224 -72 -0.1
.data 612 616 4 0.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914288 914752 464 0.1
(read/write) 133216 133184 -32 -0.0
.bss 131120 131088 -32 -0.0
.data 2092 2096 4 0.2
.text 914280 914744 464 0.1
BRD4161A+rpc (read only) 948508 948988 480 0.1
(read/write) 149904 149876 -28 -0.0
.bss 147608 147576 -32 -0.0
.data 2296 2300 4 0.2
.text 948500 948980 480 0.1
BRD4161A+rs911x (read only) 788836 789196 360 0.0
(read/write) 129488 129460 -28 -0.0
.bss 127388 127356 -32 -0.0
.data 2100 2104 4 0.2
.text 788828 789188 360 0.0
lock-app BRD4161A+wf200 (read only) 954064 954352 288 0.0
(read/write) 128268 128244 -24 -0.0
.bss 126204 126172 -32 -0.0
.data 2064 2068 4 0.2
.text 954056 954344 288 0.0
window-app BRD4161A (read only) 899216 899680 464 0.1
(read/write) 133280 133256 -24 -0.0
.bss 131192 131160 -32 -0.0
.data 2088 2092 4 0.2
.text 899208 899672 464 0.1
esp32 all-clusters-app c3devkit (read only) 1004822 1005432 610 0.1
(read/write) 1479522 1479594 72 0.0
.dram0.bss 69176 69144 -32 -0.0
.dram0.data 14648 14656 8 0.1
.flash.rodata 210256 210360 104 0.0
.flash.text 1004822 1005432 610 0.1
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060023 1060587 564 0.1
(read/write) 481744 481808 64 0.0
.dram0.bss 74696 74664 -32 -0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240844 240940 96 0.0
.flash.text 1054639 1055203 564 0.1
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680676 681000 324 0.0
.bss 80200 80168 -32 -0.0
.data 2008 2012 4 0.2
.text 596764 597116 352 0.1
lock k32w061+release (read/write) 732092 732504 412 0.1
.bss 80632 80600 -32 -0.0
.data 1976 1980 4 0.2
.text 647780 648220 440 0.1
linux all-clusters-app debug (read only) 2766585 2769441 2856 0.1
(read/write) 178080 178272 192 0.1
.bss 86272 86240 -32 -0.0
.data 2032 2032 0 0.0
.data.rel.ro 83624 83832 208 0.2
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243645 243677 32 0.0
.text 2349538 2351858 2320 0.1
all-clusters-minimal-app debug (read only) 2643737 2646561 2824 0.1
(read/write) 170112 170272 160 0.1
.bss 85536 85504 -32 -0.0
.data 1904 1904 0 0.0
.data.rel.ro 76520 76712 192 0.3
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2226130 2228450 2320 0.1
bridge-app debug+rpc (read only) 2028681 2029753 1072 0.1
(read/write) 147768 147896 128 0.1
.bss 72928 72896 -32 -0.0
.data 3936 3936 0 0.0
.data.rel.ro 65320 65480 160 0.2
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168832 168768 -64 -0.0
.text 1703858 1704514 656 0.0
chip-tool debug (read only) 9678149 9680645 2496 0.0
(read/write) 602512 602736 224 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571136 571336 200 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496349 496317 -32 -0.0
.text 7789157 7790965 1808 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9422124 9423884 1760 0.0
(read/write) 668785 668993 208 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606528 606736 208 0.0
.dynamic 528 528 0 0.0
.got 15016 15008 -8 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459956 460036 80 0.0
.text 7434100 7435140 1040 0.0
lighting-app debug+rpc (read only) 2317505 2318305 800 0.0
(read/write) 153408 153504 96 0.1
.bss 74784 74720 -64 -0.1
.data 2048 2048 0 0.0
.data.rel.ro 70824 70984 160 0.2
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187464 187400 -64 -0.0
.text 1964818 1965202 384 0.0
lock-app debug (read only) 2257257 2258377 1120 0.0
(read/write) 148504 148632 128 0.1
.bss 73472 73440 -32 -0.0
.data 1568 1568 0 0.0
.data.rel.ro 67752 67912 160 0.2
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1896562 1897202 640 0.0
ota-provider-app debug (read only) 2066865 2067441 576 0.0
(read/write) 141456 141584 128 0.1
.bss 73056 73024 -32 -0.0
.data 1768 1768 0 0.0
.data.rel.ro 60824 60984 160 0.3
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180248 180184 -64 -0.0
.text 1728050 1728210 160 0.0
ota-requestor-app debug (read only) 2095969 2096241 272 0.0
(read/write) 144296 144424 128 0.1
.bss 73760 73728 -32 -0.0
.data 1960 1960 0 0.0
.data.rel.ro 62920 63080 160 0.3
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176320 176256 -64 -0.0
.text 1759618 1759474 -144 -0.0
shell debug (read only) 2570881 2573545 2664 0.1
(read/write) 201584 201680 96 0.0
.bss 117192 117096 -96 -0.1
.data 1376 1376 0 0.0
.data.rel.ro 77256 77448 192 0.2
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223762 223794 32 0.0
.text 2188226 2190354 2128 0.1
thermostat-no-ble arm64 (read only) 2365996 2366452 456 0.0
(read/write) 177313 177425 112 0.1
.bss 87969 87921 -48 -0.1
.data 1520 1528 8 0.5
.data.rel.ro 80016 80176 160 0.2
.dynamic 528 528 0 0.0
.got 4800 4792 -8 -0.2
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148156 148164 8 0.0
.text 1988720 1988704 -16 -0.0
tv-app debug (read only) 2878297 2876105 -2192 -0.1
(read/write) 280208 280176 -32 -0.0
.bss 191112 191048 -64 -0.0
.data 4672 4672 0 0.0
.data.rel.ro 78152 78200 48 0.1
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222368 222112 -256 -0.1
.text 2473682 2471458 -2224 -0.1
tv-casting-app debug (read only) 5432585 5437833 5248 0.1
(read/write) 225904 226160 256 0.1
.bss 78696 78632 -64 -0.1
.data 2400 2400 0 0.0
.data.rel.ro 138576 138912 336 0.2
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339648 339808 160 0.0
.text 4734210 4738434 4224 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424544 2424944 400 0.0
.bss 202652 202620 -32 -0.0
.data 5872 5872 0 0.0
.text 1387188 1387588 400 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1185703 1186495 792 0.1
bss 139308 139276 -32 -0.0
rodata 153488 153584 96 0.1
text 814040 814728 688 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1134459 1135227 768 0.1
bss 138540 138508 -32 -0.0
rodata 130052 130148 96 0.1
text 787060 787728 668 0.1
p6 all-clusters-app default (read/write) 2539952 2540816 864 0.0
.bss 137136 137104 -32 -0.0
.data 2800 2808 8 0.3
.text 1498216 1499080 864 0.1
all-clusters-minimal-app default (read/write) 2485920 2486760 840 0.0
.bss 136360 136328 -32 -0.0
.data 2744 2744 0 0.0
.text 1444184 1445024 840 0.1
light-app default (read/write) 2420192 2420712 520 0.0
.bss 129464 129432 -32 -0.0
.data 2600 2600 0 0.0
.text 1378456 1378976 520 0.0
lock-app default (read/write) 2438216 2438760 544 0.0
.bss 129280 129248 -32 -0.0
.data 2568 2568 0 0.0
.text 1396480 1397024 544 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779472 779708 236 0.0
bss 70596 70564 -32 -0.0
noinit 40416 40416 0 0.0
text 551334 551518 184 0.0
lighting-app tlsr9518adk80d (read/write) 799500 799736 236 0.0
bss 70856 70824 -32 -0.0
noinit 40416 40416 0 0.0
text 568068 568252 184 0.0

@lazarkov lazarkov merged commit 07933c1 into project-chip:master May 31, 2022
@lazarkov lazarkov deleted the feature/add-user-prompter-to-tv-android-app branch May 31, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@hawk248 hawk248 Awaiting requested review from hawk248

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarkov @hawk248 @chrisdecenzo