Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple spec compliance fixes to NOC cluster #18965

Merged
merged 20 commits into from
Jun 1, 2022
Merged

Multiple spec compliance fixes to NOC cluster #18965

merged 20 commits into from
Jun 1, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • A lot of error-handling in NOC cluster is not spec-compliant with too many different situations to list individually.
  • The RemoveTrustedRootCertificate command no longer exisets
  • There is missing interlock between the fail-safe and AddNOC/UpdateNOC/AddTrustedRootCertificate/CSRRequest

Issue #18633
Fixes #15311
Fixes #17209

Change overview

  • Add all missing IM-level checks that would lead to
    INVALID_COMMAND error on incorrectly provided inputs
  • Normalize logging of errors some more
  • Add missing interlocks on fail-safe
  • Remove RemoveTrustedRootCertificate command
  • Ensure error-handling in AddTrustedRootCertificate
    does not destroy in-progress state on innocuous errors
  • Move some IM structural checks before fail-safe checks
    in AddNOC/UpdateNOC

Testing

  • Unit tests pass
  • Cert tests pass
  • Added YAML tests for the AddNOC/UpdateNOC/CSRRequest/AddTrustedRootCertificate handling of being called outside fail-safe

@tcarmelveilleux
Multiple spec compliance fixes to NOC cluster
fe67e05 
- Add all missing IM-level checks that would lead to
  INVALID_COMMAND error on incorrectly provided inputs
- Normalize logging of errors some more
- Add missing interlocks on fail-safe
- Remove RemoveTrustedRootCertificate command
- Ensure error-handling in AddTrustedRootCertificate
  does not destroy in-progress state on innocuous errors
- Move some IM structural checks before fail-safe checks
  in AddNOC/UpdateNOC

Issue project-chip#18633
Fixes project-chip#15311
Fixes project-chip#17209
@tcarmelveilleux
ZAP changes
88c3b94
@restyled-io restyled-io bot mentioned this pull request May 30, 2022
Closed
@restyled-io restyled-io bot mentioned this pull request May 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

PR #18965: Size comparison from 6ef806b to 8c5d5cd

Increases above 0.2%:

platform target config section 6ef806b 8c5d5cd change % change
linux thermostat-no-ble arm64 .rodata 148164 148660 496 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 153584 153972 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 130148 130540 392 0.3
Increases (20 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6ef806b 8c5d5cd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621842 622162 320 0.1
.app_xip_area 525420 525740 320 0.1
lock cyw930739m2evb_01 (read/write) 630550 630870 320 0.1
.app_xip_area 535600 535920 320 0.1
efr32 lighting-app BRD4161A (read only) 914752 915112 360 0.0
.text 914744 915104 360 0.0
BRD4161A+rpc (read only) 948988 949252 264 0.0
.text 948980 949244 264 0.0
BRD4161A+rs911x (read only) 789196 789556 360 0.0
.text 789188 789548 360 0.0
lock-app BRD4161A+wf200 (read only) 954352 954632 280 0.0
.text 954344 954624 280 0.0
window-app BRD4161A (read only) 899680 900048 368 0.0
.text 899672 900040 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005432 1005478 46 0.0
(read/write) 1479594 1479994 400 0.0
.flash.rodata 210360 210760 400 0.2
.flash.text 1005432 1005478 46 0.0
m5stack (read only) 1060587 1060615 28 0.0
(read/write) 481808 482200 392 0.1
.flash.rodata 240940 241332 392 0.2
.flash.text 1055203 1055231 28 0.0
k32w lock k32w061+release (read/write) 732504 732760 256 0.0
.text 648220 648476 256 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 460036 460244 208 0.0
thermostat-no-ble arm64 (read only) 2366452 2366836 384 0.0
(read/write) 177425 177441 16 0.0
.data.rel.ro 80176 80200 24 0.0
.rodata 148164 148660 496 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186495 1186835 340 0.0
bss 139276 139280 4 0.0
rodata 153584 153972 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135227 1135571 344 0.0
rodata 130148 130540 392 0.3
p6 all-clusters-app default (read/write) 2540816 2541184 368 0.0
.text 1499080 1499448 368 0.0
all-clusters-minimal-app default (read/write) 2486760 2487136 376 0.0
.text 1445024 1445400 376 0.0
light-app default (read/write) 2420712 2421080 368 0.0
.text 1378976 1379344 368 0.0
lock-app default (read/write) 2438760 2439136 376 0.0
.text 1397024 1397400 376 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779708 780136 428 0.1
text 551518 551554 36 0.0
lighting-app tlsr9518adk80d (read/write) 799736 800172 436 0.1
text 568252 568288 36 0.0
Decreases (7 builds for cyw30739, k32w, linux, mbed, nrfconnect)
platform target config section 6ef806b 8c5d5cd change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570902 570870 -32 -0.0
.app_xip_area 466024 465992 -32 -0.0
k32w light k32w061+release (read/write) 681000 680768 -232 -0.0
.text 597116 596884 -232 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9423884 9423196 -688 -0.0
(read/write) 668993 668801 -192 -0.0
.data.rel.ro 606736 606560 -176 -0.0
.got 15008 15000 -8 -0.1
.text 7435140 7434692 -448 -0.0
thermostat-no-ble arm64 .text 1988704 1988576 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424944 2424816 -128 -0.0
.text 1387588 1387460 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814728 814684 -44 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 787728 787688 -40 -0.0
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6ef806b 8c5d5cd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621842 622162 320 0.1
.app_xip_area 525420 525740 320 0.1
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630550 630870 320 0.1
.app_xip_area 535600 535920 320 0.1
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570902 570870 -32 -0.0
.app_xip_area 466024 465992 -32 -0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914752 915112 360 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914744 915104 360 0.0
BRD4161A+rpc (read only) 948988 949252 264 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948980 949244 264 0.0
BRD4161A+rs911x (read only) 789196 789556 360 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789188 789548 360 0.0
lock-app BRD4161A+wf200 (read only) 954352 954632 280 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954344 954624 280 0.0
window-app BRD4161A (read only) 899680 900048 368 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899672 900040 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005432 1005478 46 0.0
(read/write) 1479594 1479994 400 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210360 210760 400 0.2
.flash.text 1005432 1005478 46 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060587 1060615 28 0.0
(read/write) 481808 482200 392 0.1
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240940 241332 392 0.2
.flash.text 1055203 1055231 28 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681000 680768 -232 -0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597116 596884 -232 -0.0
lock k32w061+release (read/write) 732504 732760 256 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648220 648476 256 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9423884 9423196 -688 -0.0
(read/write) 668993 668801 -192 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606736 606560 -176 -0.0
.dynamic 528 528 0 0.0
.got 15008 15000 -8 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460036 460244 208 0.0
.text 7435140 7434692 -448 -0.0
thermostat-no-ble arm64 (read only) 2366452 2366836 384 0.0
(read/write) 177425 177441 16 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80176 80200 24 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148660 496 0.3
.text 1988704 1988576 -128 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424944 2424816 -128 -0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387588 1387460 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186495 1186835 340 0.0
bss 139276 139280 4 0.0
rodata 153584 153972 388 0.3
text 814728 814684 -44 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135227 1135571 344 0.0
bss 138508 138508 0 0.0
rodata 130148 130540 392 0.3
text 787728 787688 -40 -0.0
p6 all-clusters-app default (read/write) 2540816 2541184 368 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499080 1499448 368 0.0
all-clusters-minimal-app default (read/write) 2486760 2487136 376 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445024 1445400 376 0.0
light-app default (read/write) 2420712 2421080 368 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1378976 1379344 368 0.0
lock-app default (read/write) 2438760 2439136 376 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397024 1397400 376 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779708 780136 428 0.1
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551518 551554 36 0.0
lighting-app tlsr9518adk80d (read/write) 799736 800172 436 0.1
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568252 568288 36 0.0

@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

PR #18965: Size comparison from 6ef806b to 5c29287

Increases above 0.2%:

platform target config section 6ef806b 5c29287 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 84263 84495 232 0.3
all-clusters-minimal-app LP_CC2652R7 .rodata 73655 73871 216 0.3
lock-ftd LP_CC2652R7 .rodata 96199 96551 352 0.4
lock-mtd LP_CC2652R7 .rodata 96087 96439 352 0.4
pump-app LP_CC2652R7 .rodata 88675 89035 360 0.4
pump-controller-app LP_CC2652R7 .rodata 83419 83755 336 0.4
shell LP_CC2652R7 .rodata 81238 81478 240 0.3
linux bridge-app debug+rpc .rodata 168768 169280 512 0.3
lighting-app debug+rpc .rodata 187400 187944 544 0.3
ota-provider-app debug .rodata 180184 180728 544 0.3
ota-requestor-app debug .rodata 176256 176768 512 0.3
thermostat-no-ble arm64 .rodata 148164 148660 496 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 153584 153972 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 130148 130540 392 0.3
Increases (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 6ef806b 5c29287 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648263 648407 144 0.0
.rodata 84263 84495 232 0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 615103 615231 128 0.0
.rodata 73655 73871 216 0.3
lock-ftd LP_CC2652R7 (read only) 679815 680079 264 0.0
.rodata 96199 96551 352 0.4
lock-mtd LP_CC2652R7 (read only) 629223 629487 264 0.0
.rodata 96087 96439 352 0.4
pump-app LP_CC2652R7 (read only) 676219 676475 256 0.0
.rodata 88675 89035 360 0.4
pump-controller-app LP_CC2652R7 (read only) 654163 654411 248 0.0
.rodata 83419 83755 336 0.4
shell LP_CC2652R7 (read only) 641262 641430 168 0.0
.rodata 81238 81478 240 0.3
cyw30739 light cyw930739m2evb_01 (read/write) 621842 622162 320 0.1
.app_xip_area 525420 525740 320 0.1
lock cyw930739m2evb_01 (read/write) 630550 630870 320 0.1
.app_xip_area 535600 535920 320 0.1
efr32 lighting-app BRD4161A (read only) 914752 915112 360 0.0
.text 914744 915104 360 0.0
BRD4161A+rpc (read only) 948988 949252 264 0.0
.text 948980 949244 264 0.0
BRD4161A+rs911x (read only) 789196 789556 360 0.0
.text 789188 789548 360 0.0
lock-app BRD4161A+wf200 (read only) 954352 954632 280 0.0
.text 954344 954624 280 0.0
window-app BRD4161A (read only) 899680 900048 368 0.0
.text 899672 900040 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005432 1005478 46 0.0
(read/write) 1479594 1479994 400 0.0
.flash.rodata 210360 210760 400 0.2
.flash.text 1005432 1005478 46 0.0
m5stack (read only) 1060587 1060615 28 0.0
(read/write) 481808 482200 392 0.1
.flash.rodata 240940 241332 392 0.2
.flash.text 1055203 1055231 28 0.0
k32w lock k32w061+release (read/write) 732504 732760 256 0.0
.text 648220 648476 256 0.0
linux all-clusters-app debug .rodata 243677 244189 512 0.2
all-clusters-minimal-app debug .rodata 245597 246077 480 0.2
bridge-app debug+rpc .rodata 168768 169280 512 0.3
chip-tool debug .rodata 496317 496541 224 0.0
chip-tool-no-interactive-ipv6only arm64 .rodata 460036 460244 208 0.0
lighting-app debug+rpc .rodata 187400 187944 544 0.3
lock-app debug .rodata 200904 201384 480 0.2
ota-provider-app debug (read only) 2067441 2068081 640 0.0
.rodata 180184 180728 544 0.3
.text 1728210 1728306 96 0.0
ota-requestor-app debug .rodata 176256 176768 512 0.3
shell debug .rodata 223794 224306 512 0.2
thermostat-no-ble arm64 (read only) 2366452 2366836 384 0.0
(read/write) 177425 177441 16 0.0
.data.rel.ro 80176 80200 24 0.0
.rodata 148164 148660 496 0.3
tv-app debug .rodata 222112 222624 512 0.2
tv-casting-app debug .rodata 339808 340160 352 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186495 1186835 340 0.0
bss 139276 139280 4 0.0
rodata 153584 153972 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135227 1135571 344 0.0
rodata 130148 130540 392 0.3
p6 all-clusters-app default (read/write) 2540816 2541184 368 0.0
.text 1499080 1499448 368 0.0
all-clusters-minimal-app default (read/write) 2486760 2487136 376 0.0
.text 1445024 1445400 376 0.0
light-app default (read/write) 2420712 2421080 368 0.0
.text 1378976 1379344 368 0.0
lock-app default (read/write) 2438760 2439136 376 0.0
.text 1397024 1397400 376 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779708 780136 428 0.1
text 551518 551554 36 0.0
lighting-app tlsr9518adk80d (read/write) 799736 800172 436 0.1
text 568252 568288 36 0.0
Decreases (24 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect)
platform target config section 6ef806b 5c29287 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .text 563764 563676 -88 -0.0
all-clusters-minimal-app LP_CC2652R7 .text 541212 541124 -88 -0.0
lock-ftd LP_CC2652R7 (read/write) 163008 162744 -264 -0.2
.text 583132 583044 -88 -0.0
lock-mtd LP_CC2652R7 .text 532644 532556 -88 -0.0
pump-app LP_CC2652R7 (read/write) 167772 167516 -256 -0.2
.text 587060 586956 -104 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189684 189436 -248 -0.1
.text 570264 570176 -88 -0.0
shell LP_CC2652R7 .text 559792 559720 -72 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570902 570870 -32 -0.0
.app_xip_area 466024 465992 -32 -0.0
k32w light k32w061+release (read/write) 681000 680768 -232 -0.0
.text 597116 596884 -232 -0.0
linux all-clusters-app debug (read only) 2769441 2769345 -96 -0.0
.text 2351858 2351250 -608 -0.0
all-clusters-minimal-app debug (read only) 2646561 2646433 -128 -0.0
.text 2228450 2227842 -608 -0.0
bridge-app debug+rpc (read only) 2029753 2029657 -96 -0.0
.text 1704514 1703906 -608 -0.0
chip-tool debug (read only) 9680645 9679685 -960 -0.0
(read/write) 602736 602544 -192 -0.0
.data.rel.ro 571336 571160 -176 -0.0
.text 7790965 7790213 -752 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423884 9423196 -688 -0.0
(read/write) 668993 668801 -192 -0.0
.data.rel.ro 606736 606560 -176 -0.0
.got 15008 15000 -8 -0.1
.text 7435140 7434692 -448 -0.0
lighting-app debug+rpc (read only) 2318305 2318001 -304 -0.0
.text 1965202 1964354 -848 -0.0
lock-app debug (read only) 2258377 2258233 -144 -0.0
.text 1897202 1896578 -624 -0.0
ota-requestor-app debug (read only) 2096241 2096145 -96 -0.0
.text 1759474 1758866 -608 -0.0
shell debug (read only) 2573545 2573449 -96 -0.0
.text 2190354 2189746 -608 -0.0
thermostat-no-ble arm64 .text 1988704 1988576 -128 -0.0
tv-app debug (read only) 2876105 2875993 -112 -0.0
.text 2471458 2470834 -624 -0.0
tv-casting-app debug (read only) 5437833 5433801 -4032 -0.1
(read/write) 226160 226000 -160 -0.1
.data.rel.ro 138912 138752 -160 -0.1
.text 4738434 4734434 -4000 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424944 2424816 -128 -0.0
.text 1387588 1387460 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814728 814684 -44 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 787728 787688 -40 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6ef806b 5c29287 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648263 648407 144 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84263 84495 232 0.3
.text 563764 563676 -88 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615103 615231 128 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73655 73871 216 0.3
.text 541212 541124 -88 -0.0
lock-ftd LP_CC2652R7 (read only) 679815 680079 264 0.0
(read/write) 163008 162744 -264 -0.2
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96199 96551 352 0.4
.text 583132 583044 -88 -0.0
lock-mtd LP_CC2652R7 (read only) 629223 629487 264 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96087 96439 352 0.4
.text 532644 532556 -88 -0.0
pump-app LP_CC2652R7 (read only) 676219 676475 256 0.0
(read/write) 167772 167516 -256 -0.2
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88675 89035 360 0.4
.text 587060 586956 -104 -0.0
pump-controller-app LP_CC2652R7 (read only) 654163 654411 248 0.0
(read/write) 189684 189436 -248 -0.1
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83419 83755 336 0.4
.text 570264 570176 -88 -0.0
shell LP_CC2652R7 (read only) 641262 641430 168 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81238 81478 240 0.3
.text 559792 559720 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621842 622162 320 0.1
.app_xip_area 525420 525740 320 0.1
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630550 630870 320 0.1
.app_xip_area 535600 535920 320 0.1
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570902 570870 -32 -0.0
.app_xip_area 466024 465992 -32 -0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914752 915112 360 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914744 915104 360 0.0
BRD4161A+rpc (read only) 948988 949252 264 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948980 949244 264 0.0
BRD4161A+rs911x (read only) 789196 789556 360 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789188 789548 360 0.0
lock-app BRD4161A+wf200 (read only) 954352 954632 280 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954344 954624 280 0.0
window-app BRD4161A (read only) 899680 900048 368 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899672 900040 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005432 1005478 46 0.0
(read/write) 1479594 1479994 400 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210360 210760 400 0.2
.flash.text 1005432 1005478 46 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060587 1060615 28 0.0
(read/write) 481808 482200 392 0.1
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240940 241332 392 0.2
.flash.text 1055203 1055231 28 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681000 680768 -232 -0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597116 596884 -232 -0.0
lock k32w061+release (read/write) 732504 732760 256 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648220 648476 256 0.0
linux all-clusters-app debug (read only) 2769441 2769345 -96 -0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83832 83832 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 244189 512 0.2
.text 2351858 2351250 -608 -0.0
all-clusters-minimal-app debug (read only) 2646561 2646433 -128 -0.0
(read/write) 170272 170272 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76712 76712 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 246077 480 0.2
.text 2228450 2227842 -608 -0.0
bridge-app debug+rpc (read only) 2029753 2029657 -96 -0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65480 65480 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 169280 512 0.3
.text 1704514 1703906 -608 -0.0
chip-tool debug (read only) 9680645 9679685 -960 -0.0
(read/write) 602736 602544 -192 -0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 571336 571160 -176 -0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496317 496541 224 0.0
.text 7790965 7790213 -752 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423884 9423196 -688 -0.0
(read/write) 668993 668801 -192 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 606736 606560 -176 -0.0
.dynamic 528 528 0 0.0
.got 15008 15000 -8 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460036 460244 208 0.0
.text 7435140 7434692 -448 -0.0
lighting-app debug+rpc (read only) 2318305 2318001 -304 -0.0
(read/write) 153504 153504 0 0.0
.bss 74720 74720 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187400 187944 544 0.3
.text 1965202 1964354 -848 -0.0
lock-app debug (read only) 2258377 2258233 -144 -0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 201384 480 0.2
.text 1897202 1896578 -624 -0.0
ota-provider-app debug (read only) 2067441 2068081 640 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60984 60984 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180728 544 0.3
.text 1728210 1728306 96 0.0
ota-requestor-app debug (read only) 2096241 2096145 -96 -0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63080 63080 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176768 512 0.3
.text 1759474 1758866 -608 -0.0
shell debug (read only) 2573545 2573449 -96 -0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77448 77448 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 224306 512 0.2
.text 2190354 2189746 -608 -0.0
thermostat-no-ble arm64 (read only) 2366452 2366836 384 0.0
(read/write) 177425 177441 16 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80176 80200 24 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148660 496 0.3
.text 1988704 1988576 -128 -0.0
tv-app debug (read only) 2876105 2875993 -112 -0.0
(read/write) 280176 280176 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78200 78200 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222624 512 0.2
.text 2471458 2470834 -624 -0.0
tv-casting-app debug (read only) 5437833 5433801 -4032 -0.1
(read/write) 226160 226000 -160 -0.1
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138912 138752 -160 -0.1
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 340160 352 0.1
.text 4738434 4734434 -4000 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424944 2424816 -128 -0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387588 1387460 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186495 1186835 340 0.0
bss 139276 139280 4 0.0
rodata 153584 153972 388 0.3
text 814728 814684 -44 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135227 1135571 344 0.0
bss 138508 138508 0 0.0
rodata 130148 130540 392 0.3
text 787728 787688 -40 -0.0
p6 all-clusters-app default (read/write) 2540816 2541184 368 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499080 1499448 368 0.0
all-clusters-minimal-app default (read/write) 2486760 2487136 376 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445024 1445400 376 0.0
light-app default (read/write) 2420712 2421080 368 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1378976 1379344 368 0.0
lock-app default (read/write) 2438760 2439136 376 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397024 1397400 376 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779708 780136 428 0.1
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551518 551554 36 0.0
lighting-app tlsr9518adk80d (read/write) 799736 800172 436 0.1
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568252 568288 36 0.0

bzbarsky-apple
bzbarsky-apple approved these changes May 31, 2022
View reviewed changes
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Jun 1, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #18965: Size comparison from eb3ac83 to c9d6588

Increases above 0.2%:

platform target config section eb3ac83 c9d6588 change % change
linux thermostat-no-ble arm64 .rodata 148164 148660 496 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 153592 153980 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 130156 130548 392 0.3
Increases (9 builds for cyw30739, k32w, linux, nrfconnect, telink)
platform target config section eb3ac83 c9d6588 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621790 622118 328 0.1
.app_xip_area 525368 525696 328 0.1
lock cyw930739m2evb_01 (read/write) 630498 630826 328 0.1
.app_xip_area 535548 535876 328 0.1
k32w lock k32w061+release (read/write) 732420 732692 272 0.0
.text 648136 648408 272 0.0
linux chip-tool-no-interactive-ipv6only arm64 .rodata 459972 460180 208 0.0
thermostat-no-ble arm64 (read only) 2366708 2367236 528 0.0
(read/write) 177441 177457 16 0.0
.data.rel.ro 80192 80216 24 0.0
.rodata 148164 148660 496 0.3
.text 1988912 1988928 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186795 340 0.0
bss 139276 139280 4 0.0
rodata 153592 153980 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135531 360 0.0
rodata 130156 130548 392 0.3
telink light-switch-app tlsr9518adk80d (read/write) 779596 780048 452 0.1
text 551404 551456 52 0.0
lighting-app tlsr9518adk80d (read/write) 799640 800092 452 0.1
text 568146 568198 52 0.0
Decreases (6 builds for cyw30739, k32w, linux, mbed, nrfconnect)
platform target config section eb3ac83 c9d6588 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570978 -32 -0.0
.app_xip_area 466132 466100 -32 -0.0
k32w light k32w061+release (read/write) 680932 680700 -232 -0.0
.text 597048 596816 -232 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9413244 -608 -0.0
(read/write) 667105 666929 -176 -0.0
.data.rel.ro 604872 604696 -176 -0.0
.got 14992 14984 -8 -0.1
.text 7429556 7429204 -352 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425016 2424832 -184 -0.0
.text 1387660 1387476 -184 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814672 814632 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 787672 787636 -36 -0.0
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
platform target config section eb3ac83 c9d6588 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621790 622118 328 0.1
.app_xip_area 525368 525696 328 0.1
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630826 328 0.1
.app_xip_area 535548 535876 328 0.1
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570978 -32 -0.0
.app_xip_area 466132 466100 -32 -0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 680932 680700 -232 -0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 596816 -232 -0.0
lock k32w061+release (read/write) 732420 732692 272 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648408 272 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9413244 -608 -0.0
(read/write) 667105 666929 -176 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604696 -176 -0.0
.dynamic 528 528 0 0.0
.got 14992 14984 -8 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 460180 208 0.0
.text 7429556 7429204 -352 -0.0
thermostat-no-ble arm64 (read only) 2366708 2367236 528 0.0
(read/write) 177441 177457 16 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80216 24 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148660 496 0.3
.text 1988912 1988928 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2424832 -184 -0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387476 -184 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186795 340 0.0
bss 139276 139280 4 0.0
rodata 153592 153980 388 0.3
text 814672 814632 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135531 360 0.0
bss 138508 138508 0 0.0
rodata 130156 130548 392 0.3
text 787672 787636 -36 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 780048 452 0.1
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551456 52 0.0
lighting-app tlsr9518adk80d (read/write) 799640 800092 452 0.1
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568198 52 0.0

@restyled-io restyled-io bot mentioned this pull request Jun 1, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #18965: Size comparison from eb3ac83 to c192af8

Increases above 0.2%:

platform target config section eb3ac83 c192af8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 84267 84499 232 0.3
all-clusters-minimal-app LP_CC2652R7 .rodata 73659 73883 224 0.3
lock-ftd LP_CC2652R7 .rodata 96211 96563 352 0.4
lock-mtd LP_CC2652R7 .rodata 96099 96451 352 0.4
pump-app LP_CC2652R7 .rodata 88687 89039 352 0.4
pump-controller-app LP_CC2652R7 .rodata 83423 83767 344 0.4
shell LP_CC2652R7 .rodata 81250 81490 240 0.3
linux all-clusters-app debug .rodata 243677 244381 704 0.3
all-clusters-minimal-app debug .rodata 245597 246269 672 0.3
bridge-app debug+rpc .rodata 168768 169472 704 0.4
lighting-app debug+rpc .rodata 187720 188456 736 0.4
lock-app debug .rodata 200904 201576 672 0.3
ota-provider-app debug .rodata 180184 180920 736 0.4
ota-requestor-app debug .rodata 176256 176960 704 0.4
shell debug .rodata 223794 224498 704 0.3
thermostat-no-ble arm64 .rodata 148164 148708 544 0.4
tv-app debug .rodata 222112 222848 736 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 153592 153980 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 rodata 130156 130548 392 0.3
Increases (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section eb3ac83 c192af8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648347 160 0.0
.rodata 84267 84499 232 0.3
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615179 152 0.0
.rodata 73659 73883 224 0.3
lock-ftd LP_CC2652R7 (read only) 679731 679995 264 0.0
.rodata 96211 96563 352 0.4
lock-mtd LP_CC2652R7 (read only) 629147 629411 264 0.0
.rodata 96099 96451 352 0.4
pump-app LP_CC2652R7 (read only) 676167 676415 248 0.0
.rodata 88687 89039 352 0.4
pump-controller-app LP_CC2652R7 (read only) 654087 654343 256 0.0
.rodata 83423 83767 344 0.4
shell LP_CC2652R7 (read only) 641194 641362 168 0.0
.rodata 81250 81490 240 0.3
cyw30739 light cyw930739m2evb_01 (read/write) 621790 622118 328 0.1
.app_xip_area 525368 525696 328 0.1
lock cyw930739m2evb_01 (read/write) 630498 630826 328 0.1
.app_xip_area 535548 535876 328 0.1
efr32 lighting-app BRD4161A (read only) 914500 914876 376 0.0
.text 914492 914868 376 0.0
BRD4161A+rpc (read only) 948736 949032 296 0.0
.text 948728 949024 296 0.0
BRD4161A+rs911x (read only) 789360 789736 376 0.0
.text 789352 789728 376 0.0
lock-app BRD4161A+wf200 (read only) 954460 954756 296 0.0
.text 954452 954748 296 0.0
window-app BRD4161A (read only) 899428 899796 368 0.0
.text 899420 899788 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005546 64 0.0
(read/write) 1479602 1480002 400 0.0
.flash.rodata 210368 210768 400 0.2
.flash.text 1005482 1005546 64 0.0
m5stack (read only) 1060687 1060691 4 0.0
(read/write) 481816 482208 392 0.1
.flash.rodata 240948 241340 392 0.2
.flash.text 1055303 1055307 4 0.0
k32w lock k32w061+release (read/write) 732420 732692 272 0.0
.text 648136 648408 272 0.0
linux all-clusters-app debug (read only) 2769745 2769985 240 0.0
.rodata 243677 244381 704 0.3
all-clusters-minimal-app debug (read only) 2646865 2647073 208 0.0
.rodata 245597 246269 672 0.3
bridge-app debug+rpc (read only) 2030057 2030297 240 0.0
.rodata 168768 169472 704 0.4
chip-tool debug .rodata 496285 496701 416 0.1
chip-tool-no-interactive-ipv6only arm64 .rodata 459972 460228 256 0.1
lighting-app debug+rpc (read only) 2319889 2319921 32 0.0
.rodata 187720 188456 736 0.4
lock-app debug (read only) 2258649 2258857 208 0.0
.rodata 200904 201576 672 0.3
ota-provider-app debug (read only) 2067729 2068689 960 0.0
.rodata 180184 180920 736 0.4
.text 1728450 1728674 224 0.0
ota-requestor-app debug (read only) 2096529 2096753 224 0.0
.rodata 176256 176960 704 0.4
shell debug (read only) 2573833 2574073 240 0.0
.rodata 223794 224498 704 0.3
thermostat-no-ble arm64 (read only) 2366708 2367316 608 0.0
(read/write) 177441 177457 16 0.0
.data.rel.ro 80192 80216 24 0.0
.rodata 148164 148708 544 0.4
.text 1988912 1988960 48 0.0
tv-app debug (read only) 2876433 2876689 256 0.0
.rodata 222112 222848 736 0.3
tv-casting-app debug .rodata 339808 340352 544 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186795 340 0.0
bss 139276 139280 4 0.0
rodata 153592 153980 388 0.3
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135531 360 0.0
rodata 130156 130548 392 0.3
p6 all-clusters-app default (read/write) 2540960 2541352 392 0.0
.text 1499224 1499616 392 0.0
all-clusters-minimal-app default (read/write) 2486928 2487304 376 0.0
.text 1445192 1445568 376 0.0
light-app default (read/write) 2420872 2421248 376 0.0
.text 1379136 1379512 376 0.0
lock-app default (read/write) 2438912 2439296 384 0.0
.text 1397176 1397560 384 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 780048 452 0.1
text 551404 551456 52 0.0
lighting-app tlsr9518adk80d (read/write) 799640 800092 452 0.1
text 568146 568198 52 0.0
Decreases (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect)
platform target config section eb3ac83 c192af8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .text 563684 563612 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 .text 541132 541060 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 163092 162828 -264 -0.2
.text 583036 582948 -88 -0.0
lock-mtd LP_CC2652R7 .text 532556 532468 -88 -0.0
pump-app LP_CC2652R7 (read/write) 167824 167576 -248 -0.1
.text 586996 586892 -104 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189760 189504 -256 -0.1
.text 570184 570096 -88 -0.0
shell LP_CC2652R7 .text 559712 559640 -72 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570978 -32 -0.0
.app_xip_area 466132 466100 -32 -0.0
k32w light k32w061+release (read/write) 680932 680700 -232 -0.0
.text 597048 596816 -232 -0.0
linux all-clusters-app debug .text 2352114 2351650 -464 -0.0
all-clusters-minimal-app debug .text 2228706 2228242 -464 -0.0
bridge-app debug+rpc .text 1704770 1704306 -464 -0.0
chip-tool debug (read only) 9669565 9668925 -640 -0.0
(read/write) 600848 600688 -160 -0.0
.data.rel.ro 569472 569296 -176 -0.0
.text 7784261 7783637 -624 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9413324 -528 -0.0
(read/write) 667105 666929 -176 -0.0
.data.rel.ro 604872 604696 -176 -0.0
.got 14992 14984 -8 -0.1
.text 7429556 7429236 -320 -0.0
lighting-app debug+rpc .text 1966418 1965714 -704 -0.0
lock-app debug .text 1897426 1896962 -464 -0.0
ota-requestor-app debug .text 1759714 1759234 -480 -0.0
shell debug .text 2190594 2190130 -464 -0.0
tv-app debug .text 2471714 2471234 -480 -0.0
tv-casting-app debug (read only) 5434009 5430313 -3696 -0.1
(read/write) 226160 226000 -160 -0.1
.data.rel.ro 138920 138760 -160 -0.1
.text 4734562 4730706 -3856 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425016 2424832 -184 -0.0
.text 1387660 1387476 -184 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814672 814632 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 787672 787636 -36 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 c192af8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648347 160 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84499 232 0.3
.text 563684 563612 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615179 152 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73883 224 0.3
.text 541132 541060 -72 -0.0
lock-ftd LP_CC2652R7 (read only) 679731 679995 264 0.0
(read/write) 163092 162828 -264 -0.2
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96563 352 0.4
.text 583036 582948 -88 -0.0
lock-mtd LP_CC2652R7 (read only) 629147 629411 264 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96451 352 0.4
.text 532556 532468 -88 -0.0
pump-app LP_CC2652R7 (read only) 676167 676415 248 0.0
(read/write) 167824 167576 -248 -0.1
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 89039 352 0.4
.text 586996 586892 -104 -0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654343 256 0.0
(read/write) 189760 189504 -256 -0.1
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83767 344 0.4
.text 570184 570096 -88 -0.0
shell LP_CC2652R7 (read only) 641194 641362 168 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81490 240 0.3
.text 559712 559640 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 622118 328 0.1
.app_xip_area 525368 525696 328 0.1
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630826 328 0.1
.app_xip_area 535548 535876 328 0.1
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 570978 -32 -0.0
.app_xip_area 466132 466100 -32 -0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914500 914876 376 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914492 914868 376 0.0
BRD4161A+rpc (read only) 948736 949032 296 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948728 949024 296 0.0
BRD4161A+rs911x (read only) 789360 789736 376 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789728 376 0.0
lock-app BRD4161A+wf200 (read only) 954460 954756 296 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954748 296 0.0
window-app BRD4161A (read only) 899428 899796 368 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899420 899788 368 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005546 64 0.0
(read/write) 1479602 1480002 400 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210768 400 0.2
.flash.text 1005482 1005546 64 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060691 4 0.0
(read/write) 481816 482208 392 0.1
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 241340 392 0.2
.flash.text 1055303 1055307 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 680700 -232 -0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 596816 -232 -0.0
lock k32w061+release (read/write) 732420 732692 272 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648408 272 0.0
linux all-clusters-app debug (read only) 2769745 2769985 240 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 244381 704 0.3
.text 2352114 2351650 -464 -0.0
all-clusters-minimal-app debug (read only) 2646865 2647073 208 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 246269 672 0.3
.text 2228706 2228242 -464 -0.0
bridge-app debug+rpc (read only) 2030057 2030297 240 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 169472 704 0.4
.text 1704770 1704306 -464 -0.0
chip-tool debug (read only) 9669565 9668925 -640 -0.0
(read/write) 600848 600688 -160 -0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569296 -176 -0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496701 416 0.1
.text 7784261 7783637 -624 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9413324 -528 -0.0
(read/write) 667105 666929 -176 -0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604696 -176 -0.0
.dynamic 528 528 0 0.0
.got 14992 14984 -8 -0.1
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 460228 256 0.1
.text 7429556 7429236 -320 -0.0
lighting-app debug+rpc (read only) 2319889 2319921 32 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 188456 736 0.4
.text 1966418 1965714 -704 -0.0
lock-app debug (read only) 2258649 2258857 208 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 201576 672 0.3
.text 1897426 1896962 -464 -0.0
ota-provider-app debug (read only) 2067729 2068689 960 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180920 736 0.4
.text 1728450 1728674 224 0.0
ota-requestor-app debug (read only) 2096529 2096753 224 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176960 704 0.4
.text 1759714 1759234 -480 -0.0
shell debug (read only) 2573833 2574073 240 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 224498 704 0.3
.text 2190594 2190130 -464 -0.0
thermostat-no-ble arm64 (read only) 2366708 2367316 608 0.0
(read/write) 177441 177457 16 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80216 24 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148708 544 0.4
.text 1988912 1988960 48 0.0
tv-app debug (read only) 2876433 2876689 256 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222848 736 0.3
.text 2471714 2471234 -480 -0.0
tv-casting-app debug (read only) 5434009 5430313 -3696 -0.1
(read/write) 226160 226000 -160 -0.1
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138760 -160 -0.1
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 340352 544 0.2
.text 4734562 4730706 -3856 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2424832 -184 -0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387476 -184 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186795 340 0.0
bss 139276 139280 4 0.0
rodata 153592 153980 388 0.3
text 814672 814632 -40 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135531 360 0.0
bss 138508 138508 0 0.0
rodata 130156 130548 392 0.3
text 787672 787636 -36 -0.0
p6 all-clusters-app default (read/write) 2540960 2541352 392 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499616 392 0.0
all-clusters-minimal-app default (read/write) 2486928 2487304 376 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445568 376 0.0
light-app default (read/write) 2420872 2421248 376 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379512 376 0.0
lock-app default (read/write) 2438912 2439296 384 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397560 384 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 780048 452 0.1
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551456 52 0.0
lighting-app tlsr9518adk80d (read/write) 799640 800092 452 0.1
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568198 52 0.0

@tcarmelveilleux tcarmelveilleux merged commit 50d1c8e into project-chip:master Jun 1, 2022
@cpagravel cpagravel mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
5 participants
@tcarmelveilleux @andy31415 @emargolis @bzbarsky-apple @restyled-commits