Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text entries to mDNS service discovery response #19027

Merged
merged 14 commits into from
Jun 3, 2022
Merged

Add text entries to mDNS service discovery response #19027

merged 14 commits into from
Jun 3, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

Change overview

  • Add map of text key/values to service discovery response from android layer

Testing

  • tested using android tv-app running against linux tv-casting-app

chrisdecenzo and others added 3 commits June 1, 2022 16:21
@chrisdecenzo
address feedback, formatting
9b7e8ab
@chrisdecenzo
fix darwin build
00046d0
@restyled-io @restyled-commits
Restyle Add text entries to mDNS service discovery response (#19028)
393f2d2 
* Restyled by whitespace

* Restyled by google-java-format

Co-authored-by: Restyled.io <commits@restyled.io>
@restyled-io restyled-io bot mentioned this pull request Jun 2, 2022
Closed
andy31415
andy31415 approved these changes Jun 2, 2022
View reviewed changes
src/platform/android/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/android/DnssdImpl.cpp Show resolved Hide resolved
@chrisdecenzo chrisdecenzo merged commit e7eb67e into master Jun 3, 2022
@chrisdecenzo chrisdecenzo deleted the tvapps-android-9 branch June 3, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@joonhaengHeo joonhaengHeo joonhaengHeo approved these changes

@sharadb-amazon sharadb-amazon sharadb-amazon approved these changes

@lazarkov lazarkov lazarkov approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android mDNS service discovery does not return txt entries
6 participants
@chrisdecenzo @andy31415 @lazarkov @sharadb-amazon @woody-apple @joonhaengHeo