-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reuse a commissionee device if it has the wrong device id. #19141
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-commissionee-reuse
Jun 6, 2022
Merged
Don't reuse a commissionee device if it has the wrong device id. #19141
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-commissionee-reuse
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found during investigation of project-chip#15409 but there may be more problems left in that issue. If we get into EstablishPASEConnection and find an existing commissionee for the peer address (which is easy for BLE, where the peer address is basically a singleton), but the device id does not match the passed-in one, we should not reuse that device. If we try to, Commission will fail to find the commissionee device by device id and fail out.
PR #19141: Size comparison from 1868a88 to 224ca1c Increases (1 build for linux)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jun 3, 2022
msandstedt
reviewed
Jun 3, 2022
msandstedt
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during investigation of
#15409 but there
may be more problems left in that issue.
If we get into EstablishPASEConnection and find an existing
commissionee for the peer address (which is easy for BLE, where the
peer address is basically a singleton), but the device id does not
match the passed-in one, we should not reuse that device. If we try
to, Commission will fail to find the commissionee device by device id
and fail out.
Problem
See above.
Change overview
See above.
Testing
Tested that the steps from #15409 (comment) no longer result in an error for the second commissioning attempt.