Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level Control Server Cluster fix for level transitions #19392

Merged
merged 14 commits into from
Jun 16, 2022
Merged

Level Control Server Cluster fix for level transitions #19392

merged 14 commits into from
Jun 16, 2022

Conversation

rochaferraz
Copy link
Contributor

@rochaferraz rochaferraz commented Jun 9, 2022 •
edited
Loading

Problem & Solution

The all-clusters and lighting apps rely on the af-gen-event.h file for the EMBER_AF_GENERATED_EVENTS definition, along with its context. However, the file is not automatically generated by zap. Thus other sample apps that rely on level control don't perform the level transition.

This definition enables the cluster events/ticks that cause a transition from one state to another on time-dependent clusters such as level control.

This change to level control deprecates the use of af-events. Level control server cluster now handles its own timer for state transitions using standard Matter SDK calls.

This fixes the issue on interop_testing_te9 event. Once discussed and approved another similar PR will be made against master branch.

Testing

  • Tested with a 2-endpoint dimmable light example in chef app and chip-tool
  • level control server cluster correctly transitions from 0->254 within the correct time span informed of 5s. Both on endpoints 1 and 2, that have level control clusters
  • level control server cluster correctly transitions from 254->0 within the correct time span informed of 10s
  • same tests as above, but interrupted during transition. So a transition that should perform a transition of 0->254 stops at around 120 by another command to perform a transition to 0, and correctly dims back to 0 on the informed transition time

@boring-cyborg boring-cyborg bot added the app label Jun 9, 2022
rochaferraz added 12 commits June 15, 2022 14:22
@rochaferraz
fix: level control server handles its own ticks
8080cc7
@rochaferraz
chg: restyle
505ea5c 
Change-Id: I7fa4e59bb4bc822220de366139fa315e94b8d369
@rochaferraz
chg: now using BitMapObjectPool to maintain list of timers running
b1a15f3
@rochaferraz
chg: restyle
2137e6d 
Change-Id: I09f5b3a2e2139aa2ff6fcf078f34ab84263db7c0
@rochaferraz
chg: removed debug logs
44458be
@rochaferraz
chg: only executes emberAfLevelControlClusterServerTickCallback if ev…
d55c392 
…ent still exists on eventEndpoints
@rochaferraz
chg: using timer context to embed the endpoint information
32d6cf2
@rochaferraz
chg: restyle
af9d7a4 
Change-Id: Iff5c718dacff7624b7af5543bac812711dd646d9
@rochaferraz
chg: cosmetic change
494132b 
Change-Id: I2384a31c63bdd87e0312184112c1cb682712f9b4
@rochaferraz
chg: removed unnecessary scheduling of callback
a1d84bf
@rochaferraz
chg: removed DeviceControlServer.h and included CHIPDeviceLayer.h
2ac0183
@rochaferraz
chg: removal of level cluster references from af-gen-event.h files
a12f513
@rochaferraz rochaferraz force-pushed the interop_testing_te9_level_cluster_fix_2_master branch from 0acfd2d to a12f513 Compare June 15, 2022 18:27
@rochaferraz
Copy link
Contributor Author

Shouldn't we (followup ok for this) remove all the emberAfLevelControlClusterServerTickCallback bits from all the af-gen-event.h files?

removed the references to level control cluster from the af-gen-event.h files

@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19392: Size comparison from a8b3a07 to f173928

Increases (8 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect)
platform target config section a8b3a07 f173928 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 657811 8 0.0
.text 570608 570616 8 0.0
pump-app LP_CC2652R7 (read/write) 171944 172184 240 0.1
pump-controller-app LP_CC2652R7 (read/write) 181324 181332 8 0.0
shell LP_CC2652R7 (read only) 687130 687146 16 0.0
.text 577408 577424 16 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 608238 608246 8 0.0
.app_xip_area 464784 464792 8 0.0
esp32 all-clusters-app c3devkit (read only) 1010748 1010780 32 0.0
.flash.text 1010748 1010780 32 0.0
m5stack (read only) 1065027 1065055 28 0.0
.flash.text 1059643 1059671 28 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 820968 820976 8 0.0
Decreases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section a8b3a07 f173928 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193012 192996 -16 -0.0
.bss 73708 73700 -8 -0.0
.data 3380 3356 -24 -0.7
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646223 -80 -0.0
.text 555824 555744 -80 -0.0
pump-app LP_CC2652R7 (read only) 669863 669623 -240 -0.0
.data 3316 3280 -36 -1.1
.text 582372 582132 -240 -0.0
pump-controller-app LP_CC2652R7 (read only) 660611 660603 -8 -0.0
.text 575196 575188 -8 -0.0
shell LP_CC2652R7 (read/write) 159180 159156 -24 -0.0
.bss 76004 75996 -8 -0.0
.data 3384 3360 -24 -0.7
cyw30739 light cyw930739m2evb_01 (read/write) 611154 610930 -224 -0.0
.app_xip_area 467844 467652 -192 -0.0
.data 764 728 -36 -4.7
efr32 lighting-app BRD4161A (read only) 920708 920484 -224 -0.0
(read/write) 132396 132360 -36 -0.0
.data 2116 2080 -36 -1.7
.text 920700 920476 -224 -0.0
BRD4161A+rpc (read only) 956364 956140 -224 -0.0
(read/write) 149272 149236 -36 -0.0
.data 2320 2284 -36 -1.6
.text 956356 956132 -224 -0.0
BRD4161A+rs911x (read only) 795824 795600 -224 -0.0
(read/write) 128676 128636 -40 -0.0
.data 2124 2088 -36 -1.7
.text 795816 795592 -224 -0.0
esp32 all-clusters-app c3devkit (read/write) 1482626 1482594 -32 -0.0
.dram0.bss 69344 69336 -8 -0.0
.dram0.data 14656 14624 -32 -0.2
m5stack (read/write) 484744 484704 -40 -0.0
.dram0.bss 74864 74856 -8 -0.0
.dram0.data 34176 34144 -32 -0.1
k32w light k32w061+release (read/write) 657352 657116 -236 -0.0
.bss 68708 68700 -8 -0.0
.data 2028 1992 -36 -1.8
.text 580816 580624 -192 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1196779 -24 -0.0
bss 141554 141542 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144835 1144755 -80 -0.0
text 793284 793200 -84 -0.0
p6 all-clusters-app default .bss 143344 143328 -16 -0.0
.data 2800 2776 -24 -0.9
all-clusters-minimal-app default (read/write) 2496056 2495960 -96 -0.0
.text 1454320 1454224 -96 -0.0
light-app default (read/write) 2426936 2426712 -224 -0.0
.data 2624 2592 -32 -1.2
.text 1385200 1384976 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806888 806620 -268 -0.0
bss 70088 70084 -4 -0.0
text 574496 574268 -228 -0.0
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section a8b3a07 f173928 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 657811 8 0.0
(read/write) 193012 192996 -16 -0.0
.bss 73708 73700 -8 -0.0
.data 3380 3356 -24 -0.7
.rodata 86883 86883 0 0.0
.text 570608 570616 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646223 -80 -0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90159 90159 0 0.0
.text 555824 555744 -80 -0.0
lock-ftd LP_CC2652R7 (read only) 688639 688639 0 0.0
(read/write) 152280 152280 0 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589244 589244 0 0.0
lock-mtd LP_CC2652R7 (read only) 638047 638047 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538764 538764 0 0.0
pump-app LP_CC2652R7 (read only) 669863 669623 -240 -0.0
(read/write) 171944 172184 240 0.1
.bss 70820 70820 0 0.0
.data 3316 3280 -36 -1.1
.rodata 87007 87007 0 0.0
.text 582372 582132 -240 -0.0
pump-controller-app LP_CC2652R7 (read only) 660611 660603 -8 -0.0
(read/write) 181324 181332 8 0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575196 575188 -8 -0.0
shell LP_CC2652R7 (read only) 687130 687146 16 0.0
(read/write) 159180 159156 -24 -0.0
.bss 76004 75996 -8 -0.0
.data 3384 3360 -24 -0.7
.rodata 109410 109410 0 0.0
.text 577408 577424 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611154 610930 -224 -0.0
.app_xip_area 467844 467652 -192 -0.0
.bss 86232 86232 0 0.0
.data 764 728 -36 -4.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608238 608246 8 0.0
.app_xip_area 464784 464792 8 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614250 614250 0 0.0
.app_xip_area 471860 471860 0 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920708 920484 -224 -0.0
(read/write) 132396 132360 -36 -0.0
.bss 130280 130280 0 0.0
.data 2116 2080 -36 -1.7
.text 920700 920476 -224 -0.0
BRD4161A+rpc (read only) 956364 956140 -224 -0.0
(read/write) 149272 149236 -36 -0.0
.bss 146952 146952 0 0.0
.data 2320 2284 -36 -1.6
.text 956356 956132 -224 -0.0
BRD4161A+rs911x (read only) 795824 795600 -224 -0.0
(read/write) 128676 128636 -40 -0.0
.bss 126548 126548 0 0.0
.data 2124 2088 -36 -1.7
.text 795816 795592 -224 -0.0
lock-app BRD4161A+wf200 (read only) 963720 963720 0 0.0
(read/write) 129012 129012 0 0.0
.bss 126924 126924 0 0.0
.data 2088 2088 0 0.0
.text 963712 963712 0 0.0
window-app BRD4161A (read only) 905580 905580 0 0.0
(read/write) 132460 132460 0 0.0
.bss 130352 130352 0 0.0
.data 2108 2108 0 0.0
.text 905572 905572 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010748 1010780 32 0.0
(read/write) 1482626 1482594 -32 -0.0
.dram0.bss 69344 69336 -8 -0.0
.dram0.data 14656 14624 -32 -0.2
.flash.rodata 213200 213200 0 0.0
.flash.text 1010748 1010780 32 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065027 1065055 28 0.0
(read/write) 484744 484704 -40 -0.0
.dram0.bss 74864 74856 -8 -0.0
.dram0.data 34176 34144 -32 -0.1
.flash.rodata 243708 243708 0 0.0
.flash.text 1059643 1059671 28 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657352 657116 -236 -0.0
.bss 68708 68700 -8 -0.0
.data 2028 1992 -36 -1.8
.text 580816 580624 -192 -0.0
lock k32w061+release (read/write) 719008 719008 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 642068 642068 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2435720 2435720 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1398364 1398364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1196779 -24 -0.0
bss 141554 141542 -12 -0.0
rodata 155420 155420 0 0.0
text 820968 820976 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144835 1144755 -80 -0.0
bss 140794 140794 0 0.0
rodata 131948 131948 0 0.0
text 793284 793200 -84 -0.0
p6 all-clusters-app default (read/write) 2550112 2550112 0 0.0
.bss 143344 143328 -16 -0.0
.data 2800 2776 -24 -0.9
.text 1508376 1508376 0 0.0
all-clusters-minimal-app default (read/write) 2496056 2495960 -96 -0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454320 1454224 -96 -0.0
light-app default (read/write) 2426936 2426712 -224 -0.0
.bss 134688 134688 0 0.0
.data 2624 2592 -32 -1.2
.text 1385200 1384976 -224 -0.0
lock-app default (read/write) 2447352 2447352 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405616 1405616 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786908 786908 0 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557804 557804 0 0.0
lighting-app tlsr9518adk80d (read/write) 806888 806620 -268 -0.0
bss 70088 70084 -4 -0.0
noinit 40416 40416 0 0.0
text 574496 574268 -228 -0.0

@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19392: Size comparison from a8b3a07 to 276b4a2

Increases (11 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, telink)
platform target config section a8b3a07 276b4a2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 657819 16 0.0
.text 570608 570624 16 0.0
pump-app LP_CC2652R7 (read/write) 171944 172184 240 0.1
pump-controller-app LP_CC2652R7 (read only) 660611 660619 8 0.0
.text 575196 575204 8 0.0
shell LP_CC2652R7 (read only) 687130 687154 24 0.0
.text 577408 577432 24 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 608238 608254 16 0.0
.app_xip_area 464784 464800 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614250 614266 16 0.0
.app_xip_area 471860 471876 16 0.0
efr32 window-app BRD4161A (read only) 905580 905596 16 0.0
.text 905572 905588 16 0.0
esp32 all-clusters-app c3devkit (read only) 1010748 1010784 36 0.0
.flash.text 1010748 1010784 36 0.0
m5stack (read only) 1065027 1065063 36 0.0
.flash.text 1059643 1059679 36 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 820968 820980 12 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786908 786916 8 0.0
text 557804 557810 6 0.0
Decreases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section a8b3a07 276b4a2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193012 192988 -24 -0.0
.bss 73708 73700 -8 -0.0
.data 3380 3356 -24 -0.7
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646223 -80 -0.0
.text 555824 555744 -80 -0.0
pump-app LP_CC2652R7 (read only) 669863 669623 -240 -0.0
.data 3316 3280 -36 -1.1
.text 582372 582132 -240 -0.0
pump-controller-app LP_CC2652R7 (read/write) 181324 181316 -8 -0.0
shell LP_CC2652R7 (read/write) 159180 159148 -32 -0.0
.bss 76004 75996 -8 -0.0
.data 3384 3360 -24 -0.7
cyw30739 light cyw930739m2evb_01 (read/write) 611154 610938 -216 -0.0
.app_xip_area 467844 467660 -184 -0.0
.data 764 728 -36 -4.7
efr32 lighting-app BRD4161A (read only) 920708 920500 -208 -0.0
(read/write) 132396 132360 -36 -0.0
.data 2116 2080 -36 -1.7
.text 920700 920492 -208 -0.0
BRD4161A+rpc (read only) 956364 956140 -224 -0.0
(read/write) 149272 149236 -36 -0.0
.data 2320 2284 -36 -1.6
.text 956356 956132 -224 -0.0
BRD4161A+rs911x (read only) 795824 795600 -224 -0.0
(read/write) 128676 128636 -40 -0.0
.data 2124 2088 -36 -1.7
.text 795816 795592 -224 -0.0
esp32 all-clusters-app c3devkit (read/write) 1482626 1482594 -32 -0.0
.dram0.bss 69344 69336 -8 -0.0
.dram0.data 14656 14624 -32 -0.2
m5stack (read/write) 484744 484704 -40 -0.0
.dram0.bss 74864 74856 -8 -0.0
.dram0.data 34176 34144 -32 -0.1
k32w light k32w061+release (read/write) 657352 657116 -236 -0.0
.bss 68708 68700 -8 -0.0
.data 2028 1992 -36 -1.8
.text 580816 580624 -192 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1196779 -24 -0.0
bss 141554 141542 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144835 1144755 -80 -0.0
text 793284 793200 -84 -0.0
p6 all-clusters-app default .bss 143344 143328 -16 -0.0
.data 2800 2776 -24 -0.9
all-clusters-minimal-app default (read/write) 2496056 2495960 -96 -0.0
.text 1454320 1454224 -96 -0.0
light-app default (read/write) 2426936 2426712 -224 -0.0
.data 2624 2592 -32 -1.2
.text 1385200 1384976 -224 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806888 806628 -260 -0.0
bss 70088 70084 -4 -0.0
text 574496 574274 -222 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a8b3a07 276b4a2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657803 657819 16 0.0
(read/write) 193012 192988 -24 -0.0
.bss 73708 73700 -8 -0.0
.data 3380 3356 -24 -0.7
.rodata 86883 86883 0 0.0
.text 570608 570624 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646303 646223 -80 -0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90159 90159 0 0.0
.text 555824 555744 -80 -0.0
lock-ftd LP_CC2652R7 (read only) 688639 688639 0 0.0
(read/write) 152280 152280 0 0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589244 589244 0 0.0
lock-mtd LP_CC2652R7 (read only) 638047 638047 0 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538764 538764 0 0.0
pump-app LP_CC2652R7 (read only) 669863 669623 -240 -0.0
(read/write) 171944 172184 240 0.1
.bss 70820 70820 0 0.0
.data 3316 3280 -36 -1.1
.rodata 87007 87007 0 0.0
.text 582372 582132 -240 -0.0
pump-controller-app LP_CC2652R7 (read only) 660611 660619 8 0.0
(read/write) 181324 181316 -8 -0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575196 575204 8 0.0
shell LP_CC2652R7 (read only) 687130 687154 24 0.0
(read/write) 159180 159148 -32 -0.0
.bss 76004 75996 -8 -0.0
.data 3384 3360 -24 -0.7
.rodata 109410 109410 0 0.0
.text 577408 577432 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 611154 610938 -216 -0.0
.app_xip_area 467844 467660 -184 -0.0
.bss 86232 86232 0 0.0
.data 764 728 -36 -4.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608238 608254 16 0.0
.app_xip_area 464784 464800 16 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614250 614266 16 0.0
.app_xip_area 471860 471876 16 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920708 920500 -208 -0.0
(read/write) 132396 132360 -36 -0.0
.bss 130280 130280 0 0.0
.data 2116 2080 -36 -1.7
.text 920700 920492 -208 -0.0
BRD4161A+rpc (read only) 956364 956140 -224 -0.0
(read/write) 149272 149236 -36 -0.0
.bss 146952 146952 0 0.0
.data 2320 2284 -36 -1.6
.text 956356 956132 -224 -0.0
BRD4161A+rs911x (read only) 795824 795600 -224 -0.0
(read/write) 128676 128636 -40 -0.0
.bss 126548 126548 0 0.0
.data 2124 2088 -36 -1.7
.text 795816 795592 -224 -0.0
lock-app BRD4161A+wf200 (read only) 963720 963720 0 0.0
(read/write) 129012 129012 0 0.0
.bss 126924 126924 0 0.0
.data 2088 2088 0 0.0
.text 963712 963712 0 0.0
window-app BRD4161A (read only) 905580 905596 16 0.0
(read/write) 132460 132460 0 0.0
.bss 130352 130352 0 0.0
.data 2108 2108 0 0.0
.text 905572 905588 16 0.0
esp32 all-clusters-app c3devkit (read only) 1010748 1010784 36 0.0
(read/write) 1482626 1482594 -32 -0.0
.dram0.bss 69344 69336 -8 -0.0
.dram0.data 14656 14624 -32 -0.2
.flash.rodata 213200 213200 0 0.0
.flash.text 1010748 1010784 36 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1065027 1065063 36 0.0
(read/write) 484744 484704 -40 -0.0
.dram0.bss 74864 74856 -8 -0.0
.dram0.data 34176 34144 -32 -0.1
.flash.rodata 243708 243708 0 0.0
.flash.text 1059643 1059679 36 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657352 657116 -236 -0.0
.bss 68708 68700 -8 -0.0
.data 2028 1992 -36 -1.8
.text 580816 580624 -192 -0.0
lock k32w061+release (read/write) 719008 719008 0 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 642068 642068 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690572 9690572 0 0.0
(read/write) 646001 646001 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 585264 585264 0 0.0
.dynamic 528 528 0 0.0
.got 13152 13152 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466396 466396 0 0.0
.text 7754036 7754036 0 0.0
thermostat-no-ble arm64 (read only) 2561996 2561996 0 0.0
(read/write) 191729 191729 0 0.0
.bss 99393 99393 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82560 82560 0 0.0
.dynamic 528 528 0 0.0
.got 5064 5064 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163004 163004 0 0.0
.text 2160704 2160704 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2435720 2435720 0 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1398364 1398364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196803 1196779 -24 -0.0
bss 141554 141542 -12 -0.0
rodata 155420 155420 0 0.0
text 820968 820980 12 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144835 1144755 -80 -0.0
bss 140794 140794 0 0.0
rodata 131948 131948 0 0.0
text 793284 793200 -84 -0.0
p6 all-clusters-app default (read/write) 2550112 2550112 0 0.0
.bss 143344 143328 -16 -0.0
.data 2800 2776 -24 -0.9
.text 1508376 1508376 0 0.0
all-clusters-minimal-app default (read/write) 2496056 2495960 -96 -0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454320 1454224 -96 -0.0
light-app default (read/write) 2426936 2426712 -224 -0.0
.bss 134688 134688 0 0.0
.data 2624 2592 -32 -1.2
.text 1385200 1384976 -224 -0.0
lock-app default (read/write) 2447352 2447352 0 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405616 1405616 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786908 786916 8 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557804 557810 6 0.0
lighting-app tlsr9518adk80d (read/write) 806888 806628 -260 -0.0
bss 70088 70084 -4 -0.0
noinit 40416 40416 0 0.0
text 574496 574274 -222 -0.0

@woody-apple
Copy link
Contributor

Fast tracking given this has had enough time for review, and comments are resolved.

@woody-apple woody-apple merged commit 22f4094 into project-chip:master Jun 16, 2022
@bzbarsky-apple
Copy link
Contributor

Fwiw, because of the confusion about this PR and #19390 there are in fact unresolved comments pending on this, they're just over on #19390. I did not realize they were targeting different branches.... @rochaferraz Can you please do a follow-up to fix?

rochaferraz added a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 17, 2022
@rochaferraz
chg: addressing a few comments left from previous pr project-chip#19390
da771b1 
project-chip#19392
@rochaferraz rochaferraz mentioned this pull request Jun 17, 2022
Merged
rochaferraz added a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 17, 2022
@rochaferraz
Level Control Server Cluster fix for level transitions (project-chip#…
c531c35 
…19392)

* fix: level control server handles its own ticks
rochaferraz added a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 17, 2022
@rochaferraz
chg: addressing a few comments left from previous pr project-chip#19390
63bf017 
project-chip#19392
rochaferraz added a commit to rochaferraz/connectedhomeip that referenced this pull request Jun 17, 2022
@rochaferraz
chg: addressing a few comments left from previous pr project-chip#19390
a73630a 
project-chip#19392
andy31415 pushed a commit that referenced this pull request Jun 18, 2022
@rochaferraz @bzbarsky-apple @restyled-commits
Addressing a comment left from previous pr #19390 (#19734)
b2c0907 
* chg: addressing a few comments left from previous pr #19390 #19392

* Update src/app/clusters/level-control/level-control.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/app/clusters/level-control/level-control.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Restyled by clang-format

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Restyled.io <commits@restyled.io>
andy31415 pushed a commit that referenced this pull request Jun 18, 2022
@rochaferraz
[interop_testing_te9] fix: level control server handles its own ticks (…
5e451a2 
…#19390)

* Level Control Server Cluster fix for level transitions (#19392)

* fix: level control server handles its own ticks

* chg: addressing a few comments left from previous pr #19390 #19392
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Sep 9, 2022
@rochaferraz @danielsilabs
fix: level control server handles its own ticks (project-chip#19390)
a3375a6 
* Level Control Server Cluster fix for level transitions (project-chip#19392)

* fix: level control server handles its own ticks

* chg: addressing a few comments left from previous pr project-chip#19390 project-chip#19392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@andy31415 andy31415 andy31415 left review comments

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app config documentation Improvements or additions to documentation examples fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rochaferraz @bzbarsky-apple @woody-apple @andy31415 @mrjerryjohns @restyled-commits