-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TestEventTrigger delegate for OTA query #19716
Merged
tcarmelveilleux
merged 7 commits into
project-chip:master
from
Damian-Nordic:test-event-trigger
Jun 22, 2022
Merged
Implement TestEventTrigger delegate for OTA query #19716
tcarmelveilleux
merged 7 commits into
project-chip:master
from
Damian-Nordic:test-event-trigger
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to use TestEventTrigger command of GeneralDiagnostics cluster to trigger OTA query on demand. The requested trigger must be 0x0100'0000'0000'01<fi>, where <fi> is fabric index of the OTA provider to query, or 00 if the OTA provider is supposed to be selected automatically. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Initialize OTATestEventTriggerDelegate in nRF Connect and Linux examples. nRF Connect examples use a constant enable key "001122(..)ff" while Linux apps allow for configuring the key at runtime using "--enable-key" argument.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
June 17, 2022 13:12
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
turon and
vijs
June 17, 2022 13:12
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
June 17, 2022 13:12
tcarmelveilleux
approved these changes
Jun 17, 2022
PR #19716: Size comparison from 5ea0ca6 to 1ff5e9e Increases (14 builds for cc13x2_26x2, cyw30739, efr32, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, mbed, p6, telink)
|
PR #19716: Size comparison from 5ea0ca6 to 542288c Increases (9 builds for cc13x2_26x2, cyw30739, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (19 builds for cc13x2_26x2, cyw30739, k32w, mbed, p6, telink)
|
PR #19716: Size comparison from 5ea0ca6 to 0349fde Increases above 0.2%:
Increases (23 builds for cc13x2_26x2, cyw30739, efr32, linux, nrfconnect)
Decreases (4 builds for cc13x2_26x2, k32w)
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #19623, we need some sort of manual trigger of the OTA query so that certification tests don't need to wait up to 24 hours for the next query.
@tcarmelveilleux proposed that we use
TestEventTrigger
command ofGeneralDiagnostics
cluster for this purpose.Change overview
Implement TestEventTriggerDelegate that handles triggers with values:
0x0100'0000'0000'01<fi>
, where<fi>
is fabric index of the OTA provider to query, or00
if the OTA provider is supposed to be selected automatically.Initialize the delegate in nRF Connect examples using a constant enable key.
Initialize the delegate in Linux examples using an enable key configured at runtime using
--enable-key
argument.Fixes #19623
Testing
Did smoke tests of the functionality on both nRF Connect lighting-app and Linux OTA-requestor app.