Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS TvCasting app: Send Content Launch By URL request and Open commissioning window #19779

Merged
merged 2 commits into from
Jun 22, 2022
Merged

iOS TvCasting app: Send Content Launch By URL request and Open commissioning window #19779

merged 2 commits into from
Jun 22, 2022

Conversation

sharadb-amazon
Copy link
Contributor

Problem

iOS TvCasting app does not have implementation for opening commissioning window or sending a content launch request.

Change overview

  1. Added ContentLauncherView and ViewModel.
  2. Added CastingServerBridge implementations to openBasicCommissioningWindow and send ContentLaunch by URL requests
  3. Other fixes: Updated examples/tv-casting-app/tv-casting-common/include/CHIPProjectAppConfig.h with a flag to fix a compilation issue (no member named "AddRequestDataNoTimedCheck," "SendSubscribeRequestWithoutValidation.") Also, update to pbxproj file to allow debug build on a arm64 M1 mac.

Testing

Built and run on iOS simulator that displays the following view for Content Launcher (End-to-end test for this is pending)

@github-actions
Copy link

github-actions bot commented Jun 20, 2022 •
edited
Loading

PR #19779: Size comparison from 48606c6 to f368f76

Increases (2 builds for cc13x2_26x2, esp32)
platform target config section 48606c6 f368f76 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 157364 157372 8 0.0
esp32 all-clusters-app c3devkit (read only) 1012958 1012960 2 0.0
.flash.text 1012958 1012960 2 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 48606c6 f368f76 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 688994 688986 -8 -0.0
.text 579024 579016 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 610122 610114 -8 -0.0
.app_xip_area 466612 466604 -8 -0.0
telink light-switch-app tlsr9518adk80d text 559678 559676 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 808800 808792 -8 -0.0
text 576138 576136 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 48606c6 f368f76 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659567 0 0.0
(read/write) 191296 191296 0 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87087 87087 0 0.0
.text 572168 572168 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648063 648063 0 0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90407 0 0.0
.text 557336 557336 0 0.0
lock-ftd LP_CC2652R7 (read only) 690531 690531 0 0.0
(read/write) 150444 150444 0 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 99163 0 0.0
.text 590884 590884 0 0.0
lock-mtd LP_CC2652R7 (read only) 639931 639931 0 0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 99043 0 0.0
.text 540396 540396 0 0.0
pump-app LP_CC2652R7 (read only) 671467 671467 0 0.0
(read/write) 170396 170396 0 0.0
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 87259 0 0.0
.text 583724 583724 0 0.0
pump-controller-app LP_CC2652R7 (read only) 657359 657359 0 0.0
(read/write) 184616 184616 0 0.0
.bss 70988 70988 0 0.0
.data 3276 3276 0 0.0
.rodata 83103 83103 0 0.0
.text 573776 573776 0 0.0
shell LP_CC2652R7 (read only) 688994 688986 -8 -0.0
(read/write) 157364 157372 8 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109658 0 0.0
.text 579024 579016 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612766 0 0.0
.app_xip_area 469432 469432 0 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610122 610114 -8 -0.0
.app_xip_area 466612 466604 -8 -0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616130 0 0.0
.app_xip_area 473684 473684 0 0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 924060 924060 0 0.0
(read/write) 132416 132416 0 0.0
.bss 130336 130336 0 0.0
.data 2080 2080 0 0.0
.text 924052 924052 0 0.0
BRD4161A+rpc (read only) 959748 959748 0 0.0
(read/write) 149292 149292 0 0.0
.bss 147008 147008 0 0.0
.data 2284 2284 0 0.0
.text 959740 959740 0 0.0
BRD4161A+rs911x (read only) 799456 799456 0 0.0
(read/write) 128692 128692 0 0.0
.bss 126604 126604 0 0.0
.data 2088 2088 0 0.0
.text 799448 799448 0 0.0
lock-app BRD4161A+wf200 (read only) 965876 965876 0 0.0
(read/write) 129068 129068 0 0.0
.bss 126980 126980 0 0.0
.data 2088 2088 0 0.0
.text 965868 965868 0 0.0
window-app BRD4161A (read only) 909204 909204 0 0.0
(read/write) 132516 132516 0 0.0
.bss 130408 130408 0 0.0
.data 2108 2108 0 0.0
.text 909196 909196 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012958 1012960 2 0.0
(read/write) 1482898 1482898 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213440 213440 0 0.0
.flash.text 1012958 1012960 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1067459 1067459 0 0.0
(read/write) 485016 485016 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243964 243964 0 0.0
.flash.text 1062075 1062075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658940 658940 0 0.0
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582392 582392 0 0.0
lock k32w061+release (read/write) 720916 720916 0 0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643920 643920 0 0.0
linux all-clusters-app debug (read only) 2931385 2931385 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260029 260029 0 0.0
.text 2494914 2494914 0 0.0
all-clusters-minimal-app debug (read only) 2785097 2785097 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261565 261565 0 0.0
.text 2349266 2349266 0 0.0
bridge-app debug+rpc (read only) 2287665 2287665 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194848 194848 0 0.0
.text 1931730 1931730 0 0.0
chip-tool debug (read only) 10141773 10141773 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509301 509301 0 0.0
.text 8226741 8226741 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9882612 9882612 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472324 472324 0 0.0
.text 7873860 7873860 0 0.0
lighting-app debug+rpc (read only) 2520433 2520433 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210632 210632 0 0.0
.text 2140098 2140098 0 0.0
lock-app debug (read only) 2459113 2459113 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 224328 224328 0 0.0
.text 2070482 2070482 0 0.0
ota-provider-app debug (read only) 2296993 2296993 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 200504 200504 0 0.0
.text 1934338 1934338 0 0.0
ota-requestor-app debug (read only) 2412705 2412705 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 204192 204192 0 0.0
.text 2038130 2038130 0 0.0
shell debug (read only) 2604865 2604865 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230290 230290 0 0.0
.text 2214818 2214818 0 0.0
thermostat-no-ble arm64 (read only) 2571580 2571580 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163340 163340 0 0.0
.text 2169120 2169120 0 0.0
tv-app debug (read only) 3068849 3068849 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 246176 246176 0 0.0
.text 2635810 2635810 0 0.0
tv-casting-app debug (read only) 5534513 5534513 0 0.0
(read/write) 195664 195664 0 0.0
.bss 84424 84424 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340137 340137 0 0.0
.text 4918146 4918146 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438104 2438104 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400748 1400748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198747 0 0.0
bss 141598 141598 0 0.0
rodata 155676 155676 0 0.0
text 822552 822552 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146703 0 0.0
bss 140850 140850 0 0.0
rodata 132200 132200 0 0.0
text 794772 794772 0 0.0
p6 all-clusters-app default (read/write) 2553928 2553928 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1512192 1512192 0 0.0
all-clusters-minimal-app default (read/write) 2499776 2499776 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1458040 1458040 0 0.0
light-app default (read/write) 2430520 2430520 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388784 1388784 0 0.0
lock-app default (read/write) 2451216 2451216 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409480 1409480 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789088 789088 0 0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559678 559676 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 808800 808792 -8 -0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576138 576136 -2 -0.0

@github-actions
Copy link

github-actions bot commented Jun 20, 2022 •
edited
Loading

PR #19779: Size comparison from 48606c6 to 944d926

Decreases (1 build for telink)
platform target config section 48606c6 944d926 change % change
telink light-switch-app tlsr9518adk80d text 559678 559676 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 48606c6 944d926 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 659567 659567 0 0.0
(read/write) 191296 191296 0 0.0
.bss 73756 73756 0 0.0
.data 3356 3356 0 0.0
.rodata 87087 87087 0 0.0
.text 572168 572168 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648063 648063 0 0.0
(read/write) 157316 157316 0 0.0
.bss 73044 73044 0 0.0
.data 3356 3356 0 0.0
.rodata 90407 90407 0 0.0
.text 557336 557336 0 0.0
lock-ftd LP_CC2652R7 (read only) 690531 690531 0 0.0
(read/write) 150444 150444 0 0.0
.bss 70756 70756 0 0.0
.data 3280 3280 0 0.0
.rodata 99163 99163 0 0.0
.text 590884 590884 0 0.0
lock-mtd LP_CC2652R7 (read only) 639931 639931 0 0.0
(read/write) 143888 143888 0 0.0
.bss 66492 66492 0 0.0
.data 3280 3280 0 0.0
.rodata 99043 99043 0 0.0
.text 540396 540396 0 0.0
pump-app LP_CC2652R7 (read only) 671467 671467 0 0.0
(read/write) 170396 170396 0 0.0
.bss 70876 70876 0 0.0
.data 3280 3280 0 0.0
.rodata 87259 87259 0 0.0
.text 583724 583724 0 0.0
pump-controller-app LP_CC2652R7 (read only) 657359 657359 0 0.0
(read/write) 184616 184616 0 0.0
.bss 70988 70988 0 0.0
.data 3276 3276 0 0.0
.rodata 83103 83103 0 0.0
.text 573776 573776 0 0.0
shell LP_CC2652R7 (read only) 688994 688994 0 0.0
(read/write) 157364 157364 0 0.0
.bss 76052 76052 0 0.0
.data 3360 3360 0 0.0
.rodata 109658 109658 0 0.0
.text 579024 579024 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 612766 612766 0 0.0
.app_xip_area 469432 469432 0 0.0
.bss 86288 86288 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610122 610122 0 0.0
.app_xip_area 466612 466612 0 0.0
.bss 86464 86464 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 616130 616130 0 0.0
.app_xip_area 473684 473684 0 0.0
.bss 85456 85456 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 924060 924060 0 0.0
(read/write) 132416 132416 0 0.0
.bss 130336 130336 0 0.0
.data 2080 2080 0 0.0
.text 924052 924052 0 0.0
BRD4161A+rpc (read only) 959748 959748 0 0.0
(read/write) 149292 149292 0 0.0
.bss 147008 147008 0 0.0
.data 2284 2284 0 0.0
.text 959740 959740 0 0.0
BRD4161A+rs911x (read only) 799456 799456 0 0.0
(read/write) 128692 128692 0 0.0
.bss 126604 126604 0 0.0
.data 2088 2088 0 0.0
.text 799448 799448 0 0.0
lock-app BRD4161A+wf200 (read only) 965876 965876 0 0.0
(read/write) 129068 129068 0 0.0
.bss 126980 126980 0 0.0
.data 2088 2088 0 0.0
.text 965868 965868 0 0.0
window-app BRD4161A (read only) 909204 909204 0 0.0
(read/write) 132516 132516 0 0.0
.bss 130408 130408 0 0.0
.data 2108 2108 0 0.0
.text 909196 909196 0 0.0
esp32 all-clusters-app c3devkit (read only) 1012958 1012958 0 0.0
(read/write) 1482898 1482898 0 0.0
.dram0.bss 69392 69392 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 213440 213440 0 0.0
.flash.text 1012958 1012958 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1067459 1067459 0 0.0
(read/write) 485016 485016 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 243964 243964 0 0.0
.flash.text 1062075 1062075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658940 658940 0 0.0
.bss 68756 68756 0 0.0
.data 1992 1992 0 0.0
.text 582392 582392 0 0.0
lock k32w061+release (read/write) 720916 720916 0 0.0
.bss 69196 69196 0 0.0
.data 2000 2000 0 0.0
.text 643920 643920 0 0.0
linux all-clusters-app debug (read only) 2931385 2931385 0 0.0
(read/write) 188656 188656 0 0.0
.bss 95744 95744 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 260029 260029 0 0.0
.text 2494914 2494914 0 0.0
all-clusters-minimal-app debug (read only) 2785097 2785097 0 0.0
(read/write) 180560 180560 0 0.0
.bss 95072 95072 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261565 261565 0 0.0
.text 2349266 2349266 0 0.0
bridge-app debug+rpc (read only) 2287665 2287665 0 0.0
(read/write) 159424 159424 0 0.0
.bss 83136 83136 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 194848 194848 0 0.0
.text 1931730 1931730 0 0.0
chip-tool debug (read only) 10141773 10141773 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509301 509301 0 0.0
.text 8226741 8226741 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9882612 9882612 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472324 472324 0 0.0
.text 7873860 7873860 0 0.0
lighting-app debug+rpc (read only) 2520433 2520433 0 0.0
(read/write) 163448 163448 0 0.0
.bss 83616 83616 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 210632 210632 0 0.0
.text 2140098 2140098 0 0.0
lock-app debug (read only) 2459113 2459113 0 0.0
(read/write) 158096 158096 0 0.0
.bss 82016 82016 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 224328 224328 0 0.0
.text 2070482 2070482 0 0.0
ota-provider-app debug (read only) 2296993 2296993 0 0.0
(read/write) 152232 152232 0 0.0
.bss 81696 81696 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 200504 200504 0 0.0
.text 1934338 1934338 0 0.0
ota-requestor-app debug (read only) 2412705 2412705 0 0.0
(read/write) 158976 158976 0 0.0
.bss 84000 84000 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 204192 204192 0 0.0
.text 2038130 2038130 0 0.0
shell debug (read only) 2604865 2604865 0 0.0
(read/write) 219288 219288 0 0.0
.bss 134504 134504 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 230290 230290 0 0.0
.text 2214818 2214818 0 0.0
thermostat-no-ble arm64 (read only) 2571580 2571580 0 0.0
(read/write) 192193 192193 0 0.0
.bss 99489 99489 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 163340 163340 0 0.0
.text 2169120 2169120 0 0.0
tv-app debug (read only) 3068849 3068849 0 0.0
(read/write) 289352 289352 0 0.0
.bss 199240 199240 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 246176 246176 0 0.0
.text 2635810 2635810 0 0.0
tv-casting-app debug (read only) 5534513 5534513 0 0.0
(read/write) 195664 195664 0 0.0
.bss 84424 84424 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340137 340137 0 0.0
.text 4918146 4918146 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438104 2438104 0 0.0
.bss 208204 208204 0 0.0
.data 5864 5864 0 0.0
.text 1400748 1400748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198747 1198747 0 0.0
bss 141598 141598 0 0.0
rodata 155676 155676 0 0.0
text 822552 822552 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1146703 1146703 0 0.0
bss 140850 140850 0 0.0
rodata 132200 132200 0 0.0
text 794772 794772 0 0.0
p6 all-clusters-app default (read/write) 2553928 2553928 0 0.0
.bss 143384 143384 0 0.0
.data 2776 2776 0 0.0
.text 1512192 1512192 0 0.0
all-clusters-minimal-app default (read/write) 2499776 2499776 0 0.0
.bss 142664 142664 0 0.0
.data 2776 2776 0 0.0
.text 1458040 1458040 0 0.0
light-app default (read/write) 2430520 2430520 0 0.0
.bss 134744 134744 0 0.0
.data 2592 2592 0 0.0
.text 1388784 1388784 0 0.0
lock-app default (read/write) 2451216 2451216 0 0.0
.bss 134568 134568 0 0.0
.data 2600 2600 0 0.0
.text 1409480 1409480 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789088 789088 0 0.0
bss 69892 69892 0 0.0
noinit 40416 40416 0 0.0
text 559678 559676 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 808800 808800 0 0.0
bss 70140 70140 0 0.0
noinit 40416 40416 0 0.0
text 576138 576138 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19779: Size comparison from a1f5426 to 329a606

Increases (3 builds for nrfconnect, telink)
platform target config section a1f5426 329a606f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201095 1201111 16 0.0
text 823124 823128 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 791712 791720 8 0.0
text 560392 560394 2 0.0
lighting-app tlsr9518adk80d text 576850 576854 4 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section a1f5426 329a606f change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 640951 640943 -8 -0.0
.text 541028 541020 -8 -0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a1f5426 329a606f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660127 0 0.0
(read/write) 191488 191488 0 0.0
.bss 74508 74508 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572576 572576 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 158068 158068 0 0.0
.bss 73796 73796 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691543 691543 0 0.0
(read/write) 150184 150184 0 0.0
.bss 71508 71508 0 0.0
.data 3280 3280 0 0.0
.rodata 99551 99551 0 0.0
.text 591508 591508 0 0.0
lock-mtd LP_CC2652R7 (read only) 640951 640943 -8 -0.0
(read/write) 144640 144640 0 0.0
.bss 67244 67244 0 0.0
.data 3280 3280 0 0.0
.rodata 99431 99431 0 0.0
.text 541028 541020 -8 -0.0
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169816 169816 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658683 658683 0 0.0
(read/write) 184044 184044 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574456 574456 0 0.0
shell LP_CC2652R7 (read only) 689870 689870 0 0.0
(read/write) 157240 157240 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110022 0 0.0
.text 579536 579536 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 614518 614518 0 0.0
.app_xip_area 469928 469928 0 0.0
.bss 87544 87544 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 611898 611898 0 0.0
.app_xip_area 467132 467132 0 0.0
.bss 87720 87720 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 618414 618414 0 0.0
.app_xip_area 474712 474712 0 0.0
.bss 86712 86712 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925520 925520 0 0.0
(read/write) 133664 133664 0 0.0
.bss 131584 131584 0 0.0
.data 2080 2080 0 0.0
.text 925512 925512 0 0.0
BRD4161A+rpc (read only) 961240 961240 0 0.0
(read/write) 150544 150544 0 0.0
.bss 148256 148256 0 0.0
.data 2284 2284 0 0.0
.text 961232 961232 0 0.0
BRD4161A+rs911x (read only) 800868 800868 0 0.0
(read/write) 129940 129940 0 0.0
.bss 127852 127852 0 0.0
.data 2088 2088 0 0.0
.text 800860 800860 0 0.0
lock-app BRD4161A+wf200 (read only) 967176 967176 0 0.0
(read/write) 130316 130316 0 0.0
.bss 128228 128228 0 0.0
.data 2088 2088 0 0.0
.text 967168 967168 0 0.0
window-app BRD4161A (read only) 910680 910680 0 0.0
(read/write) 133768 133768 0 0.0
.bss 131656 131656 0 0.0
.data 2108 2108 0 0.0
.text 910672 910672 0 0.0
k32w light k32w061+release (read/write) 660644 660644 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583096 583096 0 0.0
lock k32w061+release (read/write) 723196 723196 0 0.0
.bss 70196 70196 0 0.0
.data 2000 2000 0 0.0
.text 645200 645200 0 0.0
linux all-clusters-app debug (read only) 2936105 2936105 0 0.0
(read/write) 177072 177072 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261149 261149 0 0.0
.text 2498514 2498514 0 0.0
all-clusters-minimal-app debug (read only) 2789817 2789817 0 0.0
(read/write) 168976 168976 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262685 262685 0 0.0
.text 2352866 2352866 0 0.0
bridge-app debug+rpc (read only) 2292513 2292513 0 0.0
(read/write) 147840 147840 0 0.0
.bss 71552 71552 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 195936 195936 0 0.0
.text 1935394 1935394 0 0.0
chip-tool debug (read only) 10147645 10147645 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510389 510389 0 0.0
.text 8231525 8231525 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9887356 9887356 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473180 0 0.0
.text 7877748 7877748 0 0.0
lighting-app debug+rpc (read only) 2525209 2525209 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72032 72032 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211688 211688 0 0.0
.text 2143730 2143730 0 0.0
lock-app debug (read only) 2463905 2463905 0 0.0
(read/write) 146576 146576 0 0.0
.bss 70432 70432 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68600 68600 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225384 225384 0 0.0
.text 2074130 2074130 0 0.0
ota-provider-app debug (read only) 2301857 2301857 0 0.0
(read/write) 140680 140680 0 0.0
.bss 70112 70112 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201624 201624 0 0.0
.text 1937986 1937986 0 0.0
ota-requestor-app debug (read only) 2417665 2417665 0 0.0
(read/write) 147392 147392 0 0.0
.bss 72416 72416 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205280 205280 0 0.0
.text 2041906 2041906 0 0.0
shell debug (read only) 2609921 2609921 0 0.0
(read/write) 196088 196088 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231378 231378 0 0.0
.text 2218786 2218786 0 0.0
thermostat-no-ble arm64 (read only) 2575988 2575988 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172720 0 0.0
tv-app debug (read only) 3073777 3073777 0 0.0
(read/write) 277768 277768 0 0.0
.bss 187656 187656 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247296 247296 0 0.0
.text 2639618 2639618 0 0.0
tv-casting-app debug (read only) 5539297 5539297 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72840 72840 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341257 341257 0 0.0
.text 4921810 4921810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439136 2439136 0 0.0
.bss 212188 212188 0 0.0
.data 5864 5864 0 0.0
.text 1401780 1401780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201095 1201111 16 0.0
bss 142846 142846 0 0.0
rodata 156312 156312 0 0.0
text 823124 823128 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149199 1149199 0 0.0
bss 142098 142098 0 0.0
rodata 132840 132840 0 0.0
text 795348 795348 0 0.0
p6 all-clusters-app default (read/write) 2555440 2555440 0 0.0
.bss 147368 147368 0 0.0
.data 2776 2776 0 0.0
.text 1513704 1513704 0 0.0
all-clusters-minimal-app default (read/write) 2501288 2501288 0 0.0
.bss 146648 146648 0 0.0
.data 2776 2776 0 0.0
.text 1459552 1459552 0 0.0
light-app default (read/write) 2432048 2432048 0 0.0
.bss 138728 138728 0 0.0
.data 2592 2592 0 0.0
.text 1390312 1390312 0 0.0
lock-app default (read/write) 2452760 2452760 0 0.0
.bss 138552 138552 0 0.0
.data 2600 2600 0 0.0
.text 1411024 1411024 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 791712 791720 8 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 560392 560394 2 0.0
lighting-app tlsr9518adk80d (read/write) 811424 811424 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 576850 576854 4 0.0

@bzbarsky-apple bzbarsky-apple merged commit d635589 into project-chip:master Jun 22, 2022
@sharadb-amazon sharadb-amazon deleted the ios-20220616 branch June 22, 2022 16:21
@sharadb-amazon sharadb-amazon mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharadb-amazon @woody-apple @chrisdecenzo @bzbarsky-apple