Truncate the branch info of the software version string while the total length greater equal to 64 bytes. #19788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
MtTsai
force-pushed
the
swVerStringTruncated
branch
from
6db74a3 to
bec37c9
Compare
|
PR #19788: Size comparison from 2ac3ee7 to bec37c9 Increases (2 builds for cc13x2_26x2, telink)
Decreases (1 build for nrfconnect)
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 21, 2022
mspang
reviewed
Jun 21, 2022
mspang
reviewed
Jun 21, 2022
msandstedt
reviewed
Jun 21, 2022
woody-apple
approved these changes
Jun 21, 2022
MtTsai
force-pushed
the
swVerStringTruncated
branch
2 times, most recently
from
06b105c to
3fba1e8
Compare
|
PR #19788: Size comparison from d635589 to 3fba1e8 Increases (3 builds for cyw30739, telink)
Decreases (1 build for esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…al length greater equal to 64 bytes. Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'.
MtTsai
force-pushed
the
swVerStringTruncated
branch
from
3fba1e8 to
89804c8
Compare
|
PR #19788: Size comparison from d1a4bb7 to 89804c8 Increases (2 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jun 25, 2022
…al length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jun 25, 2022
…al length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'.
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jun 25, 2022
…al length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'.
andy31415
pushed a commit
that referenced
this pull request
Jun 27, 2022
…19979) * Pigweed: Update to 67bc89cdda8c (#19560) * Fix esp32 wifi and add RPC support on linux (#19260) * Chef - Extended Pigweed RPC support (#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <rgoliver@google.com> Reviewed-by: Kevin Cheung <kkmcheun@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <spang@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <rgoliver@google.com> Reviewed-by: Kevin Cheung <kkmcheun@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <spang@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <rochaferraz@google.com> Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710) * Chef - Add 13 sample apps (#19663) * Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps * Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (#19710)" (#19786) This reverts commit 8da6fc8. * Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'. * Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <bozowski@google.com> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <bozowski@google.com> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <bozowski@google.com> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <bozowski@google.com> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle * Chef - Fix broken esp32 RPC build caused by #18621 (#19876) * Chef - Fix broken esp32 RPC build caused by #18621 * Chef - Fix esp32 RPC build issue caused by pigweed update * Make Scenes name support dependent on FeatureMap attribute (#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI * Rebuild Zap generated files * Fix CI for ipv6only/esp32 example build * Fix errors regarding ownership of repo. (Taken from #18302) * Bump chef.yaml platform containers to 0.5.75 Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Douglas Rocha Ferraz <rochaferraz@google.com> Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: MtTsai <7930801+MtTsai@users.noreply.github.com> Co-authored-by: Michael Spang <mcspang@gmail.com> Co-authored-by: Austin Bozowski <bozowski@google.com> Co-authored-by: Jean-Francois Penven <67962328+jepenven-silabs@users.noreply.github.com>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Sep 9, 2022
…roject-chip#19979) * Pigweed: Update to 67bc89cdda8c (project-chip#19560) * Fix esp32 wifi and add RPC support on linux (project-chip#19260) * Chef - Extended Pigweed RPC support (project-chip#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <rgoliver@google.com> Reviewed-by: Kevin Cheung <kkmcheun@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <spang@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (project-chip#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <rgoliver@google.com> Reviewed-by: Kevin Cheung <kkmcheun@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <spang@google.com> Reviewed-by: Jerry Lee <jerrymhlee@google.com> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <rochaferraz@google.com> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (project-chip#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <rochaferraz@google.com> Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> * Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710) * Chef - Add 13 sample apps (project-chip#19663) * Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps * Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8. * Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'. * Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (project-chip#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <bozowski@google.com> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <bozowski@google.com> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <bozowski@google.com> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <bozowski@google.com> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <bozowski@google.com> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle * Chef - Fix broken esp32 RPC build caused by project-chip#18621 (project-chip#19876) * Chef - Fix broken esp32 RPC build caused by project-chip#18621 * Chef - Fix esp32 RPC build issue caused by pigweed update * Make Scenes name support dependent on FeatureMap attribute (project-chip#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI * Rebuild Zap generated files * Fix CI for ipv6only/esp32 example build * Fix errors regarding ownership of repo. (Taken from project-chip#18302) * Bump chef.yaml platform containers to 0.5.75 Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Douglas Rocha Ferraz <rochaferraz@google.com> Co-authored-by: Sebastian Mauer <mauimauer@google.com> Co-authored-by: MT Tsai <mttsai@google.com> Co-authored-by: vinitg1 <62729931+vinitg1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: MtTsai <7930801+MtTsai@users.noreply.github.com> Co-authored-by: Michael Spang <mcspang@gmail.com> Co-authored-by: Austin Bozowski <bozowski@google.com> Co-authored-by: Jean-Francois Penven <67962328+jepenven-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Therefore, let's put the truncated branch info so that it could fit in the 64 bytes limitation(and keep commit_id be a completed 40 bytes sha1 value).
And we also create a new option for this filling version behavior to make his build nondeterminism stamp not by default.
Testing
Testing on linux sample app of chef build, the build command is as below.
$ cd examples/chef.py
$ ./chef.py --bootstrap_zap
$ ./chef.py -zbra -t linux -d rootnode_dimmablelight_gY80DaqEUL
And use rpc console to getDeviceInfo to check the value of software version string.