[nrfconnect] Include GenericSwitch in light-switch example #19848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
markus-becker-tridonic-com
force-pushed
the
upstream-nrf-generic-switch
branch
from
bf762cd to
66a6a45
Compare
* Directly calling GenericSwitchInitialPress/GenericSwitchReleasePress without Timer * Rename newPosition/previousPosition
* Remove Switch cluster on EP0 * Disabled Groups, Scenes, Binding on EP2 * Named EP2
Thanks @greg-fer. Co-authored-by: Grzegorz Ferenc <41291385+greg-fer@users.noreply.github.com>
markus-becker-tridonic-com
force-pushed
the
upstream-nrf-generic-switch
branch
from
66a6a45 to
cd1b9e1
Compare
|
PR #19848: Size comparison from 29451fb to e039af7 Increases (5 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (4 builds for cc13x2_26x2, nrfconnect)
Full report (44 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
greg-fer
approved these changes
Jun 23, 2022
|
Thanks for applying the edits, @markus-becker-tridonic-com ! |
|
PR #19848: Size comparison from 29451fb to c4b4ca0 Increases above 0.2%:
Increases (31 builds for cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, p6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (44 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
pushed a commit
that referenced
this pull request
Jun 23, 2022
…nes (#19881) GenericSwitch only requires ``` ClusterName Client/Server Quality Conformance Identify Server M Switch Server M FixedLabel Server desc ``` according to spec. As requested in #19848 (comment).
bzbarsky-apple
approved these changes
Jun 23, 2022
|
Proposals how to fix the misspell error? It's for keepSubscriptions in which is in a code section. Add to wordlist or has the code section be marked somehow? |
andy31415
reviewed
Jun 23, 2022
|
PR #19848: Size comparison from 2d0c529 to a5c6bb1 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for k32w)
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
It probably is missing backticks, so it thingks it is words. In the quote I seem to see a missing starting backtick |
andy31415
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In matter there are 2 types of light switch device types:
Up to now only the first type was shown in the light-switch example.
Change overview
This PR adds GenericSwitch for the nrfconnect light-switch sample.
The GenericSwitch has been added on EP 2 and uses button 3.
The code implements a momentary switch with features MS and MSR.
Testing
Tested using chip-tool and DK:
Subscribe to the initial-press and short-release