Chef - Continue instead of breaking on build error #19988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #19988: Size comparison from c38e915 to e8f3163 Increases (2 builds for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
Jun 27, 2022
andy31415
reviewed
Jun 27, 2022
I clarified in the description that this change is for Chef CD only. It seems prudent here to get as many viable builds as possible despite having a single platform fail. Major issues should be caught in CI, so this is likely catching issues related to environment/container differences or incompatible interactions between specific sample app types and a specific platform. In either case, it seems reasonable to try to get as many builds as we can. Do you disagree? |
I do not understand what "is prudent" here means. It seems that we still want to have build outputs even if some fail. This is supported by other tools, but always as command line arguments (e.g. make has if you implement such a support, please make it controlled by a command line flag and it should not be the default. We want CI to generally fail on any error and we should not consider compile failure to be something normal. |
|
Testing is needed, at a minimum compile with and without the change locally to validate functionality. Eventually introduce an error in the build logic to see if things work as expected. |
|
I will update this PR to include a flag similar to the behavior of cmake |
woody-apple
approved these changes
Jun 28, 2022
andy31415
reviewed
Jun 28, 2022
Updated. Everything should be in order now. |
|
PR #19988: Size comparison from 14aa3c2 to bfd2a70 Increases (1 build for telink)
Decreases (1 build for telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jun 29, 2022
cpagravel
added a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Jul 2, 2022
andy31415
pushed a commit
that referenced
this pull request
Jul 3, 2022
…atform building. (#20248) * Put software version string as <branch>:<commit_id> on esp32 while doing automation testing (#19943) * RPC: Support pw logging for linux rpc examples (#20057) Add a config option CHIP_USE_PW_LOGGING, which uses pw log output instead of printf on linux. This allows the logs to correctly get HDLC encoded and be piped over the socket for linux RPC builds. * Chef - Continue instead of breaking on build error (#19988) * Move chef .matter files back to /chef/devices (#20142) * Remove matter files from root zzz * Move .matter regen for chef * Update bundle for changed .matter location * Chef - Support cross platform Linux builds for arm64 (#20232) * Chef - Use array for passing linux args to args.gni * Chef - Add support for cross compiling linux on arm64 Co-authored-by: MtTsai <7930801+MtTsai@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Austin Bozowski <bozowski@google.com>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Sep 9, 2022
…atform building. (project-chip#20248) * Put software version string as <branch>:<commit_id> on esp32 while doing automation testing (project-chip#19943) * RPC: Support pw logging for linux rpc examples (project-chip#20057) Add a config option CHIP_USE_PW_LOGGING, which uses pw log output instead of printf on linux. This allows the logs to correctly get HDLC encoded and be piped over the socket for linux RPC builds. * Chef - Continue instead of breaking on build error (project-chip#19988) * Move chef .matter files back to /chef/devices (project-chip#20142) * Remove matter files from root zzz * Move .matter regen for chef * Update bundle for changed .matter location * Chef - Support cross platform Linux builds for arm64 (project-chip#20232) * Chef - Use array for passing linux args to args.gni * Chef - Add support for cross compiling linux on arm64 Co-authored-by: MtTsai <7930801+MtTsai@users.noreply.github.com> Co-authored-by: rgoliver <rgoliver@google.com> Co-authored-by: Austin Bozowski <bozowski@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
Tested locally by building with broken platform code with and without the
--keep_goingflag.