-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to do our BLE callbacks on the right dispatch queue. #20235
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-darwin-ble-threading
Jul 2, 2022
Merged
Make sure to do our BLE callbacks on the right dispatch queue. #20235
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-darwin-ble-threading
Jul 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were calling back into the Matter core while running on the BLE queue. project-chip#20230
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
July 1, 2022 20:56
pullapprove
bot
requested review from
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
July 1, 2022 20:56
pullapprove
bot
added
review - pending
darwin
platform
and removed
platform
darwin
labels
Jul 1, 2022
jtung-apple
approved these changes
Jul 1, 2022
carol-apple
approved these changes
Jul 1, 2022
fast-tracking platform-specific change. |
PR #20235: Size comparison from 6fd06ea to 181c742 Increases (2 builds for esp32, nrfconnect)
Decreases (2 builds for cyw30739, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling back into the Matter core while running on the BLE queue.
#20230
Problem
See above.
Change overview
Dispatch thing to the right queue.
Testing
Ensured that iOS CHIPTool no longer hits the threading asserts when trying to commision an m5stack.