-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFR32 Device Attestation Credentials provider bugfix. #20371
Merged
woody-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:efr32_dac_bugfix
Jul 6, 2022
Merged
EFR32 Device Attestation Credentials provider bugfix. #20371
woody-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:efr32_dac_bugfix
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
July 6, 2022 15:51
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
July 6, 2022 15:51
rcasallas-silabs
force-pushed
the
efr32_dac_bugfix
branch
from
July 6, 2022 15:56
c458bb8
to
fb5a32d
Compare
woody-apple
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes
PR #20371: Size comparison from 126f6b2 to fb5a32d Increases (2 builds for efr32, esp32)
Decreases (3 builds for cyw30739, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Jul 6, 2022
@woody-apple Is this something that could be cherry-picked in the SVE branch? |
tcarmelveilleux
approved these changes
Jul 6, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SignWithDeviceAttestationKey now receives the full message, instead of the message hash. The signature calculation therefore has to be modified accordingly.
Change overview
Signature calculation changed from
psa_sign_hash
topsa_sign_message
.Testing
Tested on EFR32. This changes only had effect on EFR32, and only if the flag
chip_build_platform_attestation_credentials_provider
is set to true.