Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACL Check on IM event per path basis #21116

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Fix ACL Check on IM event per path basis #21116

merged 4 commits into from
Jul 29, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Jul 22, 2022 •
edited
Loading

Problem

#20787

Change overview

we loops over paths, puts in errors for the concrete event paths that are not allowed. For ACL denied concrete ones from wildcard, we just silently do nothing

Testing

compilation and enable acl event tests where

  1. Read events with concrete event path, reject that event path, we see event status with UnsupportedAccess in report.
  2. Read events with wildcard path, reject that event path, we silently skip those ACL denied paths.

@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21116: Size comparison from 75f1ddf to 58c9d0f

Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 75f1ddf 58c9d0f change % change
bl602 lighting-app bl602 (read/write) 1381354 1381498 144 0.0
.text 1051424 1051572 148 0.0
bl602+rpc (read/write) 1426762 1426906 144 0.0
.text 1083080 1083228 148 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668379 668451 72 0.0
.text 579652 579724 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633971 634043 72 0.0
.text 556012 556084 72 0.0
lock-ftd LP_CC2652R7 (read only) 671527 671599 72 0.0
.text 594584 594656 72 0.0
lock-mtd LP_CC2652R7 (read only) 653755 653827 72 0.0
.text 552112 552184 72 0.0
pump-app LP_CC2652R7 (read only) 680951 681183 232 0.0
.rodata 89175 89255 80 0.1
.text 591292 591444 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666703 666943 240 0.0
.rodata 85007 85087 80 0.1
.text 581216 581376 160 0.0
shell LP_CC2652R7 (read only) 660854 660926 72 0.0
.text 575364 575436 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583302 583374 72 0.0
.app_xip_area 460440 460512 72 0.0
lock cyw930739m2evb_01 (read/write) 589222 589294 72 0.0
.app_xip_area 461632 461704 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589042 589274 232 0.0
.app_xip_area 466996 467228 232 0.0
efr32 lighting-app BRD4161A (read/write) 1088112 1088336 224 0.0
.text 952768 952992 224 0.0
BRD4161A+rpc (read/write) 1142404 1142644 240 0.0
.text 990168 990408 240 0.0
BRD4161A+rs911x (read/write) 952640 952888 248 0.0
.text 809580 809828 248 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128472 248 0.0
.text 981788 982036 248 0.0
window-app BRD4161A (read/write) 1081588 1081812 224 0.0
.text 944740 944964 224 0.0
esp32 all-clusters-app c3devkit (read only) 1022026 1022196 170 0.0
(read/write) 1486586 1486674 88 0.0
.flash.rodata 216264 216352 88 0.0
.flash.text 1022026 1022196 170 0.0
m5stack (read only) 1075675 1075799 124 0.0
(read/write) 488608 488688 80 0.0
.flash.rodata 246668 246748 80 0.0
.flash.text 1070291 1070415 124 0.0
k32w light k32w0+release (read/write) 641728 641808 80 0.0
.text 567244 567324 80 0.0
lock k32w0+release (read/write) 699024 699104 80 0.0
.text 624092 624172 80 0.0
linux chip-tool-ipv6only arm64 (read only) 9808468 9809300 832 0.0
(read/write) 678593 678625 32 0.0
.data.rel.ro 623936 623960 24 0.0
.rodata 466196 466276 80 0.0
.text 7759972 7760692 720 0.0
thermostat-no-ble arm64 (read only) 2341484 2342268 784 0.0
(read/write) 141393 141409 16 0.0
.data.rel.ro 75672 75696 24 0.0
.rodata 139428 139508 80 0.1
.text 1965008 1965680 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449328 2449560 232 0.0
.text 1411972 1412204 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177083 1177311 228 0.0
rodata 142660 142744 84 0.1
text 812360 812512 152 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157135 1157363 228 0.0
rodata 134192 134276 84 0.1
text 801668 801824 156 0.0
p6 all-clusters-app default (read/write) 1686996 1687244 248 0.0
.text 1526832 1527080 248 0.0
all-clusters-minimal-app default (read/write) 1631100 1631340 240 0.0
.text 1471656 1471896 240 0.0
light-app default (read/write) 1551452 1551692 240 0.0
.text 1400312 1400552 240 0.0
lock-app default (read/write) 1589052 1589292 240 0.0
.text 1433440 1433680 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799612 799872 260 0.0
text 567144 567320 176 0.0
lighting-app tlsr9518adk80d (read/write) 819720 819980 260 0.0
text 583716 583892 176 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 75f1ddf 58c9d0f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182980 182908 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 170024 169952 -72 -0.0
lock-mtd LP_CC2652R7 (read/write) 183484 183412 -72 -0.0
pump-app LP_CC2652R7 (read/write) 161432 161200 -232 -0.1
pump-controller-app LP_CC2652R7 (read/write) 175816 175576 -240 -0.1
shell LP_CC2652R7 (read/write) 186024 185952 -72 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 75f1ddf 58c9d0f change % change
bl602 lighting-app bl602 (read/write) 1381354 1381498 144 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051424 1051572 148 0.0
bl602+rpc (read/write) 1426762 1426906 144 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083080 1083228 148 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668379 668451 72 0.0
(read/write) 182980 182908 -72 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579652 579724 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633971 634043 72 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556012 556084 72 0.0
lock-ftd LP_CC2652R7 (read only) 671527 671599 72 0.0
(read/write) 170024 169952 -72 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594584 594656 72 0.0
lock-mtd LP_CC2652R7 (read only) 653755 653827 72 0.0
(read/write) 183484 183412 -72 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552112 552184 72 0.0
pump-app LP_CC2652R7 (read only) 680951 681183 232 0.0
(read/write) 161432 161200 -232 -0.1
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89255 80 0.1
.text 591292 591444 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666703 666943 240 0.0
(read/write) 175816 175576 -240 -0.1
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85087 80 0.1
.text 581216 581376 160 0.0
shell LP_CC2652R7 (read only) 660854 660926 72 0.0
(read/write) 186024 185952 -72 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575364 575436 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583302 583374 72 0.0
.app_xip_area 460440 460512 72 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589222 589294 72 0.0
.app_xip_area 461632 461704 72 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589042 589274 232 0.0
.app_xip_area 466996 467228 232 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088112 1088336 224 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952768 952992 224 0.0
BRD4161A+rpc (read/write) 1142404 1142644 240 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990168 990408 240 0.0
BRD4161A+rs911x (read/write) 952640 952888 248 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809580 809828 248 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128472 248 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981788 982036 248 0.0
window-app BRD4161A (read/write) 1081588 1081812 224 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944740 944964 224 0.0
esp32 all-clusters-app c3devkit (read only) 1022026 1022196 170 0.0
(read/write) 1486586 1486674 88 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216352 88 0.0
.flash.text 1022026 1022196 170 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075675 1075799 124 0.0
(read/write) 488608 488688 80 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246748 80 0.0
.flash.text 1070291 1070415 124 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641728 641808 80 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567244 567324 80 0.0
lock k32w0+release (read/write) 699024 699104 80 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624092 624172 80 0.0
linux chip-tool-ipv6only arm64 (read only) 9808468 9809300 832 0.0
(read/write) 678593 678625 32 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623960 24 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466196 466276 80 0.0
.text 7759972 7760692 720 0.0
thermostat-no-ble arm64 (read only) 2341484 2342268 784 0.0
(read/write) 141393 141409 16 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75696 24 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139428 139508 80 0.1
.text 1965008 1965680 672 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449560 232 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1412204 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177083 1177311 228 0.0
bss 143132 143132 0 0.0
rodata 142660 142744 84 0.1
text 812360 812512 152 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157135 1157363 228 0.0
bss 142368 142368 0 0.0
rodata 134192 134276 84 0.1
text 801668 801824 156 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1686996 1687244 248 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526832 1527080 248 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631100 1631340 240 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471656 1471896 240 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551452 1551692 240 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400312 1400552 240 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589052 1589292 240 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433440 1433680 240 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799612 799872 260 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567144 567320 176 0.0
lighting-app tlsr9518adk80d (read/write) 819720 819980 260 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583716 583892 176 0.0

@yunhanw-google yunhanw-google marked this pull request as ready for review July 26, 2022 20:20
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

PR #21116: Size comparison from a7ad1d8 to 0f35703

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a7ad1d8 0f35703 change % change
bl602 lighting-app bl602 (read/write) 1381450 1381602 152 0.0
.text 1051520 1051676 156 0.0
bl602+rpc (read/write) 1426866 1427018 152 0.0
.text 1083188 1083340 152 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668499 72 0.0
.text 579700 579772 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634091 72 0.0
.text 556060 556132 72 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671647 80 0.0
.text 594624 594704 80 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653867 72 0.0
.text 552152 552224 72 0.0
pump-app LP_CC2652R7 (read only) 680999 681231 232 0.0
.rodata 89175 89255 80 0.1
.text 591340 591492 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666991 240 0.0
.rodata 85007 85087 80 0.1
.text 581264 581424 160 0.0
shell LP_CC2652R7 (read only) 660894 660966 72 0.0
.text 575404 575476 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583406 72 0.0
.app_xip_area 460472 460544 72 0.0
lock cyw930739m2evb_01 (read/write) 589254 589326 72 0.0
.app_xip_area 461664 461736 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589314 232 0.0
.app_xip_area 467036 467268 232 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088400 240 0.0
.text 952816 953056 240 0.0
BRD4161A+rpc (read/write) 1142452 1142692 240 0.0
.text 990216 990456 240 0.0
BRD4161A+rs911x (read/write) 952704 952936 232 0.0
.text 809644 809876 232 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128504 248 0.0
.text 981820 982068 248 0.0
window-app BRD4161A (read/write) 1081636 1081876 240 0.0
.text 944788 945028 240 0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022282 168 0.0
(read/write) 1486586 1486674 88 0.0
.flash.rodata 216264 216352 88 0.0
.flash.text 1022114 1022282 168 0.0
m5stack (read only) 1075771 1075903 132 0.0
(read/write) 488608 488688 80 0.0
.flash.rodata 246668 246748 80 0.0
.flash.text 1070387 1070519 132 0.0
k32w light k32w0+release (read/write) 641776 641856 80 0.0
.text 567292 567372 80 0.0
lock k32w0+release (read/write) 699056 699136 80 0.0
.text 624124 624204 80 0.0
linux all-clusters-app debug (read only) 2986593 2987777 1184 0.0
.rodata 268139 268235 96 0.0
.text 2540098 2541186 1088 0.0
all-clusters-minimal-app debug (read only) 2829473 2830657 1184 0.0
.rodata 268139 268235 96 0.0
.text 2385586 2386674 1088 0.0
bridge-app debug+rpc (read only) 2344289 2345473 1184 0.1
.rodata 200456 200552 96 0.0
.text 1981282 1982370 1088 0.1
chip-tool debug (read only) 10385937 10387121 1184 0.0
.rodata 532693 532757 64 0.0
.text 8401668 8402788 1120 0.0
chip-tool-ipv6only arm64 (read only) 9809588 9810436 848 0.0
(read/write) 678593 678625 32 0.0
.data.rel.ro 623936 623960 24 0.0
.rodata 466436 466516 80 0.0
.text 7760852 7761588 736 0.0
lighting-app debug+rpc (read only) 2567361 2568545 1184 0.0
.rodata 216144 216240 96 0.0
.text 2180578 2181666 1088 0.0
lock-app debug (read only) 2532409 2533593 1184 0.0
.rodata 231120 231216 96 0.0
.text 2135426 2136514 1088 0.1
ota-provider-app debug (read only) 2336193 2337361 1168 0.0
.rodata 206136 206200 64 0.0
.text 1966610 1967714 1104 0.1
ota-requestor-app debug (read only) 2461169 2462353 1184 0.0
.rodata 210112 210208 96 0.0
.text 2078994 2080082 1088 0.1
shell debug (read only) 2570009 2571161 1152 0.0
.rodata 230322 230386 64 0.0
.text 2181842 2182930 1088 0.0
thermostat-no-ble arm64 (read only) 2342156 2342972 816 0.0
(read/write) 141393 141409 16 0.0
.data.rel.ro 75672 75696 24 0.0
.rodata 139588 139684 96 0.1
.text 1965520 1966208 688 0.0
tv-app debug (read only) 3117409 3118593 1184 0.0
.rodata 252168 252264 96 0.0
.text 2676530 2677618 1088 0.0
tv-casting-app debug (read only) 5372345 5373545 1200 0.0
.rodata 337249 337345 96 0.0
.text 4768306 4769410 1104 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449328 2449560 232 0.0
.text 1411972 1412204 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177359 228 0.0
rodata 142660 142744 84 0.1
text 812408 812560 152 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157411 228 0.0
rodata 134192 134276 84 0.1
text 801716 801872 156 0.0
p6 all-clusters-app default (read/write) 1687044 1687292 248 0.0
.text 1526880 1527128 248 0.0
all-clusters-minimal-app default (read/write) 1631148 1631388 240 0.0
.text 1471704 1471944 240 0.0
light-app default (read/write) 1551516 1551740 224 0.0
.text 1400376 1400600 224 0.0
lock-app default (read/write) 1589116 1589340 224 0.0
.text 1433504 1433728 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799920 260 0.0
text 567186 567366 180 0.0
lighting-app tlsr9518adk80d (read/write) 819760 820020 260 0.0
text 583758 583934 176 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section a7ad1d8 0f35703 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182932 182860 -72 -0.0
lock-ftd LP_CC2652R7 (read/write) 169984 169904 -80 -0.0
lock-mtd LP_CC2652R7 (read/write) 183444 183372 -72 -0.0
pump-app LP_CC2652R7 (read/write) 161384 161152 -232 -0.1
pump-controller-app LP_CC2652R7 (read/write) 175768 175528 -240 -0.1
shell LP_CC2652R7 (read/write) 185984 185912 -72 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a7ad1d8 0f35703 change % change
bl602 lighting-app bl602 (read/write) 1381450 1381602 152 0.0
.bss 117538 117538 0 0.0
.data 4480 4480 0 0.0
.text 1051520 1051676 156 0.0
bl602+rpc (read/write) 1426866 1427018 152 0.0
.bss 124978 124978 0 0.0
.data 4600 4600 0 0.0
.text 1083188 1083340 152 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668427 668499 72 0.0
(read/write) 182932 182860 -72 -0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88411 0 0.0
.text 579700 579772 72 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634019 634091 72 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77635 0 0.0
.text 556060 556132 72 0.0
lock-ftd LP_CC2652R7 (read only) 671567 671647 80 0.0
(read/write) 169984 169904 -80 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76463 0 0.0
.text 594624 594704 80 0.0
lock-mtd LP_CC2652R7 (read only) 653795 653867 72 0.0
(read/write) 183444 183372 -72 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101163 0 0.0
.text 552152 552224 72 0.0
pump-app LP_CC2652R7 (read only) 680999 681231 232 0.0
(read/write) 161384 161152 -232 -0.1
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89255 80 0.1
.text 591340 591492 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666751 666991 240 0.0
(read/write) 175768 175528 -240 -0.1
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85087 80 0.1
.text 581264 581424 160 0.0
shell LP_CC2652R7 (read only) 660894 660966 72 0.0
(read/write) 185984 185912 -72 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85174 0 0.0
.text 575404 575476 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583334 583406 72 0.0
.app_xip_area 460472 460544 72 0.0
.bss 65656 65656 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589254 589326 72 0.0
.app_xip_area 461664 461736 72 0.0
.bss 70384 70384 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589082 589314 232 0.0
.app_xip_area 467036 467268 232 0.0
.bss 64896 64896 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088160 1088400 240 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952816 953056 240 0.0
BRD4161A+rpc (read/write) 1142452 1142692 240 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990216 990456 240 0.0
BRD4161A+rs911x (read/write) 952704 952936 232 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809644 809876 232 0.0
lock-app BRD4161A+wf200 (read/write) 1128256 1128504 248 0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981820 982068 248 0.0
window-app BRD4161A (read/write) 1081636 1081876 240 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944788 945028 240 0.0
esp32 all-clusters-app c3devkit (read only) 1022114 1022282 168 0.0
(read/write) 1486586 1486674 88 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216264 216352 88 0.0
.flash.text 1022114 1022282 168 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075771 1075903 132 0.0
(read/write) 488608 488688 80 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246668 246748 80 0.0
.flash.text 1070387 1070519 132 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641776 641856 80 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567292 567372 80 0.0
lock k32w0+release (read/write) 699056 699136 80 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624124 624204 80 0.0
linux all-clusters-app debug (read only) 2986593 2987777 1184 0.0
(read/write) 155480 155480 0 0.0
.bss 61856 61856 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 268139 268235 96 0.0
.text 2540098 2541186 1088 0.0
all-clusters-minimal-app debug (read only) 2829473 2830657 1184 0.0
(read/write) 147184 147184 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268139 268235 96 0.0
.text 2385586 2386674 1088 0.0
bridge-app debug+rpc (read only) 2344289 2345473 1184 0.1
(read/write) 127056 127056 0 0.0
.bss 50144 50144 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 200456 200552 96 0.0
.text 1981282 1982370 1088 0.1
chip-tool debug (read only) 10385937 10387121 1184 0.0
(read/write) 631088 631088 0 0.0
.bss 24824 24824 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596592 596592 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532693 532757 64 0.0
.text 8401668 8402788 1120 0.0
chip-tool-ipv6only arm64 (read only) 9809588 9810436 848 0.0
(read/write) 678593 678625 32 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623960 24 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466436 466516 80 0.0
.text 7760852 7761588 736 0.0
lighting-app debug+rpc (read only) 2567361 2568545 1184 0.0
(read/write) 129992 129992 0 0.0
.bss 49696 49696 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 216144 216240 96 0.0
.text 2180578 2181666 1088 0.0
lock-app debug (read only) 2532409 2533593 1184 0.0
(read/write) 125040 125040 0 0.0
.bss 48096 48096 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 231120 231216 96 0.0
.text 2135426 2136514 1088 0.1
ota-provider-app debug (read only) 2336193 2337361 1168 0.0
(read/write) 118840 118840 0 0.0
.bss 47744 47744 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 206136 206200 64 0.0
.text 1966610 1967714 1104 0.1
ota-requestor-app debug (read only) 2461169 2462353 1184 0.0
(read/write) 126200 126200 0 0.0
.bss 50112 50112 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 210112 210208 96 0.0
.text 2078994 2080082 1088 0.1
shell debug (read only) 2570009 2571161 1152 0.0
(read/write) 141632 141632 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 230322 230386 64 0.0
.text 2181842 2182930 1088 0.0
thermostat-no-ble arm64 (read only) 2342156 2342972 816 0.0
(read/write) 141393 141409 16 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75696 24 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139588 139684 96 0.1
.text 1965520 1966208 688 0.0
tv-app debug (read only) 3117409 3118593 1184 0.0
(read/write) 257224 257224 0 0.0
.bss 167160 167160 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78888 78888 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 252168 252264 96 0.0
.text 2676530 2677618 1088 0.0
tv-casting-app debug (read only) 5372345 5373545 1200 0.0
(read/write) 158464 158464 0 0.0
.bss 51320 51320 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 337249 337345 96 0.0
.text 4768306 4769410 1104 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449328 2449560 232 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1411972 1412204 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177131 1177359 228 0.0
bss 143132 143132 0 0.0
rodata 142660 142744 84 0.1
text 812408 812560 152 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157183 1157411 228 0.0
bss 142368 142368 0 0.0
rodata 134192 134276 84 0.1
text 801716 801872 156 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687044 1687292 248 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526880 1527128 248 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631148 1631388 240 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471704 1471944 240 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551516 1551740 224 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400376 1400600 224 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589116 1589340 224 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433504 1433728 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799660 799920 260 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567186 567366 180 0.0
lighting-app tlsr9518adk80d (read/write) 819760 820020 260 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583758 583934 176 0.0

mrjerryjohns
mrjerryjohns reviewed Jul 27, 2022
View reviewed changes
src/app/reporting/Engine.cpp Show resolved Hide resolved
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
src/app/tests/MockAclTestContext.cpp Outdated Show resolved Hide resolved
src/app/tests/MockAclTestContext.h Outdated Show resolved Hide resolved
src/app/tests/TestAclEvent.cpp Show resolved Hide resolved
src/app/tests/TestAclEvent.cpp Show resolved Hide resolved
src/app/tests/TestAclEvent.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

PR #21116: Size comparison from 8c18775 to f119e34

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c18775 f119e34 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381482 152 0.0
.text 1051628 1051780 152 0.0
bl602+rpc (read/write) 1426746 1426906 160 0.0
.text 1083292 1083448 156 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668299 668379 80 0.0
.text 579788 579868 80 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 633955 80 0.0
.text 556140 556220 80 0.0
lock-ftd LP_CC2652R7 (read only) 671455 671527 72 0.0
.text 594712 594784 72 0.0
lock-mtd LP_CC2652R7 (read only) 653555 653627 72 0.0
.text 552200 552272 72 0.0
pump-app LP_CC2652R7 (read only) 680735 680967 232 0.0
.rodata 88863 88943 80 0.1
.text 591388 591540 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666487 666727 240 0.0
.rodata 84679 84767 88 0.1
.text 581328 581480 152 0.0
shell LP_CC2652R7 (read only) 661006 661078 72 0.0
.text 575524 575596 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583278 72 0.0
.app_xip_area 460016 460088 72 0.0
lock cyw930739m2evb_01 (read/write) 589126 589198 72 0.0
.app_xip_area 461208 461280 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588938 589178 240 0.0
.app_xip_area 466564 466804 240 0.1
efr32 lighting-app BRD4161A (read/write) 1087832 1088056 224 0.0
.text 952480 952704 224 0.0
BRD4161A+rpc (read/write) 1142124 1142348 224 0.0
.text 989880 990104 224 0.0
BRD4161A+rs911x (read/write) 973224 973472 248 0.0
.text 809420 809668 248 0.0
lock-app BRD4161A+wf200 (read/write) 1128296 1128528 232 0.0
.text 981852 982084 232 0.0
window-app BRD4161A (read/write) 1081308 1081540 232 0.0
.text 944452 944684 232 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022626 166 0.0
(read/write) 1486274 1486362 88 0.0
.flash.rodata 215936 216024 88 0.0
.flash.text 1022460 1022626 166 0.0
m5stack (read only) 1076107 1076239 132 0.0
(read/write) 488312 488400 88 0.0
.flash.rodata 246364 246452 88 0.0
.flash.text 1070723 1070855 132 0.0
k32w light k32w0+release (read/write) 642600 642680 80 0.0
.text 568108 568188 80 0.0
lock k32w0+release (read/write) 699832 699912 80 0.0
.text 624892 624972 80 0.0
linux all-clusters-app debug (read only) 2989849 2991033 1184 0.0
.rodata 269067 269163 96 0.0
.text 2542210 2543298 1088 0.0
all-clusters-minimal-app debug (read only) 2832889 2834073 1184 0.0
.rodata 269227 269323 96 0.0
.text 2387698 2388786 1088 0.0
bridge-app debug+rpc (read only) 2351177 2352345 1168 0.0
.rodata 201384 201448 64 0.0
.text 1987026 1988130 1104 0.1
chip-tool debug (read only) 10425609 10426793 1184 0.0
.rodata 535381 535445 64 0.0
.text 8438340 8439460 1120 0.0
chip-tool-ipv6only arm64 (read only) 9842868 9843700 832 0.0
(read/write) 678609 678641 32 0.0
.data.rel.ro 623936 623960 24 0.0
.rodata 467588 467668 80 0.0
.text 7792932 7793652 720 0.0
lighting-app debug+rpc (read only) 2574169 2575369 1200 0.0
.rodata 217104 217200 96 0.0
.text 2186210 2187314 1104 0.1
lock-app debug (read only) 2539185 2540369 1184 0.0
.rodata 231984 232080 96 0.0
.text 2141122 2142210 1088 0.1
ota-provider-app debug (read only) 2343545 2344729 1184 0.1
.rodata 207576 207672 96 0.0
.text 1972306 1973394 1088 0.1
ota-requestor-app debug (read only) 2464553 2465721 1168 0.0
.rodata 211136 211200 64 0.0
.text 2081138 2082242 1104 0.1
shell debug (read only) 2573377 2574545 1168 0.0
.rodata 231250 231314 64 0.0
.text 2184066 2185170 1104 0.1
thermostat-no-ble arm64 (read only) 2343388 2344172 784 0.0
(read/write) 141601 141633 32 0.0
.data.rel.ro 75856 75880 24 0.0
.rodata 138964 139044 80 0.1
.text 1967200 1967888 688 0.0
tv-app debug (read only) 3123553 3124737 1184 0.0
.rodata 253416 253512 96 0.0
.text 2681138 2682226 1088 0.0
tv-casting-app debug (read only) 5378297 5379481 1184 0.0
.rodata 338513 338609 96 0.0
.text 4772706 4773794 1088 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2450384 2450616 232 0.0
.text 1413028 1413260 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172935 244 0.0
rodata 141828 141912 84 0.1
text 808808 808964 156 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152971 228 0.0
rodata 133360 133444 84 0.1
text 798120 798272 152 0.0
p6 all-clusters-app default (read/write) 1686700 1686948 248 0.0
.text 1526528 1526776 248 0.0
all-clusters-minimal-app default (read/write) 1630796 1631044 248 0.0
.text 1471344 1471592 248 0.0
light-app default (read/write) 1552220 1552468 248 0.0
.text 1401072 1401320 248 0.0
lock-app default (read/write) 1589828 1590076 248 0.0
.text 1434208 1434456 248 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799868 268 0.0
text 567240 567420 180 0.0
lighting-app tlsr9518adk80d (read/write) 819708 819968 260 0.0
text 583810 583988 178 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 8c18775 f119e34 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183068 182988 -80 -0.0
lock-ftd LP_CC2652R7 (read/write) 170104 170032 -72 -0.0
lock-mtd LP_CC2652R7 (read/write) 183692 183620 -72 -0.0
pump-app LP_CC2652R7 (read/write) 161656 161424 -232 -0.1
pump-controller-app LP_CC2652R7 (read/write) 176040 175800 -240 -0.1
shell LP_CC2652R7 (read/write) 185880 185808 -72 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c18775 f119e34 change % change
bl602 lighting-app bl602 (read/write) 1381330 1381482 152 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051628 1051780 152 0.0
bl602+rpc (read/write) 1426746 1426906 160 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083292 1083448 156 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668299 668379 80 0.0
(read/write) 183068 182988 -80 -0.0
.bss 74260 74260 0 0.0
.data 3356 3356 0 0.0
.rodata 88195 88195 0 0.0
.text 579788 579868 80 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633875 633955 80 0.0
(read/write) 157828 157828 0 0.0
.bss 73556 73556 0 0.0
.data 3356 3356 0 0.0
.rodata 77411 77411 0 0.0
.text 556140 556220 80 0.0
lock-ftd LP_CC2652R7 (read only) 671455 671527 72 0.0
(read/write) 170104 170032 -72 -0.0
.bss 71340 71340 0 0.0
.data 3280 3280 0 0.0
.rodata 76263 76263 0 0.0
.text 594712 594784 72 0.0
lock-mtd LP_CC2652R7 (read only) 653555 653627 72 0.0
(read/write) 183692 183620 -72 -0.0
.bss 67028 67028 0 0.0
.data 3280 3280 0 0.0
.rodata 100875 100875 0 0.0
.text 552200 552272 72 0.0
pump-app LP_CC2652R7 (read only) 680735 680967 232 0.0
(read/write) 161656 161424 -232 -0.1
.bss 71404 71404 0 0.0
.data 3280 3280 0 0.0
.rodata 88863 88943 80 0.1
.text 591388 591540 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666487 666727 240 0.0
(read/write) 176040 175800 -240 -0.1
.bss 71540 71540 0 0.0
.data 3276 3276 0 0.0
.rodata 84679 84767 88 0.1
.text 581328 581480 152 0.0
shell LP_CC2652R7 (read only) 661006 661078 72 0.0
(read/write) 185880 185808 -72 -0.0
.bss 76580 76580 0 0.0
.data 3360 3360 0 0.0
.rodata 85166 85166 0 0.0
.text 575524 575596 72 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583206 583278 72 0.0
.app_xip_area 460016 460088 72 0.0
.bss 65648 65648 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589126 589198 72 0.0
.app_xip_area 461208 461280 72 0.0
.bss 70376 70376 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588938 589178 240 0.0
.app_xip_area 466564 466804 240 0.1
.bss 64888 64888 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087832 1088056 224 0.0
.bss 133284 133284 0 0.0
.data 2048 2048 0 0.0
.text 952480 952704 224 0.0
BRD4161A+rpc (read/write) 1142124 1142348 224 0.0
.bss 149964 149964 0 0.0
.data 2260 2260 0 0.0
.text 989880 990104 224 0.0
BRD4161A+rs911x (read/write) 973224 973472 248 0.0
.bss 161736 161736 0 0.0
.data 2048 2048 0 0.0
.text 809420 809668 248 0.0
lock-app BRD4161A+wf200 (read/write) 1128296 1128528 232 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981852 982084 232 0.0
window-app BRD4161A (read/write) 1081308 1081540 232 0.0
.bss 134756 134756 0 0.0
.data 2076 2076 0 0.0
.text 944452 944684 232 0.0
esp32 all-clusters-app c3devkit (read only) 1022460 1022626 166 0.0
(read/write) 1486274 1486362 88 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 216024 88 0.0
.flash.text 1022460 1022626 166 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076107 1076239 132 0.0
(read/write) 488312 488400 88 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246452 88 0.0
.flash.text 1070723 1070855 132 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642600 642680 80 0.0
.bss 69736 69736 0 0.0
.data 2028 2028 0 0.0
.text 568108 568188 80 0.0
lock k32w0+release (read/write) 699832 699912 80 0.0
.bss 70176 70176 0 0.0
.data 2036 2036 0 0.0
.text 624892 624972 80 0.0
linux all-clusters-app debug (read only) 2989849 2991033 1184 0.0
(read/write) 155584 155584 0 0.0
.bss 61888 61888 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 269067 269163 96 0.0
.text 2542210 2543298 1088 0.0
all-clusters-minimal-app debug (read only) 2832889 2834073 1184 0.0
(read/write) 147288 147288 0 0.0
.bss 61088 61088 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 269227 269323 96 0.0
.text 2387698 2388786 1088 0.0
bridge-app debug+rpc (read only) 2351177 2352345 1168 0.0
(read/write) 127160 127160 0 0.0
.bss 50176 50176 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201384 201448 64 0.0
.text 1987026 1988130 1104 0.1
chip-tool debug (read only) 10425609 10426793 1184 0.0
(read/write) 631224 631224 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 596592 596592 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535381 535445 64 0.0
.text 8438340 8439460 1120 0.0
chip-tool-ipv6only arm64 (read only) 9842868 9843700 832 0.0
(read/write) 678609 678641 32 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623960 24 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467588 467668 80 0.0
.text 7792932 7793652 720 0.0
lighting-app debug+rpc (read only) 2574169 2575369 1200 0.0
(read/write) 130096 130096 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217104 217200 96 0.0
.text 2186210 2187314 1104 0.1
lock-app debug (read only) 2539185 2540369 1184 0.0
(read/write) 125176 125176 0 0.0
.bss 48160 48160 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 231984 232080 96 0.0
.text 2141122 2142210 1088 0.1
ota-provider-app debug (read only) 2343545 2344729 1184 0.1
(read/write) 118944 118944 0 0.0
.bss 47776 47776 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207576 207672 96 0.0
.text 1972306 1973394 1088 0.1
ota-requestor-app debug (read only) 2464553 2465721 1168 0.0
(read/write) 126304 126304 0 0.0
.bss 50144 50144 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211136 211200 64 0.0
.text 2081138 2082242 1104 0.1
shell debug (read only) 2573377 2574545 1168 0.0
(read/write) 141736 141736 0 0.0
.bss 57736 57736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231250 231314 64 0.0
.text 2184066 2185170 1104 0.1
thermostat-no-ble arm64 (read only) 2343388 2344172 784 0.0
(read/write) 141601 141633 32 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75880 24 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 138964 139044 80 0.1
.text 1967200 1967888 688 0.0
tv-app debug (read only) 3123553 3124737 1184 0.0
(read/write) 257416 257416 0 0.0
.bss 167256 167256 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78888 78888 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 253416 253512 96 0.0
.text 2681138 2682226 1088 0.0
tv-casting-app debug (read only) 5378297 5379481 1184 0.0
(read/write) 158592 158592 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338513 338609 96 0.0
.text 4772706 4773794 1088 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450384 2450616 232 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413028 1413260 232 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172691 1172935 244 0.0
bss 143140 143140 0 0.0
rodata 141828 141912 84 0.1
text 808808 808964 156 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152743 1152971 228 0.0
bss 142376 142376 0 0.0
rodata 133360 133444 84 0.1
text 798120 798272 152 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686700 1686948 248 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526776 248 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1630796 1631044 248 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471344 1471592 248 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552220 1552468 248 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401072 1401320 248 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589828 1590076 248 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434208 1434456 248 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799600 799868 268 0.0
bss 70816 70816 0 0.0
noinit 40416 40416 0 0.0
text 567240 567420 180 0.0
lighting-app tlsr9518adk80d (read/write) 819708 819968 260 0.0
bss 71660 71660 0 0.0
noinit 40416 40416 0 0.0
text 583810 583988 178 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jul 28, 2022
View reviewed changes
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
erjiaqing and others added 3 commits July 28, 2022 20:20
@restyled-io restyled-io bot mentioned this pull request Jul 29, 2022
Closed
@yunhanw-google yunhanw-google enabled auto-merge (squash) July 29, 2022 04:36
@github-actions
Copy link

github-actions bot commented Jul 29, 2022 •
edited
Loading

PR #21116: Size comparison from 21b1e5a to 5e251ca

Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 21b1e5a 5e251ca change % change
bl602 lighting-app bl602 (read/write) 1381618 1381770 152 0.0
.text 1051888 1052040 152 0.0
bl602+rpc (read/write) 1427034 1427186 152 0.0
.text 1083556 1083708 152 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668523 668611 88 0.0
.text 580012 580100 88 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634107 634195 88 0.0
.text 556372 556460 88 0.0
lock-ftd LP_CC2652R7 (read only) 671495 671583 88 0.0
.text 594752 594840 88 0.0
lock-mtd LP_CC2652R7 (read only) 653595 653683 88 0.0
.text 552240 552328 88 0.0
pump-app LP_CC2652R7 (read only) 680959 681167 208 0.0
.rodata 88863 88919 56 0.1
.text 591612 591764 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666527 666735 208 0.0
.rodata 84679 84743 64 0.1
.text 581368 581512 144 0.0
shell LP_CC2652R7 (read only) 661206 661302 96 0.0
.text 575724 575820 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583414 583502 88 0.0
.app_xip_area 460232 460320 88 0.0
lock cyw930739m2evb_01 (read/write) 589158 589254 96 0.0
.app_xip_area 461248 461344 96 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588970 589194 224 0.0
.app_xip_area 466604 466828 224 0.0
efr32 lighting-app BRD4161A (read/write) 1088048 1088248 200 0.0
.text 952704 952904 200 0.0
BRD4161A+rpc (read/write) 1142356 1142556 200 0.0
.text 990120 990320 200 0.0
BRD4161A+rs911x (read/write) 973912 974136 224 0.0
.text 810108 810332 224 0.0
lock-app BRD4161A+wf200 (read/write) 1128392 1128616 224 0.0
.text 981948 982172 224 0.0
window-app BRD4161A (read/write) 1081316 1081540 224 0.0
.text 944468 944692 224 0.0
esp32 all-clusters-app c3devkit (read only) 1022806 1022964 158 0.0
(read/write) 1486274 1486338 64 0.0
.flash.rodata 215936 216000 64 0.0
.flash.text 1022806 1022964 158 0.0
m5stack (read only) 1076295 1076451 156 0.0
(read/write) 488312 488376 64 0.0
.flash.rodata 246364 246428 64 0.0
.flash.text 1070911 1071067 156 0.0
k32w light k32w0+release (read/write) 642800 642896 96 0.0
.text 568316 568412 96 0.0
lock k32w0+release (read/write) 699920 700016 96 0.0
.text 624988 625084 96 0.0
linux all-clusters-app debug (read only) 2991257 2992409 1152 0.0
.rodata 269195 269259 64 0.0
.text 2543490 2544578 1088 0.0
all-clusters-minimal-app debug (read only) 2834297 2835449 1152 0.0
.rodata 269355 269419 64 0.0
.text 2388978 2390066 1088 0.0
bridge-app debug+rpc (read only) 2352649 2353801 1152 0.0
.rodata 201480 201544 64 0.0
.text 1988402 1989490 1088 0.1
chip-tool debug (read only) 10466289 10467473 1184 0.0
.rodata 535989 536053 64 0.0
.text 8445892 8447012 1120 0.0
chip-tool-ipv6only arm64 (read only) 9881988 9882836 848 0.0
(read/write) 689041 689073 32 0.0
.data.rel.ro 634336 634360 24 0.0
.rodata 468196 468260 64 0.0
.text 7798660 7799412 752 0.0
lighting-app debug+rpc (read only) 2575513 2576665 1152 0.0
.rodata 217232 217296 64 0.0
.text 2187426 2188514 1088 0.0
lock-app debug (read only) 2539617 2540785 1168 0.0
.rodata 232112 232176 64 0.0
.text 2141426 2142530 1104 0.1
ota-provider-app debug (read only) 2343961 2345113 1152 0.0
.rodata 207704 207768 64 0.0
.text 1972594 1973682 1088 0.1
ota-requestor-app debug (read only) 2464873 2466041 1168 0.0
.rodata 211264 211328 64 0.0
.text 2081330 2082434 1104 0.1
shell debug (read only) 2574785 2575937 1152 0.0
.rodata 231282 231346 64 0.0
.text 2185442 2186530 1088 0.0
thermostat-no-ble arm64 (read only) 2343516 2344316 800 0.0
(read/write) 141633 141649 16 0.0
.data.rel.ro 75880 75904 24 0.0
.rodata 138964 139028 64 0.0
.text 1967312 1968016 704 0.0
tv-app debug (read only) 3147041 3148193 1152 0.0
.rodata 255240 255304 64 0.0
.text 2702418 2703506 1088 0.0
tv-casting-app debug (read only) 5382121 5383273 1152 0.0
.rodata 338641 338705 64 0.0
.text 4776402 4777490 1088 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2450672 2450880 208 0.0
.text 1413316 1413524 208 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1173135 220 0.0
rodata 141828 141888 60 0.0
text 809024 809184 160 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152967 1153187 220 0.0
rodata 133360 133420 60 0.0
text 798336 798492 156 0.0
p6 all-clusters-app default (read/write) 1686972 1687196 224 0.0
.text 1526800 1527024 224 0.0
all-clusters-minimal-app default (read/write) 1631084 1631308 224 0.0
.text 1471632 1471856 224 0.0
light-app default (read/write) 1552492 1552716 224 0.0
.text 1401344 1401568 224 0.0
lock-app default (read/write) 1589908 1590132 224 0.0
.text 1434288 1434512 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799608 799836 228 0.0
text 567246 567416 170 0.0
lighting-app tlsr9518adk80d (read/write) 820024 820252 228 0.0
text 584110 584276 166 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 21b1e5a 5e251ca change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182820 182732 -88 -0.0
lock-ftd LP_CC2652R7 (read/write) 170040 169952 -88 -0.1
lock-mtd LP_CC2652R7 (read/write) 183628 183540 -88 -0.0
pump-app LP_CC2652R7 (read/write) 161408 161200 -208 -0.1
pump-controller-app LP_CC2652R7 (read/write) 175976 175768 -208 -0.1
shell LP_CC2652R7 (read/write) 185656 185560 -96 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 21b1e5a 5e251ca change % change
bl602 lighting-app bl602 (read/write) 1381618 1381770 152 0.0
.bss 117618 117618 0 0.0
.data 4480 4480 0 0.0
.text 1051888 1052040 152 0.0
bl602+rpc (read/write) 1427034 1427186 152 0.0
.bss 125058 125058 0 0.0
.data 4600 4600 0 0.0
.text 1083556 1083708 152 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668523 668611 88 0.0
(read/write) 182820 182732 -88 -0.0
.bss 74236 74236 0 0.0
.data 3372 3372 0 0.0
.rodata 88195 88195 0 0.0
.text 580012 580100 88 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634107 634195 88 0.0
(read/write) 157820 157820 0 0.0
.bss 73532 73532 0 0.0
.data 3372 3372 0 0.0
.rodata 77411 77411 0 0.0
.text 556372 556460 88 0.0
lock-ftd LP_CC2652R7 (read only) 671495 671583 88 0.0
(read/write) 170040 169952 -88 -0.1
.bss 71316 71316 0 0.0
.data 3296 3296 0 0.0
.rodata 76263 76263 0 0.0
.text 594752 594840 88 0.0
lock-mtd LP_CC2652R7 (read only) 653595 653683 88 0.0
(read/write) 183628 183540 -88 -0.0
.bss 67004 67004 0 0.0
.data 3296 3296 0 0.0
.rodata 100875 100875 0 0.0
.text 552240 552328 88 0.0
pump-app LP_CC2652R7 (read only) 680959 681167 208 0.0
(read/write) 161408 161200 -208 -0.1
.bss 71380 71380 0 0.0
.data 3296 3296 0 0.0
.rodata 88863 88919 56 0.1
.text 591612 591764 152 0.0
pump-controller-app LP_CC2652R7 (read only) 666527 666735 208 0.0
(read/write) 175976 175768 -208 -0.1
.bss 71516 71516 0 0.0
.data 3292 3292 0 0.0
.rodata 84679 84743 64 0.1
.text 581368 581512 144 0.0
shell LP_CC2652R7 (read only) 661206 661302 96 0.0
(read/write) 185656 185560 -96 -0.1
.bss 76556 76556 0 0.0
.data 3376 3376 0 0.0
.rodata 85166 85166 0 0.0
.text 575724 575820 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583414 583502 88 0.0
.app_xip_area 460232 460320 88 0.0
.bss 65624 65624 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589158 589254 96 0.0
.app_xip_area 461248 461344 96 0.0
.bss 70352 70352 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 588970 589194 224 0.0
.app_xip_area 466604 466828 224 0.0
.bss 64864 64864 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088048 1088248 200 0.0
.bss 133260 133260 0 0.0
.data 2064 2064 0 0.0
.text 952704 952904 200 0.0
BRD4161A+rpc (read/write) 1142356 1142556 200 0.0
.bss 149940 149940 0 0.0
.data 2276 2276 0 0.0
.text 990120 990320 200 0.0
BRD4161A+rs911x (read/write) 973912 974136 224 0.0
.bss 161736 161736 0 0.0
.data 2048 2048 0 0.0
.text 810108 810332 224 0.0
lock-app BRD4161A+wf200 (read/write) 1128392 1128616 224 0.0
.bss 144368 144368 0 0.0
.data 2056 2056 0 0.0
.text 981948 982172 224 0.0
window-app BRD4161A (read/write) 1081316 1081540 224 0.0
.bss 134732 134732 0 0.0
.data 2092 2092 0 0.0
.text 944468 944692 224 0.0
esp32 all-clusters-app c3devkit (read only) 1022806 1022964 158 0.0
(read/write) 1486274 1486338 64 0.0
.dram0.bss 70296 70296 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215936 216000 64 0.0
.flash.text 1022806 1022964 158 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076295 1076451 156 0.0
(read/write) 488312 488376 64 0.0
.dram0.bss 75808 75808 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246364 246428 64 0.0
.flash.text 1070911 1071067 156 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 642800 642896 96 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 568316 568412 96 0.0
lock k32w0+release (read/write) 699920 700016 96 0.0
.bss 70152 70152 0 0.0
.data 2052 2052 0 0.0
.text 624988 625084 96 0.0
linux all-clusters-app debug (read only) 2991257 2992409 1152 0.0
(read/write) 155584 155584 0 0.0
.bss 61888 61888 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85272 85272 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 269195 269259 64 0.0
.text 2543490 2544578 1088 0.0
all-clusters-minimal-app debug (read only) 2834297 2835449 1152 0.0
(read/write) 147288 147288 0 0.0
.bss 61088 61088 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77864 77864 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 269355 269419 64 0.0
.text 2388978 2390066 1088 0.0
bridge-app debug+rpc (read only) 2352649 2353801 1152 0.0
(read/write) 127160 127160 0 0.0
.bss 50176 50176 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201480 201544 64 0.0
.text 1988402 1989490 1088 0.1
chip-tool debug (read only) 10466289 10467473 1184 0.0
(read/write) 641464 641464 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 606824 606824 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535989 536053 64 0.0
.text 8445892 8447012 1120 0.0
chip-tool-ipv6only arm64 (read only) 9881988 9882836 848 0.0
(read/write) 689041 689073 32 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 634336 634360 24 0.0
.dynamic 560 560 0 0.0
.got 13584 13584 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468196 468260 64 0.0
.text 7798660 7799412 752 0.0
lighting-app debug+rpc (read only) 2575513 2576665 1152 0.0
(read/write) 130096 130096 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72344 72344 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217232 217296 64 0.0
.text 2187426 2188514 1088 0.0
lock-app debug (read only) 2539617 2540785 1168 0.0
(read/write) 125176 125176 0 0.0
.bss 48160 48160 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69352 69352 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 232112 232176 64 0.0
.text 2141426 2142530 1104 0.1
ota-provider-app debug (read only) 2343961 2345113 1152 0.0
(read/write) 118944 118944 0 0.0
.bss 47776 47776 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207704 207768 64 0.0
.text 1972594 1973682 1088 0.1
ota-requestor-app debug (read only) 2464873 2466041 1168 0.0
(read/write) 126304 126304 0 0.0
.bss 50144 50144 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211264 211328 64 0.0
.text 2081330 2082434 1104 0.1
shell debug (read only) 2574785 2575937 1152 0.0
(read/write) 141736 141736 0 0.0
.bss 57736 57736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231282 231346 64 0.0
.text 2185442 2186530 1088 0.0
thermostat-no-ble arm64 (read only) 2343516 2344316 800 0.0
(read/write) 141633 141649 16 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75904 24 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 138964 139028 64 0.0
.text 1967312 1968016 704 0.0
tv-app debug (read only) 3147041 3148193 1152 0.0
(read/write) 257640 257640 0 0.0
.bss 167320 167320 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79032 79032 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 255240 255304 64 0.0
.text 2702418 2703506 1088 0.0
tv-casting-app debug (read only) 5382121 5383273 1152 0.0
(read/write) 158592 158592 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98432 98432 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338641 338705 64 0.0
.text 4776402 4777490 1088 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450672 2450880 208 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1413316 1413524 208 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172915 1173135 220 0.0
bss 143120 143120 0 0.0
rodata 141828 141888 60 0.0
text 809024 809184 160 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152967 1153187 220 0.0
bss 142356 142356 0 0.0
rodata 133360 133420 60 0.0
text 798336 798492 156 0.0
p6 all-clusters-app default (read only) 881560 881560 0 0.0
(read/write) 1686972 1687196 224 0.0
.bss 149136 149136 0 0.0
.data 2648 2648 0 0.0
.text 1526800 1527024 224 0.0
all-clusters-minimal-app default (read only) 882280 882280 0 0.0
(read/write) 1631084 1631308 224 0.0
.bss 148416 148416 0 0.0
.data 2648 2648 0 0.0
.text 1471632 1471856 224 0.0
light-app default (read only) 890584 890584 0 0.0
(read/write) 1552492 1552716 224 0.0
.bss 140320 140320 0 0.0
.data 2440 2440 0 0.0
.text 1401344 1401568 224 0.0
lock-app default (read only) 886112 886112 0 0.0
(read/write) 1589908 1590132 224 0.0
.bss 144776 144776 0 0.0
.data 2456 2456 0 0.0
.text 1434288 1434512 224 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799608 799836 228 0.0
bss 70796 70796 0 0.0
noinit 40416 40416 0 0.0
text 567246 567416 170 0.0
lighting-app tlsr9518adk80d (read/write) 820024 820252 228 0.0
bss 71640 71640 0 0.0
noinit 40416 40416 0 0.0
text 584110 584276 166 0.0

@yunhanw-google yunhanw-google merged commit 19cc9e7 into project-chip:master Jul 29, 2022
github-actions bot pushed a commit that referenced this pull request Jul 29, 2022
@yunhanw-google @erjiaqing @web-flow
Fix ACL Check on IM event per path basis (#21116)
6146d8e 
* Implement RemoveUnaccessableEventPaths

* fix compilation issues and leak bugs

enable acl event test for concrete and wildcard acl denied events

* address comments

* address comments

Co-authored-by: Song Guo <songguo@google.com>
mrjerryjohns pushed a commit to mrjerryjohns/connectedhomeip that referenced this pull request Jul 29, 2022
@yunhanw-google @erjiaqing @mrjerryjohns
Fix ACL Check on IM event per path basis (project-chip#21116)
cbd55d1 
* Implement RemoveUnaccessableEventPaths

* fix compilation issues and leak bugs

enable acl event test for concrete and wildcard acl denied events

* address comments

* address comments

Co-authored-by: Song Guo <songguo@google.com>
woody-apple added a commit that referenced this pull request Jul 29, 2022
@woody-apple @yunhanw-google @erjiaqing
Fix ACL Check on IM event per path basis (#21116) (#21418)
40c11e0 
* Implement RemoveUnaccessableEventPaths

* fix compilation issues and leak bugs

enable acl event test for concrete and wildcard acl denied events

* address comments

* address comments

Co-authored-by: Song Guo <songguo@google.com>

Co-authored-by: yunhanw-google <yunhanw@google.com>
Co-authored-by: Song Guo <songguo@google.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @erjiaqing @isiu-apple
Fix ACL Check on IM event per path basis (project-chip#21116)
7d13314 
* Implement RemoveUnaccessableEventPaths

* fix compilation issues and leak bugs

enable acl event test for concrete and wildcard acl denied events

* address comments

* address comments

Co-authored-by: Song Guo <songguo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

Assignees
No one assigned
Labels
app cert blocker review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yunhanw-google @mrjerryjohns @yufengwangca @woody-apple @bzbarsky-apple @cjandhyala @erjiaqing