Update ZAP to tip. #21210
Merged
Update ZAP to tip. #21210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
saurabhst
|
PR #21210: Size comparison from 2987329 to fc684db Increases (1 build for cc13x2_26x2)
Decreases (7 builds for bl602, cc13x2_26x2, linux, telink)
Full report (36 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
update-zap
branch
from
fc684db to
cf98062
Compare
|
PR #21210: Size comparison from 2987329 to cf98062 Increases (3 builds for cc13x2_26x2, esp32)
Decreases (8 builds for bl602, cc13x2_26x2, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This update stops guessing at fabric-scoping based on the types of struct/event fields and instead explicitly says which structs are fabric-scoped and which events are fabric-sensitive in the XML. The required FabricIndex field is then synthesized by ZAP, so we don't want it in the XML anymore. This fixes the naming of the FabricIndex field for some of the structs involved and lays the groundwork for a per-spec implementation of LeaveEvent (which is not fabric-sensitive but has a fabric-idx-typed field).
bzbarsky-apple
force-pushed
the
update-zap
branch
from
cf98062 to
25006bf
Compare
|
PR #21210: Size comparison from 925cff6 to 25006bf Increases (2 builds for esp32, telink)
Decreases (5 builds for cc13x2_26x2, linux, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 26, 2022
mrjerryjohns
approved these changes
Jul 26, 2022
jtung-apple
approved these changes
Jul 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
This update stops guessing at fabric-scoping based on the types of struct/event fields and instead explicitly says which structs are fabric-scoped and which events are fabric-sensitive in the XML. The required FabricIndex field is then synthesized by ZAP, so we don't want it in the XML anymore. This fixes the naming of the FabricIndex field for some of the structs involved and lays the groundwork for a per-spec implementation of LeaveEvent (which is not fabric-sensitive but has a fabric-idx-typed field).
woody-apple
added a commit
that referenced
this pull request
Jul 27, 2022
This update stops guessing at fabric-scoping based on the types of struct/event fields and instead explicitly says which structs are fabric-scoped and which events are fabric-sensitive in the XML. The required FabricIndex field is then synthesized by ZAP, so we don't want it in the XML anymore. This fixes the naming of the FabricIndex field for some of the structs involved and lays the groundwork for a per-spec implementation of LeaveEvent (which is not fabric-sensitive but has a fabric-idx-typed field). Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
This update stops guessing at fabric-scoping based on the types of struct/event fields and instead explicitly says which structs are fabric-scoped and which events are fabric-sensitive in the XML. The required FabricIndex field is then synthesized by ZAP, so we don't want it in the XML anymore. This fixes the naming of the FabricIndex field for some of the structs involved and lays the groundwork for a per-spec implementation of LeaveEvent (which is not fabric-sensitive but has a fabric-idx-typed field).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update stops guessing at fabric-scoping based on the types of struct/event
fields and instead explicitly says which structs are fabric-scoped and which
events are fabric-sensitive in the XML.
The required FabricIndex field is then synthesized by ZAP, so we don't want it
in the XML anymore.
This fixes the naming of the FabricIndex field for some of the structs involved
and lays the groundwork for a per-spec implementation of LeaveEvent (which is
not fabric-sensitive but has a fabric-idx-typed field).
Problem
See above. Need this to fix #21192
Change overview
See above.
Testing
Looked at the generated code. There should be no behavior changes apart from better name alignment with the spec.