Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manage role to invoke TestEventTrigger command #21283

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add manage role to invoke TestEventTrigger command #21283

merged 1 commit into from
Jul 27, 2022

Conversation

tehampson
Copy link
Contributor

Problem

TestEventTrigger command requires manage privilege.

Change overview

Added <access op="invoke" role="manage"/> to general-diagnostics-cluster.xml regenerated files.

Testing

  • CI

@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

PR #21283: Size comparison from 5cd92fb to 57cbe8a

Increases (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5cd92fb 57cbe8a change % change
bl602 lighting-app bl602 (read/write) 1381578 1381586 8 0.0
bl602+rpc (read/write) 1426978 1426986 8 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 .rodata 88411 88419 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634059 634067 8 0.0
.rodata 77635 77643 8 0.0
lock-ftd LP_CC2652R7 (read only) 671607 671623 16 0.0
.rodata 76463 76479 16 0.0
lock-mtd LP_CC2652R7 (read only) 653835 653843 8 0.0
.rodata 101163 101171 8 0.0
pump-app LP_CC2652R7 (read only) 681047 681063 16 0.0
.rodata 89175 89183 8 0.0
.text 591388 591396 8 0.0
pump-controller-app LP_CC2652R7 (read only) 666815 666823 8 0.0
.rodata 85007 85015 8 0.0
shell LP_CC2652R7 (read only) 660942 660950 8 0.0
.rodata 85174 85182 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583358 583374 16 0.0
.app_xip_area 460176 460192 16 0.0
lock cyw930739m2evb_01 (read/write) 589278 589286 8 0.0
.app_xip_area 461368 461376 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589138 589146 8 0.0
.app_xip_area 466772 466780 8 0.0
efr32 lighting-app BRD4161A (read/write) 1088208 1088216 8 0.0
.text 952864 952872 8 0.0
BRD4161A+rpc (read/write) 1142500 1142508 8 0.0
.text 990264 990272 8 0.0
BRD4161A+rs911x (read/write) 952880 952888 8 0.0
.text 809820 809828 8 0.0
window-app BRD4161A (read/write) 1081684 1081692 8 0.0
.text 944836 944844 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1486578 1486586 8 0.0
.flash.rodata 216256 216264 8 0.0
m5stack (read/write) 488600 488608 8 0.0
.flash.rodata 246660 246668 8 0.0
k32w light k32w0+release (read/write) 641808 641816 8 0.0
.text 567324 567332 8 0.0
lock k32w0+release (read/write) 699104 699112 8 0.0
.text 624172 624180 8 0.0
linux thermostat-no-ble arm64 (read only) 2342868 2342876 8 0.0
.rodata 139180 139188 8 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2449392 2449400 8 0.0
.text 1412036 1412044 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172767 1172775 8 0.0
rodata 141936 141944 8 0.0
text 808780 808784 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152819 1152827 8 0.0
rodata 133468 133476 8 0.0
p6 all-clusters-app default (read/write) 1687092 1687100 8 0.0
.text 1526928 1526936 8 0.0
all-clusters-minimal-app default (read/write) 1631196 1631204 8 0.0
.text 1471752 1471760 8 0.0
light-app default (read/write) 1551548 1551556 8 0.0
.text 1400408 1400416 8 0.0
lock-app default (read/write) 1589148 1589156 8 0.0
.text 1433536 1433544 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799684 799692 8 0.0
lighting-app tlsr9518adk80d (read/write) 819792 819800 8 0.0
text 583788 583790 2 0.0
Decreases (7 builds for cc13x2_26x2, efr32)
platform target config section 5cd92fb 57cbe8a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .text 579748 579740 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 169944 169928 -16 -0.0
lock-mtd LP_CC2652R7 (read/write) 183404 183396 -8 -0.0
pump-app LP_CC2652R7 (read/write) 161336 161320 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175704 175696 -8 -0.0
shell LP_CC2652R7 (read/write) 185936 185928 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1128384 1128376 -8 -0.0
.text 981948 981940 -8 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5cd92fb 57cbe8a change % change
bl602 lighting-app bl602 (read/write) 1381578 1381586 8 0.0
.bss 117610 117610 0 0.0
.data 4480 4480 0 0.0
.text 1051572 1051572 0 0.0
bl602+rpc (read/write) 1426978 1426986 8 0.0
.bss 125050 125050 0 0.0
.data 4600 4600 0 0.0
.text 1083236 1083236 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668475 668475 0 0.0
(read/write) 182884 182884 0 0.0
.bss 74252 74252 0 0.0
.data 3356 3356 0 0.0
.rodata 88411 88419 8 0.0
.text 579748 579740 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634059 634067 8 0.0
(read/write) 157820 157820 0 0.0
.bss 73548 73548 0 0.0
.data 3356 3356 0 0.0
.rodata 77635 77643 8 0.0
.text 556100 556100 0 0.0
lock-ftd LP_CC2652R7 (read only) 671607 671623 16 0.0
(read/write) 169944 169928 -16 -0.0
.bss 71332 71332 0 0.0
.data 3280 3280 0 0.0
.rodata 76463 76479 16 0.0
.text 594664 594664 0 0.0
lock-mtd LP_CC2652R7 (read only) 653835 653843 8 0.0
(read/write) 183404 183396 -8 -0.0
.bss 67020 67020 0 0.0
.data 3280 3280 0 0.0
.rodata 101163 101171 8 0.0
.text 552192 552192 0 0.0
pump-app LP_CC2652R7 (read only) 681047 681063 16 0.0
(read/write) 161336 161320 -16 -0.0
.bss 71396 71396 0 0.0
.data 3280 3280 0 0.0
.rodata 89175 89183 8 0.0
.text 591388 591396 8 0.0
pump-controller-app LP_CC2652R7 (read only) 666815 666823 8 0.0
(read/write) 175704 175696 -8 -0.0
.bss 71532 71532 0 0.0
.data 3276 3276 0 0.0
.rodata 85007 85015 8 0.0
.text 581328 581328 0 0.0
shell LP_CC2652R7 (read only) 660942 660950 8 0.0
(read/write) 185936 185928 -8 -0.0
.bss 76572 76572 0 0.0
.data 3360 3360 0 0.0
.rodata 85174 85182 8 0.0
.text 575452 575452 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583358 583374 16 0.0
.app_xip_area 460176 460192 16 0.0
.bss 65640 65640 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589278 589286 8 0.0
.app_xip_area 461368 461376 8 0.0
.bss 70368 70368 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589138 589146 8 0.0
.app_xip_area 466772 466780 8 0.0
.bss 64880 64880 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088208 1088216 8 0.0
.bss 133276 133276 0 0.0
.data 2048 2048 0 0.0
.text 952864 952872 8 0.0
BRD4161A+rpc (read/write) 1142500 1142508 8 0.0
.bss 149956 149956 0 0.0
.data 2260 2260 0 0.0
.text 990264 990272 8 0.0
BRD4161A+rs911x (read/write) 952880 952888 8 0.0
.bss 140992 140992 0 0.0
.data 2048 2048 0 0.0
.text 809820 809828 8 0.0
lock-app BRD4161A+wf200 (read/write) 1128384 1128376 -8 -0.0
.bss 144360 144360 0 0.0
.data 2056 2056 0 0.0
.text 981948 981940 -8 -0.0
window-app BRD4161A (read/write) 1081684 1081692 8 0.0
.bss 134748 134748 0 0.0
.data 2076 2076 0 0.0
.text 944836 944844 8 0.0
esp32 all-clusters-app c3devkit (read only) 1022468 1022468 0 0.0
(read/write) 1486578 1486586 8 0.0
.dram0.bss 70288 70288 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216256 216264 8 0.0
.flash.text 1022468 1022468 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076139 1076139 0 0.0
(read/write) 488600 488608 8 0.0
.dram0.bss 75800 75800 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246668 8 0.0
.flash.text 1070755 1070755 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641808 641816 8 0.0
.bss 69728 69728 0 0.0
.data 2028 2028 0 0.0
.text 567324 567332 8 0.0
lock k32w0+release (read/write) 699104 699112 8 0.0
.bss 70168 70168 0 0.0
.data 2036 2036 0 0.0
.text 624172 624180 8 0.0
linux chip-tool-ipv6only arm64 (read only) 9836724 9836724 0 0.0
(read/write) 678593 678593 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 623936 0 0.0
.dynamic 560 560 0 0.0
.got 13536 13536 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467940 467940 0 0.0
.text 7786484 7786484 0 0.0
thermostat-no-ble arm64 (read only) 2342868 2342876 8 0.0
(read/write) 141585 141585 0 0.0
.bss 55297 55297 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 560 560 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139180 139188 8 0.0
.text 1966464 1966464 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449392 2449400 8 0.0
.bss 214508 214508 0 0.0
.data 5872 5872 0 0.0
.text 1412036 1412044 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172767 1172775 8 0.0
bss 143132 143132 0 0.0
rodata 141936 141944 8 0.0
text 808780 808784 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1152819 1152827 8 0.0
bss 142368 142368 0 0.0
rodata 133468 133476 8 0.0
text 798092 798092 0 0.0
p6 all-clusters-app default (read only) 881568 881568 0 0.0
(read/write) 1687092 1687100 8 0.0
.bss 149128 149128 0 0.0
.data 2648 2648 0 0.0
.text 1526928 1526936 8 0.0
all-clusters-minimal-app default (read only) 882288 882288 0 0.0
(read/write) 1631196 1631204 8 0.0
.bss 148408 148408 0 0.0
.data 2648 2648 0 0.0
.text 1471752 1471760 8 0.0
light-app default (read only) 890592 890592 0 0.0
(read/write) 1551548 1551556 8 0.0
.bss 140312 140312 0 0.0
.data 2440 2440 0 0.0
.text 1400408 1400416 8 0.0
lock-app default (read only) 886120 886120 0 0.0
(read/write) 1589148 1589156 8 0.0
.bss 144768 144768 0 0.0
.data 2456 2456 0 0.0
.text 1433536 1433544 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799684 799692 8 0.0
bss 70808 70808 0 0.0
noinit 40416 40416 0 0.0
text 567216 567216 0 0.0
lighting-app tlsr9518adk80d (read/write) 819792 819800 8 0.0
bss 71652 71652 0 0.0
noinit 40416 40416 0 0.0
text 583788 583790 2 0.0

@woody-apple woody-apple merged commit 661cb82 into project-chip:master Jul 27, 2022
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
@tehampson @web-flow
Add manage role to TestEventTrigger command (#21283)
941a2f8
woody-apple added a commit that referenced this pull request Jul 28, 2022
@woody-apple @tehampson
Add manage role to TestEventTrigger command (#21283) (#21318)
9292dd7 
Co-authored-by: Terence Hampson <thampson@google.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@tehampson @isiu-apple
Add manage role to TestEventTrigger command (project-chip#21283)
9ef06f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @tcarmelveilleux @msandstedt @woody-apple