-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the weak MatterGetAccessPrivilegeForXX functions and add stubs #21387
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-ae2ca6d22e6594614df712fec3becad8e6ef2c6c
Jul 29, 2022
Merged
Remove the weak MatterGetAccessPrivilegeForXX functions and add stubs #21387
woody-apple
merged 1 commit into
sve
from
cherry-pick-ae2ca6d22e6594614df712fec3becad8e6ef2c6c
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test-helper and chip-im-responder/initiator (#21220)
PR #21387: Size comparison from efb3209 to a2fd8e2 Increases (4 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-ae2ca6d22e6594614df712fec3becad8e6ef2c6c
branch
July 29, 2022 05:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#19706
The
MatterGetAccessPrivilegeForXX
functions insrc/app/RequiredPrivilege.cpp
sometimes does not override the weak functions insrc/app/RequiredPrivilege.cpp
.Change overview
Remove the weak functions and add stubs for
tests:helper
andchip-im-responder/initiator
Testing
CI