Restyle Introduce Python-based freestanding tests #21568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
- Testing with Cirque requires complex setup and it is not easy to add tests. - Testing with chip-repl is interactive only - We needed a way to test more complex test scenarios than possible with chip-tool which cannot deal with complex test cases including recomputed cryptographic values due to complex logic and data dependencies. This PR: - Uses existing Mobly test framework dependency to add capabilities to make freestanding tests (see `src/python_testing/hello_test.py`) - Adds a module that only depends on existing CHIP modules in the virtual environment to provide needed scaffolding for tests running, including being able to commission a device from the command line - Adds needed cryptographic dependencies to environment for upcoming tests - Adds an example test (`hello_test.py`) - Added support to Python ChipDeviceCtrl to do on-network commissioning (thanks @erjiaqing!) What will follow-up: - Better docs - More sample tests - A way to re-use credentials from chip-tool with Python (already WIP) Testing done: - Built a test for TC-DA-1.7 (not included here) and ran it successfully against an all-clusters-app - Unit tests still pass - Integration tests still pass
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #21567 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.