Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix subscription id #21609

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix subscription id #21609

merged 2 commits into from
Aug 4, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

#21594

Change overview

ReadClient should return error when receiving report with subscription
Id and current action is read.
Rename mIsPrimingReports with comments.

Testing

Add test to validate the returned error when receiving report with subscription
Id and current action is read.

@yunhanw-google
fix subscription id
92093d7 
ReadClient should return error when receiving report with subscription
Id when current action is read.
@yunhanw-google yunhanw-google force-pushed the feature/fix_subscription_id_handling branch from 5bb6e73 to 92093d7 Compare August 3, 2022 20:45
bzbarsky-apple
bzbarsky-apple approved these changes Aug 3, 2022
View reviewed changes
src/app/ReadClient.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

PR #21609: Size comparison from fab04e7 to 92093d7

Increases (13 builds for bl602, cc13x2_26x2, efr32, linux, p6, telink)
platform target config section fab04e7 92093d7 change % change
bl602 lighting-app bl602 (read/write) 1380026 1380034 8 0.0
.text 1048208 1048216 8 0.0
bl602+rpc (read/write) 1425274 1425282 8 0.0
.text 1079708 1079716 8 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181860 181876 16 0.0
pump-controller-app LP_CC2652R7 (read/write) 175464 175472 8 0.0
shell LP_CC2652R7 (read/write) 183728 183736 8 0.0
efr32 lighting-app BRD4161A (read/write) 1090712 1090728 16 0.0
.text 955336 955352 16 0.0
BRD4161A+rpc (read/write) 1145004 1145020 16 0.0
.text 992736 992752 16 0.0
window-app BRD4161A (read/write) 1082460 1082476 16 0.0
.text 945596 945612 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9843900 9843980 80 0.0
.text 7754020 7754100 80 0.0
thermostat-no-ble arm64 (read only) 2346556 2346620 64 0.0
.text 1969792 1969856 64 0.0
p6 all-clusters-app default (read/write) 1690316 1690332 16 0.0
.text 1530112 1530128 16 0.0
lock-app default (read/write) 1592084 1592100 16 0.0
.text 1436424 1436440 16 0.0
telink lighting-app tlsr9518adk80d text 587288 587290 2 0.0
Decreases (6 builds for cc13x2_26x2, cyw30739, nrfconnect)
platform target config section fab04e7 92093d7 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655395 655379 -16 -0.0
.text 553520 553504 -16 -0.0
pump-controller-app LP_CC2652R7 (read only) 667047 667039 -8 -0.0
.text 581824 581816 -8 -0.0
shell LP_CC2652R7 (read only) 663174 663166 -8 -0.0
.text 577444 577436 -8 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 590646 590638 -8 -0.0
.app_xip_area 462672 462664 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589874 589866 -8 -0.0
.app_xip_area 467492 467484 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812568 812564 -4 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fab04e7 92093d7 change % change
bl602 lighting-app bl602 (read/write) 1380026 1380034 8 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048208 1048216 8 0.0
bl602+rpc (read/write) 1425274 1425282 8 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079708 1079716 8 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670507 670507 0 0.0
(read/write) 180876 180876 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88467 88467 0 0.0
.text 581724 581724 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636035 636035 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77723 77723 0 0.0
.text 557988 557988 0 0.0
lock-ftd LP_CC2652R7 (read only) 672991 672991 0 0.0
(read/write) 168576 168576 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76535 76535 0 0.0
.text 595976 595976 0 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655379 -16 -0.0
(read/write) 181860 181876 16 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101395 101395 0 0.0
.text 553520 553504 -16 -0.0
pump-app LP_CC2652R7 (read only) 682575 682575 0 0.0
(read/write) 159800 159800 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89199 89199 0 0.0
.text 592892 592892 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667047 667039 -8 -0.0
(read/write) 175464 175472 8 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581824 581816 -8 -0.0
shell LP_CC2652R7 (read only) 663174 663166 -8 -0.0
(read/write) 183728 183736 8 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85414 85414 0 0.0
.text 577444 577436 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584750 584750 0 0.0
.app_xip_area 461560 461560 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590646 590638 -8 -0.0
.app_xip_area 462672 462664 -8 -0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589874 589866 -8 -0.0
.app_xip_area 467492 467484 -8 -0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1090712 1090728 16 0.0
.bss 133292 133292 0 0.0
.data 2064 2064 0 0.0
.text 955336 955352 16 0.0
BRD4161A+rpc (read/write) 1145004 1145020 16 0.0
.bss 149972 149972 0 0.0
.data 2276 2276 0 0.0
.text 992736 992752 16 0.0
BRD4161A+rs911x (read/write) 977200 977200 0 0.0
.bss 161784 161784 0 0.0
.data 2052 2052 0 0.0
.text 813340 813340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1130728 1130728 0 0.0
.bss 144416 144416 0 0.0
.data 2060 2060 0 0.0
.text 984228 984228 0 0.0
window-app BRD4161A (read/write) 1082460 1082476 16 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945596 945612 16 0.0
k32w light k32w0+release (read/write) 644312 644312 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569820 569820 0 0.0
lock k32w0+release (read/write) 701568 701568 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626604 626604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9843900 9843980 80 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 463052 463052 0 0.0
.text 7754020 7754100 80 0.0
thermostat-no-ble arm64 (read only) 2346556 2346620 64 0.0
(read/write) 141601 141601 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139348 139348 0 0.0
.text 1969792 1969856 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453288 2453288 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1415932 1415932 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177303 1177303 0 0.0
bss 143222 143222 0 0.0
rodata 142664 142664 0 0.0
text 812568 812564 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157359 1157359 0 0.0
bss 142460 142460 0 0.0
rodata 134360 134360 0 0.0
text 801720 801720 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690316 1690332 16 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530112 1530128 16 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634524 1634524 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475040 1475040 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554812 1554812 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403648 1403648 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592084 1592100 16 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436424 1436440 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805592 805592 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569448 569448 0 0.0
lighting-app tlsr9518adk80d (read/write) 827264 827264 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587288 587290 2 0.0

@yunhanw-google @bzbarsky-apple
Update src/app/ReadClient.cpp
268ceee 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google yunhanw-google enabled auto-merge (squash) August 3, 2022 21:32
@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

PR #21609: Size comparison from fab04e7 to 268ceee

Increases (20 builds for bl602, cc13x2_26x2, linux, mbed, telink)
platform target config section fab04e7 268ceee2 change % change
bl602 lighting-app bl602 (read/write) 1380026 1380034 8 0.0
.text 1048208 1048216 8 0.0
bl602+rpc (read/write) 1425274 1425290 16 0.0
.text 1079708 1079720 12 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181860 181868 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 175464 175472 8 0.0
shell LP_CC2652R7 (read/write) 183728 183736 8 0.0
linux all-clusters-app debug (read only) 3018673 3018769 96 0.0
.text 2567522 2567618 96 0.0
all-clusters-minimal-app debug (read only) 2860521 2860617 96 0.0
.text 2411938 2412034 96 0.0
bridge-app debug+rpc (read only) 2366329 2366425 96 0.0
.text 2000274 2000370 96 0.0
chip-tool debug (read only) 10435929 10436025 96 0.0
.text 8409044 8409140 96 0.0
chip-tool-ipv6only arm64 (read only) 9843900 9844012 112 0.0
.text 7754020 7754132 112 0.0
lighting-app debug+rpc (read only) 2589009 2589105 96 0.0
.text 2199042 2199138 96 0.0
lock-app debug (read only) 2573209 2573289 80 0.0
.text 2170370 2170450 80 0.0
ota-provider-app debug (read only) 2353313 2353409 96 0.0
.text 1980482 1980578 96 0.0
ota-requestor-app debug (read only) 2473905 2474001 96 0.0
.text 2088930 2089026 96 0.0
shell debug (read only) 2589897 2589993 96 0.0
.text 2198466 2198562 96 0.0
thermostat-no-ble arm64 (read only) 2346556 2346652 96 0.0
.text 1969792 1969888 96 0.0
tv-app debug (read only) 3159937 3160033 96 0.0
.text 2713618 2713714 96 0.0
tv-casting-app debug (read only) 5397105 5397201 96 0.0
.text 4789698 4789794 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2453288 2453376 88 0.0
.text 1415932 1416020 88 0.0
telink light-switch-app tlsr9518adk80d text 569448 569450 2 0.0
Decreases (9 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect)
platform target config section fab04e7 268ceee2 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655395 655387 -8 -0.0
.text 553520 553512 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 667047 667039 -8 -0.0
.text 581824 581816 -8 -0.0
shell LP_CC2652R7 (read only) 663174 663166 -8 -0.0
.text 577444 577436 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584750 584742 -8 -0.0
.app_xip_area 461560 461552 -8 -0.0
lock cyw930739m2evb_01 (read/write) 590646 590630 -16 -0.0
.app_xip_area 462672 462656 -16 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589874 589866 -8 -0.0
.app_xip_area 467492 467484 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1025400 1025396 -4 -0.0
.flash.text 1025400 1025396 -4 -0.0
m5stack (read only) 1078859 1078855 -4 -0.0
.flash.text 1073475 1073471 -4 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812568 812564 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section fab04e7 268ceee2 change % change
bl602 lighting-app bl602 (read/write) 1380026 1380034 8 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048208 1048216 8 0.0
bl602+rpc (read/write) 1425274 1425290 16 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079708 1079720 12 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670507 670507 0 0.0
(read/write) 180876 180876 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88467 88467 0 0.0
.text 581724 581724 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636035 636035 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77723 77723 0 0.0
.text 557988 557988 0 0.0
lock-ftd LP_CC2652R7 (read only) 672991 672991 0 0.0
(read/write) 168576 168576 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76535 76535 0 0.0
.text 595976 595976 0 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655387 -8 -0.0
(read/write) 181860 181868 8 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101395 101395 0 0.0
.text 553520 553512 -8 -0.0
pump-app LP_CC2652R7 (read only) 682575 682575 0 0.0
(read/write) 159800 159800 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89199 89199 0 0.0
.text 592892 592892 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667047 667039 -8 -0.0
(read/write) 175464 175472 8 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581824 581816 -8 -0.0
shell LP_CC2652R7 (read only) 663174 663166 -8 -0.0
(read/write) 183728 183736 8 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85414 85414 0 0.0
.text 577444 577436 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584750 584742 -8 -0.0
.app_xip_area 461560 461552 -8 -0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590646 590630 -16 -0.0
.app_xip_area 462672 462656 -16 -0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589874 589866 -8 -0.0
.app_xip_area 467492 467484 -8 -0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1090712 1090712 0 0.0
.bss 133292 133292 0 0.0
.data 2064 2064 0 0.0
.text 955336 955336 0 0.0
BRD4161A+rpc (read/write) 1145004 1145004 0 0.0
.bss 149972 149972 0 0.0
.data 2276 2276 0 0.0
.text 992736 992736 0 0.0
BRD4161A+rs911x (read/write) 977200 977200 0 0.0
.bss 161784 161784 0 0.0
.data 2052 2052 0 0.0
.text 813340 813340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1130728 1130728 0 0.0
.bss 144416 144416 0 0.0
.data 2060 2060 0 0.0
.text 984228 984228 0 0.0
window-app BRD4161A (read/write) 1082460 1082460 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945596 945596 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025400 1025396 -4 -0.0
(read/write) 1487154 1487154 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216784 216784 0 0.0
.flash.text 1025400 1025396 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078859 1078855 -4 -0.0
(read/write) 489160 489160 0 0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247188 247188 0 0.0
.flash.text 1073475 1073471 -4 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644312 644312 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569820 569820 0 0.0
lock k32w0+release (read/write) 701568 701568 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626604 626604 0 0.0
linux all-clusters-app debug (read only) 3018673 3018769 96 0.0
(read/write) 155688 155688 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85352 85352 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272267 272267 0 0.0
.text 2567522 2567618 96 0.0
all-clusters-minimal-app debug (read only) 2860521 2860617 96 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272331 272331 0 0.0
.text 2411938 2412034 96 0.0
bridge-app debug+rpc (read only) 2366329 2366425 96 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203048 203048 0 0.0
.text 2000274 2000370 96 0.0
chip-tool debug (read only) 10435929 10436025 96 0.0
(read/write) 646336 646336 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 530933 530933 0 0.0
.text 8409044 8409140 96 0.0
chip-tool-ipv6only arm64 (read only) 9843900 9844012 112 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 463052 463052 0 0.0
.text 7754020 7754132 112 0.0
lighting-app debug+rpc (read only) 2589009 2589105 96 0.0
(read/write) 130232 130232 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218896 218896 0 0.0
.text 2199042 2199138 96 0.0
lock-app debug (read only) 2573209 2573289 80 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235824 235824 0 0.0
.text 2170370 2170450 80 0.0
ota-provider-app debug (read only) 2353313 2353409 96 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 208952 208952 0 0.0
.text 1980482 1980578 96 0.0
ota-requestor-app debug (read only) 2473905 2474001 96 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212480 212480 0 0.0
.text 2088930 2089026 96 0.0
shell debug (read only) 2589897 2589993 96 0.0
(read/write) 141840 141840 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76976 76976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 233202 233202 0 0.0
.text 2198466 2198562 96 0.0
thermostat-no-ble arm64 (read only) 2346556 2346652 96 0.0
(read/write) 141601 141601 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139348 139348 0 0.0
.text 1969792 1969888 96 0.0
tv-app debug (read only) 3159937 3160033 96 0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 256744 256744 0 0.0
.text 2713618 2713714 96 0.0
tv-casting-app debug (read only) 5397105 5397201 96 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 340113 340113 0 0.0
.text 4789698 4789794 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453288 2453376 88 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1415932 1416020 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177303 1177303 0 0.0
bss 143222 143222 0 0.0
rodata 142664 142664 0 0.0
text 812568 812564 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157359 1157359 0 0.0
bss 142460 142460 0 0.0
rodata 134360 134360 0 0.0
text 801720 801720 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690316 1690316 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530112 1530112 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634524 1634524 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475040 1475040 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554812 1554812 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403648 1403648 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592084 1592084 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436424 1436424 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805592 805592 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569448 569450 2 0.0
lighting-app tlsr9518adk80d (read/write) 827264 827264 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587288 587288 0 0.0

@yunhanw-google yunhanw-google merged commit f32d1c8 into project-chip:master Aug 4, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @bzbarsky-apple @isiu-apple
fix subscription id (project-chip#21609)
00ed87e 
* fix subscription id

ReadClient should return error when receiving report with subscription
Id when current action is read.

* Update src/app/ReadClient.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @bzbarsky-apple