Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read client matching for unsolicited report #21771

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix read client matching for unsolicited report #21771

merged 1 commit into from
Aug 10, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Aug 9, 2022 •
edited
Loading

Problem

#21593

Change overview

Use fabric index, peer node id, subscription id to identify a subscription uniquely on the client side
Rename IsMatchingClient to IsMatchingSubscriptionId

Testing

Existing test covers

bzbarsky-apple
bzbarsky-apple approved these changes Aug 9, 2022
View reviewed changes
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
@woody-apple woody-apple enabled auto-merge (squash) August 9, 2022 21:59
@github-actions github-actions bot added the app label Aug 9, 2022
@woody-apple woody-apple merged commit ab7b3bd into project-chip:master Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Aug 10, 2022 •
edited
Loading

PR #21771: Size comparison from 3860268 to f1ef67f

Increases (31 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 3860268 f1ef67f change % change
bl602 lighting-app bl602 (read/write) 1379954 1380058 104 0.0
.text 1048132 1048232 100 0.0
bl602+rpc (read/write) 1425210 1425306 96 0.0
.text 1079632 1079732 100 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670927 670991 64 0.0
.text 582140 582204 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636471 636535 64 0.0
.text 558420 558484 64 0.0
lock-ftd LP_CC2652R7 (read only) 672787 672843 56 0.0
.text 595896 595952 56 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655451 56 0.0
.text 553552 553608 56 0.0
pump-app LP_CC2652R7 (read only) 683011 683083 72 0.0
.text 593212 593284 72 0.0
pump-controller-app LP_CC2652R7 (read only) 667487 667551 64 0.0
.text 582144 582208 64 0.0
shell LP_CC2652R7 (read only) 663610 663666 56 0.0
.text 577876 577932 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584646 584710 64 0.0
.app_xip_area 461448 461512 64 0.0
lock cyw930739m2evb_01 (read/write) 590582 590646 64 0.0
.app_xip_area 462600 462664 64 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596962 597026 64 0.0
.app_xip_area 474484 474548 64 0.0
efr32 lighting-app BRD4161A (read/write) 1096372 1096516 144 0.0
.text 961436 961580 144 0.0
BRD4161A+rpc (read/write) 1150636 1150780 144 0.0
.text 998804 998948 144 0.0
BRD4161A+rs911x (read/write) 985908 986036 128 0.0
.text 821648 821776 128 0.0
lock-app BRD4161A+wf200 (read/write) 1136468 1136532 64 0.0
.text 989560 989624 64 0.0
window-app BRD4161A (read/write) 1088104 1088248 144 0.0
.text 951696 951840 144 0.0
esp32 all-clusters-app c3devkit (read only) 1026078 1026138 60 0.0
.flash.text 1026078 1026138 60 0.0
m5stack (read only) 1079367 1079451 84 0.0
.flash.text 1073983 1074067 84 0.0
k32w light k32w0+release (read/write) 643644 643708 64 0.0
.text 569160 569224 64 0.0
lock k32w0+release (read/write) 701076 701140 64 0.0
.text 626112 626176 64 0.0
linux chip-tool-ipv6only arm64 (read only) 10007084 10007228 144 0.0
.text 7903284 7903428 144 0.0
thermostat-no-ble arm64 (read only) 2350956 2351100 144 0.0
.text 1973712 1973856 144 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177959 1178023 64 0.0
text 813112 813172 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157983 1158047 64 0.0
text 802232 802292 60 0.0
p6 all-clusters-app default (read/write) 1693812 1693956 144 0.0
.text 1533600 1533744 144 0.0
all-clusters-minimal-app default (read/write) 1637980 1638124 144 0.0
.text 1478488 1478632 144 0.0
light-app default (read/write) 1556668 1556796 128 0.0
.text 1405496 1405624 128 0.0
lock-app default (read/write) 1593980 1594108 128 0.0
.text 1438312 1438440 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806120 806184 64 0.0
text 569822 569886 64 0.0
lighting-app tlsr9518adk80d (read/write) 827928 827992 64 0.0
text 587798 587862 64 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 3860268 f1ef67f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180456 180392 -64 -0.0
lock-ftd LP_CC2652R7 (read/write) 168780 168724 -56 -0.0
lock-mtd LP_CC2652R7 (read/write) 181860 181804 -56 -0.0
pump-app LP_CC2652R7 (read/write) 159364 159292 -72 -0.0
pump-controller-app LP_CC2652R7 (read/write) 175024 174960 -64 -0.0
shell LP_CC2652R7 (read/write) 183292 183236 -56 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3860268 f1ef67f change % change
bl602 lighting-app bl602 (read/write) 1379954 1380058 104 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048132 1048232 100 0.0
bl602+rpc (read/write) 1425210 1425306 96 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079632 1079732 100 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670927 670991 64 0.0
(read/write) 180456 180392 -64 -0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 582140 582204 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636471 636535 64 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558420 558484 64 0.0
lock-ftd LP_CC2652R7 (read only) 672787 672843 56 0.0
(read/write) 168780 168724 -56 -0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595896 595952 56 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655451 56 0.0
(read/write) 181860 181804 -56 -0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101363 101363 0 0.0
.text 553552 553608 56 0.0
pump-app LP_CC2652R7 (read only) 683011 683083 72 0.0
(read/write) 159364 159292 -72 -0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89315 89315 0 0.0
.text 593212 593284 72 0.0
pump-controller-app LP_CC2652R7 (read only) 667487 667551 64 0.0
(read/write) 175024 174960 -64 -0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84863 84863 0 0.0
.text 582144 582208 64 0.0
shell LP_CC2652R7 (read only) 663610 663666 56 0.0
(read/write) 183292 183236 -56 -0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577876 577932 56 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584646 584710 64 0.0
.app_xip_area 461448 461512 64 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590582 590646 64 0.0
.app_xip_area 462600 462664 64 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596962 597026 64 0.0
.app_xip_area 474484 474548 64 0.0
.bss 64952 64952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096372 1096516 144 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961436 961580 144 0.0
BRD4161A+rpc (read/write) 1150636 1150780 144 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998804 998948 144 0.0
BRD4161A+rs911x (read/write) 985908 986036 128 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821648 821776 128 0.0
lock-app BRD4161A+wf200 (read/write) 1136468 1136532 64 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989560 989624 64 0.0
window-app BRD4161A (read/write) 1088104 1088248 144 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951696 951840 144 0.0
esp32 all-clusters-app c3devkit (read only) 1026078 1026138 60 0.0
(read/write) 1487418 1487418 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217048 217048 0 0.0
.flash.text 1026078 1026138 60 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079367 1079451 84 0.0
(read/write) 489392 489392 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247412 247412 0 0.0
.flash.text 1073983 1074067 84 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643644 643708 64 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569160 569224 64 0.0
lock k32w0+release (read/write) 701076 701140 64 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626112 626176 64 0.0
linux chip-tool-ipv6only arm64 (read only) 10007084 10007228 144 0.0
(read/write) 695153 695153 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640360 640360 0 0.0
.dynamic 560 560 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474124 474124 0 0.0
.text 7903284 7903428 144 0.0
thermostat-no-ble arm64 (read only) 2350956 2351100 144 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139716 139716 0 0.0
.text 1973712 1973856 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452720 2452720 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415364 1415364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177959 1178023 64 0.0
bss 143222 143222 0 0.0
rodata 142776 142776 0 0.0
text 813112 813172 60 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157983 1158047 64 0.0
bss 142460 142460 0 0.0
rodata 134472 134472 0 0.0
text 802232 802292 60 0.0
p6 all-clusters-app default (read only) 881520 881520 0 0.0
(read/write) 1693812 1693956 144 0.0
.bss 149168 149168 0 0.0
.data 2656 2656 0 0.0
.text 1533600 1533744 144 0.0
all-clusters-minimal-app default (read only) 882240 882240 0 0.0
(read/write) 1637980 1638124 144 0.0
.bss 148448 148448 0 0.0
.data 2656 2656 0 0.0
.text 1478488 1478632 144 0.0
light-app default (read only) 890560 890560 0 0.0
(read/write) 1556668 1556796 128 0.0
.bss 140336 140336 0 0.0
.data 2448 2448 0 0.0
.text 1405496 1405624 128 0.0
lock-app default (read only) 886064 886064 0 0.0
(read/write) 1593980 1594108 128 0.0
.bss 144816 144816 0 0.0
.data 2464 2464 0 0.0
.text 1438312 1438440 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806120 806184 64 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569822 569886 64 0.0
lighting-app tlsr9518adk80d (read/write) 827928 827992 64 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587798 587862 64 0.0

@mrjerryjohns mrjerryjohns mentioned this pull request Aug 12, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @isiu-apple
Fix read client matching for unsolicited report (project-chip#21771)
3bebb95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @yufengwangca @bzbarsky-apple @woody-apple