-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to customize OTA responses in DarwinFWTool #22277
Add ability to customize OTA responses in DarwinFWTool #22277
Conversation
6de8384
to
a8afff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
I tested these against the OTA-Requestor app on sve-2 branch commit: 5471b35
PR #22277: Size comparison from 3be848d to a8afff4 Increases (2 builds for cc13x2_26x2)
Decreases (5 builds for cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
Accepted for 1.0: changes in /examples subdirectory only, also seems platform-specific (darwin) |
examples/darwin-framework-tool/commands/provider/OTAProviderDelegate.mm
Outdated
Show resolved
Hide resolved
a8afff4
to
dfc7a86
Compare
PR #22277: Size comparison from 297397c to dfc7a86 Increases (2 builds for esp32, psoc6)
Decreases (3 builds for bl602, psoc6, qpg)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
dfc7a86
to
694eada
Compare
PR #22277: Size comparison from 3522317 to 694eada Increases (4 builds for bl602, cc13x2_26x2, nrfconnect)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (31 builds for bl602, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #22277: Size comparison from ebd654b to 02d6989 Increases (4 builds for nrfconnect, psoc6, qpg, telink)
Decreases (1 build for esp32)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22277: Size comparison from e535710 to 7697b37 Increases (4 builds for esp32, nrfconnect, psoc6, qpg)
Decreases (1 build for k32w)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@krypton36 - merge conflicts, but ready to merge after that. |
7697b37
to
10a52b9
Compare
PR #22277: Size comparison from a60fb5a to 10a52b9 Increases (6 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem
Change overview
New command to set params in interactive mode:
Fixes #22560
Testing