-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA: Fix linux BlockEOF with data length zero #22314
Merged
andy31415
merged 1 commit into
sve-2
from
cherry-pick-1af4af09319fea47816936a2ee8649c1e4a7913b
Aug 31, 2022
Merged
OTA: Fix linux BlockEOF with data length zero #22314
andy31415
merged 1 commit into
sve-2
from
cherry-pick-1af4af09319fea47816936a2ee8649c1e4a7913b
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec indicates BlockEOF May have data length zero.
PR #22314: Size comparison from e32aa19 to d714448 Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes issue #22308 where linux currently doesn't support BlockEOF of data length zero.
Change overview
Remove this check, it is checked immediately after in SetBlock: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Linux/OTAImageProcessorImpl.cpp#L244
But at this point the block is released correctly and it does not return an error.
Testing
Did an ota which finished with a BlockEOF with data length zero and confirmed it finished.