Apply API review fixes for MTRReadParams and MTRSubscribeParams. #22592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #22592: Size comparison from 9c131da to 928fea2 Increases (5 builds for bl602, bl702, psoc6, telink)
Decreases (3 builds for esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-subscribe-params-fixes
branch
from
928fea2 to
967dc7d
Compare
|
PR #22592: Size comparison from 9441289 to 967dc7d Decreases (1 build for bl702)
Full report (6 builds for bl702, linux, qpg)
|
* Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". Fixes project-chip#22536 Fixes project-chip#22534 Addresses part of project-chip#22420
bzbarsky-apple
force-pushed
the
darwin-subscribe-params-fixes
branch
from
967dc7d to
b2b8cf3
Compare
|
PR #22592: Size comparison from 8626d39 to b2b8cf3 Increases (3 builds for bl702, telink)
Full report (12 builds for bl702, k32w, linux, mbed, qpg, telink)
|
vivien-apple
approved these changes
Sep 14, 2022
|
Fast-tracking platform-specific fix with platform owner review. |
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ject-chip#22592) * Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". Fixes project-chip#22536 Fixes project-chip#22534 Addresses part of project-chip#22420
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2022
This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs. * Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs. * The changes to MTRDeviceController+XPC.h are source+binary compatible. * MTRDeviceOverXPC.h is not a public header. * In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 4, 2022
) This is a re-landing of PR #22592 but modified to preserve the old APIs. * Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs. * The changes to MTRDeviceController+XPC.h are source+binary compatible. * MTRDeviceOverXPC.h is not a public header. * In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ject-chip#23491) This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs. * Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs. * The changes to MTRDeviceController+XPC.h are source+binary compatible. * MTRDeviceOverXPC.h is not a public header. * In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ject-chip#23491) This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs. * Move minInterval and maxInterval into MTRSubscribeParams. * Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default". The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs. * The changes to MTRDeviceController+XPC.h are source+binary compatible. * MTRDeviceOverXPC.h is not a public header. * In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move minInterval and maxInterval into MTRSubscribeParams.
Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default".
Addresses part of #22420
Issue Being Resolved
Change overview
See above.