Address API review issues in MTRDeviceController. #22596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
rgoliver
bzbarsky-apple
force-pushed
the
darwin-controller-api-fixes
branch
from
489bcf9 to
f62606e
Compare
|
PR #22596: Size comparison from 8626d39 to f62606e Increases (5 builds for bl602, bl702, cc13x2_26x2, nrfconnect)
Decreases (4 builds for cc13x2_26x2, psoc6, qpg)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-controller-api-fixes
branch
from
f62606e to
49707b9
Compare
|
PR #22596: Size comparison from 8626d39 to 49707b9 Increases (9 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (1 build for cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/darwin-framework-tool/commands/tests/TestCommandBridge.h
Outdated
Show resolved
Hide resolved
bzbarsky-apple
force-pushed
the
darwin-controller-api-fixes
branch
from
49707b9 to
5b53dec
Compare
vivien-apple
approved these changes
Sep 14, 2022
|
Fast-tracking platform-specific fix reviewed by platform owner. |
|
PR #22596: Size comparison from f4f81f2 to 5b53dec Increases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-controller-api-fixes
branch
from
5b53dec to
1307520
Compare
* Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Rename "pairDevice" to "setupCommissioningSessionWithPayload", fix its signature, improve documentation. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Add a way to generate a QR code from an MTRSetupPayload to allow correct recovery of long discriminators in setupCommissioningSessionWithPayload. * Fix signature of computePaseVerifier. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. Fixes project-chip#22533 Addresses part of project-chip#22420
bzbarsky-apple
force-pushed
the
darwin-controller-api-fixes
branch
from
1307520 to
20a83bb
Compare
|
PR #22596: Size comparison from e0a9cca to 20a83bb Increases (3 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Address API review issues in MTRDeviceController. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Rename "pairDevice" to "setupCommissioningSessionWithPayload", fix its signature, improve documentation. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Add a way to generate a QR code from an MTRSetupPayload to allow correct recovery of long discriminators in setupCommissioningSessionWithPayload. * Fix signature of computePaseVerifier. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. Fixes project-chip#22533 Addresses part of project-chip#22420 * Address review comments.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…oller. This is a re-landing of some of the API addition parts of project-chip#22596 and project-chip#22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in project-chip#23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…oller. This is a re-landing of some of the API addition parts of project-chip#22596 and project-chip#22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in project-chip#23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
bzbarsky-apple
added a commit
that referenced
this pull request
Oct 13, 2022
…oller. (#23159) This is a re-landing of some of the API addition parts of #22596 and #22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in #23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. * Address review comments.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 8, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 9, 2022
This is a re-landing of PR #22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22596 but with changes made for backwards compat. * Make MTRBaseDevice creation synchronous. This requires updates to MTRBaseDeviceOverXPC to do the possible async getting of the controller id it needs during its async operations, not when getting the device object. * Deprecate pairDevice methods. * Rename "commissionDevice" to "commissionNodeWithID". * Rename "stopDevicePairing" to "cancelCommissioningForNodeID" and document. * Rename "getDeviceBeingCommissioned" to "getDeviceBeingCommissionedWithNodeID". * Various documentation improvements. * Fix signature of computePaseVerifier. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRDeviceController.h, the change to isRunning is binary and source compatible. * MTRDeviceControllerOverXPC_Internal.h is not public API. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * The changes to MTRSetupPayload.h are backward-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #22420
Issue Being Resolved
Change overview
See above.