-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus #22633
Merged
franck-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_RenameMTRDevicePairingDelegateAndMTRPairingStatus
Sep 15, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
September 14, 2022 16:59
pullapprove
bot
requested review from
selissia,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 14, 2022 16:59
Should fix part 1 and 2 of issue #22537 |
bzbarsky-apple
approved these changes
Sep 14, 2022
Fast-tracking platform-specific fix with platform owner review. |
PR #22633: Size comparison from e0a9cca to 75a40fb Increases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (5 builds for bl702, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
fix #22638 |
vivien-apple
force-pushed
the
Darwin_RenameMTRDevicePairingDelegateAndMTRPairingStatus
branch
from
September 14, 2022 19:16
75a40fb
to
fa57dd8
Compare
PR #22633: Size comparison from 6ebd6b6 to fa57dd8 Increases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (project-chip#22633) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 11, 2022
…te and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 16, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (#23587) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR #22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs. * Address review comments. Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (project-chip#23587) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs. * Address review comments. Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…te and MTRPairingStatus to MTRCommissioningStatus (project-chip#23587) * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate and MTRPairingStatus to MTRCommissioningStatus This is a re-landing of PR project-chip#22633 but with changes made for backwards compat. * [Darwin] Rename MTRDevicePairingDelegate to MTRDeviceControllerDelegate * [Darwin] Rename MTRPairingStatus to MTRCommissioningStatus * Add backwards compat shims for the old APIs. * Address review comments. Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
I have opened a dedicated issue for that:
fix #22638
Change overview
MTRDevicePairingDelegate
->MTRDeviceControllerDelegate
MTRPairingStatus
->MTRCommissioningStatus