Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API review comments for MTRAttributeCacheContainer. #22636

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix API review comments for MTRAttributeCacheContainer. #22636

merged 1 commit into from
Sep 15, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

  • Fix function naming to indicate we are reading a path (maybe multiple attributes), not just an attribute.
  • Fix documentation.
  • Rename to MTRClusterStateCacheContainer.

Addresses part of #22420

Issue Being Resolved

Change overview

See above.

@bzbarsky-apple bzbarsky-apple force-pushed the darwin-attr-cache-container branch 2 times, most recently from e01b0aa to 6492d75 Compare September 14, 2022 17:30
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-attr-cache-container branch from 6492d75 to 9d6a450 Compare September 14, 2022 17:33
@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

PR #22636: Size comparison from e0a9cca to 9d6a450

Increases (4 builds for nrfconnect, psoc6, telink)
platform target config section e0a9cca 9d6a450 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815932 815936 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26813750 26813751 1 0.0
light cy8ckit_062s2_43012 .debug_info 22016852 22016853 1 0.0
telink light-switch-app tlsr9518adk80d text 574710 574712 2 0.0
Decreases (6 builds for bl602, bl702, esp32, nrfconnect, qpg)
platform target config section e0a9cca 9d6a450 change % change
bl602 lighting-app bl602 .text 1067582 1067580 -2 -0.0
bl702 lighting-app bl702 .debug_info 37894019 37894018 -1 -0.0
.text 957172 957170 -2 -0.0
esp32 all-clusters-app c3devkit (read/write) 1788110 1788102 -8 -0.0
.flash.rodata 257664 257656 -8 -0.0
m5stack (read/write) 563996 563988 -8 -0.0
.flash.rodata 314720 314712 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 804328 804324 -4 -0.0
qpg lock-app qpg6105+debug (read/write) 1101888 1101880 -8 -0.0
.text 548988 548980 -8 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section e0a9cca 9d6a450 change % change
bl602 lighting-app bl602 (read/write) 1412862 1412862 0 0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067582 1067580 -2 -0.0
bl602+rpc (read/write) 1458338 1458338 0 0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1099186 1099186 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188427 1188427 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506731 1506731 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486348 486348 0 0.0
.debug_info 37894019 37894018 -1 -0.0
.debug_line 5253486 5253486 0 0.0
.debug_loc 3363590 3363590 0 0.0
.debug_ranges 360256 360256 0 0.0
.debug_str 3455308 3455308 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957172 957170 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284339 1284339 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644310 1644310 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511724 511724 0 0.0
.debug_info 41800589 41800589 0 0.0
.debug_line 5628025 5628025 0 0.0
.debug_loc 3556258 3556258 0 0.0
.debug_ranges 382712 382712 0 0.0
.debug_str 3851275 3851275 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030874 1030874 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676939 676939 0 0.0
(read/write) 174484 174484 0 0.0
.bss 74316 74316 0 0.0
.data 3380 3380 0 0.0
.rodata 89451 89451 0 0.0
.text 587176 587176 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641651 641651 0 0.0
(read/write) 157884 157884 0 0.0
.bss 73588 73588 0 0.0
.data 3380 3380 0 0.0
.rodata 78595 78595 0 0.0
.text 562736 562736 0 0.0
lock-ftd LP_CC2652R7 (read only) 678055 678055 0 0.0
(read/write) 163680 163680 0 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600280 600280 0 0.0
lock-mtd LP_CC2652R7 (read only) 661883 661883 0 0.0
(read/write) 175540 175540 0 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103131 0 0.0
.text 558272 558272 0 0.0
pump-app LP_CC2652R7 (read only) 687291 687291 0 0.0
(read/write) 155148 155148 0 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90563 90563 0 0.0
.text 596244 596244 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671783 0 0.0
(read/write) 170768 170768 0 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 86119 86119 0 0.0
.text 585184 585184 0 0.0
shell LP_CC2652R7 (read only) 667982 667982 0 0.0
(read/write) 178952 178952 0 0.0
.bss 76628 76628 0 0.0
.data 3376 3376 0 0.0
.rodata 86174 86174 0 0.0
.text 581492 581492 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587410 587410 0 0.0
.app_xip_area 464068 464068 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594498 594498 0 0.0
.app_xip_area 465828 465828 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543482 543482 0 0.0
.app_xip_area 425164 425164 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110704 1110704 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 972280 972280 0 0.0
BRD4161A+rpc (read/write) 973588 973588 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820472 820472 0 0.0
BRD4161A+rs911x (read/write) 1003968 1003968 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832716 832716 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151476 1151476 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 997136 997136 0 0.0
window-app BRD4161A (read/write) 1101928 1101928 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 962040 962040 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223856 1223856 0 0.0
(read/write) 1788110 1788102 -8 -0.0
.dram0.bss 76952 76952 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257664 257656 -8 -0.0
.flash.text 1223856 1223856 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233723 1233723 0 0.0
(read/write) 563996 563988 -8 -0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314720 314712 -8 -0.0
.flash.text 1228339 1228339 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649972 649972 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574464 574464 0 0.0
lock k32w0+release (read/write) 706960 706960 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630996 630996 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10345860 10345860 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503028 503028 0 0.0
.text 8188884 8188884 0 0.0
thermostat-no-ble arm64 (read only) 2368252 2368252 0 0.0
(read/write) 142497 142497 0 0.0
.bss 55233 55233 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141588 141588 0 0.0
.text 1987664 1987664 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455952 2455952 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418596 1418596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182723 1182723 0 0.0
bss 143641 143641 0 0.0
rodata 144212 144212 0 0.0
text 815932 815936 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161923 1161923 0 0.0
bss 142868 142868 0 0.0
rodata 135804 135804 0 0.0
text 804328 804324 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1744780 1744780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229158 1229158 0 0.0
.debug_aranges 111800 111800 0 0.0
.debug_frame 373224 373224 0 0.0
.debug_info 26813750 26813751 1 0.0
.debug_line 3668978 3668978 0 0.0
.debug_loc 3582717 3582717 0 0.0
.debug_ranges 340576 340576 0 0.0
.debug_str 3439101 3439101 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571696 571696 0 0.0
.symtab 422080 422080 0 0.0
.text 1545008 1545008 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1687972 1687972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1220957 1220957 0 0.0
.debug_aranges 111272 111272 0 0.0
.debug_frame 376304 376304 0 0.0
.debug_info 26550599 26550599 0 0.0
.debug_line 3689694 3689694 0 0.0
.debug_loc 3570354 3570354 0 0.0
.debug_ranges 339192 339192 0 0.0
.debug_str 3428114 3428114 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536170 536170 0 0.0
.symtab 408672 408672 0 0.0
.text 1488936 1488936 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1605236 1605236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055116 1055116 0 0.0
.debug_aranges 103448 103448 0 0.0
.debug_frame 346572 346572 0 0.0
.debug_info 22016852 22016853 1 0.0
.debug_line 3259861 3259861 0 0.0
.debug_loc 3268724 3268724 0 0.0
.debug_ranges 304664 304664 0 0.0
.debug_str 3233368 3233368 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469469 469469 0 0.0
.symtab 375760 375760 0 0.0
.text 1414432 1414432 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642924 1642924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062571 1062571 0 0.0
.debug_aranges 104120 104120 0 0.0
.debug_frame 349400 349400 0 0.0
.debug_info 22396228 22396228 0 0.0
.debug_line 3268581 3268581 0 0.0
.debug_loc 3308561 3308561 0 0.0
.debug_ranges 308008 308008 0 0.0
.debug_str 3260785 3260785 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475672 475672 0 0.0
.symtab 378944 378944 0 0.0
.text 1447088 1447088 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130876 1130876 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577972 577972 0 0.0
lock-app qpg6105+debug (read/write) 1101888 1101880 -8 -0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548988 548980 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813868 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574710 574712 2 0.0
lighting-app tlsr9518adk80d (read/write) 835800 835800 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592852 592852 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843916 843916 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 599112 599112 0 0.0

@andy31415
Copy link
Contributor

@bzbarsky-apple - conflicts

@bzbarsky-apple
Fix API review comments for MTRAttributeCacheContainer.
1a8c406 
* Fix function naming to indicate we are reading a path (maybe multiple
  attributes), not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.

Fixes project-chip#22532

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-attr-cache-container branch from 9d6a450 to 1a8c406 Compare September 15, 2022 16:04
@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) September 15, 2022 16:05
@github-actions
Copy link

github-actions bot commented Sep 15, 2022 •
edited
Loading

PR #22636: Size comparison from 822993c to 1a8c406

Increases (4 builds for bl702, nrfconnect, psoc6, telink)
platform target config section 822993c 1a8c406 change % change
bl702 lighting-app bl702+rpc .debug_info 41800588 41800589 1 0.0
.text 1030900 1030902 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815348 815352 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22017603 22017605 2 0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 843916 843924 8 0.0
text 599112 599114 2 0.0
Decreases (5 builds for bl602, bl702, psoc6, telink)
platform target config section 822993c 1a8c406 change % change
bl602 lighting-app bl602 (read/write) 1412878 1412870 -8 -0.0
.text 1067596 1067592 -4 -0.0
bl702 lighting-app bl702 .debug_info 37894019 37894017 -2 -0.0
.text 957200 957196 -4 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22396952 22396950 -2 -0.0
telink light-switch-app tlsr9518adk80d text 574712 574710 -2 -0.0
lighting-app tlsr9518adk80d text 592852 592848 -4 -0.0
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 822993c 1a8c406 change % change
bl602 lighting-app bl602 (read/write) 1412878 1412870 -8 -0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067596 1067592 -4 -0.0
bl602+rpc (read/write) 1458346 1458346 0 0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1099198 1099198 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188443 1188443 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506733 1506733 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486348 486348 0 0.0
.debug_info 37894019 37894017 -2 -0.0
.debug_line 5253283 5253283 0 0.0
.debug_loc 3363557 3363557 0 0.0
.debug_ranges 360232 360232 0 0.0
.debug_str 3455381 3455381 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116504 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957200 957196 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284371 1284371 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644312 1644312 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511724 511724 0 0.0
.debug_info 41800588 41800589 1 0.0
.debug_line 5627822 5627822 0 0.0
.debug_loc 3556225 3556225 0 0.0
.debug_ranges 382688 382688 0 0.0
.debug_str 3851348 3851348 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030900 1030902 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676483 676483 0 0.0
(read/write) 174932 174932 0 0.0
.bss 74308 74308 0 0.0
.data 3380 3380 0 0.0
.rodata 89595 89595 0 0.0
.text 586576 586576 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640771 640771 0 0.0
(read/write) 157876 157876 0 0.0
.bss 73580 73580 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78747 0 0.0
.text 561704 561704 0 0.0
lock-ftd LP_CC2652R7 (read only) 678063 678063 0 0.0
(read/write) 163672 163672 0 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600288 600288 0 0.0
lock-mtd LP_CC2652R7 (read only) 661891 661891 0 0.0
(read/write) 175532 175532 0 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103131 0 0.0
.text 558280 558280 0 0.0
pump-app LP_CC2652R7 (read only) 687299 687299 0 0.0
(read/write) 155140 155140 0 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90563 90563 0 0.0
.text 596252 596252 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671783 0 0.0
(read/write) 170768 170768 0 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 86119 86119 0 0.0
.text 585184 585184 0 0.0
shell LP_CC2652R7 (read only) 667486 667486 0 0.0
(read/write) 179440 179440 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 86302 86302 0 0.0
.text 580868 580868 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587426 587426 0 0.0
.app_xip_area 464084 464084 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594514 594514 0 0.0
.app_xip_area 465844 465844 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543506 543506 0 0.0
.app_xip_area 425188 425188 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110720 1110720 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 972296 972296 0 0.0
BRD4161A+rpc (read/write) 973588 973588 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820472 820472 0 0.0
BRD4161A+rs911x (read/write) 1003968 1003968 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832716 832716 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151492 1151492 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 997152 997152 0 0.0
window-app BRD4161A (read/write) 1102832 1102832 0 0.0
.bss 137780 137780 0 0.0
.data 2096 2096 0 0.0
.text 962936 962936 0 0.0
k32w light k32w0+release (read/write) 649972 649972 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574464 574464 0 0.0
lock k32w0+release (read/write) 706960 706960 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630996 630996 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10348916 10348916 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503220 503220 0 0.0
.text 8191748 8191748 0 0.0
thermostat-no-ble arm64 (read only) 2368828 2368828 0 0.0
(read/write) 142545 142545 0 0.0
.bss 55249 55249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 76704 76704 0 0.0
.dynamic 560 560 0 0.0
.got 5096 5096 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141748 141748 0 0.0
.text 1987984 1987984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455808 2455808 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418452 1418452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182159 1182159 0 0.0
bss 143633 143633 0 0.0
rodata 144224 144224 0 0.0
text 815348 815352 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160847 1160847 0 0.0
bss 142860 142860 0 0.0
rodata 135816 135816 0 0.0
text 803244 803244 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1744260 1744260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229305 1229305 0 0.0
.debug_aranges 111784 111784 0 0.0
.debug_frame 373212 373212 0 0.0
.debug_info 26815322 26815322 0 0.0
.debug_line 3669118 3669118 0 0.0
.debug_loc 3582878 3582878 0 0.0
.debug_ranges 340664 340664 0 0.0
.debug_str 3439012 3439012 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569356 569356 0 0.0
.symtab 421168 421168 0 0.0
.text 1544496 1544496 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1686964 1686964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221104 1221104 0 0.0
.debug_aranges 111256 111256 0 0.0
.debug_frame 376292 376292 0 0.0
.debug_info 26552169 26552169 0 0.0
.debug_line 3689834 3689834 0 0.0
.debug_loc 3570515 3570515 0 0.0
.debug_ranges 339280 339280 0 0.0
.debug_str 3428025 3428025 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533445 533445 0 0.0
.symtab 407600 407600 0 0.0
.text 1487936 1487936 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605476 1605476 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055160 1055160 0 0.0
.debug_aranges 103464 103464 0 0.0
.debug_frame 346620 346620 0 0.0
.debug_info 22017603 22017605 2 0.0
.debug_line 3259846 3259846 0 0.0
.debug_loc 3268819 3268819 0 0.0
.debug_ranges 304608 304608 0 0.0
.debug_str 3233557 3233557 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469822 469822 0 0.0
.symtab 376048 376048 0 0.0
.text 1414640 1414640 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845864 845864 0 0.0
(read/write) 1643148 1643148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062595 1062595 0 0.0
.debug_aranges 104136 104136 0 0.0
.debug_frame 349448 349448 0 0.0
.debug_info 22396952 22396950 -2 -0.0
.debug_line 3268581 3268581 0 0.0
.debug_loc 3308657 3308657 0 0.0
.debug_ranges 307952 307952 0 0.0
.debug_str 3260974 3260974 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476025 476025 0 0.0
.symtab 379232 379232 0 0.0
.text 1447280 1447280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130892 1130892 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577988 577988 0 0.0
lock-app qpg6105+debug (read/write) 1101888 1101888 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548988 548988 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813868 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574712 574710 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 835800 835800 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592852 592848 -4 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 843916 843924 8 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 599112 599114 2 0.0

@bzbarsky-apple bzbarsky-apple merged commit 8e1c833 into project-chip:master Sep 15, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Fix API review comments for MTRAttributeCacheContainer. (project-chip…
34c8f1b 
…#22636)

* Fix function naming to indicate we are reading a path (maybe multiple
  attributes), not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.

Fixes project-chip#22532

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple deleted the darwin-attr-cache-container branch September 16, 2022 15:32
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 16, 2022
@bzbarsky-apple
Fix API review comments for MTRAttributeCacheContainer.
82f8781 
This is a re-landing of PR project-chip#22636 but with changes made for backwards compat.

* Fix function naming to indicate we may be reading a multiple
  attributes, not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 16, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Nov 16, 2022
@bzbarsky-apple
Fix API review comments for MTRAttributeCacheContainer.
a3c5901 
This is a re-landing of PR project-chip#22636 but with changes made for backwards compat.

* Fix function naming to indicate we may be reading a multiple
  attributes, not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.
bzbarsky-apple added a commit that referenced this pull request Nov 17, 2022
@bzbarsky-apple
Fix API review comments for MTRAttributeCacheContainer. (#23639)
3edba4a 
This is a re-landing of PR #22636 but with changes made for backwards compat.

* Fix function naming to indicate we may be reading a multiple
  attributes, not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix API review comments for MTRAttributeCacheContainer. (project-chip…
182c6f7 
…#23639)

This is a re-landing of PR project-chip#22636 but with changes made for backwards compat.

* Fix function naming to indicate we may be reading a multiple
  attributes, not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix API review comments for MTRAttributeCacheContainer. (project-chip…
b4a5073 
…#23639)

This is a re-landing of PR project-chip#22636 but with changes made for backwards compat.

* Fix function naming to indicate we may be reading a multiple
  attributes, not just an attribute.
* Fix documentation.
* Rename to MTRClusterStateCacheContainer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Improve documentation in MTRAttributeCacheContainer.h
3 participants
@bzbarsky-apple @andy31415 @vivien-apple