-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure darwin-framework-tool is beeing rebuilt when something changes… #22677
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_RebuildWhenFrameworkGeneratedCodeChanges
Sep 15, 2022
Merged
Ensure darwin-framework-tool is beeing rebuilt when something changes… #22677
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_RebuildWhenFrameworkGeneratedCodeChanges
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the generated code from src/darwin/Framework/CHIP/zap-generated
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
September 15, 2022 17:26
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 15, 2022 17:26
jtung-apple
approved these changes
Sep 15, 2022
andy31415
approved these changes
Sep 15, 2022
PR #22677: Size comparison from 7d707fa to ce35feb Increases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, nrfconnect, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… in the generated code from src/darwin/Framework/CHIP/zap-generated (project-chip#22677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in the generated code from src/darwin/Framework/CHIP/zap-generated
Issue Being Resolved
src/darwin/Framework/CHIP/zap-generated
does not trigger the rebuilding ofexamples/darwin-framework-tool
Change overview
src/darwin/Framework/CHIP/zap-generated
as an input sources inexamples/darwin-framework-tool/BUILD.gn