-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts] created bootstrap script for ZAP #22757
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
markaj-nordic:zap_scripts_refinement
Oct 5, 2022
Merged
[scripts] created bootstrap script for ZAP #22757
Damian-Nordic
merged 1 commit into
project-chip:master
from
markaj-nordic:zap_scripts_refinement
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
September 20, 2022 09:54
pullapprove
bot
requested review from
selissia,
vivien-apple,
tcarmelveilleux,
wbschiller,
tecimovic,
woody-apple,
turon,
xylophone21,
vijs and
yufengwangca
September 22, 2022 10:10
bzbarsky-apple
approved these changes
Sep 22, 2022
I see the ZAP template generation CI is failing. Need to fix that. |
LuDuda
approved these changes
Sep 23, 2022
markaj-nordic
force-pushed
the
zap_scripts_refinement
branch
from
September 29, 2022 10:28
6f645da
to
5428de5
Compare
PR #22757: Size comparison from 57c7321 to 5428de5 Increases (7 builds for bl602, bl702, telink)
Full report (16 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
markaj-nordic
force-pushed
the
zap_scripts_refinement
branch
from
September 29, 2022 11:03
5428de5
to
1f4a2da
Compare
PR #22757: Size comparison from 57c7321 to 1f4a2da Increases (4 builds for bl602, bl702, psoc6)
Decreases (3 builds for esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Sep 29, 2022
andy31415
approved these changes
Sep 29, 2022
Extracted bootstrap code from run_zaptool.sh and reuse it in other Python scripts. This allows to run ZAP convert/generate tools out of the box without necessity to run zaptool beforehand. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
markaj-nordic
force-pushed
the
zap_scripts_refinement
branch
from
October 4, 2022 12:49
1f4a2da
to
502a009
Compare
PR #22757: Size comparison from b44263f to 502a009 Increases (3 builds for esp32, psoc6, telink)
Decreases (5 builds for bl602, bl702, nrfconnect, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
Extracted the ZAP tool bootstrap code from the
run_zaptool.sh
and populated it in the standalone scripts.Testing
Tested on a pure Ubuntu 20.04 by cloning chip repo and running:
generate.py
convert.py
zap_regen_all.py
zap_convert_all.py
without running zaptool before. As a result all required nodejs packets are installed and the scripts run properly.