Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[privacy] Implement privacy decrypt support in message layer #22783

Merged
merged 21 commits into from
Jan 23, 2023
Merged

[privacy] Implement privacy decrypt support in message layer #22783

merged 21 commits into from
Jan 23, 2023

Conversation

turon
Copy link
Contributor

@turon turon commented Sep 20, 2022

Issue Being Resolved

Change overview

Adds support for privacy decryption of group messages per spec.
Includes unit test to verify the feature.

turon added 16 commits January 19, 2023 17:49
@turon
[privacy] Remove negative PrivacyDecrypt testVectors.
fecbcc7
@turon
[restyle]
c264461
@turon
[privacy] Fix type conversion issue in CI.
5e36fdf
@turon
[privacy] rebase
a33082a
@turon
[privacy] Update message header codec tests to test P-flag.
3991869
@turon
[privacy] Remove superfluous comments.
e61c215
@turon
[test] Add negative test capability and tests for wrong MIC.
aecd02b
@turon
[test] Add test for dropping pase / secure unicast when privacy enabled.
03bd0b8
@turon
[test] Add test for dropping private group message with wrong MIC.
df04c8f
@turon
[privacy] Resolve review comments.
c0f5a29
@turon
[privacy] Split per-key processing into dedicated static function.
b2829fd
@turon
[privacy] Add test case for CHIP_CONFIG_PRIVACY_ACCEPT_NONSPEC_SVE2.
2acf243
@turon
[privacy][test] Update name of unit test for group replay protection.
4c431bc
@turon
[privacy] Make PacketHeader::PrivacyHeader a utility function.
1e72bd4
@turon
[privacy] Resolve comments by bzbarsky-apple.
bf24fb6
@turon
[privacy] Fixed const and partialPacketHeader naming.
2486fe0
robszewczyk
robszewczyk approved these changes Jan 20, 2023
View reviewed changes
src/lib/core/CHIPConfig.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited
Loading

PR #22783: Size comparison from 6648ef2 to 2486fe0

Increases (35 builds for cyw30739, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6648ef2 2486fe0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 584786 585386 600 0.1
.app_xip_area 461132 461732 600 0.1
lock cyw930739m2evb_01 (read/write) 588518 589118 600 0.1
.app_xip_area 459568 460168 600 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549486 550318 832 0.2
.app_xip_area 431320 432152 832 0.2
esp32 all-clusters-app c3devkit (read only) 1220280 1220826 546 0.0
(read/write) 1786730 1786906 176 0.0
.flash.rodata 245256 245432 176 0.1
.flash.text 1220280 1220826 546 0.0
m5stack (read only) 1234167 1234811 644 0.1
(read/write) 559979 560147 168 0.0
.flash.rodata 311060 311228 168 0.1
.flash.text 1228783 1229427 644 0.1
linux all-clusters-app debug (read only) 3121393 3124609 3216 0.1
.rodata 281835 281995 160 0.1
.text 2654690 2657746 3056 0.1
all-clusters-minimal-app debug (read only) 2933585 2936833 3248 0.1
.rodata 280491 280683 192 0.1
.text 2471506 2474562 3056 0.1
bridge-app debug (read only) 2497233 2500449 3216 0.1
.rodata 212544 212704 160 0.1
.text 2112818 2115874 3056 0.1
chip-tool debug (read only) 11483729 11486977 3248 0.0
.rodata 637157 637349 192 0.0
.text 9349316 9352372 3056 0.0
chip-tool-ipv6only arm64 (read only) 10877428 10880372 2944 0.0
(read/write) 695576 695608 32 0.0
.data.rel.ro 639104 639128 24 0.0
.rodata 564084 564244 160 0.0
.text 8666260 8669012 2752 0.0
lighting-app debug+rpc (read only) 2664809 2668025 3216 0.1
.rodata 228512 228672 160 0.1
.text 2259458 2262514 3056 0.1
lock-app debug (read only) 2623537 2626753 3216 0.1
.rodata 244680 244840 160 0.1
.text 2206866 2209922 3056 0.1
ota-provider-app debug (read only) 2197433 2200649 3216 0.1
.rodata 196008 196168 160 0.1
.text 1861426 1864482 3056 0.2
ota-requestor-app debug (read only) 2358913 2362129 3216 0.1
.rodata 202736 202896 160 0.1
.text 2007186 2010242 3056 0.2
shell debug (read only) 2653961 2657177 3216 0.1
.rodata 240018 240178 160 0.1
.text 2254050 2257106 3056 0.1
thermostat-no-ble arm64 (read only) 2479452 2482396 2944 0.1
(read/write) 143016 143032 16 0.0
.data.rel.ro 76632 76656 24 0.0
.rodata 149832 149992 160 0.1
.text 2069024 2071776 2752 0.1
tv-app debug (read only) 3287857 3291073 3216 0.1
.rodata 269464 269624 160 0.1
.text 2823954 2827010 3056 0.1
tv-casting-app debug (read only) 5639409 5642625 3216 0.1
.rodata 361369 361529 160 0.0
.text 4999906 5002962 3056 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2461952 2462888 936 0.0
.text 1424596 1425532 936 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163144 1163964 820 0.1
rodata 132632 132796 164 0.1
text 803556 804220 664 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1364784 1365560 776 0.1
rodata 210116 210284 168 0.1
text 762796 763408 612 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1108968 1109804 836 0.1
rodata 109912 110076 164 0.1
text 772948 773620 672 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1747380 1748276 896 0.1
.debug_abbrev 1247001 1247061 60 0.0
.debug_aranges 111184 111208 24 0.0
.debug_frame 373384 373484 100 0.0
.debug_info 27325031 27342769 17738 0.1
.debug_line 3753075 3755693 2618 0.1
.debug_loc 3642680 3646688 4008 0.1
.debug_ranges 356400 356864 464 0.1
.debug_str 3470057 3470769 712 0.0
.strtab 575120 575666 546 0.1
.symtab 423200 423392 192 0.0
.text 1547680 1548576 896 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1688812 1689708 896 0.1
.debug_abbrev 1232808 1232868 60 0.0
.debug_aranges 110448 110472 24 0.0
.debug_frame 375828 375928 100 0.0
.debug_info 26886603 26904342 17739 0.1
.debug_line 3761872 3764514 2642 0.1
.debug_loc 3626080 3630089 4009 0.1
.debug_ranges 354368 354832 464 0.1
.debug_str 3454863 3455575 712 0.0
.strtab 535500 536046 546 0.1
.symtab 408160 408352 192 0.0
.text 1489880 1490776 896 0.1
light cy8ckit_062s2_43012 (read/write) 1608924 1609820 896 0.1
.debug_abbrev 1067806 1067866 60 0.0
.debug_aranges 102736 102760 24 0.0
.debug_frame 346404 346504 100 0.0
.debug_info 22362517 22379449 16932 0.1
.debug_line 3328379 3330966 2587 0.1
.debug_loc 3327954 3331959 4005 0.1
.debug_ranges 318592 319056 464 0.1
.debug_str 3260660 3261372 712 0.0
.strtab 473441 473987 546 0.1
.symtab 377392 377584 192 0.1
.text 1418168 1419064 896 0.1
lock cy8ckit_062s2_43012 (read/write) 1642956 1643868 912 0.1
.debug_abbrev 1069852 1069912 60 0.0
.debug_aranges 103120 103144 24 0.0
.debug_frame 348204 348304 100 0.0
.debug_info 22580917 22597851 16934 0.1
.debug_line 3329481 3332064 2583 0.1
.debug_loc 3349469 3353578 4109 0.1
.debug_ranges 320448 320912 464 0.1
.debug_str 3277067 3277779 712 0.0
.strtab 476376 476922 546 0.1
.symtab 379216 379408 192 0.1
.text 1447208 1448120 912 0.1
qpg lighting-app qpg6105+debug (read/write) 1147676 1148460 784 0.1
.text 594776 595560 784 0.1
lock-app qpg6105+debug (read/write) 1115020 1115828 808 0.1
.text 562116 562924 808 0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1024752 1025628 876 0.1
text 687932 688636 704 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 963092 963968 876 0.1
text 651224 651928 704 0.1
contact-sensor-app tlsr9518adk80d (read/write) 867724 868600 876 0.1
text 581720 582424 704 0.1
light-switch-app tlsr9518adk80d (read/write) 884180 885048 868 0.1
text 596326 597028 702 0.1
lighting-app tlsr9518adk80d (read/write) 962532 963408 876 0.1
text 662338 663042 704 0.1
ota-requestor-app tlsr9518adk80d (read/write) 898020 898896 876 0.1
text 607444 608146 702 0.1
thermostat tlsr9518adk80d (read/write) 887404 888280 876 0.1
text 597086 597792 706 0.1
Full report (35 builds for cyw30739, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6648ef2 2486fe0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 584786 585386 600 0.1
.app_xip_area 461132 461732 600 0.1
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588518 589118 600 0.1
.app_xip_area 459568 460168 600 0.1
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549486 550318 832 0.2
.app_xip_area 431320 432152 832 0.2
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1220280 1220826 546 0.0
(read/write) 1786730 1786906 176 0.0
.dram0.bss 75824 75824 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245256 245432 176 0.1
.flash.text 1220280 1220826 546 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1234167 1234811 644 0.1
(read/write) 559979 560147 168 0.0
.dram0.bss 80976 80976 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311060 311228 168 0.1
.flash.text 1228783 1229427 644 0.1
.iram0.text 124803 124803 0 0.0
linux all-clusters-app debug (read only) 3121393 3124609 3216 0.1
(read/write) 153008 153008 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 81688 81688 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 281835 281995 160 0.1
.text 2654690 2657746 3056 0.1
all-clusters-minimal-app debug (read only) 2933585 2936833 3248 0.1
(read/write) 146416 146416 0 0.0
.bss 61600 61600 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76104 76104 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280491 280683 192 0.1
.text 2471506 2474562 3056 0.1
bridge-app debug (read only) 2497233 2500449 3216 0.1
(read/write) 130976 130976 0 0.0
.bss 52512 52512 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68712 68712 0 0.0
.dynamic 608 608 0 0.0
.got 4608 4608 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212544 212704 160 0.1
.text 2112818 2115874 3056 0.1
chip-tool debug (read only) 11483729 11486977 3248 0.0
(read/write) 646256 646256 0 0.0
.bss 26168 26168 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 610288 610288 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 637157 637349 192 0.0
.text 9349316 9352372 3056 0.0
chip-tool-ipv6only arm64 (read only) 10877428 10880372 2944 0.0
(read/write) 695576 695608 32 0.0
.bss 34168 34168 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 639104 639128 24 0.0
.dynamic 560 560 0 0.0
.got 14104 14104 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 564084 564244 160 0.0
.text 8666260 8669012 2752 0.0
lighting-app debug+rpc (read only) 2664809 2668025 3216 0.1
(read/write) 130312 130312 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 71848 71848 0 0.0
.dynamic 608 608 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228512 228672 160 0.1
.text 2259458 2262514 3056 0.1
lock-app debug (read only) 2623537 2626753 3216 0.1
(read/write) 125360 125360 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 68824 68824 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244680 244840 160 0.1
.text 2206866 2209922 3056 0.1
ota-provider-app debug (read only) 2197433 2200649 3216 0.1
(read/write) 105104 105104 0 0.0
.bss 46592 46592 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51320 51320 0 0.0
.dynamic 608 608 0 0.0
.got 3736 3736 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196168 160 0.1
.text 1861426 1864482 3056 0.2
ota-requestor-app debug (read only) 2358913 2362129 3216 0.1
(read/write) 112800 112800 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 56088 56088 0 0.0
.dynamic 608 608 0 0.0
.got 3736 3736 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202736 202896 160 0.1
.text 2007186 2010242 3056 0.2
shell debug (read only) 2653961 2657177 3216 0.1
(read/write) 137504 137504 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 72568 72568 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 240018 240178 160 0.1
.text 2254050 2257106 3056 0.1
thermostat-no-ble arm64 (read only) 2479452 2482396 2944 0.1
(read/write) 143016 143032 16 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76656 24 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149832 149992 160 0.1
.text 2069024 2071776 2752 0.1
tv-app debug (read only) 3287857 3291073 3216 0.1
(read/write) 259344 259344 0 0.0
.bss 170776 170776 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 77952 77952 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 269464 269624 160 0.1
.text 2823954 2827010 3056 0.1
tv-casting-app debug (read only) 5639409 5642625 3216 0.1
(read/write) 160792 160792 0 0.0
.bss 52344 52344 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 99880 99880 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 361369 361529 160 0.0
.text 4999906 5002962 3056 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461952 2462888 936 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424596 1425532 936 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1163144 1163964 820 0.1
bss 146736 146736 0 0.0
rodata 132632 132796 164 0.1
text 803556 804220 664 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1364784 1365560 776 0.1
bss 106036 106036 0 0.0
rodata 210116 210284 168 0.1
text 762796 763408 612 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108968 1109804 836 0.1
bss 145939 145939 0 0.0
rodata 109912 110076 164 0.1
text 772948 773620 672 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842032 842032 0 0.0
(read/write) 1747380 1748276 896 0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188648 188648 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247001 1247061 60 0.0
.debug_aranges 111184 111208 24 0.0
.debug_frame 373384 373484 100 0.0
.debug_info 27325031 27342769 17738 0.1
.debug_line 3753075 3755693 2618 0.1
.debug_loc 3642680 3646688 4008 0.1
.debug_ranges 356400 356864 464 0.1
.debug_str 3470057 3470769 712 0.0
.heap 842032 842032 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575120 575666 546 0.1
.symtab 423200 423392 192 0.0
.text 1547680 1548576 896 0.1
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842800 842800 0 0.0
(read/write) 1688812 1689708 896 0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187888 187888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1232808 1232868 60 0.0
.debug_aranges 110448 110472 24 0.0
.debug_frame 375828 375928 100 0.0
.debug_info 26886603 26904342 17739 0.1
.debug_line 3761872 3764514 2642 0.1
.debug_loc 3626080 3630089 4009 0.1
.debug_ranges 354368 354832 464 0.1
.debug_str 3454863 3455575 712 0.0
.heap 842800 842800 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535500 536046 546 0.1
.symtab 408160 408352 192 0.0
.text 1489880 1490776 896 0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608924 1609820 896 0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067806 1067866 60 0.0
.debug_aranges 102736 102760 24 0.0
.debug_frame 346404 346504 100 0.0
.debug_info 22362517 22379449 16932 0.1
.debug_line 3328379 3330966 2587 0.1
.debug_loc 3327954 3331959 4005 0.1
.debug_ranges 318592 319056 464 0.1
.debug_str 3260660 3261372 712 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473441 473987 546 0.1
.symtab 377392 377584 192 0.1
.text 1418168 1419064 896 0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642956 1643868 912 0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069852 1069912 60 0.0
.debug_aranges 103120 103144 24 0.0
.debug_frame 348204 348304 100 0.0
.debug_info 22580917 22597851 16934 0.1
.debug_line 3329481 3332064 2583 0.1
.debug_loc 3349469 3353578 4109 0.1
.debug_ranges 320448 320912 464 0.1
.debug_str 3277067 3277779 712 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476376 476922 546 0.1
.symtab 379216 379408 192 0.1
.text 1447208 1448120 912 0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147676 1148460 784 0.1
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 594776 595560 784 0.1
lock-app qpg6105+debug (read/write) 1115020 1115828 808 0.1
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562116 562924 808 0.1
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1024752 1025628 876 0.1
bss 98172 98172 0 0.0
text 687932 688636 704 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963092 963968 876 0.1
bss 97360 97360 0 0.0
text 651224 651928 704 0.1
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867724 868600 876 0.1
bss 89524 89524 0 0.0
text 581720 582424 704 0.1
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884180 885048 868 0.1
bss 89620 89620 0 0.0
text 596326 597028 702 0.1
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 962532 963408 876 0.1
bss 97676 97676 0 0.0
text 662338 663042 704 0.1
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898020 898896 876 0.1
bss 90568 90568 0 0.0
text 607444 608146 702 0.1
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887404 888280 876 0.1
bss 91008 91008 0 0.0
text 597086 597792 706 0.1

@bzbarsky-apple bzbarsky-apple dismissed woody-apple’s stale review January 20, 2023 21:48

The compat issue has been addressed: the new code is backwards-compatible with the old.

@turon turon mentioned this pull request Jan 21, 2023
Open
@andy31415 andy31415 merged commit ebd0d29 into project-chip:master Jan 23, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@turon
[privacy] Implement privacy decrypt support in message layer (project…
ebf1453 
…-chip#22783)

* [session][test] Add short payload secure unicast message test vector.

* [privacy] Add privacy parsing to message layer.

[test] Add test of private group.

* [privacy] test vector passes decrypt, but fails message counter.

* [privacy] Remove negative PrivacyDecrypt testVectors.

* [restyle]

* [privacy] Fix type conversion issue in CI.

* [privacy] rebase

* [privacy] Update message header codec tests to test P-flag.

* [privacy] Remove superfluous comments.

* [test] Add negative test capability and tests for wrong MIC.

* [test] Add test for dropping pase / secure unicast when privacy enabled.

* [test] Add test for dropping private group message with wrong MIC.

* [privacy] Resolve review comments.

* [privacy] Split per-key processing into dedicated static function.

* [privacy] Add test case for CHIP_CONFIG_PRIVACY_ACCEPT_NONSPEC_SVE2.

* [privacy][test] Update name of unit test for group replay protection.

* [privacy] Make PacketHeader::PrivacyHeader a utility function.

* [privacy] Resolve comments by bzbarsky-apple.

* [privacy] Fixed const and partialPacketHeader naming.

* [privacy] Fixed doc error - mismatched param name.

* [privacy] Add issue ref to TODO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@robszewczyk robszewczyk robszewczyk approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@woody-apple woody-apple Awaiting requested review from woody-apple

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

Assignees
No one assigned
Labels
core lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[groups] privacy feature not implemented
8 participants
@turon @mrjerryjohns @tcarmelveilleux @robszewczyk @woody-apple @bzbarsky-apple @jmartinez-silabs @andy31415