-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix telink examples on vscode image #22911
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_telink_examples_on_vscode_image
Sep 27, 2022
Merged
Fix telink examples on vscode image #22911
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_telink_examples_on_vscode_image
Sep 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22911: Size comparison from ba344ce to 2cf7b68 Increases (6 builds for bl702, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, esp32, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cpagravel
pushed a commit
to cpagravel/connectedhomeip
that referenced
this pull request
Sep 30, 2022
* Fix telink builds on vscode: force more env variables set * Fix unit tests
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
* Fix telink builds on vscode: force more env variables set * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building:
This was failing with
Assertion failed: GNUARMEMB_TOOLCHAIN_PATH is not set
From what I could tell, this is due to ZEPHYR_TOOLCHAIN_VARIANT not having been set during the build phase. I have moved the ZEPHYR_TOOLCHAIN_VARIANT and ZEPHYR_BASE to be both set during both build and generation phases (was generation only before)