Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove groups cluster from lock endpoint on lock-app #22954

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

mykrupp
Copy link
Contributor

@mykrupp mykrupp commented Sep 29, 2022

Fixes #22183

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

PR #22954: Size comparison from baff1a7 to ddba254

Increases above 0.2%:

platform target config section baff1a7 ddba254 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 170688 173512 2824 1.7
lock-mtd LP_CC2652R7 (read/write) 182484 185348 2864 1.6
Increases (7 builds for bl702, cc13x2_26x2, efr32, esp32, psoc6, qpg)
platform target config section baff1a7 ddba254 change % change
bl702 lighting-app bl702 .debug_info 37899568 37899569 1 0.0
.text 956552 956554 2 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 170688 173512 2824 1.7
lock-mtd LP_CC2652R7 (read/write) 182484 185348 2864 1.6
efr32 lighting-app BRD4161A+rpc (read/write) 973724 973740 16 0.0
.text 820408 820424 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1788054 1788062 8 0.0
.flash.rodata 257624 257632 8 0.0
psoc6 lock cy8ckit_062s2_43012 (read only) 845864 845880 16 0.0
.heap 845864 845880 16 0.0
qpg lighting-app qpg6105+debug (read/write) 1148528 1148536 8 0.0
.text 595624 595632 8 0.0
Decreases (15 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, mbed, psoc6, qpg, telink)
platform target config section baff1a7 ddba254 change % change
bl602 lighting-app bl602 .text 1068356 1068354 -2 -0.0
bl602+rpc .text 1099704 1099702 -2 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 678015 675175 -2840 -0.4
.bss 78484 78468 -16 -0.0
.rodata 77231 77071 -160 -0.2
.text 600304 597624 -2680 -0.4
lock-mtd LP_CC2652R7 (read only) 661907 659027 -2880 -0.4
.bss 74172 74156 -16 -0.0
.rodata 103099 102939 -160 -0.2
.text 558328 555608 -2720 -0.5
cyw30739 lock cyw930739m2evb_01 (read/write) 594354 591546 -2808 -0.5
.app_xip_area 465684 462884 -2800 -0.6
.bss 71096 71088 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1151372 1147956 -3416 -0.3
.bss 152248 152232 -16 -0.0
.text 997032 993632 -3400 -0.3
k32w lock k32w0+release (read/write) 706832 703968 -2864 -0.4
.bss 71160 71152 -8 -0.0
.text 630868 628012 -2856 -0.5
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2455648 2451728 -3920 -0.2
.bss 215044 215028 -16 -0.0
.text 1418292 1414372 -3920 -0.3
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26821647 26821646 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26558429 26558428 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22022610 22022609 -1 -0.0
lock cy8ckit_062s2_43012 (read/write) 1643356 1639396 -3960 -0.2
.bss 185008 184992 -16 -0.0
.debug_abbrev 1062744 1057428 -5316 -0.5
.debug_aranges 104168 103896 -272 -0.3
.debug_frame 349560 348628 -932 -0.3
.debug_info 22401976 22261214 -140762 -0.6
.debug_line 3268207 3257354 -10853 -0.3
.debug_loc 3308436 3297157 -11279 -0.3
.debug_ranges 306216 304816 -1400 -0.5
.debug_str 3261783 3253842 -7941 -0.2
.strtab 476186 472353 -3833 -0.8
.symtab 379152 377584 -1568 -0.4
.text 1447488 1443544 -3944 -0.3
qpg lock-app qpg6105+debug (read/write) 1116432 1113576 -2856 -0.3
.bss 106380 106364 -16 -0.0
.text 563532 560676 -2856 -0.5
telink light-switch-app tlsr9518adk80d text 574576 574574 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 844564 844556 -8 -0.0
text 598978 598976 -2 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section baff1a7 ddba254 change % change
bl602 lighting-app bl602 (read/write) 1388754 1388754 0 0.0
.bss 90729 90729 0 0.0
.data 9928 9928 0 0.0
.text 1068356 1068354 -2 -0.0
bl602+rpc (read/write) 1433966 1433966 0 0.0
.bss 98161 98161 0 0.0
.data 10312 10312 0 0.0
.text 1099704 1099702 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1187963 1187963 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67094 67094 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506903 1506903 0 0.0
.debug_aranges 133080 133080 0 0.0
.debug_frame 486372 486372 0 0.0
.debug_info 37899568 37899569 1 0.0
.debug_line 5252792 5252792 0 0.0
.debug_loc 3364396 3364396 0 0.0
.debug_ranges 359104 359104 0 0.0
.debug_str 3456111 3456111 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116536 116536 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564835 564835 0 0.0
.symtab 171584 171584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956552 956554 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283883 1283883 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75142 75142 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644448 1644448 0 0.0
.debug_aranges 140584 140584 0 0.0
.debug_frame 511748 511748 0 0.0
.debug_info 41806179 41806179 0 0.0
.debug_line 5627327 5627327 0 0.0
.debug_loc 3557140 3557140 0 0.0
.debug_ranges 381560 381560 0 0.0
.debug_str 3852011 3852011 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129928 129928 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624008 624008 0 0.0
.symtab 189392 189392 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030256 1030256 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676491 676491 0 0.0
(read/write) 175044 175044 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89547 89547 0 0.0
.text 586632 586632 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640739 640739 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78683 78683 0 0.0
.text 561736 561736 0 0.0
lock-ftd LP_CC2652R7 (read only) 678015 675175 -2840 -0.4
(read/write) 170688 173512 2824 1.7
.bss 78484 78468 -16 -0.0
.data 3304 3304 0 0.0
.rodata 77231 77071 -160 -0.2
.text 600304 597624 -2680 -0.4
lock-mtd LP_CC2652R7 (read only) 661907 659027 -2880 -0.4
(read/write) 182484 185348 2864 1.6
.bss 74172 74156 -16 -0.0
.data 3304 3304 0 0.0
.rodata 103099 102939 -160 -0.2
.text 558328 555608 -2720 -0.5
pump-app LP_CC2652R7 (read only) 687339 687339 0 0.0
(read/write) 162068 162068 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90531 90531 0 0.0
.text 596324 596324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671839 671839 0 0.0
(read/write) 177680 177680 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86087 86087 0 0.0
.text 585272 585272 0 0.0
shell LP_CC2652R7 (read only) 667542 667542 0 0.0
(read/write) 186304 186304 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86262 86262 0 0.0
.text 580964 580964 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587290 587290 0 0.0
.app_xip_area 463948 463948 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594354 591546 -2808 -0.5
.app_xip_area 465684 462884 -2800 -0.6
.bss 71096 71088 -8 -0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543282 543282 0 0.0
.app_xip_area 424964 424964 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110568 1110568 0 0.0
.bss 136532 136532 0 0.0
.data 2072 2072 0 0.0
.text 971944 971944 0 0.0
BRD4161A+rpc (read/write) 973724 973740 16 0.0
.bss 151044 151044 0 0.0
.data 2252 2252 0 0.0
.text 820408 820424 16 0.0
BRD4161A+rs911x (read/write) 1003856 1003856 0 0.0
.bss 169368 169368 0 0.0
.data 2064 2064 0 0.0
.text 832404 832404 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151372 1147956 -3416 -0.3
.bss 152248 152232 -16 -0.0
.data 2072 2072 0 0.0
.text 997032 993632 -3400 -0.3
window-app BRD4161A (read/write) 1102576 1102576 0 0.0
.bss 137980 137980 0 0.0
.data 2096 2096 0 0.0
.text 962480 962480 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222930 1222930 0 0.0
(read/write) 1788054 1788062 8 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257624 257632 8 0.0
.flash.text 1222930 1222930 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233023 1233023 0 0.0
(read/write) 563948 563948 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314680 314680 0 0.0
.flash.text 1227639 1227639 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649908 649908 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574400 574400 0 0.0
lock k32w0+release (read/write) 706832 703968 -2864 -0.4
.bss 71160 71152 -8 -0.0
.data 2076 2076 0 0.0
.text 630868 628012 -2856 -0.5
linux chip-tool-ipv6only arm64 (read only) 10422508 10422508 0 0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 517404 517404 0 0.0
.text 8251124 8251124 0 0.0
thermostat-no-ble arm64 (read only) 2387428 2387428 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143644 143644 0 0.0
.text 2001488 2001488 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455648 2451728 -3920 -0.2
.bss 215044 215028 -16 -0.0
.data 5872 5872 0 0.0
.text 1418292 1414372 -3920 -0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182863 1182863 0 0.0
bss 144433 144433 0 0.0
rodata 144208 144208 0 0.0
text 815304 815304 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161531 1161531 0 0.0
bss 143660 143660 0 0.0
rodata 135780 135780 0 0.0
text 803196 803196 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1744340 1744340 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229470 1229470 0 0.0
.debug_aranges 111816 111816 0 0.0
.debug_frame 373328 373328 0 0.0
.debug_info 26821647 26821646 -1 -0.0
.debug_line 3668858 3668858 0 0.0
.debug_loc 3582935 3582935 0 0.0
.debug_ranges 338928 338928 0 0.0
.debug_str 3439783 3439783 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569480 569480 0 0.0
.symtab 421040 421040 0 0.0
.text 1544576 1544576 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1686948 1686948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221269 1221269 0 0.0
.debug_aranges 111288 111288 0 0.0
.debug_frame 376408 376408 0 0.0
.debug_info 26558429 26558428 -1 -0.0
.debug_line 3689574 3689574 0 0.0
.debug_loc 3570572 3570572 0 0.0
.debug_ranges 337544 337544 0 0.0
.debug_str 3428796 3428796 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533569 533569 0 0.0
.symtab 407472 407472 0 0.0
.text 1487920 1487920 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605476 1605476 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055325 1055325 0 0.0
.debug_aranges 103496 103496 0 0.0
.debug_frame 346736 346736 0 0.0
.debug_info 22022610 22022609 -1 -0.0
.debug_line 3259490 3259490 0 0.0
.debug_loc 3268547 3268547 0 0.0
.debug_ranges 302872 302872 0 0.0
.debug_str 3234328 3234328 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469946 469946 0 0.0
.symtab 375920 375920 0 0.0
.text 1414640 1414640 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845864 845880 16 0.0
(read/write) 1643356 1639396 -3960 -0.2
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 184992 -16 -0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062744 1057428 -5316 -0.5
.debug_aranges 104168 103896 -272 -0.3
.debug_frame 349560 348628 -932 -0.3
.debug_info 22401976 22261214 -140762 -0.6
.debug_line 3268207 3257354 -10853 -0.3
.debug_loc 3308436 3297157 -11279 -0.3
.debug_ranges 306216 304816 -1400 -0.5
.debug_str 3261783 3253842 -7941 -0.2
.heap 845864 845880 16 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476186 472353 -3833 -0.8
.symtab 379152 377584 -1568 -0.4
.text 1447488 1443544 -3944 -0.3
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148528 1148536 8 0.0
.bss 110548 110548 0 0.0
.data 868 868 0 0.0
.text 595624 595632 8 0.0
lock-app qpg6105+debug (read/write) 1116432 1113576 -2856 -0.3
.bss 106380 106364 -16 -0.0
.data 872 872 0 0.0
.text 563532 560676 -2856 -0.5
telink light-switch-app tlsr9518adk80d (read/write) 814500 814500 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574576 574574 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 836604 836604 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592794 592794 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844564 844556 -8 -0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598978 598976 -2 -0.0

@selissia selissia merged commit 35703fc into project-chip:master Sep 30, 2022
sharad-patil24 pushed a commit to sharad-patil24/connectedhomeip that referenced this pull request Sep 30, 2022
)

* remove groups cluster from lock endpoint on lock-app

* Restyled by whitespace

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SV2] Door Lock Zap File Enables Groups Cluster
4 participants