-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zephyr] remove BLE advertisement rerun flag #23006
Merged
andy31415
merged 2 commits into
project-chip:master
from
deveritec-rosc:unused_variable_error_zephyr
Oct 6, 2022
Merged
[Zephyr] remove BLE advertisement rerun flag #23006
andy31415
merged 2 commits into
project-chip:master
from
deveritec-rosc:unused_variable_error_zephyr
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23006: Size comparison from b44263f to 605f549 Increases (3 builds for psoc6, telink)
Decreases (2 builds for bl702, nrfconnect)
Full report (45 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign CLA and fix restyled issues.
@deveritec-rosc - please sign the CLA |
andy31415
approved these changes
Oct 4, 2022
If present, debug builds will fail with `unused-variable`-error by the compiler. Code which used the variable was removed with cba92c0.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
msandstedt
October 6, 2022 07:40
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
October 6, 2022 07:40
*fixed |
PR #23006: Size comparison from 55b0a19 to d0d7d98 Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Full report (46 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If present, debug builds (using the Zephyr config
CONFIG_DEBUG
) will fail withunused-variable
-error by the compiler. Since not used anymore,isAdvertisingRerun
can be deleted.Code which used the variable was removed with cba92c0.