Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick][EFR32] Implement the CommisionableData Provider (#22705) #23072

Merged
merged 2 commits into from
Oct 7, 2022
Merged

[Cherry-pick][EFR32] Implement the CommisionableData Provider (#22705) #23072

merged 2 commits into from
Oct 7, 2022

Conversation

jmartinez-silabs
Copy link
Member

This is a Cherry-pick of #22705 (merged in master) to v1.0-branch.

This CP only affects the EFR32 platforms

@jmartinez-silabs
[EFR32] Implement the CommisionableData Provider (project-chip#22705)
db8cd42 
* WIP

* WIP Add the Commisionable Data provide to the ligthing-app

* Fix reading potential garbage bytes. Create python script to inject commissionable data to a efr32 device

* Add EFR32CommissinableDataProvider to all silabs examples. Add a fallback to use TEST_SETUP_VALUES if credentials are not found in nvm3. Add a Readme for the provider script.

* Fix typo and add a subscript in the readme.md

* Create a class and remove the use of global variables. Fix other comments

* fix merge conflict, run restyle

* Remove Passcode storing, Instead store qrcode bitset payload. Support deviceInstanceInfoProvider, augment FactoryDataProvider and add checks

* Add commissioning flow and rendez-vous flag args to the factoryDataProvider script

* fix build issue

* Enable EFR32DeviceDataProvider for the wifi platform examples also

* address last few comments
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

PR #23072: Size comparison from c50094a to 2088d84

Increases (20 builds for bl602, bl702, cc13x2_26x2, k32w, linux, nrfconnect, qpg, telink)
platform target config section c50094a 2088d84 change % change
bl602 lighting-app bl602 (read/write) 1388526 1388550 24 0.0
.text 1068290 1068316 26 0.0
bl602+rpc (read/write) 1433738 1433762 24 0.0
.text 1099636 1099664 28 0.0
bl702 lighting-app bl702 (read/write) 1188507 1188539 32 0.0
.debug_aranges 133160 133168 8 0.0
.debug_frame 486636 486676 40 0.0
.debug_info 37899273 37899319 46 0.0
.debug_line 5256254 5256312 58 0.0
.debug_loc 3363557 3363591 34 0.0
.debug_ranges 359928 359936 8 0.0
.debug_str 3456520 3456569 49 0.0
.strtab 565136 565170 34 0.0
.symtab 171840 171856 16 0.0
.text 957104 957132 28 0.0
bl702+rpc (read/write) 1284419 1284451 32 0.0
.debug_aranges 140664 140672 8 0.0
.debug_frame 512012 512052 40 0.0
.debug_info 41805889 41805937 48 0.0
.debug_line 5630789 5630847 58 0.0
.debug_loc 3556237 3556271 34 0.0
.debug_ranges 382384 382392 8 0.0
.debug_str 3852487 3852536 49 0.0
.strtab 624309 624343 34 0.0
.symtab 189648 189664 16 0.0
.text 1030810 1030838 28 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676595 676619 24 0.0
.text 586680 586704 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640835 640859 24 0.0
.text 561776 561800 24 0.0
lock-ftd LP_CC2652R7 (read only) 678119 678143 24 0.0
.text 600352 600376 24 0.0
lock-mtd LP_CC2652R7 (read only) 661947 661971 24 0.0
.text 558344 558368 24 0.0
pump-app LP_CC2652R7 (read only) 687275 687307 32 0.0
.text 596284 596316 32 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671815 32 0.0
.text 585240 585272 32 0.0
k32w light k32w0+release (read/write) 641400 641416 16 0.0
.text 561792 561808 16 0.0
lock k32w0+release (read/write) 635512 635544 32 0.0
.text 555104 555136 32 0.0
linux thermostat-no-ble arm64 (read only) 2388644 2388692 48 0.0
.text 2001680 2001728 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182051 1182083 32 0.0
text 815276 815304 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160703 1160719 16 0.0
text 803144 803168 24 0.0
qpg lighting-app qpg6105+debug (read/write) 1148116 1148140 24 0.0
.text 595216 595240 24 0.0
lock-app qpg6105+debug (read/write) 1116036 1116060 24 0.0
.text 563132 563156 24 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813676 813708 32 0.0
text 574574 574610 36 0.0
lighting-app tlsr9518adk80d (read/write) 835780 835820 40 0.0
text 592794 592832 38 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843732 843772 40 0.0
text 598974 599012 38 0.0
Decreases (7 builds for bl702, cc13x2_26x2)
platform target config section c50094a 2088d84 change % change
bl702 lighting-app bl702 .debug_abbrev 1506960 1506948 -12 -0.0
bl702+rpc .debug_abbrev 1644539 1644527 -12 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174940 174916 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 170584 170560 -24 -0.0
lock-mtd LP_CC2652R7 (read/write) 182444 182420 -24 -0.0
pump-app LP_CC2652R7 (read/write) 162132 162100 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177736 177704 -32 -0.0
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section c50094a 2088d84 change % change
bl602 lighting-app bl602 (read/write) 1388526 1388550 24 0.0
.bss 90529 90529 0 0.0
.data 9936 9936 0 0.0
.text 1068290 1068316 26 0.0
bl602+rpc (read/write) 1433738 1433762 24 0.0
.bss 97961 97961 0 0.0
.data 10320 10320 0 0.0
.text 1099636 1099664 28 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188507 1188539 32 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67006 67006 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506960 1506948 -12 -0.0
.debug_aranges 133160 133168 8 0.0
.debug_frame 486636 486676 40 0.0
.debug_info 37899273 37899319 46 0.0
.debug_line 5256254 5256312 58 0.0
.debug_loc 3363557 3363591 34 0.0
.debug_ranges 359928 359936 8 0.0
.debug_str 3456520 3456569 49 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565136 565170 34 0.0
.symtab 171840 171856 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957104 957132 28 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284419 1284451 32 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75038 75038 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644539 1644527 -12 -0.0
.debug_aranges 140664 140672 8 0.0
.debug_frame 512012 512052 40 0.0
.debug_info 41805889 41805937 48 0.0
.debug_line 5630789 5630847 58 0.0
.debug_loc 3556237 3556271 34 0.0
.debug_ranges 382384 382392 8 0.0
.debug_str 3852487 3852536 49 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130008 130008 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624309 624343 34 0.0
.symtab 189648 189664 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030810 1030838 28 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676595 676619 24 0.0
(read/write) 174940 174916 -24 -0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89603 89603 0 0.0
.text 586680 586704 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640835 640859 24 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78739 78739 0 0.0
.text 561776 561800 24 0.0
lock-ftd LP_CC2652R7 (read only) 678119 678143 24 0.0
(read/write) 170584 170560 -24 -0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77287 77287 0 0.0
.text 600352 600376 24 0.0
lock-mtd LP_CC2652R7 (read only) 661947 661971 24 0.0
(read/write) 182444 182420 -24 -0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103123 103123 0 0.0
.text 558344 558368 24 0.0
pump-app LP_CC2652R7 (read only) 687275 687307 32 0.0
(read/write) 162132 162100 -32 -0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90507 90507 0 0.0
.text 596284 596316 32 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671815 32 0.0
(read/write) 177736 177704 -32 -0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86063 86063 0 0.0
.text 585240 585272 32 0.0
shell LP_CC2652R7 (read only) 667614 667614 0 0.0
(read/write) 186232 186232 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 580980 580980 0 0.0
k32w light k32w0+release (read/write) 641400 641416 16 0.0
.bss 74816 74816 0 0.0
.data 2064 2064 0 0.0
.text 561792 561808 16 0.0
lock k32w0+release (read/write) 635512 635544 32 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 555104 555136 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10359148 10359148 0 0.0
(read/write) 706305 706305 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650584 650584 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 504364 504364 0 0.0
.text 8199284 8199284 0 0.0
thermostat-no-ble arm64 (read only) 2388644 2388692 48 0.0
(read/write) 143585 143585 0 0.0
.bss 55361 55361 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144124 144124 0 0.0
.text 2001680 2001728 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455640 2455640 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418284 1418284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182051 1182083 32 0.0
bss 143633 143633 0 0.0
rodata 144196 144196 0 0.0
text 815276 815304 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160703 1160719 16 0.0
bss 142860 142860 0 0.0
rodata 135768 135768 0 0.0
text 803144 803168 24 0.0
qpg lighting-app qpg6105+debug (read/write) 1148116 1148140 24 0.0
.bss 110348 110348 0 0.0
.data 832 832 0 0.0
.text 595216 595240 24 0.0
lock-app qpg6105+debug (read/write) 1116036 1116060 24 0.0
.bss 106172 106172 0 0.0
.data 836 836 0 0.0
.text 563132 563156 24 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813676 813708 32 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574574 574610 36 0.0
lighting-app tlsr9518adk80d (read/write) 835780 835820 40 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592794 592832 38 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843732 843772 40 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598974 599012 38 0.0

@andy31415 andy31415 merged commit 26a054c into project-chip:v1.0-branch Oct 7, 2022
@jmartinez-silabs jmartinez-silabs deleted the CP_dataProvider_v1.0 branch October 7, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app efr32 examples platform scripts test driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinez-silabs @andy31415