-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Add -Wshorten-64-to-32 compiler flag for is_clang #23111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
October 11, 2022 15:49
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 08:27
4446745
to
50ebadd
Compare
PR #23111: Size comparison from 2c9cd92 to 50ebadd Increases (5 builds for bl702, telink)
Full report (8 builds for bl702, mbed, qpg, telink)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 09:20
50ebadd
to
29c99f1
Compare
PR #23111: Size comparison from 2c9cd92 to 29c99f1 Increases (6 builds for bl602, bl702, linux, qpg)
Full report (12 builds for bl602, bl702, k32w, linux, mbed, qpg)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 09:53
29c99f1
to
57733d3
Compare
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 10:34
57733d3
to
c9c7257
Compare
PR #23111: Size comparison from 2c9cd92 to c9c7257 Increases (19 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, linux, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 11:48
c9c7257
to
39a6984
Compare
PR #23111: Size comparison from 2c9cd92 to 39a6984 Increases (7 builds for bl602, bl702, cc13x2_26x2, linux, qpg)
Decreases (1 build for cc13x2_26x2)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 12:41
39a6984
to
53dcedd
Compare
PR #23111: Size comparison from 2c9cd92 to 53dcedd Increases (15 builds for bl602, bl702, cc13x2_26x2, efr32, linux, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 14:15
53dcedd
to
dc0dd36
Compare
PR #23111: Size comparison from 83d5027 to dc0dd36 Increases (2 builds for bl702)
Full report (5 builds for bl702, k32w)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 15:22
dc0dd36
to
44738c4
Compare
PR #23111: Size comparison from 83d5027 to 44738c4 Increases (9 builds for bl602, bl702, linux, psoc6)
Decreases (5 builds for psoc6, telink)
Full report (24 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
Build_Shorten
branch
from
October 13, 2022 16:13
44738c4
to
a62e85e
Compare
PR #23111: Size comparison from bd5956d to a62e85e Increases (13 builds for bl602, bl702, efr32, esp32, linux, psoc6)
Decreases (7 builds for esp32, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 14, 2022
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Oct 17, 2022
andy31415
added a commit
that referenced
this pull request
Oct 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some
uint64_t
are sometimes shortened touint32_t
Changes
This PR adds
-Wshorten-64-to-32
for clang based builds.