-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Regression from #22708. Revert chip::Platform::CopyString… #23231
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_RegressionCopyString
Oct 17, 2022
Merged
[chip-tool] Regression from #22708. Revert chip::Platform::CopyString… #23231
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_RegressionCopyString
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::CopyString to memcpy (it previously uses to be strncpy which was confusing)
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
October 17, 2022 16:51
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple and
xylophone21
October 17, 2022 16:51
bzbarsky-apple
approved these changes
Oct 17, 2022
andy31415
approved these changes
Oct 17, 2022
PR #23231: Size comparison from b96f795 to e090b95 Increases (1 build for cc13x2_26x2)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, nrfconnect, qpg, telink)
|
msandstedt
approved these changes
Oct 17, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…::CopyString to memcpy (it previously uses to be strncpy which was confusing) (project-chip#23231)
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…::CopyString to memcpy (it previously uses to be strncpy which was confusing) (project-chip#23231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to memcpy (it previously uses to be strncpy which was confusing)
Problem
fix #23200