Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Restart commissioning after setting SpakeInfo #23276

Merged
merged 1 commit into from
Oct 26, 2022
Merged

RPC: Restart commissioning after setting SpakeInfo #23276

merged 1 commit into from
Oct 26, 2022

Conversation

rgoliver
Copy link

Problem:
The CommissioningWindowManager now caches the CommssionableDataProvider and breaks rpcs.chip.rpc.Device.SetSpakeInfo, which provides the ability for a test harness to change the spake info temporarily at runtime.

Changed:
Close and reopen the commissioning window after setting the value.

Testing:
Verified changing discriminator and spake info on efr32:

spake2p gen-verifier --pin-code 11223344 --iteration-count 1234 --salt "SaltySalty123456789alksd" -o -
Index,PIN Code,Iteration Count,Salt,Verifier
0,11223344,1234,SaltySalty123456789alksd,DvfoUmF9TFQLpbP1Mp1/m75suEm0OU1XZs++AEI/RWcExlq8fGr/K1K1q2J97qbk4r86Zm4jxcmpr/lEhvTIRdwL3OsPJIGTYfKzu9ydz1YcfQmjZEAHpMpZ7KB4WDQM9Q==

>>> v=base64.b64decode("DvfoUmF9TFQLpbP1Mp1/m75suEm0OU1XZs++AEI/RWcExlq8fGr/K1K1q2J97qbk4r86Zm4jxcmpr/lEhvTIRdwL3OsPJIGTYfKzu9ydz1YcfQmjZEAHpMpZ7KB4WDQM9Q==")
>>> s=base64.b64decode("SaltySalty123456789alksd")
>>> rpcs.chip.rpc.Device.SetPairingInfo(discriminator=123)
>>> rpcs.chip.rpc.Device.SetSpakeInfo(salt=s, iteration_count=1234, verifier=v)
>>> rpcs.chip.rpc.Device.SetPairingState(pairing_enabled=True)

./chip-tool pairing ble-thread 60 hex:$hex 11223344 123

@github-actions
Copy link

PR #23276: Size comparison from d7cd5aa to aea35dd

Increases (3 builds for bl702, telink)
platform target config section d7cd5aa aea35dd change % change
bl702 lighting-app bl702+rpc .debug_info 41815677 41816085 408 0.0
.debug_line 5632517 5632730 213 0.0
.debug_loc 3560376 3560424 48 0.0
.debug_ranges 382024 382072 48 0.0
telink light-switch-app tlsr9518adk80d text 553856 553858 2 0.0
lighting-app tlsr9518adk80d text 565992 565994 2 0.0
Decreases (2 builds for nrfconnect, telink)
platform target config section d7cd5aa aea35dd change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815888 815884 -4 -0.0
telink ota-requestor-app tlsr9518adk80d text 564864 564862 -2 -0.0
Full report (9 builds for bl702, linux, nrfconnect, telink)
platform target config section d7cd5aa aea35dd change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1189219 1189219 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506978 1506978 0 0.0
.debug_aranges 133168 133168 0 0.0
.debug_frame 486752 486752 0 0.0
.debug_info 37909063 37909063 0 0.0
.debug_line 5257986 5257986 0 0.0
.debug_loc 3367729 3367729 0 0.0
.debug_ranges 359568 359568 0 0.0
.debug_str 3458100 3458100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565314 565314 0 0.0
.symtab 171728 171728 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957578 957578 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284883 1284883 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644523 1644523 0 0.0
.debug_aranges 140672 140672 0 0.0
.debug_frame 512124 512124 0 0.0
.debug_info 41815677 41816085 408 0.0
.debug_line 5632517 5632730 213 0.0
.debug_loc 3560376 3560424 48 0.0
.debug_ranges 382024 382072 48 0.0
.debug_str 3854070 3854070 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624487 624487 0 0.0
.symtab 189536 189536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1031024 1031024 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10429700 10429700 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8255988 8255988 0 0.0
thermostat-no-ble arm64 (read only) 2390796 2390796 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2003408 2003408 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183659 1183659 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 815888 815884 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162343 1162343 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803784 803784 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790300 790300 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553856 553858 2 0.0
lighting-app tlsr9518adk80d (read/write) 805532 805532 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 565992 565994 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804416 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 564864 564862 -2 -0.0

@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited
Loading

PR #23276: Size comparison from d7cd5aa to 393f699

Increases (9 builds for bl602, bl702, efr32, esp32, mbed, psoc6, telink)
platform target config section d7cd5aa 393f699 change % change
bl602 lighting-app bl602 .text 1069636 1069638 2 0.0
bl702 lighting-app bl702+rpc (read/write) 1284883 1285139 256 0.0
.debug_info 41815677 41816235 558 0.0
.debug_line 5632517 5632832 315 0.0
.debug_loc 3560376 3560472 96 0.0
.debug_ranges 382024 382104 80 0.0
.text 1031024 1031280 256 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974092 974140 48 0.0
.text 819548 819596 48 0.0
esp32 all-clusters-app c3devkit (read only) 1223648 1223650 2 0.0
.flash.text 1223648 1223650 2 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452200 2452264 64 0.0
.text 1414844 1414908 64 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26574284 26574285 1 0.0
light cy8ckit_062s2_43012 .debug_info 22038006 22038007 1 0.0
telink light-switch-app tlsr9518adk80d text 553856 553858 2 0.0
lighting-app tlsr9518adk80d text 565992 565996 4 0.0
Decreases (2 builds for esp32, qpg)
platform target config section d7cd5aa 393f699 change % change
esp32 all-clusters-app c3devkit (read/write) 1788342 1788334 -8 -0.0
.flash.rodata 257896 257888 -8 -0.0
qpg lock-app qpg6105+debug (read/write) 1113712 1113704 -8 -0.0
.text 560808 560800 -8 -0.0
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section d7cd5aa 393f699 change % change
bl602 lighting-app bl602 (read/write) 1390246 1390246 0 0.0
.bss 90745 90745 0 0.0
.data 9928 9928 0 0.0
.text 1069636 1069638 2 0.0
bl602+rpc (read/write) 1435470 1435470 0 0.0
.bss 98177 98177 0 0.0
.data 10312 10312 0 0.0
.text 1100986 1100986 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189219 1189219 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506978 1506978 0 0.0
.debug_aranges 133168 133168 0 0.0
.debug_frame 486752 486752 0 0.0
.debug_info 37909063 37909063 0 0.0
.debug_line 5257986 5257986 0 0.0
.debug_loc 3367729 3367729 0 0.0
.debug_ranges 359568 359568 0 0.0
.debug_str 3458100 3458100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565314 565314 0 0.0
.symtab 171728 171728 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957578 957578 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284883 1285139 256 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644523 1644523 0 0.0
.debug_aranges 140672 140672 0 0.0
.debug_frame 512124 512124 0 0.0
.debug_info 41815677 41816235 558 0.0
.debug_line 5632517 5632832 315 0.0
.debug_loc 3560376 3560472 96 0.0
.debug_ranges 382024 382104 80 0.0
.debug_str 3854070 3854070 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624487 624487 0 0.0
.symtab 189536 189536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031024 1031280 256 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677359 677359 0 0.0
(read/write) 174200 174200 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89791 89791 0 0.0
.text 587256 587256 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641607 641607 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 78927 78927 0 0.0
.text 562360 562360 0 0.0
lock-ftd LP_CC2652R7 (read only) 675851 675851 0 0.0
(read/write) 172844 172844 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77315 77315 0 0.0
.text 598056 598056 0 0.0
lock-mtd LP_CC2652R7 (read only) 659615 659615 0 0.0
(read/write) 184768 184768 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103135 103135 0 0.0
.text 556000 556000 0 0.0
pump-app LP_CC2652R7 (read only) 688131 688131 0 0.0
(read/write) 161300 161300 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90763 90763 0 0.0
.text 596884 596884 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672455 672455 0 0.0
(read/write) 177072 177072 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86319 86319 0 0.0
.text 585656 585656 0 0.0
shell LP_CC2652R7 (read only) 668382 668382 0 0.0
(read/write) 185496 185496 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86502 86502 0 0.0
.text 581564 581564 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588138 588138 0 0.0
.app_xip_area 464724 464724 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592178 592178 0 0.0
.app_xip_area 463468 463468 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543998 543998 0 0.0
.app_xip_area 425664 425664 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974092 974140 48 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 819548 819596 48 0.0
BRD4161A+rs911x (read/write) 1031448 1031448 0 0.0
.bss 186680 186680 0 0.0
.data 2092 2092 0 0.0
.text 842656 842656 0 0.0
BRD4187C (read/write) 1146348 1146348 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980492 980492 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157056 1157056 0 0.0
.bss 158208 158208 0 0.0
.data 2100 2100 0 0.0
.text 996728 996728 0 0.0
window-app BRD4187C (read/write) 1139568 1139568 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972272 972272 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223648 1223650 2 0.0
(read/write) 1788342 1788334 -8 -0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257896 257888 -8 -0.0
.flash.text 1223648 1223650 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233699 1233699 0 0.0
(read/write) 564252 564252 0 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314952 314952 0 0.0
.flash.text 1228315 1228315 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661284 661284 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563028 563028 0 0.0
light k32w0+release (read/write) 671528 671528 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 591900 591900 0 0.0
lock k32w0+release (read/write) 633092 633092 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552684 552684 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10429700 10429700 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8255988 8255988 0 0.0
thermostat-no-ble arm64 (read only) 2390796 2390796 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2003408 2003408 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452200 2452264 64 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414844 1414908 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183659 1183659 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 815888 815888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162343 1162343 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803784 803784 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745644 1745644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229487 1229487 0 0.0
.debug_aranges 111904 111904 0 0.0
.debug_frame 373628 373628 0 0.0
.debug_info 26837503 26837503 0 0.0
.debug_line 3673331 3673331 0 0.0
.debug_loc 3590250 3590250 0 0.0
.debug_ranges 339704 339704 0 0.0
.debug_str 3441503 3441503 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569882 569882 0 0.0
.symtab 421328 421328 0 0.0
.text 1545864 1545864 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688244 1688244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221286 1221286 0 0.0
.debug_aranges 111376 111376 0 0.0
.debug_frame 376708 376708 0 0.0
.debug_info 26574284 26574285 1 0.0
.debug_line 3694048 3694048 0 0.0
.debug_loc 3577887 3577887 0 0.0
.debug_ranges 338320 338320 0 0.0
.debug_str 3430516 3430516 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533971 533971 0 0.0
.symtab 407760 407760 0 0.0
.text 1489200 1489200 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1606788 1606788 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055397 1055397 0 0.0
.debug_aranges 103584 103584 0 0.0
.debug_frame 347040 347040 0 0.0
.debug_info 22038006 22038007 1 0.0
.debug_line 3263972 3263972 0 0.0
.debug_loc 3275848 3275848 0 0.0
.debug_ranges 303624 303624 0 0.0
.debug_str 3236048 3236048 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470348 470348 0 0.0
.symtab 376208 376208 0 0.0
.text 1415928 1415928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640492 1640492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1057336 1057336 0 0.0
.debug_aranges 103976 103976 0 0.0
.debug_frame 348896 348896 0 0.0
.debug_info 22271296 22271296 0 0.0
.debug_line 3260937 3260937 0 0.0
.debug_loc 3303430 3303430 0 0.0
.debug_ranges 305560 305560 0 0.0
.debug_str 3255446 3255446 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472699 472699 0 0.0
.symtab 377824 377824 0 0.0
.text 1444640 1444640 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148824 1148824 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 595924 595924 0 0.0
lock-app qpg6105+debug (read/write) 1113712 1113704 -8 -0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560808 560800 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 790300 790300 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553856 553858 2 0.0
lighting-app tlsr9518adk80d (read/write) 805532 805532 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 565992 565996 4 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804416 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 564864 564864 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Oct 20, 2022
View reviewed changes
examples/common/pigweed/rpc_services/Device.h Outdated Show resolved Hide resolved
examples/common/pigweed/rpc_services/Device.h Outdated Show resolved Hide resolved
@rgoliver rgoliver force-pushed the restart-spake branch 3 times, most recently from 026c0d4 to 42ff525 Compare October 21, 2022 17:06
@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited
Loading

PR #23276: Size comparison from a325034 to 42ff525

Increases (12 builds for bl602, bl702, cc13x2_26x2, efr32, k32w, mbed, psoc6, telink)
platform target config section a325034 42ff525 change % change
bl602 lighting-app bl602 .text 1069636 1069638 2 0.0
bl602+rpc (read/write) 1435462 1435470 8 0.0
.text 1100984 1100986 2 0.0
bl702 lighting-app bl702+rpc (read/write) 1284883 1285139 256 0.0
.debug_info 41815676 41816275 599 0.0
.debug_line 5632517 5632878 361 0.0
.debug_loc 3560376 3560423 47 0.0
.debug_ranges 382024 382104 80 0.0
.text 1031022 1031278 256 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 641599 641607 8 0.0
.text 562352 562360 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974092 974156 64 0.0
.text 819548 819612 64 0.0
k32w contact k32w0+release (read/write) 661268 661284 16 0.0
.text 563012 563028 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452200 2452264 64 0.0
.text 1414844 1414908 64 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26837501 26837502 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26574283 26574284 1 0.0
light cy8ckit_062s2_43012 .debug_info 22038005 22038007 2 0.0
telink light-switch-app tlsr9518adk80d text 553858 553860 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804424 8 0.0
text 564862 564866 4 0.0
Decreases (5 builds for bl702, cyw30739, esp32, k32w, nrfconnect)
platform target config section a325034 42ff525 change % change
bl702 lighting-app bl702 .debug_info 37909063 37909062 -1 -0.0
.text 957578 957576 -2 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 592178 592170 -8 -0.0
.app_xip_area 463468 463460 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1223652 1223648 -4 -0.0
.flash.text 1223652 1223648 -4 -0.0
k32w lock k32w0+release (read/write) 633092 633076 -16 -0.0
.text 552684 552668 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815888 815884 -4 -0.0
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a325034 42ff525 change % change
bl602 lighting-app bl602 (read/write) 1390246 1390246 0 0.0
.bss 90745 90745 0 0.0
.data 9928 9928 0 0.0
.text 1069636 1069638 2 0.0
bl602+rpc (read/write) 1435462 1435470 8 0.0
.bss 98177 98177 0 0.0
.data 10312 10312 0 0.0
.text 1100984 1100986 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189219 1189219 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506978 1506978 0 0.0
.debug_aranges 133168 133168 0 0.0
.debug_frame 486752 486752 0 0.0
.debug_info 37909063 37909062 -1 -0.0
.debug_line 5257986 5257986 0 0.0
.debug_loc 3367729 3367729 0 0.0
.debug_ranges 359568 359568 0 0.0
.debug_str 3458100 3458100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565314 565314 0 0.0
.symtab 171728 171728 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957578 957576 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284883 1285139 256 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644523 1644523 0 0.0
.debug_aranges 140672 140672 0 0.0
.debug_frame 512124 512124 0 0.0
.debug_info 41815676 41816275 599 0.0
.debug_line 5632517 5632878 361 0.0
.debug_loc 3560376 3560423 47 0.0
.debug_ranges 382024 382104 80 0.0
.debug_str 3854070 3854070 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624487 624487 0 0.0
.symtab 189536 189536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031022 1031278 256 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677359 677359 0 0.0
(read/write) 174200 174200 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89791 89791 0 0.0
.text 587256 587256 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641599 641607 8 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 78927 78927 0 0.0
.text 562352 562360 8 0.0
lock-ftd LP_CC2652R7 (read only) 675851 675851 0 0.0
(read/write) 172844 172844 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77315 77315 0 0.0
.text 598056 598056 0 0.0
lock-mtd LP_CC2652R7 (read only) 659615 659615 0 0.0
(read/write) 184768 184768 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103135 103135 0 0.0
.text 556000 556000 0 0.0
pump-app LP_CC2652R7 (read only) 688131 688131 0 0.0
(read/write) 161300 161300 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90763 90763 0 0.0
.text 596884 596884 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672455 672455 0 0.0
(read/write) 177072 177072 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86319 86319 0 0.0
.text 585656 585656 0 0.0
shell LP_CC2652R7 (read only) 668382 668382 0 0.0
(read/write) 185496 185496 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86502 86502 0 0.0
.text 581564 581564 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588138 588138 0 0.0
.app_xip_area 464724 464724 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592178 592170 -8 -0.0
.app_xip_area 463468 463460 -8 -0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543998 543998 0 0.0
.app_xip_area 425664 425664 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974092 974156 64 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 819548 819612 64 0.0
BRD4161A+rs911x (read/write) 1031640 1031640 0 0.0
.bss 186680 186680 0 0.0
.data 2092 2092 0 0.0
.text 842848 842848 0 0.0
BRD4187C (read/write) 1146348 1146348 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980492 980492 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157248 1157248 0 0.0
.bss 158208 158208 0 0.0
.data 2100 2100 0 0.0
.text 996920 996920 0 0.0
window-app BRD4187C (read/write) 1139568 1139568 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972272 972272 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223652 1223648 -4 -0.0
(read/write) 1788342 1788342 0 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257896 257896 0 0.0
.flash.text 1223652 1223648 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233699 1233699 0 0.0
(read/write) 564252 564252 0 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314952 314952 0 0.0
.flash.text 1228315 1228315 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661268 661284 16 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563012 563028 16 0.0
light k32w0+release (read/write) 671528 671528 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 591900 591900 0 0.0
lock k32w0+release (read/write) 633092 633076 -16 -0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552684 552668 -16 -0.0
linux chip-tool-ipv6only arm64 (read only) 10429700 10429700 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8255988 8255988 0 0.0
thermostat-no-ble arm64 (read only) 2390796 2390796 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2003408 2003408 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452200 2452264 64 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414844 1414908 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183659 1183659 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 815888 815884 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162343 1162343 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803784 803784 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745644 1745644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229487 1229487 0 0.0
.debug_aranges 111904 111904 0 0.0
.debug_frame 373628 373628 0 0.0
.debug_info 26837501 26837502 1 0.0
.debug_line 3673331 3673331 0 0.0
.debug_loc 3590250 3590250 0 0.0
.debug_ranges 339704 339704 0 0.0
.debug_str 3441503 3441503 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569882 569882 0 0.0
.symtab 421328 421328 0 0.0
.text 1545864 1545864 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688244 1688244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221286 1221286 0 0.0
.debug_aranges 111376 111376 0 0.0
.debug_frame 376708 376708 0 0.0
.debug_info 26574283 26574284 1 0.0
.debug_line 3694048 3694048 0 0.0
.debug_loc 3577887 3577887 0 0.0
.debug_ranges 338320 338320 0 0.0
.debug_str 3430516 3430516 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533971 533971 0 0.0
.symtab 407760 407760 0 0.0
.text 1489200 1489200 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1606788 1606788 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055397 1055397 0 0.0
.debug_aranges 103584 103584 0 0.0
.debug_frame 347040 347040 0 0.0
.debug_info 22038005 22038007 2 0.0
.debug_line 3263972 3263972 0 0.0
.debug_loc 3275848 3275848 0 0.0
.debug_ranges 303624 303624 0 0.0
.debug_str 3236048 3236048 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470348 470348 0 0.0
.symtab 376208 376208 0 0.0
.text 1415928 1415928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640492 1640492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1057336 1057336 0 0.0
.debug_aranges 103976 103976 0 0.0
.debug_frame 348896 348896 0 0.0
.debug_info 22271296 22271296 0 0.0
.debug_line 3260937 3260937 0 0.0
.debug_loc 3303430 3303430 0 0.0
.debug_ranges 305560 305560 0 0.0
.debug_str 3255446 3255446 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472699 472699 0 0.0
.symtab 377824 377824 0 0.0
.text 1444640 1444640 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148816 1148816 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 595916 595916 0 0.0
lock-app qpg6105+debug (read/write) 1113704 1113704 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560800 560800 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790300 790300 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553858 553860 2 0.0
lighting-app tlsr9518adk80d (read/write) 805532 805532 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 565992 565992 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804424 8 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 564862 564866 4 0.0

@github-actions
Copy link

PR #23276: Size comparison from 559c7d5 to 752405c

Increases (3 builds for bl702, mbed, telink)
platform target config section 559c7d5 752405c change % change
bl702 lighting-app bl702+rpc (read/write) 1284883 1285139 256 0.0
.debug_info 41815678 41816322 644 0.0
.debug_line 5632517 5632878 361 0.0
.debug_loc 3560376 3560423 47 0.0
.debug_ranges 382024 382104 80 0.0
.text 1031024 1031280 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452200 2452264 64 0.0
.text 1414844 1414908 64 0.0
telink lighting-app tlsr9518adk80d text 565992 565994 2 0.0
Full report (12 builds for bl702, linux, mbed, nrfconnect, qpg, telink)
platform target config section 559c7d5 752405c change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1189219 1189219 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506980 1506980 0 0.0
.debug_aranges 133168 133168 0 0.0
.debug_frame 486752 486752 0 0.0
.debug_info 37909064 37909064 0 0.0
.debug_line 5257986 5257986 0 0.0
.debug_loc 3367729 3367729 0 0.0
.debug_ranges 359568 359568 0 0.0
.debug_str 3458100 3458100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565314 565314 0 0.0
.symtab 171728 171728 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957578 957578 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284883 1285139 256 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644525 1644525 0 0.0
.debug_aranges 140672 140672 0 0.0
.debug_frame 512124 512124 0 0.0
.debug_info 41815678 41816322 644 0.0
.debug_line 5632517 5632878 361 0.0
.debug_loc 3560376 3560423 47 0.0
.debug_ranges 382024 382104 80 0.0
.debug_str 3854070 3854070 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624487 624487 0 0.0
.symtab 189536 189536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1031024 1031280 256 0.0
linux chip-tool-ipv6only arm64 (read only) 10429700 10429700 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518148 518148 0 0.0
.text 8255988 8255988 0 0.0
thermostat-no-ble arm64 (read only) 2390796 2390796 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144484 144484 0 0.0
.text 2003408 2003408 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452200 2452264 64 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414844 1414908 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183659 1183659 0 0.0
bss 144457 144457 0 0.0
rodata 144428 144428 0 0.0
text 815888 815888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162343 1162343 0 0.0
bss 143684 143684 0 0.0
rodata 136000 136000 0 0.0
text 803784 803784 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148824 1148824 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 595924 595924 0 0.0
lock-app qpg6105+debug (read/write) 1113712 1113712 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560808 560808 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790300 790300 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553858 553858 0 0.0
lighting-app tlsr9518adk80d (read/write) 805532 805532 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 565992 565994 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804416 804416 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 564864 564864 0 0.0

RPC: Restart commissioning after setting SpakeInfo
d66541f 
The CommissioningWindowManager now caches the CommssionableDataProvider
and therefore needs to be restarted after changing the SpakeInfo using
the RPC for testing.
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

PR #23276: Size comparison from 0c2f7c6 to d66541f

Increases (13 builds for bl602, bl702, cc13x2_26x2, efr32, mbed, psoc6, qpg, telink)
platform target config section 0c2f7c6 d66541f change % change
bl602 lighting-app bl602 .text 1069916 1069920 4 0.0
bl602+rpc (read/write) 1435814 1436078 264 0.0
.text 1101264 1101522 258 0.0
bl702 lighting-app bl702 .debug_info 37926232 37926233 1 0.0
.text 957998 958000 2 0.0
bl702+rpc (read/write) 1284931 1285187 256 0.0
.debug_info 41833208 4183660 3392 0.0
.debug_line 5631555 5632402 847 0.0
.debug_loc 3559912 3560063 151 0.0
.debug_ranges 381008 381352 344 0.1
.debug_str 3846939 3847090 151 0.0
.text 1031188 1031446 258 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677559 677567 8 0.0
.text 587384 587392 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974292 974436 144 0.0
.text 819748 819892 144 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452400 2452528 128 0.0
.text 1415044 1415172 128 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26859254 26859256 2 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26595884 26595886 2 0.0
light cy8ckit_062s2_43012 .debug_info 22057379 22057380 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22290568 22290569 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1149000 1149008 8 0.0
.text 596100 596108 8 0.0
telink ota-requestor-app tlsr9518adk80d text 565082 565084 2 0.0
Decreases (3 builds for bl702, cc13x2_26x2, esp32)
platform target config section 0c2f7c6 d66541f change % change
bl702 lighting-app bl702+rpc .debug_abbrev 1645361 1645345 -16 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174000 173992 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1223868 1223866 -2 -0.0
.flash.text 1223868 1223866 -2 -0.0
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0c2f7c6 d66541f change % change
bl602 lighting-app bl602 (read/write) 1390598 1390598 0 0.0
.bss 90745 90745 0 0.0
.data 9928 9928 0 0.0
.text 1069916 1069920 4 0.0
bl602+rpc (read/write) 1435814 1436078 264 0.0
.bss 98177 98177 0 0.0
.data 10312 10312 0 0.0
.text 1101264 1101522 258 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189507 1189507 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1507974 1507974 0 0.0
.debug_aranges 132000 132000 0 0.0
.debug_frame 484268 484268 0 0.0
.debug_info 37926232 37926233 1 0.0
.debug_line 5256837 5256837 0 0.0
.debug_loc 3367293 3367293 0 0.0
.debug_ranges 358552 358552 0 0.0
.debug_str 3450962 3450962 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116600 116600 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565413 565413 0 0.0
.symtab 171840 171840 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957998 958000 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284931 1285187 256 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1645361 1645345 -16 -0.0
.debug_aranges 139504 139504 0 0.0
.debug_frame 509640 509640 0 0.0
.debug_info 41833208 4183660 3392 0.0
.debug_line 5631555 5632402 847 0.0
.debug_loc 3559912 3560063 151 0.0
.debug_ranges 381008 381352 344 0.1
.debug_str 3846939 3847090 151 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130008 130008 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624586 624586 0 0.0
.symtab 189648 189648 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031188 1031446 258 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677559 677567 8 0.0
(read/write) 174000 173992 -8 -0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89863 89863 0 0.0
.text 587384 587392 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641815 641815 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 78999 78999 0 0.0
.text 562496 562496 0 0.0
lock-ftd LP_CC2652R7 (read only) 676083 676083 0 0.0
(read/write) 172612 172612 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77387 77387 0 0.0
.text 598216 598216 0 0.0
lock-mtd LP_CC2652R7 (read only) 659807 659807 0 0.0
(read/write) 184576 184576 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103199 103199 0 0.0
.text 556128 556128 0 0.0
pump-app LP_CC2652R7 (read only) 688339 688339 0 0.0
(read/write) 161092 161092 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90835 90835 0 0.0
.text 597020 597020 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672623 672623 0 0.0
(read/write) 176904 176904 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86383 86383 0 0.0
.text 585760 585760 0 0.0
shell LP_CC2652R7 (read only) 668582 668582 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86566 86566 0 0.0
.text 581700 581700 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588242 588242 0 0.0
.app_xip_area 464828 464828 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592290 592290 0 0.0
.app_xip_area 463580 463580 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544198 544198 0 0.0
.app_xip_area 425864 425864 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974292 974436 144 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 819748 819892 144 0.0
BRD4161A+rs911x (read/write) 1031920 1031920 0 0.0
.bss 186680 186680 0 0.0
.data 2092 2092 0 0.0
.text 843128 843128 0 0.0
BRD4187C (read/write) 1146628 1146628 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980772 980772 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157464 1157464 0 0.0
.bss 158208 158208 0 0.0
.data 2100 2100 0 0.0
.text 997136 997136 0 0.0
window-app BRD4187C (read/write) 1139848 1139848 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972552 972552 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223868 1223866 -2 -0.0
(read/write) 1788414 1788414 0 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257968 257968 0 0.0
.flash.text 1223868 1223866 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233823 1233823 0 0.0
(read/write) 564332 564332 0 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315032 315032 0 0.0
.flash.text 1228439 1228439 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661380 661380 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563124 563124 0 0.0
light k32w0+release (read/write) 671712 671712 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592084 592084 0 0.0
lock k32w0+release (read/write) 633188 633188 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552780 552780 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10431188 10431188 0 0.0
(read/write) 706353 706353 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650632 650632 0 0.0
.dynamic 560 560 0 0.0
.got 13896 13896 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518228 518228 0 0.0
.text 8257396 8257396 0 0.0
thermostat-no-ble arm64 (read only) 2391660 2391660 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2004208 2004208 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452400 2452528 128 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415044 1415172 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183871 1183871 0 0.0
bss 144457 144457 0 0.0
rodata 144496 144496 0 0.0
text 816028 816028 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162543 1162543 0 0.0
bss 143684 143684 0 0.0
rodata 136072 136072 0 0.0
text 803916 803916 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745924 1745924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229891 1229891 0 0.0
.debug_aranges 110680 110680 0 0.0
.debug_frame 371092 371092 0 0.0
.debug_info 26859254 26859256 2 0.0
.debug_line 3673060 3673060 0 0.0
.debug_loc 3590923 3590923 0 0.0
.debug_ranges 338736 338736 0 0.0
.debug_str 3434833 3434833 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570130 570130 0 0.0
.symtab 421456 421456 0 0.0
.text 1546144 1546144 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688524 1688524 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221734 1221734 0 0.0
.debug_aranges 110152 110152 0 0.0
.debug_frame 374172 374172 0 0.0
.debug_info 26595884 26595886 2 0.0
.debug_line 3693804 3693804 0 0.0
.debug_loc 3578560 3578560 0 0.0
.debug_ranges 337352 337352 0 0.0
.debug_str 3423854 3423854 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534219 534219 0 0.0
.symtab 407888 407888 0 0.0
.text 1489480 1489480 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607052 1607052 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1056242 1056242 0 0.0
.debug_aranges 102360 102360 0 0.0
.debug_frame 344504 344504 0 0.0
.debug_info 22057379 22057380 1 0.0
.debug_line 3263439 3263439 0 0.0
.debug_loc 3276259 3276259 0 0.0
.debug_ranges 302656 302656 0 0.0
.debug_str 3229374 3229374 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470596 470596 0 0.0
.symtab 376336 376336 0 0.0
.text 1416192 1416192 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640740 1640740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1058226 1058226 0 0.0
.debug_aranges 102752 102752 0 0.0
.debug_frame 346360 346360 0 0.0
.debug_info 22290568 22290569 1 0.0
.debug_line 3260420 3260420 0 0.0
.debug_loc 3303837 3303837 0 0.0
.debug_ranges 304592 304592 0 0.0
.debug_str 3248768 3248768 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472947 472947 0 0.0
.symtab 377952 377952 0 0.0
.text 1444888 1444888 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149000 1149008 8 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 596100 596108 8 0.0
lock-app qpg6105+debug (read/write) 1113888 1113888 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560984 560984 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790588 790588 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554060 554060 0 0.0
lighting-app tlsr9518adk80d (read/write) 805836 805836 0 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 566212 566212 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804728 804728 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565082 565084 2 0.0

@woody-apple woody-apple merged commit a95dd6f into project-chip:master Oct 26, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@adbridge
RPC: Restart commissioning after setting SpakeInfo (project-chip#23276)
4a4891f 
The CommissioningWindowManager now caches the CommssionableDataProvider
and therefore needs to be restarted after changing the SpakeInfo using
the RPC for testing.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@adbridge
RPC: Restart commissioning after setting SpakeInfo (project-chip#23276)
4e4b812 
The CommissioningWindowManager now caches the CommssionableDataProvider
and therefore needs to be restarted after changing the SpakeInfo using
the RPC for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgoliver @tcarmelveilleux @bzbarsky-apple @woody-apple