-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not used CHIP time service config defines #23289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
darwin
efr32
esp32
examples
linux
nrf connect
platform
telink
test driver
zephyr
labels
Oct 21, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
October 21, 2022 11:01
pullapprove
bot
removed
platform
darwin
efr32
esp32
linux
nrf connect
zephyr
telink
test driver
labels
Oct 21, 2022
PR #23289: Size comparison from 66c0270 to e20a3d8 Increases (10 builds for cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for bl702, cc13x2_26x2, cyw30739, k32w, nrfconnect, qpg)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 21, 2022
github-actions
bot
added
darwin
efr32
esp32
examples
linux
nrf connect
platform
telink
test driver
zephyr
labels
Oct 21, 2022
PR #23289: Size comparison from a325034 to a817bc5 Increases (8 builds for cc13x2_26x2, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for nrfconnect, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 21, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Andrei Litvin <andy314@gmail.com>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems that defines related to CHIP Time Sync protocol are not used anywhere (are they obsolete?)
Changes
Removed defines for:
CHIP_DEVICE_CONFIG_ENABLE_CHIP_TIME_SERVICE_TIME_SYNC
CHIP_DEVICE_CONFIG_CHIP_TIME_SERVICE_ENDPOINT_ID
CHIP_DEVICE_CONFIG_DEFAULT_TIME_SYNC_INTERVAL
CHIP_DEVICE_CONFIG_TIME_SYNC_TIMEOUT
Testing
CI will verify that