[EFR32] Link the door lock relock behaviour with the app UI #23331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro and
Damian-Nordic
pullapprove
bot
requested review from
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
bzbarsky-apple
requested changes
Oct 24, 2022
|
PR #23331: Size comparison from db11e29 to e597750 Increases (18 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl602, bl702, cc13x2_26x2, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…r and calls the application callback
jmartinez-silabs
changed the title
|
PR #23331: Size comparison from db11e29 to d9fcef2 Increases (45 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, cc13x2_26x2, cyw30739, k32w, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
selissia
approved these changes
Oct 26, 2022
bzbarsky-apple
approved these changes
Oct 26, 2022
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Nov 2, 2022
…aviour with the app UI (project-chip#23331)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/fix_autorelock to silabs_1.0 Squashed commit of the following: commit 76df32b2d0e6c627545656d9e675c33825f2dab9 Author: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com> Date: Wed Oct 26 17:16:25 2022 -0400 [EFR32] Link the door lock relock behaviour with the app UI (project-chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
rerasool
added a commit
to SiliconLabs/matter
that referenced
this pull request
Nov 2, 2022
…k relock behaviour with the app UI (project-chip#23331)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/fix_autorelock to silabs_1.0 Squashed commit of the following: commit 76df32b2d0e6c627545656d9e675c33825f2dab9 Author: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com> Date: Wed Oct 26 17:16:25 2022 -0400 [EFR32] Link the door lock relock behaviour with the app UI (project-chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The door lock cluster implementation mostly left the callback to be implemented by the app.
However, the relock callback is implemented directly in the cluster server implementation and changes the attribute Lock state directly. Make that callback weak and let an application reimplement it if needed.
Re-Implement the callback in the efr32 application implementation so it updates our UI directly (LCD and LED