[platform] Move more product attributes to DeviceInstanceInfoProvider #23385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
Damian-Nordic
commented
Oct 28, 2022
|
PR #23385: Size comparison from 753cb9c to 27d5995 Increases (19 builds for bl702, cc13x2_26x2, linux, psoc6, qpg)
Decreases (28 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 28, 2022
Vendor and product identifiers were already moved from ConfigurationManager to DeviceInstanceInfoProvider to allow for easier integration with platform factory data providers as they may differ across devices running the same firmware. Somehow PartNumber, ProductURL and ProductLabel slipped unnoticed. Move accessors of these attributes to DeviceInstanceInfoProvider and update all implementations to preserve the existing behavior. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Damian-Nordic
force-pushed
the
partnumberetc
branch
from
27d5995 to
3c48e4d
Compare
|
PR #23385: Size comparison from a99675e to 3c48e4d Increases (6 builds for bl702, linux, qpg)
Decreases (5 builds for bl602, bl702, mbed)
Full report (12 builds for bl602, bl702, k32w, linux, mbed, qpg)
|
Damian-Nordic
force-pushed
the
partnumberetc
branch
from
c0cd26f to
aa8daa7
Compare
|
PR #23385: Size comparison from a99675e to aa8daa7 Increases (9 builds for bl702, cc13x2_26x2, linux, qpg)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, k32w, telink)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, qpg, telink)
|
Damian-Nordic
force-pushed
the
partnumberetc
branch
from
aa8daa7 to
de3391d
Compare
|
PR #23385: Size comparison from a99675e to de3391d Increases (15 builds for bl702, cc13x2_26x2, efr32, linux, psoc6, qpg)
Decreases (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, mbed, nrfconnect, psoc6, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
s07641069
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Nov 9, 2022
andy31415
pushed a commit
that referenced
this pull request
Nov 10, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23385) * [platform] Move more product attributes to DeviceInstanceInfoProvider Vendor and product identifiers were already moved from ConfigurationManager to DeviceInstanceInfoProvider to allow for easier integration with platform factory data providers as they may differ across devices running the same firmware. Somehow PartNumber, ProductURL and ProductLabel slipped unnoticed. Move accessors of these attributes to DeviceInstanceInfoProvider and update all implementations to preserve the existing behavior. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * [nrfconnect] Read PartNumber, URL and Label from factory data Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * Code review * Remove obsolete definitions to fix the build Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23385) * [platform] Move more product attributes to DeviceInstanceInfoProvider Vendor and product identifiers were already moved from ConfigurationManager to DeviceInstanceInfoProvider to allow for easier integration with platform factory data providers as they may differ across devices running the same firmware. Somehow PartNumber, ProductURL and ProductLabel slipped unnoticed. Move accessors of these attributes to DeviceInstanceInfoProvider and update all implementations to preserve the existing behavior. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * [nrfconnect] Read PartNumber, URL and Label from factory data Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * Code review * Remove obsolete definitions to fix the build Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor and product identifiers were already moved from ConfigurationManager to DeviceInstanceInfoProvider to allow for easier integration with platform factory data providers as they may differ across devices running the same firmware.
Somehow PartNumber, ProductURL and ProductLabel slipped unnoticed. Move accessors of these attributes to DeviceInstanceInfoProvider and update all implementations to preserve the existing behavior.
Followup on #23253: for nRF Connect add implementation that retrieves the mentioned attributes from the factory data partition.