-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Enabled chip shell for lighting app #23417
Merged
andy31415
merged 1 commit into
project-chip:master
from
jadhavrohit924:enable_chip_shell
Nov 2, 2022
Merged
[ESP32] Enabled chip shell for lighting app #23417
andy31415
merged 1 commit into
project-chip:master
from
jadhavrohit924:enable_chip_shell
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
November 1, 2022 07:14
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs and
vivien-apple
November 1, 2022 07:14
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 1, 2022 07:14
dhrishi
approved these changes
Nov 1, 2022
PR #23417: Size comparison from eeb4cdc to ce18880 Increases (6 builds for bl602, bl702, cc13x2_26x2, esp32, telink)
Decreases (3 builds for bl602, cc13x2_26x2, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 2, 2022
jadhavrohit924
force-pushed
the
enable_chip_shell
branch
from
November 2, 2022 04:55
ce18880
to
74d9e8e
Compare
PR #23417: Size comparison from 887822a to 74d9e8e Increases (6 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Testing