-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Absolute Position to Window-app zap #23464
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/window-app
Dec 13, 2022
Merged
Enable Absolute Position to Window-app zap #23464
jmartinez-silabs
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/window-app
Dec 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
November 3, 2022 14:44
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 3, 2022 14:44
andy31415
approved these changes
Nov 3, 2022
PR #23464: Size comparison from 90453bf to 37cf8d0 Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do all the per-platform examples handle this?
jepenven-silabs
approved these changes
Dec 12, 2022
pullapprove
bot
requested review from
ksperling-apple
and removed request for
kghost,
erjiaqing,
wbschiller and
isiu-apple
December 12, 2022 13:35
jmartinez-silabs
approved these changes
Dec 12, 2022
mkardous-silabs
force-pushed
the
fix/window-app
branch
from
December 12, 2022 14:31
37cf8d0
to
81b11ee
Compare
@bzbarsky-apple I assume so but i don't have a definitive answer. |
PR #23464: Size comparison from 71da650 to 81b11ee Increases (4 builds for bl702, cc13x2_26x2, esp32, k32w)
Decreases (5 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled absolute position support to window-app zap file
Testing
Regen and manual tests with chip-tool to validate
go-to-*-value
commands are accepted