-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove un-used functions from ConnectivityManagerImpl #23475
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/platfrom/connectivity
Nov 4, 2022
Merged
Remove un-used functions from ConnectivityManagerImpl #23475
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/platfrom/connectivity
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufengwangca
changed the title
Remove unused functions from ConnectivityManagerImpl
Remove un-used functions from ConnectivityManagerImpl
Nov 3, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
November 3, 2022 18:11
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst and
selissia
November 3, 2022 18:11
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 3, 2022 18:11
andy31415
approved these changes
Nov 3, 2022
Damian-Nordic
approved these changes
Nov 3, 2022
PR #23475: Size comparison from 706e9bb to 2ae08c6 Increases (7 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Decreases (2 builds for bl702, esp32)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23475: Size comparison from 93afba1 to 9a1ddc6 Increases (8 builds for bl602, cc13x2_26x2, psoc6, qpg)
Decreases (5 builds for cc13x2_26x2, esp32, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API ProvisionWiFiNetwork is duplicated with ConnectWiFiNetworkAsync in ConnectivityManagerImpl, this function is not hooked to upper layer and is not used at all. We should remove it.
The new product should only implement API ConnectWiFiNetworkAsync for wifi provisioning.